[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove unused uses and fix @covers

2016-11-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused uses and fix @covers
..


Remove unused uses and fix @covers

Change-Id: I7fea644c296ebdf921be5dcc60eec181e9446367
---
M repo/tests/phpunit/maintenance/AddUnitsTest.php
M repo/tests/phpunit/maintenance/MockAddUnits.php
M repo/tests/phpunit/maintenance/UpdateUnitsTest.php
3 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/tests/phpunit/maintenance/AddUnitsTest.php 
b/repo/tests/phpunit/maintenance/AddUnitsTest.php
index a953194..a8793e7 100644
--- a/repo/tests/phpunit/maintenance/AddUnitsTest.php
+++ b/repo/tests/phpunit/maintenance/AddUnitsTest.php
@@ -8,12 +8,11 @@
 use Wikibase\Repo\Maintenance\SPARQLClient;
 use Wikibase\Repo\Tests\Rdf\NTriplesRdfTestHelper;
 use Wikibase\Test\Rdf\RdfBuilderTestData;
-use Wikibase\UpdateUnits;
 
 require_once __DIR__ . '/MockAddUnits.php';
 
 /**
- * @covers updateUnits.php
+ * @covers Wikibase\AddUnitConversions
  * @group Wikibase
  */
 class AddUnitsTest extends MediaWikiLangTestCase {
diff --git a/repo/tests/phpunit/maintenance/MockAddUnits.php 
b/repo/tests/phpunit/maintenance/MockAddUnits.php
index 11aa037..186e5e6 100644
--- a/repo/tests/phpunit/maintenance/MockAddUnits.php
+++ b/repo/tests/phpunit/maintenance/MockAddUnits.php
@@ -3,7 +3,6 @@
 
 use Wikibase\AddUnitConversions;
 use Wikibase\Lib\UnitConverter;
-use Wikibase\Rdf\Values\QuantityRdfBuilder;
 use Wikibase\Repo\Maintenance\SPARQLClient;
 
 class MockAddUnits extends AddUnitConversions {
diff --git a/repo/tests/phpunit/maintenance/UpdateUnitsTest.php 
b/repo/tests/phpunit/maintenance/UpdateUnitsTest.php
index 24bb0df..a1cf2bd 100644
--- a/repo/tests/phpunit/maintenance/UpdateUnitsTest.php
+++ b/repo/tests/phpunit/maintenance/UpdateUnitsTest.php
@@ -5,7 +5,7 @@
 use Wikibase\UpdateUnits;
 
 /**
- * @covers updateUnits.php
+ * @covers Wikibase\UpdateUnits
  * @group Wikibase
  */
 class UpdateUnitsTest extends MediaWikiLangTestCase {

-- 
To view, visit https://gerrit.wikimedia.org/r/321924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fea644c296ebdf921be5dcc60eec181e9446367
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove unused uses

2016-09-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused uses
..


Remove unused uses

Change-Id: I3b188c6d6beb0caa8c424b80145e38b8a7d2476c
---
M client/includes/Hooks/InfoActionHookHandler.php
M client/includes/Specials/SpecialEntityUsage.php
M client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php
M repo/includes/Api/GetClaims.php
M repo/includes/Api/ModifyEntity.php
M repo/tests/phpunit/includes/EditEntityTest.php
M repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
7 files changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/includes/Hooks/InfoActionHookHandler.php 
b/client/includes/Hooks/InfoActionHookHandler.php
index d5880ad..fa4485d 100644
--- a/client/includes/Hooks/InfoActionHookHandler.php
+++ b/client/includes/Hooks/InfoActionHookHandler.php
@@ -6,7 +6,6 @@
 use IContextSource;
 use Title;
 use Wikibase\Client\RepoLinker;
-use Wikibase\Client\Usage\Sql\SqlUsageTracker;
 use Wikibase\Client\Usage\UsageLookup;
 use Wikibase\DataModel\Entity\ItemId;
 use Wikibase\Lib\Store\SiteLinkLookup;
diff --git a/client/includes/Specials/SpecialEntityUsage.php 
b/client/includes/Specials/SpecialEntityUsage.php
index 496427c..9d97ba8 100644
--- a/client/includes/Specials/SpecialEntityUsage.php
+++ b/client/includes/Specials/SpecialEntityUsage.php
@@ -9,7 +9,6 @@
 use QueryPage;
 use Skin;
 use Title;
-use Wikibase\Client\WikibaseClient;
 use Wikibase\Client\Usage\EntityUsage;
 use Wikibase\DataModel\Entity\ItemId;
 
diff --git a/client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php 
b/client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php
index 6a6b7e0..7bedea4 100644
--- a/client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php
+++ b/client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php
@@ -3,7 +3,6 @@
 namespace Wikibase\Client\Tests\Api;
 
 use ApiMain;
-use ApiPageSet;
 use ApiQuery;
 use FauxRequest;
 use MediaWikiLangTestCase;
diff --git a/repo/includes/Api/GetClaims.php b/repo/includes/Api/GetClaims.php
index 5190f11..dfe42de 100644
--- a/repo/includes/Api/GetClaims.php
+++ b/repo/includes/Api/GetClaims.php
@@ -12,7 +12,6 @@
 use Wikibase\DataModel\Services\Statement\StatementGuidValidator;
 use Wikibase\DataModel\Statement\StatementList;
 use Wikibase\DataModel\Statement\StatementListProvider;
-use Wikibase\Lib\Store\EntityRevisionLookup;
 use Wikibase\Repo\WikibaseRepo;
 use Wikibase\StatementRankSerializer;
 
diff --git a/repo/includes/Api/ModifyEntity.php 
b/repo/includes/Api/ModifyEntity.php
index e4a5d6e..4cb362a 100644
--- a/repo/includes/Api/ModifyEntity.php
+++ b/repo/includes/Api/ModifyEntity.php
@@ -12,9 +12,6 @@
 use Wikibase\ChangeOp\ChangeOpException;
 use Wikibase\ChangeOp\ChangeOpValidationException;
 use Wikibase\DataModel\Entity\EntityDocument;
-use Wikibase\DataModel\Entity\EntityId;
-use Wikibase\DataModel\Entity\EntityIdParser;
-use Wikibase\DataModel\Entity\EntityIdParsingException;
 use Wikibase\DataModel\Entity\ItemId;
 use Wikibase\Lib\Store\EntityRevisionLookup;
 use Wikibase\Lib\Store\EntityTitleLookup;
diff --git a/repo/tests/phpunit/includes/EditEntityTest.php 
b/repo/tests/phpunit/includes/EditEntityTest.php
index 429f567..8bee761 100644
--- a/repo/tests/phpunit/includes/EditEntityTest.php
+++ b/repo/tests/phpunit/includes/EditEntityTest.php
@@ -19,7 +19,6 @@
 use Wikibase\DataModel\Services\Diff\EntityPatcher;
 use Wikibase\DataModel\Term\Fingerprint;
 use Wikibase\EditEntity;
-use Wikibase\Lib\Store\EntityRevisionLookup;
 use Wikibase\Lib\Store\EntityTitleLookup;
 use Wikibase\Lib\Tests\MockRepository;
 use Wikibase\Repo\Hooks\EditFilterHookRunner;
diff --git 
a/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php 
b/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
index e7d7fd0..a481e59 100644
--- a/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
+++ b/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
@@ -10,7 +10,6 @@
 use Wikibase\EntityRevision;
 use Wikibase\Lib\Store\EntityNamespaceLookup;
 use Wikibase\Lib\Store\EntityRevisionLookup;
-use Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataAccessor;
 use Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup;
 use Wikibase\Repo\WikibaseRepo;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/311426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b188c6d6beb0caa8c424b80145e38b8a7d2476c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove unused uses

2016-09-19 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311426

Change subject: Remove unused uses
..

Remove unused uses

Change-Id: I3b188c6d6beb0caa8c424b80145e38b8a7d2476c
---
M client/includes/Hooks/InfoActionHookHandler.php
M client/includes/Specials/SpecialEntityUsage.php
M client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php
M repo/includes/Api/GetClaims.php
M repo/includes/Api/ModifyEntity.php
M repo/tests/phpunit/includes/EditEntityTest.php
M repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
7 files changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/26/311426/1

diff --git a/client/includes/Hooks/InfoActionHookHandler.php 
b/client/includes/Hooks/InfoActionHookHandler.php
index d5880ad..fa4485d 100644
--- a/client/includes/Hooks/InfoActionHookHandler.php
+++ b/client/includes/Hooks/InfoActionHookHandler.php
@@ -6,7 +6,6 @@
 use IContextSource;
 use Title;
 use Wikibase\Client\RepoLinker;
-use Wikibase\Client\Usage\Sql\SqlUsageTracker;
 use Wikibase\Client\Usage\UsageLookup;
 use Wikibase\DataModel\Entity\ItemId;
 use Wikibase\Lib\Store\SiteLinkLookup;
diff --git a/client/includes/Specials/SpecialEntityUsage.php 
b/client/includes/Specials/SpecialEntityUsage.php
index 496427c..9d97ba8 100644
--- a/client/includes/Specials/SpecialEntityUsage.php
+++ b/client/includes/Specials/SpecialEntityUsage.php
@@ -9,7 +9,6 @@
 use QueryPage;
 use Skin;
 use Title;
-use Wikibase\Client\WikibaseClient;
 use Wikibase\Client\Usage\EntityUsage;
 use Wikibase\DataModel\Entity\ItemId;
 
diff --git a/client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php 
b/client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php
index 6a6b7e0..7bedea4 100644
--- a/client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php
+++ b/client/tests/phpunit/includes/Api/ApiListEntityUsageTest.php
@@ -3,7 +3,6 @@
 namespace Wikibase\Client\Tests\Api;
 
 use ApiMain;
-use ApiPageSet;
 use ApiQuery;
 use FauxRequest;
 use MediaWikiLangTestCase;
diff --git a/repo/includes/Api/GetClaims.php b/repo/includes/Api/GetClaims.php
index 5190f11..dfe42de 100644
--- a/repo/includes/Api/GetClaims.php
+++ b/repo/includes/Api/GetClaims.php
@@ -12,7 +12,6 @@
 use Wikibase\DataModel\Services\Statement\StatementGuidValidator;
 use Wikibase\DataModel\Statement\StatementList;
 use Wikibase\DataModel\Statement\StatementListProvider;
-use Wikibase\Lib\Store\EntityRevisionLookup;
 use Wikibase\Repo\WikibaseRepo;
 use Wikibase\StatementRankSerializer;
 
diff --git a/repo/includes/Api/ModifyEntity.php 
b/repo/includes/Api/ModifyEntity.php
index e4a5d6e..4cb362a 100644
--- a/repo/includes/Api/ModifyEntity.php
+++ b/repo/includes/Api/ModifyEntity.php
@@ -12,9 +12,6 @@
 use Wikibase\ChangeOp\ChangeOpException;
 use Wikibase\ChangeOp\ChangeOpValidationException;
 use Wikibase\DataModel\Entity\EntityDocument;
-use Wikibase\DataModel\Entity\EntityId;
-use Wikibase\DataModel\Entity\EntityIdParser;
-use Wikibase\DataModel\Entity\EntityIdParsingException;
 use Wikibase\DataModel\Entity\ItemId;
 use Wikibase\Lib\Store\EntityRevisionLookup;
 use Wikibase\Lib\Store\EntityTitleLookup;
diff --git a/repo/tests/phpunit/includes/EditEntityTest.php 
b/repo/tests/phpunit/includes/EditEntityTest.php
index 429f567..8bee761 100644
--- a/repo/tests/phpunit/includes/EditEntityTest.php
+++ b/repo/tests/phpunit/includes/EditEntityTest.php
@@ -19,7 +19,6 @@
 use Wikibase\DataModel\Services\Diff\EntityPatcher;
 use Wikibase\DataModel\Term\Fingerprint;
 use Wikibase\EditEntity;
-use Wikibase\Lib\Store\EntityRevisionLookup;
 use Wikibase\Lib\Store\EntityTitleLookup;
 use Wikibase\Lib\Tests\MockRepository;
 use Wikibase\Repo\Hooks\EditFilterHookRunner;
diff --git 
a/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php 
b/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
index e7d7fd0..a481e59 100644
--- a/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
+++ b/repo/tests/phpunit/includes/Store/Sql/WikiPageEntityMetaDataLookupTest.php
@@ -10,7 +10,6 @@
 use Wikibase\EntityRevision;
 use Wikibase\Lib\Store\EntityNamespaceLookup;
 use Wikibase\Lib\Store\EntityRevisionLookup;
-use Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataAccessor;
 use Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup;
 use Wikibase\Repo\WikibaseRepo;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/311426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b188c6d6beb0caa8c424b80145e38b8a7d2476c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/li