Jakob has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370634 )
Change subject: [DNM] Testing QUnit CI failure.
......................................................................
[DNM] Testing QUnit CI failure.
Change-Id: I2617e02f2d598992bd1f4c7214af77793b7505ba
---
M tests/qunit/i18n/Messages.tests.js
1 file changed, 36 insertions(+), 39 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/34/370634/1
diff --git a/tests/qunit/i18n/Messages.tests.js
b/tests/qunit/i18n/Messages.tests.js
index 4600dbc..d4481ad 100644
--- a/tests/qunit/i18n/Messages.tests.js
+++ b/tests/qunit/i18n/Messages.tests.js
@@ -6,51 +6,48 @@
/** @type {wikibase.lexeme.i18n.Messages} */
var messages = require( 'wikibase.lexeme.i18n.Messages' );
- QUnit.module( 'wikibase.lexeme.i18n.Messages', function () {
- var EXISTING_MESSAGE_KEY = 'message1';
- var EXISTING_TRANSLATION = 'translation1';
+ var EXISTING_MESSAGE_KEY = 'message1';
+ var EXISTING_TRANSLATION = 'translation1';
- QUnit.module( 'getUnparameterizedTranslation', {
- beforeEach: function () {
- mediaWiki.messages.set( EXISTING_MESSAGE_KEY,
EXISTING_TRANSLATION );
- },
- afterEach: function () {
- delete mediaWiki.messages.values[
EXISTING_MESSAGE_KEY ];
- }
- }, function () {
+ QUnit.module( 'wikibase.lexeme.i18n.Messages', {
+ beforeEach: function () {
+ mediaWiki.messages.set( EXISTING_MESSAGE_KEY,
EXISTING_TRANSLATION );
+ },
+ afterEach: function () {
+ delete mediaWiki.messages.values[ EXISTING_MESSAGE_KEY
];
+ }
+ }, function () {
+ QUnit.test( 'returns translation', function ( assert ) {
+ var translation =
messages.getUnparameterizedTranslation( EXISTING_MESSAGE_KEY );
- QUnit.test( 'returns translation', function ( assert ) {
- var translation =
messages.getUnparameterizedTranslation( EXISTING_MESSAGE_KEY );
+ assert.equal( translation, EXISTING_TRANSLATION );
+ } );
- assert.equal( translation, EXISTING_TRANSLATION
);
- } );
-
- QUnit.test( 'accepts strings only', function ( assert )
{
- var invalidMessageKeyValues = [
- null,
- undefined,
- [],
- {},
- function () {
- }
- ];
- invalidMessageKeyValues.forEach( function ( key
) {
- assert.throws( function () {
-
messages.getUnparameterizedTranslation( key );
- }, typeof key );
- } );
- } );
-
- QUnit.test( 'doesn\'t accept any arguments except the
key', function ( assert ) {
+ QUnit.test( 'accepts strings only', function ( assert ) {
+ var invalidMessageKeyValues = [
+ null,
+ undefined,
+ [],
+ {},
+ function () {
+ }
+ ];
+ invalidMessageKeyValues.forEach( function ( key ) {
assert.throws( function () {
- messages.getUnparameterizedTranslation(
EXISTING_MESSAGE_KEY, 'some argument' );
- } );
+ messages.getUnparameterizedTranslation(
key );
+ }, typeof key );
} );
+ } );
- QUnit.test( 'throws error if message does not exist',
function ( assert ) {
- assert.throws( function () {
- messages.getUnparameterizedTranslation(
'some-message' );
- } );
+ QUnit.test( 'doesn\'t accept any arguments except the key',
function ( assert ) {
+ assert.throws( function () {
+ messages.getUnparameterizedTranslation(
EXISTING_MESSAGE_KEY, 'some argument' );
+ } );
+ } );
+
+ QUnit.test( 'throws error if message does not exist', function
( assert ) {
+ assert.throws( function () {
+ messages.getUnparameterizedTranslation(
'some-message' );
} );
} );
} );
--
To view, visit https://gerrit.wikimedia.org/r/370634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2617e02f2d598992bd1f4c7214af77793b7505ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Jakob <jakob.warkot...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
