[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Only log ChangesList filters for logged-in users

2016-09-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Only log ChangesList filters for logged-in users
..


Only log ChangesList filters for logged-in users

To reduce the event volume and try to filter out crawlers.

Bug: T144331
Change-Id: I7863ef6d4a5ce4a90af80902282a463128897b63
---
M WikimediaEventsHooks.php
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Sbisson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index 50bfe0c..8ba1267 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -562,6 +562,11 @@
 * @param &$filters Associative array of filter definitions.
 */
public static function onChangesListSpecialPageFilters( $special, 
&$filters ) {
+   // For volume/capacity reasons, only log this for logged-in 
users
+   if ( $special->getUser()->isAnon() ) {
+   return;
+   }
+
$logData = [
'pagename' => $special->getName()
];

-- 
To view, visit https://gerrit.wikimedia.org/r/311162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7863ef6d4a5ce4a90af80902282a463128897b63
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: Sbisson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Only log ChangesList filters for logged-in users

2016-09-16 Thread Catrope (Code Review) 
Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311162

Change subject: Only log ChangesList filters for logged-in users
..

Only log ChangesList filters for logged-in users

To reduce the event volume and try to filter out crawlers.

Bug: T144331
Change-Id: I7863ef6d4a5ce4a90af80902282a463128897b63
---
M WikimediaEventsHooks.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/62/311162/1

diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index 50bfe0c..8ba1267 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -562,6 +562,11 @@
 * @param &$filters Associative array of filter definitions.
 */
public static function onChangesListSpecialPageFilters( $special, 
&$filters ) {
+   // For volume/capacity reasons, only log this for logged-in 
users
+   if ( $special->getUser()->isAnon() ) {
+   return;
+   }
+
$logData = [
'pagename' => $special->getName()
];

-- 
To view, visit https://gerrit.wikimedia.org/r/311162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7863ef6d4a5ce4a90af80902282a463128897b63
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits