[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Skipping 2 tests for hatnotes in the experimental endpoints

2016-12-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Skipping 2 tests for hatnotes in the experimental endpoints
..


Skipping 2 tests for hatnotes in the experimental endpoints

Looks like an edit caused this to fail.
Also I think the implementation is not correct.
The hatnote should still appear since it still exist in wikitext after the edit
https://en.wikipedia.org/w/index.php?title=Order_of_chivalry=next=752548387

but in the test it doesn't have it.

Change-Id: Iaab7f6ee5b03d6660f8d7de481a78c615a17f609
TODO: needs further investigation
---
M test/features/mobile-sections-lead/pagecontent.js
M test/features/mobile-sections/pagecontent-v2.js
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mholloway: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/test/features/mobile-sections-lead/pagecontent.js 
b/test/features/mobile-sections-lead/pagecontent.js
index f9203c0..03c4f25 100644
--- a/test/features/mobile-sections-lead/pagecontent.js
+++ b/test/features/mobile-sections-lead/pagecontent.js
@@ -153,7 +153,7 @@
 'Expected section text to start with lead paragraph. 
Actual text ' + res.body.sections[0].text);
 });
 });
-it('Enwiki hatnotes are promoted to the lead object', function() {
+it.skip('Enwiki hatnotes are promoted to the lead object', function() {
 return preq.get({ uri: server.config.uri + 
'en.wikipedia.org/v1/page/mobile-sections-lead/Chivalric%20order' })
 .then(function (res) {
 assert.deepEqual(res.status, 200);
diff --git a/test/features/mobile-sections/pagecontent-v2.js 
b/test/features/mobile-sections/pagecontent-v2.js
index 61f28cf..ff75931 100644
--- a/test/features/mobile-sections/pagecontent-v2.js
+++ b/test/features/mobile-sections/pagecontent-v2.js
@@ -9,7 +9,7 @@
 
 before(function () { return server.start(); });
 
-it('Hatnotes do not appear in the lead object', function() {
+it.skip('Hatnotes do not appear in the lead object', function() {
 return preq.get({ uri: server.config.uri + 
'en.wikipedia.org/v1/page/formatted-lead/Chivalric%20order' })
 .then(function (res) {
 assert.deepEqual(res.status, 200);

-- 
To view, visit https://gerrit.wikimedia.org/r/324825
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaab7f6ee5b03d6660f8d7de481a78c615a17f609
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Skipping 2 tests for hatnotes in the experimental endpoints

2016-12-01 Thread BearND (Code Review) 
BearND has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324825

Change subject: Skipping 2 tests for hatnotes in the experimental endpoints
..

Skipping 2 tests for hatnotes in the experimental endpoints

Looks like an edit caused this to fail.
Also I think the implementation is not correct.
The hatnote should still appear since it still exist in wikitext after the edit
https://en.wikipedia.org/w/index.php?title=Order_of_chivalry=next=752548387

but in the test it doesn't have it.

Change-Id: Iaab7f6ee5b03d6660f8d7de481a78c615a17f609
TODO: needs further investigation
---
M test/features/mobile-sections-lead/pagecontent.js
M test/features/mobile-sections/pagecontent-v2.js
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/25/324825/1

diff --git a/test/features/mobile-sections-lead/pagecontent.js 
b/test/features/mobile-sections-lead/pagecontent.js
index f9203c0..03c4f25 100644
--- a/test/features/mobile-sections-lead/pagecontent.js
+++ b/test/features/mobile-sections-lead/pagecontent.js
@@ -153,7 +153,7 @@
 'Expected section text to start with lead paragraph. 
Actual text ' + res.body.sections[0].text);
 });
 });
-it('Enwiki hatnotes are promoted to the lead object', function() {
+it.skip('Enwiki hatnotes are promoted to the lead object', function() {
 return preq.get({ uri: server.config.uri + 
'en.wikipedia.org/v1/page/mobile-sections-lead/Chivalric%20order' })
 .then(function (res) {
 assert.deepEqual(res.status, 200);
diff --git a/test/features/mobile-sections/pagecontent-v2.js 
b/test/features/mobile-sections/pagecontent-v2.js
index 61f28cf..ff75931 100644
--- a/test/features/mobile-sections/pagecontent-v2.js
+++ b/test/features/mobile-sections/pagecontent-v2.js
@@ -9,7 +9,7 @@
 
 before(function () { return server.start(); });
 
-it('Hatnotes do not appear in the lead object', function() {
+it.skip('Hatnotes do not appear in the lead object', function() {
 return preq.get({ uri: server.config.uri + 
'en.wikipedia.org/v1/page/formatted-lead/Chivalric%20order' })
 .then(function (res) {
 assert.deepEqual(res.status, 200);

-- 
To view, visit https://gerrit.wikimedia.org/r/324825
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaab7f6ee5b03d6660f8d7de481a78c615a17f609
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits