[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Clarify usage of `@max-width-*` Less variables
jenkins-bot has submitted this change and it was merged.
Change subject: MediaWiki theme: Clarify usage of `@max-width-*` Less variables
..
MediaWiki theme: Clarify usage of `@max-width-*` Less variables
Clarifying usage of `@max-width-*` Less variables to be future-proof
and replace one static value with variable.
Change-Id: I48a754dd09c982eef5eab81cfa5148e8eca28cc1
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/layouts.less
M src/themes/mediawiki/widgets.less
3 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Prtksxna: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 685ace4..cefa1ef 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -55,7 +55,8 @@
// Box Sizes
@min-height-toggleswitch: 26px; // equals `16px` @size-toggleswitch-grip-min +
4px*2 distance top/bottom + 1px*2 border top/bottom
-@max-width-input-default: 50em;
+@max-width-default: 50em;
+@max-width-input: @max-width-default;
@size-icon-min: 24px;
@size-indicator-min: 12px;
diff --git a/src/themes/mediawiki/layouts.less
b/src/themes/mediawiki/layouts.less
index 0523ed7..17c1945 100644
--- a/src/themes/mediawiki/layouts.less
+++ b/src/themes/mediawiki/layouts.less
@@ -103,7 +103,7 @@
}
.theme-oo-ui-actionFieldLayout () {
- max-width: 50em;
+ max-width: @max-width-default;
}
.theme-oo-ui-fieldsetLayout () {
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 4aad9cc..80d3a92 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -106,7 +106,7 @@
.theme-oo-ui-dropdownWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
.oo-ui-inline-spacing( 0.5em );
&-handle {
@@ -207,7 +207,7 @@
.theme-oo-ui-selectFileWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
.oo-ui-inline-spacing( 0.5em );
&-selectButton {
@@ -492,7 +492,7 @@
.theme-oo-ui-dropdownInputWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
select {
background-color: @background-color-default;
@@ -675,7 +675,7 @@
.theme-oo-ui-textInputWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
input,
textarea {
@@ -858,7 +858,7 @@
.theme-oo-ui-capsuleMultiselectWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
&-handle {
min-height: 2.4em;
@@ -1390,7 +1390,7 @@
}
.theme-oo-ui-numberInputWidget () {
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
&-buttoned {
.oo-ui-buttonWidget {
@@ -1566,7 +1566,7 @@
}
.theme-oo-ui-progressBarWidget () {
- max-width: @max-width-input-default;
+ max-width: @max-width-default;
background-color: @background-color-default;
border: @border-default;
border-radius: @border-radius-default;
--
To view, visit https://gerrit.wikimedia.org/r/310629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48a754dd09c982eef5eab81cfa5148e8eca28cc1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE
Gerrit-Reviewer: Bartosz Dziewoński
Gerrit-Reviewer: Jforrester
Gerrit-Reviewer: Prtksxna
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Clarify usage of `@max-width-*` Less variables
VolkerE has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310629
Change subject: MediaWiki theme: Clarify usage of `@max-width-*` Less variables
..
MediaWiki theme: Clarify usage of `@max-width-*` Less variables
Clarifying usage of `@max-width-*` Less variables to be future-proof
and replace one static value with variable.
Change-Id: I48a754dd09c982eef5eab81cfa5148e8eca28cc1
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/layouts.less
M src/themes/mediawiki/widgets.less
3 files changed, 10 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/29/310629/1
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 685ace4..cefa1ef 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -55,7 +55,8 @@
// Box Sizes
@min-height-toggleswitch: 26px; // equals `16px` @size-toggleswitch-grip-min +
4px*2 distance top/bottom + 1px*2 border top/bottom
-@max-width-input-default: 50em;
+@max-width-default: 50em;
+@max-width-input: @max-width-default;
@size-icon-min: 24px;
@size-indicator-min: 12px;
diff --git a/src/themes/mediawiki/layouts.less
b/src/themes/mediawiki/layouts.less
index 0523ed7..17c1945 100644
--- a/src/themes/mediawiki/layouts.less
+++ b/src/themes/mediawiki/layouts.less
@@ -103,7 +103,7 @@
}
.theme-oo-ui-actionFieldLayout () {
- max-width: 50em;
+ max-width: @max-width-default;
}
.theme-oo-ui-fieldsetLayout () {
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 4aad9cc..80d3a92 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -106,7 +106,7 @@
.theme-oo-ui-dropdownWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
.oo-ui-inline-spacing( 0.5em );
&-handle {
@@ -207,7 +207,7 @@
.theme-oo-ui-selectFileWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
.oo-ui-inline-spacing( 0.5em );
&-selectButton {
@@ -492,7 +492,7 @@
.theme-oo-ui-dropdownInputWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
select {
background-color: @background-color-default;
@@ -675,7 +675,7 @@
.theme-oo-ui-textInputWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
input,
textarea {
@@ -858,7 +858,7 @@
.theme-oo-ui-capsuleMultiselectWidget () {
width: 100%;
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
&-handle {
min-height: 2.4em;
@@ -1390,7 +1390,7 @@
}
.theme-oo-ui-numberInputWidget () {
- max-width: @max-width-input-default;
+ max-width: @max-width-input;
&-buttoned {
.oo-ui-buttonWidget {
@@ -1566,7 +1566,7 @@
}
.theme-oo-ui-progressBarWidget () {
- max-width: @max-width-input-default;
+ max-width: @max-width-default;
background-color: @background-color-default;
border: @border-default;
border-radius: @border-radius-default;
--
To view, visit https://gerrit.wikimedia.org/r/310629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48a754dd09c982eef5eab81cfa5148e8eca28cc1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
