WMDE-Fisch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371107 )
Change subject: Update to mediawiki-codesniffer 0.10.1 and fix
......................................................................
Update to mediawiki-codesniffer 0.10.1 and fix
Change-Id: I136e625a0795b7e20a08842b0d190e5eb73e84e8
---
M composer.json
M php/Element.php
M php/Tag.php
M php/Widget.php
M php/mixins/ButtonElement.php
M php/mixins/FlaggedElement.php
M php/mixins/GroupElement.php
M php/widgets/ButtonWidget.php
M php/widgets/CheckboxInputWidget.php
M php/widgets/RadioInputWidget.php
M php/widgets/TextInputWidget.php
11 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/07/371107/1
diff --git a/composer.json b/composer.json
index 85a6641..0270fe6 100644
--- a/composer.json
+++ b/composer.json
@@ -51,7 +51,7 @@
],
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.10.0",
+ "mediawiki/mediawiki-codesniffer": "0.10.1",
"phpunit/phpunit": "4.8.21"
},
"autoload": {
diff --git a/php/Element.php b/php/Element.php
index bd90d15..04c81e0 100644
--- a/php/Element.php
+++ b/php/Element.php
@@ -125,7 +125,7 @@
* Check if element supports one or more methods.
*
* @param string|string[] $methods Method or list of methods to check
- * @return boolean All methods are supported
+ * @return bool All methods are supported
*/
public function supports( $methods ) {
$support = 0;
diff --git a/php/Tag.php b/php/Tag.php
index 9273455..44d35a8 100644
--- a/php/Tag.php
+++ b/php/Tag.php
@@ -63,7 +63,7 @@
* Check for CSS class.
*
* @param string $class CSS class name
- * @return boolean
+ * @return bool
*/
public function hasClass( $class ) {
return in_array( $class, $this->classes );
@@ -264,7 +264,7 @@
/**
* Get client-side infusability.
*
- * @return boolean If this tag/element/widget can be referenced
client-side.
+ * @return bool If this tag/element/widget can be referenced
client-side.
*/
public function isInfusable() {
return $this->infusable;
@@ -345,7 +345,7 @@
* distinguish them from malformed absolute ones (again, very lax rules
for parsing protocols).
*
* @param string $url URL
- * @return boolean [description]
+ * @return bool [description]
*/
public static function isSafeUrl( $url ) {
// Keep this function in sync with OO.ui.isSafeUrl
diff --git a/php/Widget.php b/php/Widget.php
index 13b937a..2f4573f 100644
--- a/php/Widget.php
+++ b/php/Widget.php
@@ -39,7 +39,7 @@
/**
* Check if the widget is disabled.
*
- * @return boolean Button is disabled
+ * @return bool Button is disabled
*/
public function isDisabled() {
return $this->disabled;
diff --git a/php/mixins/ButtonElement.php b/php/mixins/ButtonElement.php
index 3ecf8e6..c91a158 100644
--- a/php/mixins/ButtonElement.php
+++ b/php/mixins/ButtonElement.php
@@ -71,7 +71,7 @@
/**
* Check if button has a frame.
*
- * @return boolean Button is framed
+ * @return bool Button is framed
*/
public function isFramed() {
return $this->framed;
diff --git a/php/mixins/FlaggedElement.php b/php/mixins/FlaggedElement.php
index bf84e7f..1e2b5da 100644
--- a/php/mixins/FlaggedElement.php
+++ b/php/mixins/FlaggedElement.php
@@ -46,7 +46,7 @@
* Check if a flag is set.
*
* @param string $flag Name of flag
- * @return boolean Has flag
+ * @return bool Has flag
*/
public function hasFlag( $flag ) {
return isset( $this->flags[$flag] );
diff --git a/php/mixins/GroupElement.php b/php/mixins/GroupElement.php
index 2cfeef7..a6335c7 100644
--- a/php/mixins/GroupElement.php
+++ b/php/mixins/GroupElement.php
@@ -35,7 +35,7 @@
/**
* Check if there are no items.
*
- * @return boolean Group is empty
+ * @return bool Group is empty
*/
public function isEmpty() {
return !count( $this->items );
diff --git a/php/widgets/ButtonWidget.php b/php/widgets/ButtonWidget.php
index fcaa205..43f1d99 100644
--- a/php/widgets/ButtonWidget.php
+++ b/php/widgets/ButtonWidget.php
@@ -108,7 +108,7 @@
/**
* Get search engine traversal hint.
*
- * @return boolean Whether search engines should avoid traversing this
hyperlink
+ * @return bool Whether search engines should avoid traversing this
hyperlink
*/
public function getNoFollow() {
return $this->noFollow;
@@ -196,7 +196,7 @@
/**
* Check if button is active.
*
- * @return boolean Button is active
+ * @return bool Button is active
*/
public function isActive() {
return $this->active;
diff --git a/php/widgets/CheckboxInputWidget.php
b/php/widgets/CheckboxInputWidget.php
index 4b0beb9..458c73e 100644
--- a/php/widgets/CheckboxInputWidget.php
+++ b/php/widgets/CheckboxInputWidget.php
@@ -59,7 +59,7 @@
/**
* Check if this checkbox is selected.
*
- * @return boolean Checkbox is selected
+ * @return bool Checkbox is selected
*/
public function isSelected() {
return $this->selected;
diff --git a/php/widgets/RadioInputWidget.php b/php/widgets/RadioInputWidget.php
index 72943d8..15a36a6 100644
--- a/php/widgets/RadioInputWidget.php
+++ b/php/widgets/RadioInputWidget.php
@@ -50,7 +50,7 @@
/**
* Check if this radio button is selected.
*
- * @return boolean Radio is selected
+ * @return bool Radio is selected
*/
public function isSelected() {
return $this->input->getAttribute( 'checked' ) === 'checked';
diff --git a/php/widgets/TextInputWidget.php b/php/widgets/TextInputWidget.php
index 885c155..30afcce 100644
--- a/php/widgets/TextInputWidget.php
+++ b/php/widgets/TextInputWidget.php
@@ -115,7 +115,7 @@
/**
* Check if the widget is read-only.
*
- * @return boolean
+ * @return bool
*/
public function isReadOnly() {
return $this->readOnly;
@@ -141,7 +141,7 @@
/**
* Check if the widget is required.
*
- * @return boolean
+ * @return bool
*/
public function isRequired() {
return $this->required;
@@ -196,7 +196,7 @@
/**
* Check if input supports multiple lines.
*
- * @return boolean
+ * @return bool
*/
public function isMultiline() {
return (bool)$this->multiline;
--
To view, visit https://gerrit.wikimedia.org/r/371107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I136e625a0795b7e20a08842b0d190e5eb73e84e8
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <christoph.jau...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
