[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"

2017-08-22 Thread Niharika29 (Code Review) 
Hello Florianschmidtwelzow, MaxSem, jenkins-bot, Kaldari,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/373142

to review the following change.


Change subject: Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"
..

Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"

This reverts commit ed93eb4587c992aae8fe91d5a9e091ae46a06fcf.

Change-Id: Ib9820dca2887f00d9f110074f9b84204884dfdc9
---
M wmf-config/InitialiseSettings.php
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/42/373142/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index fab2d9d..2d9d8e2 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -19334,9 +19334,10 @@
 ],
 
 'wmgUseCodeMirror' => [
-   'default' => false,
-   'simplewiki' => true,
-   'testwiki' => true, // T169284
+   'default' => true,
+   'rtl' => false,
+   'wikidatawiki' => false, // Didn't feel well when this was deployed
+   'testwikidatawiki' => false,
 ],
 
 'wmgUseParserMigration' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/373142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9820dca2887f00d9f110074f9b84204884dfdc9
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Niharika29 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"

2017-08-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370943 )

Change subject: Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"
..


Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"

This reverts commit 33124d99739cac7079ad72529038327f0d750e58.

Change-Id: Ib54524d7abb23a4ec2599dc87f4a19c3bab222dd
---
M wmf-config/InitialiseSettings.php
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index fab2d9d..2d9d8e2 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -19334,9 +19334,10 @@
 ],
 
 'wmgUseCodeMirror' => [
-   'default' => false,
-   'simplewiki' => true,
-   'testwiki' => true, // T169284
+   'default' => true,
+   'rtl' => false,
+   'wikidatawiki' => false, // Didn't feel well when this was deployed
+   'testwikidatawiki' => false,
 ],
 
 'wmgUseParserMigration' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/370943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib54524d7abb23a4ec2599dc87f4a19c3bab222dd
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"

2017-08-09 Thread MaxSem (Code Review) 
Hello Florianschmidtwelzow, jenkins-bot, Kaldari,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/370943

to review the following change.


Change subject: Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"
..

Redo "Enable CodeMirror everywhere but RTL wikis and wikidata"

This reverts commit 33124d99739cac7079ad72529038327f0d750e58.

Change-Id: Ib54524d7abb23a4ec2599dc87f4a19c3bab222dd
---
M wmf-config/InitialiseSettings.php
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/43/370943/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index bea92dc..cb9d26d 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -19323,9 +19323,10 @@
 ],
 
 'wmgUseCodeMirror' => [
-   'default' => false,
-   'simplewiki' => true,
-   'testwiki' => true, // T169284
+   'default' => true,
+   'rtl' => false,
+   'wikidatawiki' => false, // Didn't feel well when this was deployed
+   'testwikidatawiki' => false,
 ],
 
 'wmgUseParserMigration' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/370943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib54524d7abb23a4ec2599dc87f4a19c3bab222dd
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits