[MediaWiki-commits] [Gerrit] operations/puppet[production]: hue_server: Restrict to production networks

2016-10-28 Thread Muehlenhoff (Code Review) 
Muehlenhoff has submitted this change and it was merged.

Change subject: hue_server: Restrict to production networks
..


hue_server: Restrict to production networks

hue/Port  is served via Varnish/cache_misc, so restrict to
$PRODUCTION_NETWORKS, $INTERNAL is needlessly broad.

Change-Id: Ic26d454fbb875b7e5ad70659773f098af23349ea
---
M modules/role/manifests/analytics_cluster/hue.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Elukey: Looks good to me, but someone else must approve
  Ottomata: Looks good to me, but someone else must approve
  Muehlenhoff: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/role/manifests/analytics_cluster/hue.pp 
b/modules/role/manifests/analytics_cluster/hue.pp
index b20dfcd..c5a04ba 100644
--- a/modules/role/manifests/analytics_cluster/hue.pp
+++ b/modules/role/manifests/analytics_cluster/hue.pp
@@ -47,7 +47,7 @@
 ferm::service{ 'hue_server':
 proto  => 'tcp',
 port   => '',
-srange => '$INTERNAL',
+srange => '$PRODUCTION_NETWORKS',
 }
 
 # Include icinga alerts if production realm.

-- 
To view, visit https://gerrit.wikimedia.org/r/316363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic26d454fbb875b7e5ad70659773f098af23349ea
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 
Gerrit-Reviewer: Elukey 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: hue_server: Restrict to production networks

2016-10-17 Thread Muehlenhoff (Code Review) 
Muehlenhoff has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316363

Change subject: hue_server: Restrict to production networks
..

hue_server: Restrict to production networks

hue/Port  is served via Varnish/cache_misc, so restrict to
$PRODUCTION_NETWORKS, $INTERNAL is needlessly broad.

Change-Id: Ic26d454fbb875b7e5ad70659773f098af23349ea
---
M modules/role/manifests/analytics_cluster/hue.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/63/316363/1

diff --git a/modules/role/manifests/analytics_cluster/hue.pp 
b/modules/role/manifests/analytics_cluster/hue.pp
index b20dfcd..c5a04ba 100644
--- a/modules/role/manifests/analytics_cluster/hue.pp
+++ b/modules/role/manifests/analytics_cluster/hue.pp
@@ -47,7 +47,7 @@
 ferm::service{ 'hue_server':
 proto  => 'tcp',
 port   => '',
-srange => '$INTERNAL',
+srange => '$PRODUCTION_NETWORKS',
 }
 
 # Include icinga alerts if production realm.

-- 
To view, visit https://gerrit.wikimedia.org/r/316363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic26d454fbb875b7e5ad70659773f098af23349ea
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits