[MediaWiki-commits] [Gerrit] operations/puppet[production]: labspuppetbackend: fix a bug with detecting project-wide pr...

2016-09-19 Thread Andrew Bogott (Code Review) 
Andrew Bogott has submitted this change and it was merged.

Change subject: labspuppetbackend:  fix a bug with detecting project-wide 
prefixes
..


labspuppetbackend:  fix a bug with detecting project-wide prefixes

The db returns b'' instead of ''

Change-Id: Ia93b974d9f812e910bd70210fa2144e1bdbb7959
---
M modules/labspuppetbackend/files/labspuppetbackend.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/labspuppetbackend/files/labspuppetbackend.py 
b/modules/labspuppetbackend/files/labspuppetbackend.py
index b6f0e48..c5e43b2 100644
--- a/modules/labspuppetbackend/files/labspuppetbackend.py
+++ b/modules/labspuppetbackend/files/labspuppetbackend.py
@@ -250,7 +250,7 @@
 """, (project, ))
 # Do the inverse of _preprocess_prefix, so callers get a consistent 
view
 return Response(
-yaml.safe_dump({'prefixes': ['_' if r[0] == '' else r[0] for r in 
cur.fetchall()]}),
+yaml.safe_dump({'prefixes': ['_' if r[0] == b'' else r[0] for r in 
cur.fetchall()]}),
 status=200,
 mimetype='application/x-yaml'
 )

-- 
To view, visit https://gerrit.wikimedia.org/r/311500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia93b974d9f812e910bd70210fa2144e1bdbb7959
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: Volans 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labspuppetbackend: fix a bug with detecting project-wide pr...

2016-09-19 Thread Andrew Bogott (Code Review) 
Andrew Bogott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311500

Change subject: labspuppetbackend:  fix a bug with detecting project-wide 
prefixes
..

labspuppetbackend:  fix a bug with detecting project-wide prefixes

The db returns b'' instead of ''

Change-Id: Ia93b974d9f812e910bd70210fa2144e1bdbb7959
---
M modules/labspuppetbackend/files/labspuppetbackend.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/00/311500/1

diff --git a/modules/labspuppetbackend/files/labspuppetbackend.py 
b/modules/labspuppetbackend/files/labspuppetbackend.py
index b6f0e48..c5e43b2 100644
--- a/modules/labspuppetbackend/files/labspuppetbackend.py
+++ b/modules/labspuppetbackend/files/labspuppetbackend.py
@@ -250,7 +250,7 @@
 """, (project, ))
 # Do the inverse of _preprocess_prefix, so callers get a consistent 
view
 return Response(
-yaml.safe_dump({'prefixes': ['_' if r[0] == '' else r[0] for r in 
cur.fetchall()]}),
+yaml.safe_dump({'prefixes': ['_' if r[0] == b'' else r[0] for r in 
cur.fetchall()]}),
 status=200,
 mimetype='application/x-yaml'
 )

-- 
To view, visit https://gerrit.wikimedia.org/r/311500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia93b974d9f812e910bd70210fa2144e1bdbb7959
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits