[MediaWiki-commits] [Gerrit] operations/puppet[production]: prometheus: ruby has Array.push, not append

2016-09-16 Thread Giuseppe Lavagetto (Code Review) 
Giuseppe Lavagetto has submitted this change and it was merged.

Change subject: prometheus: ruby has Array.push, not append
..


prometheus: ruby has Array.push, not append

Change-Id: I83162c8b945c899a0c56ff73c76c83760450b036
---
M modules/role/templates/prometheus/node_site.yaml.erb
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Giuseppe Lavagetto: Verified; Looks good to me, approved



diff --git a/modules/role/templates/prometheus/node_site.yaml.erb 
b/modules/role/templates/prometheus/node_site.yaml.erb
index 417ad9d..ba7abe4 100644
--- a/modules/role/templates/prometheus/node_site.yaml.erb
+++ b/modules/role/templates/prometheus/node_site.yaml.erb
@@ -6,11 +6,12 @@
 
 clusters.each do |cluster, sites|
   sites.each do |site, targets|
-  all.append(
+  all.push(
 {
   'labels' => {'cluster' => cluster, 'site' => site },
   'targets' => targets,
-})
+}
+  )
   end
 end
 -%>

-- 
To view, visit https://gerrit.wikimedia.org/r/37
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I83162c8b945c899a0c56ff73c76c83760450b036
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto 
Gerrit-Reviewer: Giuseppe Lavagetto 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: prometheus: ruby has Array.push, not append

2016-09-16 Thread Giuseppe Lavagetto (Code Review) 
Giuseppe Lavagetto has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/37

Change subject: prometheus: ruby has Array.push, not append
..

prometheus: ruby has Array.push, not append

Change-Id: I83162c8b945c899a0c56ff73c76c83760450b036
---
M modules/role/templates/prometheus/node_site.yaml.erb
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/17/37/1

diff --git a/modules/role/templates/prometheus/node_site.yaml.erb 
b/modules/role/templates/prometheus/node_site.yaml.erb
index 417ad9d..ba7abe4 100644
--- a/modules/role/templates/prometheus/node_site.yaml.erb
+++ b/modules/role/templates/prometheus/node_site.yaml.erb
@@ -6,11 +6,12 @@
 
 clusters.each do |cluster, sites|
   sites.each do |site, targets|
-  all.append(
+  all.push(
 {
   'labels' => {'cluster' => cluster, 'site' => site },
   'targets' => targets,
-})
+}
+  )
   end
 end
 -%>

-- 
To view, visit https://gerrit.wikimedia.org/r/37
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83162c8b945c899a0c56ff73c76c83760450b036
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits