[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetdbquery: fix argument ordering

[Giuseppe Lavagetto (Code Review)]

Giuseppe Lavagetto has submitted this change and it was merged.

Change subject: puppetdbquery: fix argument ordering
..


puppetdbquery: fix argument ordering

Change-Id: I68105ab79c4a67ef9f4bfff9c6c61cab9ca713e1
---
M modules/puppetdbquery/lib/puppetdb/connection.rb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Giuseppe Lavagetto: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/puppetdbquery/lib/puppetdb/connection.rb 
b/modules/puppetdbquery/lib/puppetdb/connection.rb
index c080ece..e13e6ab 100644
--- a/modules/puppetdbquery/lib/puppetdb/connection.rb
+++ b/modules/puppetdbquery/lib/puppetdb/connection.rb
@@ -90,7 +90,7 @@
   # @param endpoint [Symbol] :resources, :facts or :nodes
   # @param query [Array] query to execute
   # @return [Array] the results of the query
-  def query(endpoint, query = nil, http = nil, version = :v3, order_by = nil)
+  def query(endpoint, query = nil, http = nil, order_by = nil, version = :v3)
 require 'json'
 
 unless http

-- 
To view, visit https://gerrit.wikimedia.org/r/311429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68105ab79c4a67ef9f4bfff9c6c61cab9ca713e1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetdbquery: fix argument ordering

[Giuseppe Lavagetto (Code Review)]

Giuseppe Lavagetto has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311429

Change subject: puppetdbquery: fix argument ordering
..

puppetdbquery: fix argument ordering

Change-Id: I68105ab79c4a67ef9f4bfff9c6c61cab9ca713e1
---
M modules/puppetdbquery/lib/puppetdb/connection.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/29/311429/1

diff --git a/modules/puppetdbquery/lib/puppetdb/connection.rb 
b/modules/puppetdbquery/lib/puppetdb/connection.rb
index c080ece..e13e6ab 100644
--- a/modules/puppetdbquery/lib/puppetdb/connection.rb
+++ b/modules/puppetdbquery/lib/puppetdb/connection.rb
@@ -90,7 +90,7 @@
   # @param endpoint [Symbol] :resources, :facts or :nodes
   # @param query [Array] query to execute
   # @return [Array] the results of the query
-  def query(endpoint, query = nil, http = nil, version = :v3, order_by = nil)
+  def query(endpoint, query = nil, http = nil, order_by = nil, version = :v3)
 require 'json'
 
 unless http

-- 
To view, visit https://gerrit.wikimedia.org/r/311429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68105ab79c4a67ef9f4bfff9c6c61cab9ca713e1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits