[MediaWiki-commits] [Gerrit] operations/puppet[production]: gerrit: Fix CSS selector for diff font size override

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged.

Change subject: gerrit: Fix CSS selector for diff font size override
..


gerrit: Fix CSS selector for diff font size override

Because Gerrit's CSS sets a font size of `small` for `table td`
elements, overriding it on the containing table element has no
effect. Overriding the font size on the child div element (the
element on which the `monospace` font family is set) does work.

Also, the font size for comment boxes is explicitly set to
prevent it from changing in other browsers such as Chrome.

Bug: T141286
Change-Id: I138c0817bd5bb475a5e5dc7a5d71611039bc17fa
---
M modules/gerrit/files/etc/GerritSite.css
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  Dzahn: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/gerrit/files/etc/GerritSite.css 
b/modules/gerrit/files/etc/GerritSite.css
index 9f8de49..db547f8 100644
--- a/modules/gerrit/files/etc/GerritSite.css
+++ b/modules/gerrit/files/etc/GerritSite.css
@@ -144,9 +144,12 @@
  * https://phabricator.wikimedia.org/T42941
  * Gerrit diff font isn't big enough, either
  */
-.com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-table {
+.com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-table 
.CodeMirror {
font-size: 9pt !important;
 }
+.com-google-gerrit-client-diff-CommentBox-Style-commentWidgets {
+   font-size: small !important;
+}
 
 /**
  * LDAP login

-- 
To view, visit https://gerrit.wikimedia.org/r/315511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I138c0817bd5bb475a5e5dc7a5d71611039bc17fa
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: PleaseStand 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: gerrit: Fix CSS selector for diff font size override

[PleaseStand (Code Review)]

PleaseStand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315511

Change subject: gerrit: Fix CSS selector for diff font size override
..

gerrit: Fix CSS selector for diff font size override

Because Gerrit's CSS sets a font size of `small` for `table td`
elements, overriding it on the containing table element has no
effect. Overriding the font size on the child div element (the
element on which the `monospace` font family is set) does work.

Bug: T141286
Change-Id: I138c0817bd5bb475a5e5dc7a5d71611039bc17fa
---
M modules/gerrit/files/etc/GerritSite.css
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/11/315511/1

diff --git a/modules/gerrit/files/etc/GerritSite.css 
b/modules/gerrit/files/etc/GerritSite.css
index 9f8de49..82a34c8 100644
--- a/modules/gerrit/files/etc/GerritSite.css
+++ b/modules/gerrit/files/etc/GerritSite.css
@@ -144,7 +144,7 @@
  * https://phabricator.wikimedia.org/T42941
  * Gerrit diff font isn't big enough, either
  */
-.com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-table {
+.com-google-gerrit-client-diff-DiffTable_BinderImpl_GenCss_style-table 
.CodeMirror {
font-size: 9pt !important;
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/315511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I138c0817bd5bb475a5e5dc7a5d71611039bc17fa
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: PleaseStand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits