[MediaWiki-commits] [Gerrit] operations/puppet[production]: site: remove duplicate firewall include on some appservers
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405984 ) Change subject: site: remove duplicate firewall include on some appservers .. site: remove duplicate firewall include on some appservers mediawiki::appservers alredy includes base::firewall, it's duplicate to add it in site.pp as well nowadays and causes a style warning. Change-Id: I25038812cb5171b14e3473bb789fa2858e8c0ba3 --- M manifests/site.pp 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/manifests/site.pp b/manifests/site.pp index fefd1f0..71bc824 100644 --- a/manifests/site.pp +++ b/manifests/site.pp @@ -1561,7 +1561,6 @@ #mw2097, mw2100-mw2117 are appservers node /^mw2(097|10[0-9]|11[0-7])\.codfw\.wmnet$/ { role(mediawiki::appserver) -include ::base::firewall } #mw2120-2147 are api appservers -- To view, visit https://gerrit.wikimedia.org/r/405984 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25038812cb5171b14e3473bb789fa2858e8c0ba3 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn Gerrit-Reviewer: Dzahn Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] operations/puppet[production]: site: remove duplicate firewall include on some appservers
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405984 ) Change subject: site: remove duplicate firewall include on some appservers .. site: remove duplicate firewall include on some appservers mediawiki::appservers alredy includes base::firewall, it's duplicate to add it in site.pp as well nowadays and causes a style warning. Change-Id: I25038812cb5171b14e3473bb789fa2858e8c0ba3 --- M manifests/site.pp 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/84/405984/1 diff --git a/manifests/site.pp b/manifests/site.pp index fefd1f0..71bc824 100644 --- a/manifests/site.pp +++ b/manifests/site.pp @@ -1561,7 +1561,6 @@ #mw2097, mw2100-mw2117 are appservers node /^mw2(097|10[0-9]|11[0-7])\.codfw\.wmnet$/ { role(mediawiki::appserver) -include ::base::firewall } #mw2120-2147 are api appservers -- To view, visit https://gerrit.wikimedia.org/r/405984 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25038812cb5171b14e3473bb789fa2858e8c0ba3 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits