[MediaWiki-commits] [Gerrit] operations/puppet[production]: xhgui: Restrict to domain networks

2016-10-12 Thread Muehlenhoff (Code Review) 
Muehlenhoff has submitted this change and it was merged.

Change subject: xhgui: Restrict to domain networks
..


xhgui: Restrict to domain networks

Only accessed from production networks in production, use DOMAIN_NETWORKS
to allow to be used in a base::firewall-enabled labs instance.

Change-Id: Ide3157490b80bfcd8a3ca765f45b69bf1054bdfc
---
M manifests/role/xhgui.pp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Muehlenhoff: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/role/xhgui.pp b/manifests/role/xhgui.pp
index c9a41db..345c397 100644
--- a/manifests/role/xhgui.pp
+++ b/manifests/role/xhgui.pp
@@ -60,13 +60,13 @@
 ferm::service { 'xhgui_mongodb':
 port   => 27017,
 proto  => 'tcp',
-srange => '$INTERNAL',
+srange => '$DOMAIN_NETWORKS',
 }
 
 ferm::service { 'xhgui_http':
 port   => 80,
 proto  => 'tcp',
-srange => '$INTERNAL',
+srange => '$DOMAIN_NETWORKS',
 }
 
 git::clone { 'operations/software/xhprof':

-- 
To view, visit https://gerrit.wikimedia.org/r/304831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide3157490b80bfcd8a3ca765f45b69bf1054bdfc
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: xhgui: Restrict to domain networks

2016-08-15 Thread Muehlenhoff (Code Review) 
Muehlenhoff has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/304831

Change subject: xhgui: Restrict to domain networks
..

xhgui: Restrict to domain networks

Only accessed from production networks in production, use DOMAIN_NETWORKS
to allow to be used in a base::firewall-enabled labs instance.

Change-Id: Ide3157490b80bfcd8a3ca765f45b69bf1054bdfc
---
M manifests/role/xhgui.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/31/304831/1

diff --git a/manifests/role/xhgui.pp b/manifests/role/xhgui.pp
index 8103532..dd45e98 100644
--- a/manifests/role/xhgui.pp
+++ b/manifests/role/xhgui.pp
@@ -60,13 +60,13 @@
 ferm::service { 'xhgui_mongodb':
 port   => 27017,
 proto  => 'tcp',
-srange => '$INTERNAL',
+srange => '$DOMAIN_NETWORKS',
 }
 
 ferm::service { 'xhgui_http':
 port   => 80,
 proto  => 'tcp',
-srange => '$INTERNAL',
+srange => '$DOMAIN_NETWORKS',
 }
 
 git::clone { 'operations/software/xhprof':

-- 
To view, visit https://gerrit.wikimedia.org/r/304831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide3157490b80bfcd8a3ca765f45b69bf1054bdfc
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits