jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/370160 )
Change subject: Escape content differences ...................................................................... Escape content differences Sadly, it can include html and we need to escape the content to have the correct representation of text changes. Bug: T172362 Change-Id: Ifd844d36ae6128b067c787e5d94764d7716ab019 --- M puppet_compiler/templates/diffs.jinja2 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Giuseppe Lavagetto: Looks good to me, approved jenkins-bot: Verified diff --git a/puppet_compiler/templates/diffs.jinja2 b/puppet_compiler/templates/diffs.jinja2 index e98bbf2..9528d65 100644 --- a/puppet_compiler/templates/diffs.jinja2 +++ b/puppet_compiler/templates/diffs.jinja2 @@ -34,7 +34,7 @@ {% endif %} {% if diff.content %} <dd> Content differences: - <pre>{{ diff.content }}</pre> + <pre>{{ diff.content|e }}</pre> </dd> {% endif %} </dl> -- To view, visit https://gerrit.wikimedia.org/r/370160 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd844d36ae6128b067c787e5d94764d7716ab019 Gerrit-PatchSet: 3 Gerrit-Project: operations/software/puppet-compiler Gerrit-Branch: master Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org> Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org> Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits