[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] Fix assertRaisesRegex call

2017-08-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370641 )

Change subject: [bugfix] Fix assertRaisesRegex call
..


[bugfix] Fix assertRaisesRegex call

Bug: T172770
Change-Id: I9fb75cf2ee9707a65ebe3a9bf32a4cbf527f030d
---
M tests/page_tests.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved



diff --git a/tests/page_tests.py b/tests/page_tests.py
index c6d659c..b4d9a5e 100644
--- a/tests/page_tests.py
+++ b/tests/page_tests.py
@@ -567,10 +567,10 @@
 # for file pages, the API should return the file itself
 self.assertEqual(image.page_image(), image)
 else:
-self.assertRaises(pywikibot.UnknownExtension,
-  'Method "loadpageimage" is not implemented '
-  'without the extension PageImages',
-  mainpage.page_image)
+self.assertRaisesRegex(pywikibot.UnknownExtension,
+   'Method "loadpageimage" is not implemented '
+   'without the extension PageImages',
+   mainpage.page_image)
 
 
 class TestPageDeprecation(DefaultSiteTestCase, DeprecationTestCase):

-- 
To view, visit https://gerrit.wikimedia.org/r/370641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9fb75cf2ee9707a65ebe3a9bf32a4cbf527f030d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] Fix assertRaisesRegex call

2017-08-08 Thread Xqt (Code Review)
Xqt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370641 )

Change subject: [bugfix] Fix assertRaisesRegex call
..

[bugfix] Fix assertRaisesRegex call

Bug: T172770
Change-Id: I9fb75cf2ee9707a65ebe3a9bf32a4cbf527f030d
---
M tests/page_tests.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/41/370641/1

diff --git a/tests/page_tests.py b/tests/page_tests.py
index c6d659c..b4d9a5e 100644
--- a/tests/page_tests.py
+++ b/tests/page_tests.py
@@ -567,10 +567,10 @@
 # for file pages, the API should return the file itself
 self.assertEqual(image.page_image(), image)
 else:
-self.assertRaises(pywikibot.UnknownExtension,
-  'Method "loadpageimage" is not implemented '
-  'without the extension PageImages',
-  mainpage.page_image)
+self.assertRaisesRegex(pywikibot.UnknownExtension,
+   'Method "loadpageimage" is not implemented '
+   'without the extension PageImages',
+   mainpage.page_image)
 
 
 class TestPageDeprecation(DefaultSiteTestCase, DeprecationTestCase):

-- 
To view, visit https://gerrit.wikimedia.org/r/370641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fb75cf2ee9707a65ebe3a9bf32a4cbf527f030d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits