[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Temporarily disable query box hiding

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371471 )

Change subject: Temporarily disable query box hiding
..


Temporarily disable query box hiding

Should be re-enabled once problems with big queries are fixed.

Bug: T172728
Change-Id: I6b1853b7549d6779c12109d1fa136c77d12f727d
---
M wikibase/queryService/ui/App.js
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Smalyshev: Looks good to me, but someone else must approve
  Jonas Kress (WMDE): Looks good to me, approved
  Lucas Werkmeister (WMDE): Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index fbf4796..3df552a 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -124,7 +124,9 @@
this._initQuery();
this._initRdfNamespaces();
this._initHandlers();
-
+   /*
+   // Temporarily disabled as fix for T172728
+   // TODO: re-enable once the problems are resolved
$( window ).scroll( function () {
var minScroll = $( '#query-box' ).offset().top + $( 
'#query-box' ).height() - $( window ).height();
 
@@ -142,7 +144,7 @@
duration: 100
} );
}
-   } );
+   } ); */
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/371471
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b1853b7549d6779c12109d1fa136c77d12f727d
Gerrit-PatchSet: 3
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Smalyshev 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Lucas Werkmeister (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Temporarily disable query box hiding

[Smalyshev (Code Review)]

Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371471 )

Change subject: Temporarily disable query box hiding
..

Temporarily disable query box hiding

Should be re-enabled once problems with big queries are fixed.

Bug: T172728
Change-Id: I6b1853b7549d6779c12109d1fa136c77d12f727d
---
M wikibase/queryService/ui/App.js
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/71/371471/1

diff --git a/wikibase/queryService/ui/App.js b/wikibase/queryService/ui/App.js
index fbf4796..51a86cf 100644
--- a/wikibase/queryService/ui/App.js
+++ b/wikibase/queryService/ui/App.js
@@ -126,6 +126,9 @@
this._initHandlers();
 
$( window ).scroll( function () {
+   // Temporarily disabled as fix for T172728
+   // TODO: re-enable once the problems are resolved
+   return;
var minScroll = $( '#query-box' ).offset().top + $( 
'#query-box' ).height() - $( window ).height();
 
if ( minScroll + 100 < $( this ).scrollTop() && $( this 
).scrollTop() > 1 ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/371471
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b1853b7549d6779c12109d1fa136c77d12f727d
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits