[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix how we get queue for RequeueDelayedMessages

2016-10-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix how we get queue for RequeueDelayedMessages
..


Fix how we get queue for RequeueDelayedMessages

Use the method that ensures a 'queue' argument

Change-Id: Ib865d351ced835848e0dd9b8e5c579327022
---
M Maintenance/RequeueDelayedMessages.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Awight: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Maintenance/RequeueDelayedMessages.php 
b/Maintenance/RequeueDelayedMessages.php
index be16a74..1d0eb6a 100644
--- a/Maintenance/RequeueDelayedMessages.php
+++ b/Maintenance/RequeueDelayedMessages.php
@@ -6,6 +6,7 @@
 use SmashPig\Core\Configuration;
 use SmashPig\Core\Logging\Logger;
 use SmashPig\Core\DataStores\DamagedDatabase;
+use SmashPig\Core\QueueConsumers\BaseQueueConsumer;
 
 $maintClass = '\SmashPig\Maintenance\RequeueDelayedMessages';
 
@@ -42,7 +43,7 @@
foreach( $messages as $message ) {
$queueName = $message['original_queue'];
// FIXME: getting it by alias, this will be annoying 
cos -new
-   $queue = $config->object( "data-store/$queueName", true 
);
+   $queue = BaseQueueConsumer::getQueue( $queueName );
unset( $message['original_queue'] );
$queue->push( $message );
$this->damagedDatabase->deleteMessage( $message );

-- 
To view, visit https://gerrit.wikimedia.org/r/315580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib865d351ced835848e0dd9b8e5c579327022
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Cdentinger 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Fix how we get queue for RequeueDelayedMessages

2016-10-12 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315580

Change subject: Fix how we get queue for RequeueDelayedMessages
..

Fix how we get queue for RequeueDelayedMessages

Use the method that ensures a 'queue' argument

Change-Id: Ib865d351ced835848e0dd9b8e5c579327022
---
M Maintenance/RequeueDelayedMessages.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/80/315580/1

diff --git a/Maintenance/RequeueDelayedMessages.php 
b/Maintenance/RequeueDelayedMessages.php
index be16a74..1d0eb6a 100644
--- a/Maintenance/RequeueDelayedMessages.php
+++ b/Maintenance/RequeueDelayedMessages.php
@@ -6,6 +6,7 @@
 use SmashPig\Core\Configuration;
 use SmashPig\Core\Logging\Logger;
 use SmashPig\Core\DataStores\DamagedDatabase;
+use SmashPig\Core\QueueConsumers\BaseQueueConsumer;
 
 $maintClass = '\SmashPig\Maintenance\RequeueDelayedMessages';
 
@@ -42,7 +43,7 @@
foreach( $messages as $message ) {
$queueName = $message['original_queue'];
// FIXME: getting it by alias, this will be annoying 
cos -new
-   $queue = $config->object( "data-store/$queueName", true 
);
+   $queue = BaseQueueConsumer::getQueue( $queueName );
unset( $message['original_queue'] );
$queue->push( $message );
$this->damagedDatabase->deleteMessage( $message );

-- 
To view, visit https://gerrit.wikimedia.org/r/315580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib865d351ced835848e0dd9b8e5c579327022
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits