[MediaWiki-commits] [Gerrit] wikimedia...rainbow[develop]: Annotate sample rate change

2017-08-09 Thread Chelsyx (Code Review)
Chelsyx has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370857 )

Change subject: Annotate sample rate change
..


Annotate sample rate change

On April 25th, we changed the sample rates for several projects, which results 
in changes in our search metrics.

Bug: T172428
Change-Id: I709222fa4fad807762c23858e6c00c43d0747d9a
---
M modules/desktop/events.R
M modules/desktop/load_times.R
M modules/desktop/paulscore.R
M modules/page_visit_times.R
M tab_documentation/desktop_events.md
M tab_documentation/desktop_load.md
M tab_documentation/paulscore_approx.html
M tab_documentation/survival.md
8 files changed, 12 insertions(+), 6 deletions(-)

Approvals:
  Chelsyx: Verified; Looks good to me, approved



diff --git a/modules/desktop/events.R b/modules/desktop/events.R
index bcfd686..4f94e44 100644
--- a/modules/desktop/events.R
+++ b/modules/desktop/events.R
@@ -32,5 +32,6 @@
 polloi::make_dygraph(xlab = "Date", ylab = "Events", title = "Desktop 
search events, by day") %>%
 dyRangeSelector %>%
 dyEvent(as.Date("2016-07-12"), "A (schema switch)", labelLoc = "bottom") 
%>%
-dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom")
+dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom") 
%>%
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
 })
diff --git a/modules/desktop/load_times.R b/modules/desktop/load_times.R
index 50fb49a..a797c80 100644
--- a/modules/desktop/load_times.R
+++ b/modules/desktop/load_times.R
@@ -5,5 +5,6 @@
 dyRangeSelector %>%
 dyEvent(as.Date("2016-07-12"), "A (schema switch)", labelLoc = "bottom") 
%>%
 dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom") 
%>%
-dyEvent(as.Date("2017-06-15"), "B (sister search)", labelLoc = "bottom")
+dyEvent(as.Date("2017-06-15"), "B (sister search)", labelLoc = "bottom") 
%>%
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
 })
diff --git a/modules/desktop/paulscore.R b/modules/desktop/paulscore.R
index 144569b..b0ffb14 100644
--- a/modules/desktop/paulscore.R
+++ b/modules/desktop/paulscore.R
@@ -10,7 +10,7 @@
 polloi::make_dygraph(xlab = "Date", ylab = "PaulScore", title = "PaulScore 
for fulltext searches, by day", use_si = FALSE, group = "paulscore_approx") %>%
 dyRangeSelector %>%
 dyLegend(labelsDiv = "paulscore_approx_legend", show = "always") %>%
-dyEvent(as.Date("2017-04-19"), "A (rates)", labelLoc = "bottom")
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
   if (input$paulscore_relative) {
 dyOut <- dyAxis(dyOut, "y", axisLabelFormatter = "function(x) { return 
Math.round(100 * x, 3) + '%'; }", valueFormatter = "function(x) { return 
Math.round(100 * x, 3) + '%'; }")
   }
@@ -29,7 +29,7 @@
 polloi::make_dygraph(xlab = "Date", ylab = "PaulScore", title = "PaulScore 
for autocomplete searches, by day", use_si = FALSE, group = "paulscore_approx") 
%>%
 dyRangeSelector %>%
 dyLegend(labelsDiv = "paulscore_approx_legend", show = "always") %>%
-dyEvent(as.Date("2017-04-19"), "A (rates)", labelLoc = "bottom")
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
   if (input$paulscore_relative) {
 dyOut <- dyAxis(dyOut, "y", axisLabelFormatter = "function(x) { return 
Math.round(100 * x, 3) + '%'; }", valueFormatter = "function(x) { return 
Math.round(100 * x, 3) + '%'; }")
   }
diff --git a/modules/page_visit_times.R b/modules/page_visit_times.R
index 4a51a78..115cbb4 100644
--- a/modules/page_visit_times.R
+++ b/modules/page_visit_times.R
@@ -6,5 +6,6 @@
axisLabelWidth = 100, pixelsPerLabel = 80) %>%
 dyLegend(labelsDiv = "lethal_dose_plot_legend") %>%
 dyRangeSelector(fillColor = "", strokeColor = "") %>%
-dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom")
+dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom") 
%>%
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
 })
diff --git a/tab_documentation/desktop_events.md 
b/tab_documentation/desktop_events.md
index 94c5f95..be4d9d8 100644
--- a/tab_documentation/desktop_events.md
+++ b/tab_documentation/desktop_events.md
@@ -21,6 +21,7 @@
 * Data in late September/early October 2015 is unavailable due to another bug 
in EventLogging as a whole, which impacted data collection.
 * '__A__': we switched to using data from 
[Schema:TestSearchSatisfaction2](https://meta.wikimedia.org/wiki/Schema:TestSearchSatisfaction2)
 instead of [Schema:Search](https://meta.wikimedia.org/wiki/Schema:Search) for 
Desktop event counts and load times on 12 July 2016.
 * '__R__': on 2017-01-01 we started calculating all of Discovery's metrics 
using a new version of [our data retrieval and processing 
codebase](https://phabricator.wikimedia.org/diffusion/WDGO/) that we migrated 
to [Wikimedia 

[MediaWiki-commits] [Gerrit] wikimedia...rainbow[develop]: Annotate sample rate change

2017-08-09 Thread Chelsyx (Code Review)
Chelsyx has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370857 )

Change subject: Annotate sample rate change
..

Annotate sample rate change

On April 25th, we changed the sample rates for several projects, which results 
in changes in our search metrics.

Bug: T172428
Change-Id: I709222fa4fad807762c23858e6c00c43d0747d9a
---
M modules/desktop/events.R
M modules/desktop/load_times.R
M modules/desktop/paulscore.R
M modules/page_visit_times.R
M tab_documentation/desktop_events.md
M tab_documentation/desktop_load.md
M tab_documentation/paulscore_approx.html
M tab_documentation/survival.md
8 files changed, 12 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/rainbow 
refs/changes/57/370857/1

diff --git a/modules/desktop/events.R b/modules/desktop/events.R
index bcfd686..4f94e44 100644
--- a/modules/desktop/events.R
+++ b/modules/desktop/events.R
@@ -32,5 +32,6 @@
 polloi::make_dygraph(xlab = "Date", ylab = "Events", title = "Desktop 
search events, by day") %>%
 dyRangeSelector %>%
 dyEvent(as.Date("2016-07-12"), "A (schema switch)", labelLoc = "bottom") 
%>%
-dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom")
+dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom") 
%>%
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
 })
diff --git a/modules/desktop/load_times.R b/modules/desktop/load_times.R
index 50fb49a..a797c80 100644
--- a/modules/desktop/load_times.R
+++ b/modules/desktop/load_times.R
@@ -5,5 +5,6 @@
 dyRangeSelector %>%
 dyEvent(as.Date("2016-07-12"), "A (schema switch)", labelLoc = "bottom") 
%>%
 dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom") 
%>%
-dyEvent(as.Date("2017-06-15"), "B (sister search)", labelLoc = "bottom")
+dyEvent(as.Date("2017-06-15"), "B (sister search)", labelLoc = "bottom") 
%>%
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
 })
diff --git a/modules/desktop/paulscore.R b/modules/desktop/paulscore.R
index 144569b..b0ffb14 100644
--- a/modules/desktop/paulscore.R
+++ b/modules/desktop/paulscore.R
@@ -10,7 +10,7 @@
 polloi::make_dygraph(xlab = "Date", ylab = "PaulScore", title = "PaulScore 
for fulltext searches, by day", use_si = FALSE, group = "paulscore_approx") %>%
 dyRangeSelector %>%
 dyLegend(labelsDiv = "paulscore_approx_legend", show = "always") %>%
-dyEvent(as.Date("2017-04-19"), "A (rates)", labelLoc = "bottom")
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
   if (input$paulscore_relative) {
 dyOut <- dyAxis(dyOut, "y", axisLabelFormatter = "function(x) { return 
Math.round(100 * x, 3) + '%'; }", valueFormatter = "function(x) { return 
Math.round(100 * x, 3) + '%'; }")
   }
@@ -29,7 +29,7 @@
 polloi::make_dygraph(xlab = "Date", ylab = "PaulScore", title = "PaulScore 
for autocomplete searches, by day", use_si = FALSE, group = "paulscore_approx") 
%>%
 dyRangeSelector %>%
 dyLegend(labelsDiv = "paulscore_approx_legend", show = "always") %>%
-dyEvent(as.Date("2017-04-19"), "A (rates)", labelLoc = "bottom")
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
   if (input$paulscore_relative) {
 dyOut <- dyAxis(dyOut, "y", axisLabelFormatter = "function(x) { return 
Math.round(100 * x, 3) + '%'; }", valueFormatter = "function(x) { return 
Math.round(100 * x, 3) + '%'; }")
   }
diff --git a/modules/page_visit_times.R b/modules/page_visit_times.R
index 4a51a78..115cbb4 100644
--- a/modules/page_visit_times.R
+++ b/modules/page_visit_times.R
@@ -6,5 +6,6 @@
axisLabelWidth = 100, pixelsPerLabel = 80) %>%
 dyLegend(labelsDiv = "lethal_dose_plot_legend") %>%
 dyRangeSelector(fillColor = "", strokeColor = "") %>%
-dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom")
+dyEvent(as.Date("2017-01-01"), "R (reportupdater)", labelLoc = "bottom") 
%>%
+dyEvent(as.Date("2017-04-25"), "S (rates)", labelLoc = "bottom")
 })
diff --git a/tab_documentation/desktop_events.md 
b/tab_documentation/desktop_events.md
index 94c5f95..be4d9d8 100644
--- a/tab_documentation/desktop_events.md
+++ b/tab_documentation/desktop_events.md
@@ -21,6 +21,7 @@
 * Data in late September/early October 2015 is unavailable due to another bug 
in EventLogging as a whole, which impacted data collection.
 * '__A__': we switched to using data from 
[Schema:TestSearchSatisfaction2](https://meta.wikimedia.org/wiki/Schema:TestSearchSatisfaction2)
 instead of [Schema:Search](https://meta.wikimedia.org/wiki/Schema:Search) for 
Desktop event counts and load times on 12 July 2016.
 * '__R__': on 2017-01-01 we started calculating all of Discovery's metrics 
using a new version of [our data retrieval and processing 
codebase](https://phabricator.wikimedia.org/diffusion/WDGO/) that we migrated 
to [Wikimedia