[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Vendor update, omnimail-silverpop.
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379419 )
Change subject: Vendor update, omnimail-silverpop.
..
Vendor update, omnimail-silverpop.
Add support for offset parameter to recipient retrieval
Change-Id: I50f65ff6f6c2e1dd2060bfb6a77fb8e88aa4a0f7
---
M composer/installed.json
M wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
M wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
3 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Eileen: Looks good to me, approved
diff --git a/composer/installed.json b/composer/installed.json
index 1af2f47..fee000a 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2277,7 +2277,7 @@
"source": {
"type": "git",
"url":
"https://github.com/eileenmcnaughton/omnimail-silverpop.git;,
-"reference": "313ef51cc3990238438f5dc5207b25cb132ea131"
+"reference": "288f2602952468a4fd5874b11b1bd8da5b0dfb7b"
},
"require": {
"league/csv": "^8.0",
@@ -2288,7 +2288,7 @@
"require-dev": {
"guzzlehttp/guzzle": "*"
},
-"time": "2017-09-12T23:04:53+00:00",
+"time": "2017-09-20T02:50:06+00:00",
"type": "library",
"installation-source": "source",
"autoload": {
diff --git
a/wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
b/wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
index 28cc42b..787779e 100644
---
a/wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
+++
b/wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
@@ -9,7 +9,7 @@
use Omnimail\Silverpop\Responses\RecipientsResponse;
-class RawRecipientDataExportRequest extends BaseRequest
+class RawRecipientDataExportRequest extends SilverpopBaseRequest
{
protected $retrievalParameters;
@@ -83,6 +83,7 @@
$response = new RecipientsResponse(array());
$response->setRetrievalParameters($this->getRetrievalParameters());
$response->setSilverpop($this->silverPop);
+$response->setOffset($this->getOffset());
$response->setContactReferenceField($this->getContactReferenceField());
return $response;
}
diff --git a/wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
b/wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
index 7d7c9cf..1bf9685 100644
--- a/wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
+++ b/wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
@@ -112,6 +112,7 @@
return $rowIndex != 0;
};
$this->reader->addFilter($filterOutRow);
+$this->reader->setOffset($this->getOffset());
$formatFunction = function ($row) {
if (isset($row['email'])) {
--
To view, visit https://gerrit.wikimedia.org/r/379419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50f65ff6f6c2e1dd2060bfb6a77fb8e88aa4a0f7
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/vendor
Gerrit-Branch: master
Gerrit-Owner: Eileen
Gerrit-Reviewer: Eileen
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wikimedia...vendor[master]: Vendor update, omnimail-silverpop.
Eileen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379419 )
Change subject: Vendor update, omnimail-silverpop.
..
Vendor update, omnimail-silverpop.
Add support for offset parameter to recipient retrieval
Change-Id: I50f65ff6f6c2e1dd2060bfb6a77fb8e88aa4a0f7
---
M composer/installed.json
M wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
M wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
3 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/vendor
refs/changes/19/379419/1
diff --git a/composer/installed.json b/composer/installed.json
index 1af2f47..fee000a 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2277,7 +2277,7 @@
"source": {
"type": "git",
"url":
"https://github.com/eileenmcnaughton/omnimail-silverpop.git;,
-"reference": "313ef51cc3990238438f5dc5207b25cb132ea131"
+"reference": "288f2602952468a4fd5874b11b1bd8da5b0dfb7b"
},
"require": {
"league/csv": "^8.0",
@@ -2288,7 +2288,7 @@
"require-dev": {
"guzzlehttp/guzzle": "*"
},
-"time": "2017-09-12T23:04:53+00:00",
+"time": "2017-09-20T02:50:06+00:00",
"type": "library",
"installation-source": "source",
"autoload": {
diff --git
a/wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
b/wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
index 28cc42b..787779e 100644
---
a/wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
+++
b/wikimedia/omnimail-silverpop/src/Requests/RawRecipientDataExportRequest.php
@@ -9,7 +9,7 @@
use Omnimail\Silverpop\Responses\RecipientsResponse;
-class RawRecipientDataExportRequest extends BaseRequest
+class RawRecipientDataExportRequest extends SilverpopBaseRequest
{
protected $retrievalParameters;
@@ -83,6 +83,7 @@
$response = new RecipientsResponse(array());
$response->setRetrievalParameters($this->getRetrievalParameters());
$response->setSilverpop($this->silverPop);
+$response->setOffset($this->getOffset());
$response->setContactReferenceField($this->getContactReferenceField());
return $response;
}
diff --git a/wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
b/wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
index 7d7c9cf..1bf9685 100644
--- a/wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
+++ b/wikimedia/omnimail-silverpop/src/Responses/RecipientsResponse.php
@@ -112,6 +112,7 @@
return $rowIndex != 0;
};
$this->reader->addFilter($filterOutRow);
+$this->reader->setOffset($this->getOffset());
$formatFunction = function ($row) {
if (isset($row['email'])) {
--
To view, visit https://gerrit.wikimedia.org/r/379419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50f65ff6f6c2e1dd2060bfb6a77fb8e88aa4a0f7
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/vendor
Gerrit-Branch: master
Gerrit-Owner: Eileen
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
