[MediaWiki-commits] [Gerrit] workaround for unfinished thumbs on history list - change (apps...wikipedia)

2014-12-05 Thread Mhurd (Code Review) 
Mhurd has submitted this change and it was merged.

Change subject: workaround for unfinished thumbs on history list
..


workaround for unfinished thumbs on history list

Change-Id: Id052300806e5f3615c7ae87316557ad92db234d1
---
M wikipedia/View Controllers/History/HistoryViewController.m
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Mhurd: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikipedia/View Controllers/History/HistoryViewController.m 
b/wikipedia/View Controllers/History/HistoryViewController.m
index 48ced7e..59ef594 100644
--- a/wikipedia/View Controllers/History/HistoryViewController.m
+++ b/wikipedia/View Controllers/History/HistoryViewController.m
@@ -346,7 +346,10 @@
 cell.methodLabel.attributedText = [self 
getIconLabelAttributedStringForDiscoveryMethod:historyEntry.discoveryMethod];
 
 MWKArticleStore *articleStore = [[SessionSingleton 
sharedInstance].dataStore articleStoreWithTitle:historyEntry.title];
-UIImage *thumbImage = [articleStore 
UIImageWithImage:articleStore.thumbnailImage];
+UIImage *thumbImage;
+if (articleStore.thumbnailImage) {
+thumbImage = [articleStore 
UIImageWithImage:articleStore.thumbnailImage];
+}
 if(thumbImage){
 cell.imageView.image = thumbImage;
 cell.useField = YES;

-- 
To view, visit https://gerrit.wikimedia.org/r/177380
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id052300806e5f3615c7ae87316557ad92db234d1
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Mhurd mh...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] workaround for unfinished thumbs on history list - change (apps...wikipedia)

2014-12-03 Thread Brion VIBBER (Code Review) 
Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177380

Change subject: workaround for unfinished thumbs on history list
..

workaround for unfinished thumbs on history list

Change-Id: Id052300806e5f3615c7ae87316557ad92db234d1
---
M wikipedia/View Controllers/History/HistoryViewController.m
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/80/177380/1

diff --git a/wikipedia/View Controllers/History/HistoryViewController.m 
b/wikipedia/View Controllers/History/HistoryViewController.m
index 48ced7e..59ef594 100644
--- a/wikipedia/View Controllers/History/HistoryViewController.m
+++ b/wikipedia/View Controllers/History/HistoryViewController.m
@@ -346,7 +346,10 @@
 cell.methodLabel.attributedText = [self 
getIconLabelAttributedStringForDiscoveryMethod:historyEntry.discoveryMethod];
 
 MWKArticleStore *articleStore = [[SessionSingleton 
sharedInstance].dataStore articleStoreWithTitle:historyEntry.title];
-UIImage *thumbImage = [articleStore 
UIImageWithImage:articleStore.thumbnailImage];
+UIImage *thumbImage;
+if (articleStore.thumbnailImage) {
+thumbImage = [articleStore 
UIImageWithImage:articleStore.thumbnailImage];
+}
 if(thumbImage){
 cell.imageView.image = thumbImage;
 cell.useField = YES;

-- 
To view, visit https://gerrit.wikimedia.org/r/177380
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id052300806e5f3615c7ae87316557ad92db234d1
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER br...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits