martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
test-chg.t almost passes on py3 after this patch.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6771
AFFECTED FILES
2 new changesets (2 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/cf9dbc7377de
changeset: 42810:cf9dbc7377de
branch: stable
user:Navaneeth Suresh
date:Sun Aug 18 02:47:32 2019 +0530
summary: tests: add test to demonstrate issue6159
valentin.gatienbaron created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6770
AFFECTED FILES
rust/hg-cpython/src/ref_sharing.rs
CHANGE DETAILS
valentin.gatienbaron added inline comments.
valentin.gatienbaron marked 2 inline comments as done.
INLINE COMMENTS
> kevincox wrote in filepatterns.rs:161
> For the other ones I think the problem is that it gets the element type from
> the first element as ``. I think a better approach then
valentin.gatienbaron updated this revision to Diff 16330.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6765?vs=16328=16330
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6765/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6765
kevincox added inline comments.
INLINE COMMENTS
> valentin.gatienbaron wrote in filepatterns.rs:161
> Indeed, although it took a compiler upgrade.
> I don't really understand why the compiler accepts the change here but not in
> the other places. It seems a bit random to remove the borrow only
valentin.gatienbaron added inline comments.
INLINE COMMENTS
> kevincox wrote in filepatterns.rs:161
> I don't think you need the `&_[..]`. https://rust.godbolt.org/z/Wo-vza
Indeed, although it took a compiler upgrade.
I don't really understand why the compiler accepts the change here but not in
valentin.gatienbaron updated this revision to Diff 16327.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6764?vs=16320=16327
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6764/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6764
valentin.gatienbaron created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I would drop this or fold it into the parent depending on reviewers' opinion.
The problem is that byte literals can converted to
valentin.gatienbaron updated this revision to Diff 16328.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6765?vs=16321=16328
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6765/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6765
valentin.gatienbaron updated this revision to Diff 16326.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6766?vs=16319=16326
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6766/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6766
kevincox added inline comments.
kevincox accepted this revision.
INLINE COMMENTS
> utils.rs:44
> fn trim() ->
> +fn chop_prefix(, needle:) -> Option<>;
> }
I have a small preference for `drop_prefix`.
> utils.rs:44
> fn trim() ->
> +fn chop_prefix(, needle:) -> Option<>;
>
kevincox added inline comments.
kevincox accepted this revision.
INLINE COMMENTS
> filepatterns.rs:161
> }
> -let mut res = b".*".to_vec();
> -res.extend(pattern);
> -res
> +[".*"[..], pattern].concat()
> }
I don't think you
Anton Shestakov wrote:
> ср, 28 авг. 2019 г. в 02:08, Victor Sudakov :
>
> > For some reason, your minimalistic example does not work for me (even
> > without any recoding) if there are several commits:
> >
> > $ hg init repo1 ; cd repo1
> > $ fortune > test.txt ; hg commit -A -m test
> > adding
ср, 28 авг. 2019 г. в 02:08, Victor Sudakov :
> For some reason, your minimalistic example does not work for me (even
> without any recoding) if there are several commits:
>
> $ hg init repo1 ; cd repo1
> $ fortune > test.txt ; hg commit -A -m test
> adding test.txt
> $ fortune > test.txt ; hg
15 matches
Mail list logo
