Re: [PATCH] hgrc: search XDG_CONFIG_HOME on Mac

2024-04-24 Thread Augie Fackler
On Mon, Apr 22, 2024, 17:34 Hraban Luyat via Mercurial-devel < mercurial-devel@lists.mercurial-scm.org> wrote: > Hi, did anything happen regarding this patch? Was it rejected / accepted / > ignored? > > On Tuesday, March 26th, 2024 at 1:36 AM, Hraban wrote: > > > > > > > # HG changeset patch > >

Re: [PATCH] httppeer: fix make_peer static - fixed for url-path argument. It has migrated to url-object, but legacy code passed just string

2023-06-24 Thread Augie Fackler
Patch LGTM, but I'm not set up to push to heptapod - can someone else handle that for me? Thanks, Augie On Thu, Jun 22, 2023, 17:01 wrote: > # HG changeset patch > # User alexrayne > # Date 1687465008 -10800 > # Thu Jun 22 23:16:48 2023 +0300 > # Node ID

Re: [PATCH] histedit: fix diff colors

2023-03-19 Thread Augie Fackler
Patch LGTM > On Mar 15, 2023, at 14:55, Jordi Gutiérrez Hermoso wrote: > > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1666906442 14400 > # Thu Oct 27 17:34:02 2022 -0400 > # Node ID 28cad0a7eb26a3bb0edd4623d1ec1c9169eb49e2 > # Parent

Re: [PATCH 7 of 7] client: handle commit messages with \0 characters for all commands

2023-03-16 Thread Augie Fackler
Series LGTM, please feel encouraged to queue. (I’m probably not a great reviewer for hglib at this point either, should we formally hand it over to someone else?) > On Mar 14, 2023, at 04:26, Mathias De Mare wrote: > > # HG changeset patch > # User Mathias De Mare > # Date 1678717940 -3600 >

Re: [PATCH] hglib: make sure configs can be passed to clone command

2023-03-09 Thread Augie Fackler
modulo the file mode weirdness, patch LGTM for hglib > On Mar 8, 2023, at 11:01, Mathias De Maré wrote: > > > > On Wed, Mar 8, 2023 at 3:24 PM Mathias De Mare > wrote: >> # HG changeset patch >> # User Mathias De Mare > > >>

Re: [PATCH] client: handle commit messages with \0 characters

2023-03-09 Thread Augie Fackler
This seems fine - note that we probably need to check individual commands to make sure they responded to -Tjson at least as far back as 3.7 (that’s how far back the hglib test suite looks right now, perhaps due to Python 3 obsoleting anything older?) Queued for hglib > On Mar 8, 2023, at

Re: [PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12

2023-03-09 Thread Augie Fackler
Series LGTM for stable, but last time I queued something from the ML I think I angered the heptapod gods, so I’ll tag a couple of people that can hopefully push this on our behalf. AF > On Mar 7, 2023, at 13:23, Mads Kiilerich wrote: > > # HG changeset patch > # User Mads Kiilerich > # Date

Re: [PATCH] histedit: fix diff colors

2022-10-25 Thread Augie Fackler
This patch looks obviously-correct to me and should be pushed. What’s going on here is that byte_string[index] returns an int, not a byte, so the .startswith() is a strict correctness improvement. Thanks! > On Oct 24, 2022, at 5:05 PM, Jordi Gutiérrez Hermoso > wrote: > > # HG changeset

Re: releasenotes: use re.MULTILINE mode when checking admonitions

2022-10-12 Thread Augie Fackler
Thanks, queued. Note that your patch suffered pretty bad whitespace damage in-flight, as though you copied and pasted the patch into a standard mail client. https://www.mercurial-scm.org/wiki/ContributingChanges#Emailing_patches

Re: mercurial@49497: 2 new changesets

2022-09-22 Thread Augie Fackler
> On Sep 22, 2022, at 14:15, Mercurial Commits wrote: > > https://www.mercurial-scm.org/repo/hg/rev/1baf0fffd82f > changeset: 49497:1baf0fffd82f > bookmark:@ > tag: tip > user:Pierre-Yves David > date:Thu Sep 22 01:50:53 2022 +0200 > summary: run-tests:

Re: Release notes Extension

2022-09-10 Thread Augie Fackler
notes file appears as: > > [sections] > deprecated=Deprecated Features > > This really needs to be added to the documentation for releasenotes > > Craig > > On Sat, Sep 10, 2022 at 11:21 AM Augie Fackler <mailto:r...@durin42.com>> wrote: > (+some relea

Re: Release notes Extension

2022-09-10 Thread Augie Fackler
(+some release notes experts) > On Sep 10, 2022, at 12:35, Craig Ozancin wrote: > > As I move my project to the point I can begin making alpha level releases, I > have decided to start using the releasenotes extension. > > While its use is a bit cryptic for beginners, I was able to get it

Re: recover files from revlog

2022-09-01 Thread Augie Fackler
That’s weird. Does `ls -hl .hg/store/00manifest.i` print anything, or is that file zero-length? Is there anything in .hg/strip-backup? > On Aug 29, 2022, at 9:56 AM, Erik Haugen wrote: > > I have a weird situation. This repository has lots of data: > > $ du -h .hg | tail -1 > 9.0G.hg >

Re: Trying out the ML after OSUOSL migration

2022-06-29 Thread Augie Fackler
Looks like it works! > On Jun 29, 2022, at 18:22, Raphaël Gomès wrote: > > Hi all, > > This email should go through the new system now that the fine folks over at > OSUOSL have taken over the administration of our mailing lists. > > This should mean a lot fewer issues and more bandwidth for

Re: pycompat.ispy3 in tests

2022-05-26 Thread Augie Fackler
Just not done yet AFAIK. Please feel encouraged to rip them out as you see them. > On May 24, 2022, at 8:05 PM, Manuel Jacob wrote: > > I’ve seen that there are some pycompat.ispy3 left in tests/, while they were > removed in mercurial/. Was there a specific reason that they are left in the >

D12609: obsolete: remove two unused constants

2022-05-05 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'm not sure what these constants were intended for, but they have no users so it's time to say goodbye. REPOSITORY rHG Mercurial BRANCH default REVISION

D12608: node: manually implement Debug

2022-05-05 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I got too irritated today with the default Debug implementation of hg::revlog::Node while playing with a new parser. This isn't quite what I wanted, but it

Re: [PATCH] rebase: add boolean config item rebase.norebasesource

2022-05-04 Thread Augie Fackler
> On Apr 20, 2022, at 2:19 PM, C. Masloch wrote: > > # HG changeset patch > # User C. Masloch > # Date 1650475479 -7200 > # Wed Apr 20 19:24:39 2022 +0200 > # Node ID 4fd9ac0558249d24552b9efeed1ac77452c73319 > # Parent f45e1618cbf68aca4e72b6fed8dd2acef6f39a10 > rebase: add boolean

D12603: diff: graduate merge diffs from experimental and add to tweakdefaults

2022-05-04 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I've been using this functionality for two years without incident and it's been outstanding. In my opinion it's time to both remove the experimental warning

Re: [PATCH stable] docs: use proper rst markup for preformatted blocks

2022-05-04 Thread Augie Fackler
This appears to be landed as 363b6. Thanks! On Tue, May 3, 2022 at 10:53 AM Mads Kiilerich wrote: > # HG changeset patch > # User Mads Kiilerich > # Date 1651574481 -7200 > # Tue May 03 12:41:21 2022 +0200 > # Branch stable > # Node ID 1d257c4c15683ee998edcc7dd6caf5a4cb52c820 > # Parent

Re: mercurial: on your commits about hash collisions

2022-04-30 Thread Augie Fackler
Strange. I don’t remember seeing anything in the moderation queue. This user does have nodupes set in mailman, so they won’t get copies of their own messages to the list, but I also don’t see anything on mercurial-devel in April from them. I’ve got nothing. > On Apr 30, 2022, at 15:05, Martin

Re: Mercurial's minimum Rust version

2022-04-28 Thread Augie Fackler
Oh, interesting. Maybe we could get away with "whatever MSRV Firefox uses" as a baseline? On Thu, Apr 28, 2022 at 10:38 AM Julien Cristau wrote: > On Thu, Apr 28, 2022 at 10:29:21AM -0400, Augie Fackler wrote: > > I think Debian (at least) has a mechanism to build packages w

Re: Mercurial's minimum Rust version

2022-04-28 Thread Augie Fackler
I think Debian (at least) has a mechanism to build packages with a newer rustc than they actually distribute. (Note that both your messages got marked as spam for me!) > On Apr 27, 2022, at 5:56 AM, Raphaël Gomès wrote: > > Hi all, > > (Sorry in advance if this mail is a duplicate, we've had

Re: Moving away from Phabricator

2022-04-13 Thread Augie Fackler
> On Apr 13, 2022, at 12:06 PM, Raphaël Gomès wrote: > > Hi everyone, > > It has now been more than a month and our window to migrate out of our VM is > closing down. > Thanks for keeping track of this! > I am happy to report that the new versions of Heptapod and the evolve > extension

Fwd: 6.1.1 and review delay

2022-04-01 Thread Augie Fackler
FYI for packagers > Begin forwarded message: > > From: Raphaël Gomès > Subject: 6.1.1 and review delay > Date: April 1, 2022 at 5:35:54 AM EDT > To: Mercurial-devel > > Hi all, > > I've been quite busy this week, not just for personal reasons, but also try > to find the source of a

Re: Python 3.x version support / dropping 3.5 and 3.6

2022-03-02 Thread Augie Fackler
> On Mar 1, 2022, at 2:53 PM, Raphaël Gomès wrote: > > > On 2/27/22 22:19, Gregory Szorc wrote: >> 6.1 will be the last release to support Python 2.7. That means 6.2 will be >> Python 3 only. >> >> Currently our Python 3 support is for 3.5-3.10. >> >> Python 3.5 dropped out of support in

D12279: cleanup: directly use concurrent.futures instead of via pycompat

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Python 2 is gone. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12279

D12283: rust: jettison Python 2 support

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12283 AFFECTED FILES rust/Cargo.lock

D12282: setup: always decode xcode version

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Not decoding was a Python 2 thing. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12281: setup: remove Rust support for Python 2

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12281 AFFECTED FILES setup.py CHANGE DETAILS

D12280: cleanup: stop bundling concurrent.futures on Python 2

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We no longer support Python 2. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12277: setup: remove pygit2 Python 2 logic

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12277 AFFECTED FILES setup.py CHANGE DETAILS

D12278: imports: allow importing futures from concurrent

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12278 AFFECTED FILES contrib/import-checker.py

D12276: setup: inline now-constant list

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This varied when we supported Python 2. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12275: setup: unconditionally do this python 3 step

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12275 AFFECTED FILES setup.py CHANGE DETAILS

D12274: setup: remove Python 2 support code for determining dylib suffix

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12274 AFFECTED FILES setup.py CHANGE DETAILS

D12273: setup: inline os.fsdecode now that we're done with Python 2

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12273 AFFECTED FILES setup.py CHANGE DETAILS

D12272: setup: inline encoding constant that is only used once

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was variable back when we supported Python 2. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12271: setup: remove printf trampoline

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12271 AFFECTED FILES setup.py CHANGE DETAILS

D12270: setup: remove more Python 2 support code

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'll inline print() etc in future patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12269: setup: remove ssl check that only matters on 2.7

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12269 AFFECTED FILES setup.py CHANGE DETAILS

D12268: setup: remove block that tries to help Python 2.6 users

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It's time to move on folks. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12266: setup: drop statement of support for Python before 3.5.3

2022-03-02 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY  REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12266 AFFECTED FILES

D12186: sparse: add timing block for parsing sparse configs

2022-02-15 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was showing up in an operation I was doing today, and I'd like to be able to get trace spans for it instead of just profiler samples. REPOSITORY rHG

D12185: narrowspec: add timing block for validating narrowspec

2022-02-15 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was showing up in an operation I was doing today, and I'd like to be able to get trace spans for it instead of just profiler samples. REPOSITORY rHG

D11958: git: add opener attribute to gitstore

2022-01-05 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11958 AFFECTED FILES hgext/git/__init__.py CHANGE DETAILS diff --git

Re: Version Control for Binary Files?

2022-01-03 Thread Augie Fackler
> On Dec 30, 2021, at 10:38 AM, Simon Harrison wrote: > > Hi list. This is a bit of a stab in the dark, and I'm just after some > pointers/ideas really. > > For a project I'm working on, I'm hosting some PDF's, docx's etc for > various companies. Obviously, files will be added, moved,

Re: [PATCH] help: properly document the default pattern

2021-12-27 Thread Augie Fackler
Queued, thanks. > On Dec 26, 2021, at 1:46 PM, Jordi Gutiérrez Hermoso > wrote: > > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550269232 18000 > # Fri Feb 15 17:20:32 2019 -0500 > # Node ID e5b62cbab03e443841b23a333aac035ad3987fbf > # Parent

Re: Mercurial development funding

2021-12-16 Thread Augie Fackler
It’s a mix. Some things happen due to individuals being enthusiastic, and some things are results of corporations sponsoring work that’s important to them. > On Dec 14, 2021, at 2:22 PM, Luke Mauldin via Mercurial > wrote: > > We are considering using Mercurial for an internal project. I have

Re: Removing exchange-v2

2021-12-03 Thread Augie Fackler
Make it so IMO. > On Dec 3, 2021, at 9:41 AM, Raphaël Gomès wrote: > > Hi all, > > The exchange-v2 protocol has been untouched for years now, is incomplete and > does not seem to have any chance at coming back to life. Its tests are > unreliable enough to make the CI flaky, which can be

Re: Proposing a new release calendar

2021-11-29 Thread Augie Fackler
Revising the calendar seems fine. I think “on or after” dates make sense, especially as release management often involves corporate contributors. > On Nov 29, 2021, at 9:58 AM, Raphaël Gomès wrote: > > This is a good point, though these are "on or around" dates, which means that > usually the

Re: Call for comments on new dirstate format contents

2021-10-18 Thread Augie Fackler
> On Oct 18, 2021, at 4:16 AM, Pierre-Yves David > wrote: > > > On 10/15/21 2:22 PM, Pierre-Yves David wrote: >> >> On 10/13/21 10:57 AM, Simon Sapin wrote: >>> Please let us know of any question or comment! >> >> >> I remember discussion about storing WC exec-bit and symlink status to

Re: Renaming foss.heptapod.net/octobus/mercurial-devel to foss.heptapod.net/mercurial/mercurial-devel

2021-09-29 Thread Augie Fackler
Seems fine to me. Can you add it to the project infrastructure wiki page with appropriate contact people listed? On Wed, Sep 29, 2021, 05:47 Raphaël Gomès wrote: > Hi all, > > We've seen some people think that > foss.heptapod.net/octobus/mercurial-devel is an Octobus-only repository > and

Re: Giving up August releases?

2021-08-25 Thread Augie Fackler
Maybe we should shift the schedule so that major releases don't fall during major european holiday windows? On Wed, Aug 25, 2021 at 12:36 PM Raphaël Gomès wrote: > Hi all, > > Mercurial 5.9 was just released and it was a painful release: there were > lots of bugs that took a long time to fix

D11233: dirstate: fix typo in docstring

2021-07-29 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Spotted while repairing git extension tests. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11233 AFFECTED

D11234: git: restore basic functionality (issue6545)

2021-07-29 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It looks like a big refactor happened on dirstate, and the git extension was just ignored. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11232: rewriteutil: fix crash when a rewritten message references f{6, 64}

2021-07-29 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Without this, the rewriteutil logic thinks it's found a reference to the wdir pseudo-revision, and then tries to look it up and rewrite it. Stop it from doing

D11231: tests: add explicit coverage for update_hash_refs from rewriteutil

2021-07-29 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I couldn't find any evidence this is covered by tests in core (but there's a good chance I missed it). We've seen a cute bug in that code, but first let's

Re: Subject: 5.9 freeze, Windows, regression-fixes and Python 2 drop

2021-07-15 Thread Augie Fackler
I’m going to be unable to pay attention to Mercurial stuff during the freeze (probably the whole freeze? unsure) so it’d be helpful if others can make sure releases happen (including signing and cross-review). I’m +0 on a freeze this time, to try and smoke out some real problems, as long as we

D11092: pyoxidizer: add hooks to inject extra python packages and install files

2021-07-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We need this type of hook to inject our internal extension and resource files at Google. Presumably this could be useful to others, so instead of trying to

D11093: packaging: add command line flag to add extra vars to pyoxidizer

2021-07-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This felt simpler than the previous incarnation of injecting content into the WiX build. I decided the easiest way to pass an arbitrary map into the process

D11030: parsers: move DirstateItem to attr.s

2021-07-08 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11030 AFFECTED FILES mercurial/pure/parsers.py CHANGE DETAILS diff --git

D11006: remotefilelog: stop using RuntimeError for control flow

2021-07-07 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We introduce a new exception to handle the various failure categories, rather than relying on RuntimeError. REPOSITORY rHG Mercurial BRANCH default

D11008: shallowutil: dedent code after the previous change

2021-07-07 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11008 AFFECTED FILES hgext/remotefilelog/shallowutil.py CHANGE DETAILS diff

D11007: shallowutil: narrow scope of try/except block

2021-07-07 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will make this code easier to understand in the future. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11005: remotefilelog: tweak corrupt cache test to grep more flexibly

2021-07-07 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'm about to fix the abuse of RuntimeError here, which breaks the test if I don't do this. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

Re: Request: Please delete my signature from quotes of my email

2021-06-16 Thread Augie Fackler
ner or later, would you try to delete the > post? > > > Log in to (or register with) Nabble and then you can find and delete > your posts on Nabble. > > http://n8.nabble.com/help/Answer.jtp?id=13 > > Den 17 juni 2021 00:44 skrev Augie Fackler : > > I’m afraid ther

Re: Request: Please delete my signature from quotes of my email

2021-06-16 Thread Augie Fackler
I’m afraid there’s nothing we can do to assist you on this: nabble isn’t even a service we run, and you’ve emailed a public mailing list with this information. Maybe nabble can help, but I’m not sure what their policy is. Sorry! > On Jun 16, 2021, at 1:28 AM, nabbisen--- via Mercurial-devel >

Does anyone still look at patchwork?

2021-06-16 Thread Augie Fackler
I’m poking some sysadmin/infra stuff today, and I’m not sure anyone looks at patchwork anymore. Is it still used, or should we consider getting rid of it? Thanks! Augie ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: Moving from Freenode

2021-06-14 Thread Augie Fackler
The SC has discussed this a bit, but really I don't think you need the SC to make this decision? If the consensus is everyone wants to chat on LC instead of freenode, that seems fine and you should feel encouraged to update/modernize the wiki page to reflect that IMO. On Mon, Jun 14, 2021 at

D10777: fuzz: add hg to sys.path when constructing mpatch corpus

2021-05-27 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10777 AFFECTED FILES contrib/fuzz/mpatch_corpus.py CHANGE DETAILS diff --git

Re: Manifest handling

2021-05-25 Thread Augie Fackler
On Fri, Apr 30, 2021 at 6:45 PM Joerg Sonnenberger wrote: > > Hello all, > this is a bit of a brain dump based on a recent discussion with > Pierre-Yves on IRC. I think it deserves some input from others and maybe > it can grow into a proper plan in time. > > For the context of this discussion,

Re: [PATCH 1 of 1] fix sparse:subprepo.subrepo - now provide DummySubrepo for subs out of sparse

2021-05-19 Thread Augie Fackler
Elaborating more: this appears to introduce import cycles caught by running the tests under Python 2.7. I’m not sure why that test is broken on Python 3, but I’ll try to make a note to explore that. > On May 19, 2021, at 4:29 AM, Raphaël Gomès wrote: > > Hi, > > This patch breaks a few tests

D10733: hghave: make error output easier to diagnose

2021-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I had a typo that meant the new bash check was throwing an exception (due to a missing argument), but it was very hard to diagnose without this change.

D10732: tests: add req on bash for test-transaction-rollback-on-sigpipe (issue6429)

2021-05-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I think we could work around this by rewriting the helper scripts in Python, but I don't want to deal with that now and this should prevent failures due to a

D6594: [ABANDONED] RFC dirstatemap

2021-05-12 Thread durin42 (Augie Fackler)
Herald added a subscriber: mercurial-patches. durin42 added a comment. durin42 added subscribers: muxator, gracinet. (+ infra list, some folks that I think volunteered in the past) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6594/new/ REVISION

Re: certificate errors when accessing http://mercurial.selenic.com/release

2021-05-07 Thread Augie Fackler
ometimes get results on > mercurial.selenic.com, see for example the third result in this one: > > https://duckduckgo.com/?q=mercurial+convert > > Since mercurial.selenic.com is an alias for mercurial-scm.org, shouldn't it > be in the certificate as well? > >> On 4 F

D10669: debugcommands: fix some plural-agreements I noticed

2021-05-04 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10669 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

Re: Mercurial 5.8rc0 tagged

2021-04-21 Thread Augie Fackler
Rc1 is now out, fixing an issue in the metadata generation in setup.py - no functional changes, but if you’re installing with pip or similar you’ll want the newer version. Thanks to nbjoerg for the fast fix! > On Apr 20, 2021, at 11:16 AM, Augie Fackler wrote: > > Please update you

Mercurial 5.8rc0 tagged

2021-04-20 Thread Augie Fackler
Please update your package builds, thanks. ___ Mercurial-packaging mailing list Mercurial-packaging@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-packaging

Re: [PATCH] improve mobile view with viewport and css media query

2021-04-12 Thread Augie Fackler
(+pulkitg because it’s website-related) > On Apr 1, 2021, at 9:14 PM, Heddi Nabbisen via Mercurial-devel > wrote: > > # HG changeset patch > # User nabbisen > # Date 1617325695 -32400 > # Fri Apr 02 10:08:15 2021 +0900 > # Node ID f269688339206a9f7c85fb089cd9adb9c8215a92 > # Parent

Re: Python 2 removal and thg packaging status

2021-04-12 Thread Augie Fackler
> On Apr 3, 2021, at 6:34 PM, Matt Harbison wrote: > > On Sat, Apr 3, 2021 at 12:18 PM Raphaël Gomès > wrote: >> >> Hello all, >> >> As you all know, Mercurial's codebase is still burdened by Python 2 >> support. Patches still >> need to be adapted for

Re: error building hgcli

2021-03-22 Thread Augie Fackler
(+ a Rust expert) On Fri, Mar 19, 2021 at 7:12 PM Chuck Tuffli wrote: > > I'm new to the rust hgcli and am hitting an error. What is the error > message trying to tell me? > > Building wheel for mercurial (PEP 517): finished with status 'done' > Created wheel for mercurial: >

D10185: black: merge config into main pyproject.toml now that we have it

2021-03-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This means that naive contributors who just run `black` on a source file will get reasonable behavior as long as they have a recent black. Yay! This was

D10184: pyproject: add config file

2021-03-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will tell pip et al to call our setup.py for the majority of packaging concerns, but also gives us a place to put standard config stuff like black.

Re: [RFC] Interaction between strip and caches

2021-02-26 Thread Augie Fackler
> On Dec 14, 2020, at 5:03 PM, Joerg Sonnenberger wrote: > > Hello all, > while looking at the revbranchcache, I noticed that it is doing quite an > expensive probalistic invalidation dance. It is essentially looking up > the revision in the changelog again and compares the first 32bit to see

Re: SHA1 replacement steps

2021-02-26 Thread Augie Fackler
> On Feb 15, 2021, at 9:18 AM, Joerg Sonnenberger wrote: > > Hello all, > to help the review process along, here are the rough steps I see in > preparation for supporting 256bit hashes: > > (1) Move the current 160bit constants from mercurial.node into a > subclass. Instead of a global

D10066: fuzz: if the caller of our makefile sets CC and CXX, trust them

2021-02-24 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This should fix the broken fuzzing build, because we've been explicitly using clang++ but are now being given a CXX=afl++, which does extra stuff. REPOSITORY

Re: Installing Mercurial on MacOS Big Sur

2021-02-16 Thread Augie Fackler
> On Feb 16, 2021, at 4:06 AM, Noel Duffy via Mercurial > wrote: > > > >> On 16/02/2021, at 21:18, Johannes wrote: >> >> Noel Duffy asked: >>> So, for Big Sur, what’s the best option to get Mercurial installed >>> with proper verification of the source? >> >> I'm not sure about the best

Re: certificate errors when accessing http://mercurial.selenic.com/release

2021-02-03 Thread Augie Fackler
We haven’t used the mercurial.selenic.com domain in several years - try using mercurial-scm.org instead. > On Jan 23, 2021, at 5:26 PM, Danny Schneider > wrote: > > This is what happens: > > > LC_TIME="en_EN.UTF-8" wget >

Re: Replacement for old "hgsubversion" extension?

2021-02-03 Thread Augie Fackler
hgsubversion absolutely can be migrated to Python 3. Nobody has stepped up to do the work, and while I’m happy to review those changes as the owner of the code, I can’t justify spending time on it as I no longer interact with any Subversion servers. > On Feb 3, 2021, at 12:28 PM, Dr Rainer

D9944: relnotes: add entry for `hg diff --merge -c`

2021-02-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9944 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git a/relnotes/next

D9939: diff: suppress `merging foo` output lines when performing a merge diff

2021-02-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9939 AFFECTED FILES mercurial/commands.py tests/test-diff-change.t CHANGE

D9908: context: add missing manifest invalidation after write in overlayworkingctx

2021-01-29 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was breaking my merge-diff logic that will be in the next patch. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

Re: historical question, when were named branches introduced, when bookmark

2021-01-24 Thread Augie Fackler
On Sun, Jan 24, 2021 at 12:31 PM Uwe Brauer wrote: > > > Hi > > I tried to search though the log msg (there is no News file). > > So I would like to simply ask. > > 1. When were named branches introduced?

D9855: histedit: rip out mysterious catch-all ignore curses.error handler

2021-01-22 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I have no idea why this was here, and ripping it out doesn't obviously break anything for me (tests all pass, I can poke around chistedit UI a bit without

D9854: histedit: notice when the main window underflows height and abort

2021-01-22 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If you try to have a 13-line-tall terminal and use curses histedit, it fails by spinning in an infinite loop due to the catch-all ignore of curses errors on

D9853: histedit: don't assign to _ for unused values

2021-01-22 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I don't know what this ignored value is, but we need to not clobber the _() function from gettext, or we get mysterious crashes instead of internationalizing

D9834: black: merge config into main pyproject.toml now that we have it

2021-01-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This means that naive contributors who just run `black` on a source file will get reasonable behavior as long as they have a recent black. Yay! REPOSITORY

D9833: pyproject: add config file

2021-01-19 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will tell pip et al to call our setup.py for the majority of packaging concerns, but also gives us a place to put standard config stuff like black.

  1   2   3   4   5   6   7   8   9   10   >