Mercurial 6.7.3 tagged

Please update your package builds, thanks. Release notes here:https://wiki.mercurial-scm.org/Release6.7 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Re: Outdated homepage and repository

On 5/4/24 11:08 PM, Mike Hommey wrote: Hi, As of writing, thewww.mercurial-scm.org homepage is still showing version 6.6.3 as download, while the latest release is 6.7.2, although it's listed onhttps://www.mercurial-scm.org/downloads (I guess it could be related to mac and windows builds not

Mercurial 6.7.2 tagged

Please update your package builds, thanks. This is the second exceptional release in a row to fix a regression introduced in 6.7. Sorry for the churn, we're reworking a lot of integral parts of Mercurial. We are currently working to improve our benchmarking to cover existing and new cases so

Mercurial 6.7.1 tagged

Please update your package builds, thanks. This is an exceptional release following a serious (but unlikely) bug being found right after the 6.7 release. Release notes here: https://wiki.mercurial-scm.org/Release6.7 Raphaël ___ Mercurial-packaging

Mercurial 6.7 tagged

Please update your package builds, thanks. Release notes can be found here: https://wiki.mercurial-scm.org/Release6.7 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.7rc0 tagged

Please update your package builds, thanks. Release notes here:https://wiki.mercurial-scm.org/Release6.7 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.6.3 tagged

Please update your package builds, thanks. Release notes here: https://wiki.mercurial-scm.org/Release6.6 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.6.2 tagged

Please update your package builds, thanks. Release notes here: https://wiki.mercurial-scm.org/Release6.6 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.6.1 tagged

Please update your package builds, thanks. This fixes an important (but non-data-corrupting) bug in 6.6. See release notes here:https://wiki.mercurial-scm.org/Release6.6 Raphaël ___ Mercurial-packaging mailing list

Mercurial 6.6 tagged

Please update your package builds, thanks. Release notes here :https://wiki.mercurial-scm.org/Release6.6 (No changes from the rc0) Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.6rc0 tagged

Please update your package builds, thanks. Release notes can be found here:https://wiki.mercurial-scm.org/Release6.6 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.5.3 tagged

Please update your package builds, thanks. Release notes here:https://wiki.mercurial-scm.org/Release6.5 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Re: Rustext's DirstateItem has no attribute 'v2_data', fsmonitor tries to access it.

On 10/23/23 01:16, Sietse Brouwer wrote: Hello everyone, I am writing about an AttributeError caused by fsmonitor trying to access someDirstateItem.v2_data(), which is not exposed by `mercurial.rustext.dirstate.DirstateItem` (but is exposed by `mercurial.pure.parsers.DirstateItem`). Steps

Re: How to contribute?

Hi Dan, Thanks for sending your patch and reaching out. We've had a massive spam wave recently and it's been tough seeing the real requests through it. I've invited you back to the project. It appears everyone missed your patch... Do you want to try out pushing it to Heptapod or should I

Mercurial 6.5.2 tagged

Please update your package builds, thanks. See the release notes here:https://wiki.mercurial-scm.org/Release6.5 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.5.1 tagged

Please update your package builds, thanks. Find the release notes here:https://wiki.mercurial-scm.org/Release6.5 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.5 final tagged

Please update your package builds, thanks. Release notes can be found here: https://wiki.mercurial-scm.org/Release6.5 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Re: [PATCH] httppeer: fix make_peer static - fixed for url-path argument. It has migrated to url-object, but legacy code passed just string

Thanks for your patch. You've left a comment-out line. Is this just forgotten debug code or did you mean to do something more there? Also a small detail, but the `ui.note` was moved from after the call to `make_peer`, which makes for a small difference in observed behavior. I don't think it

Mercurial 6.4.5 and 6.5rc0 tagged

Please update your package builds, thanks. Release notes can be found here: https://wiki.mercurial-scm.org/Release6.4 https://wiki.mercurial-scm.org/Release6.5 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.4.4 tagged

Please update your package builds, thanks. See the release notes here:https://wiki.mercurial-scm.org/Release6.4 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Mercurial 6.4.3 tagged

Please update your package builds, thanks. This fixes (among other things), the packaging issue with `environ` being used while undeclared in a recent change. Release notes here:https://wiki.mercurial-scm.org/Release6.4 ___ Mercurial-packaging

Mercurial 6.4.2 tagged

Please update your package builds, thanks. This is an exceptional release due to a data-loss bug when using clonebundles on repos with files with a large history. Release notes here: https://wiki.mercurial-scm.org/Release6.4 Raphaël ___

Mercurial 6.4.1 tagged

Please update your package builds, thanks. Release notes here:https://www.mercurial-scm.org/wiki/Release6.4 ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Re: 'hg rebase -n' loses changes in working directory

Thanks a lot for the reproduction and the (multiple) pings, this had indeed eluded our attention. We're trying to sort out many things at once, and the bug tracker is in a sad state. A fix for this issue (which seems to pretty much always have existed?) will be landed in the next hour and in

Re: Sharing .hg-data between repos

Hi Hartmut, You can absolutely do this using Mercurial using the `share` feature. With ideally Mercurial 6.1 or more recent (because some subtle bugs were found in `share`), you can just `hg share clone1 clone2` and `clone 2` will use the same storage as `clone1`, while being able to work on

Mercurial 6.4 tagged

Please update your package builds, thanks. This is quite a big release for improved performance and a big rework of the transaction and dirstate systems. Check out the release notes here:https://www.mercurial-scm.org/wiki/Release6.4 Raphaël ___

Re: [PATCH 1 of 2] py3: fix for Python 3.12 emitting SyntaxWarning on invalid escape sequences

Patch 1 was taken and will land in 6.4, patch 2 doesn't pass CI and is just a quality of life improvement for devs, so that'll have to wait for later. I'll still get to answering your email about the review process next week, I've been too busy so far. Raphaël On 3/21/23 17:51, Mads

Re: [PATCH 1 of 4 stable] cext: fix for PyLong refactoring in CPython 3.12

Queued¹ (by Pierre-Yves, reviewed by me) all except the redundant Cargo.toml patch with slightly one modified patch due to formatting. [1] https://foss.heptapod.net/mercurial/mercurial-devel/-/merge_requests/505/ On 3/7/23 19:23, Mads Kiilerich wrote: # HG changeset patch # User Mads

Re: [PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12

Scratch that sorry, I didn't look hard enough, I could just take the first three patches. How do you prefer to do it? I see you have an account on Heptapod already. On 3/13/23 15:44, Raphaël Gomès wrote: The idea is to have everything run through the CI. Contributions going through the repo

Re: [PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12

The idea is to have everything run through the CI. Contributions going through the repo and thus Heptapod makes it much easier for reviewers. Email remains as the lowest bar of entry (since you don't need an account and two out-of-core extensions) and for people truly allergic to the new

Re: [PATCH] fastexport: fix data handling

Just so it doesn't look like we've ignored this, this series has also been sent to Heptapod, which is the preferred method of contribution. Raphaël On 3/2/23 21:13, Felipe Contreras wrote: Commit messages are supposed to end on a newline, and blobs should not be modified at all. All data

Mercurial 6.3.3 tagged

Please update your package builds, thanks. Here are the relnotes: https://www.mercurial-scm.org/wiki/Release6.3 6.4rc0 was also released at the same time (and I didn't send this email correctly the first time around). These are both delayed from the calendar mostly due to personal reasons.

Mercurial 6.4rc0 tagged

Please update your package builds, thanks. Relnotes available here:https://www.mercurial-scm.org/wiki/Release6.4 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Re: [hgbook ver. 2015] Source?

Hi Marcus, My company Octobus in partnership with Software Heritage created an archive of all Mercurial Bitbucket repositories. You can find the repository here: https://bitbucket-archive.softwareheritage.org/projects/hg/hgbook/hgbook.html I hope this is helpful. Note that we probably

Re: Merge union order

On 1/24/23 11:35, Cédric Krier via Mercurial wrote: On 2023-01-14 10:54, Cédric Krier via Mercurial wrote: Hi, In our repository we are filling a CHANGELOG text file when developing new feature. The rule is to append on top of the file new entries. The problem is that obviously we have very

Mercurial 6.3.2 tagged

Please update your package builds, thanks. Release notes can be found here: https://www.mercurial-scm.org/wiki/Release6.3 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Re: List only public branches

Hi, `hg branches -r 'public()'` should do the trick. Raphaël On 12/21/22 11:36, Cédric Krier via Mercurial wrote: Hi, We recently migrated to Heptapod and the usage of topics. I have some scripts that need to retrieve the public branches only (not the topics). I do not see any option on `hg

Mercurial 6.3.1 tagged

Please update your package builds, thanks. Exceptional release due to Python 3.11 breaking BC on where regex flags are allowed. This also includes a fix for a memory explosion in `hg log`. https://www.mercurial-scm.org/wiki/Release6.3 Raphaël ___

Mercurial 6.3 tagged

Please update your package builds, thanks. Sorry about the delay. There were multiple bugs that needed to be squashed and my work life would have made it quite difficult to ensure a normal release timing. https://www.mercurial-scm.org/wiki/Release6.3 Raphaël

Re: 6.3rc0

Good catch! This is now fixed. I actually laughed out loud, thanks for that. I also had botched the month somehow, not just the ordering? Raphaël On 11/8/22 23:28, Scott Palmer wrote: The web site at WhatsNew - Mercurial (mercurial-scm.org)  

Mercurial 6.3rc0 tagged

Please update your package builds, thanks. Seehttps://www.mercurial-scm.org/wiki/Release6.3 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-packaging

Re: releasenotes: use re.MULTILINE mode when checking admonitions

Sorry, I seemed to have missed (or never received) the email for your member submission, I granted you access to Heptapod just now. Thanks for contributing! On 10/13/22 06:38, Craig Ozancin wrote: Thanks for letting me know. It won't happen again.  I am now setup with mailbomb and waiting on

Mercurial 6.2.3 tagged

Please update your package builds, thanks. https://www.mercurial-scm.org/wiki/Release6.2 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-packaging

Mercurial 6.2.2 tagged

Please update your package builds, thanks. Release notes: https://www.mercurial-scm.org/wiki/Release6.2 Raphaël ___ Mercurial-packaging mailing list Mercurial-packaging@lists.mercurial-scm.org

Re: [Bug 6719] New: ttrr

This spam is perfect to try out bugzilla email reply On 6/24/22 20:13, mercurial-b...@mercurial-scm.org wrote: https://bz.mercurial-scm.org/show_bug.cgi?id=6719 Bug ID: 6719 Summary: ttrr Product: Mercurial Version: 6.1rc0 Hardware:

Re: Rust error stratergy in the hg codebase

] https://old.reddit.com/r/rust/comments/wuomjt/help_needed_for_error_stratergy_inside_mercurial/ On 8/22/22 11:06, Raphaël Gomès wrote: Hi all, I've been having an ergonomic issue with error handling lately. Error handling strategy used to be kind of a rough edge in Rust because of the different

Two-weeks absence and slower review cadance

Hi all, I wanted to warn all contributors that I will be basically out (but not unreachable for emergencies) for at least 2 weeks starting on September 3rd. My own review cadence has already slowed down because of the amount of urgent things I need to care of currently, though I'll still take

Re: [PATCH 1 of 4 STABLE] automation: refresh requirements

Merged as https://foss.heptapod.net/mercurial/mercurial-devel/-/merge_requests/210, sorry for the delay On 7/21/22 05:06, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1654313106 25200 # Fri Jun 03 20:25:06 2022 -0700 # Branch stable # Node ID

Rust error stratergy in the hg codebase

Hi all, I've been having an ergonomic issue with error handling lately. Error handling strategy used to be kind of a rough edge in Rust because of the different constraints of both the compiler and the standard library. Lately it seems that most projects are happy with using a mix of

Re: [PATCH v2] rebase: add boolean config item rebase.norebasesource

Hi, sorry for the (very long) delay. This slipped through the cracks twice, somehow. Here is the current state of your patch: https://foss.heptapod.net/mercurial/mercurial-devel/-/merge_requests/202 I've taken the liberty to amend it for it to go through faster, how does that sound?

Re: [PATCH 1 of 4 STABLE] automation: refresh requirements

If another reviewer better versed than I in email series importing can figure out how to import this, that would be nice. I can circle back to it later, but my usual tooling fails for now. On 7/21/22 05:06, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1654313106

Re: [PATCH stable] rust: bump to memmap2 0.5.3, micro-timer 0.4.0, and crossbeam-channel 0.5.0

Queued, thanks On 7/11/22 23:03, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1657572476 -7200 # Mon Jul 11 22:47:56 2022 +0200 # Branch stable # Node ID f1713e81437e894fab0658e4f410184e10d35e5e # Parent 55adff8105464f6247983940ba109684d36b689d rust: bump to

Mercurial 6.2.1 tagged

Please update your package builds, thanks. This is a little early due to vacation plans (and we broke 3.6 SSL support, so it doesn't hurt to be early) https://www.mercurial-scm.org/wiki/Release6.2 Raphaël ___ Mercurial-packaging mailing list

Mercurial 6.1.4 and 6.2rc0 tagged

Please update your package builds, thanks. Since we're dropping Python 2 in 6.2, we figured one last stable release for 6.1.x made sense to get the few extra bugfixes in. Raphaël ___ Mercurial-packaging mailing list

Re: How to submit large series of loosely related changesets in Heptapod

Sorry, the mailing daemon broke because Phabricator used up all disk space while fighting for its life. I made sure this wouldn't happen again, but only just restarted the daemon, so the email got delayed by a few days. On 6/3/22 20:23, Manuel Jacob wrote: I have a branch with Python 3

Re: [PATCH stable] rust: relax im-rc dependency to allow minor updates

Queued this morning, sorry for the delay. On 5/24/22 15:04, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1653395384 -7200 # Tue May 24 14:29:44 2022 +0200 # Branch stable # Node ID 32de89308ead51d42d631c208ab17c866218e1c5 # Parent

Mercurial 6.1.3 tagged

Please update your package builds, thanks. This includes a security fix for the narrow extension, see 6b10151b962108f65bfa12b3918b1021ca334f73 for more details. Release notes for convenience: https://www.mercurial-scm.org/wiki/Release6.1 Raphaël

Re: [PATCH 1 of 2 stable] worker: do not suppress EINTR

Before I review these (and your previous series), is there a reason why you use the ML instead of Heptapod (as per https://www.mercurial-scm.org/pipermail/mercurial-devel/2022-May/148466.html ) considering you're already using it for your pre-submission CI? On 5/25/22 02:30, Manuel Jacob

Re: Plan for the migration out of Phabricator

.), but the base is pretty much ready so I though I'd send the email sooner rather than later. Raphaël On 5/2/22 21:38, Raphaël Gomès wrote: Hello all, It is time to set a flag day for our migration to Heptapod as a review tool. We are currently making very good progress with the team at OSUOSL who

Mercurial 6.1.2 tagged

Please update your package builds, thanks. There is an important fix for the experimental Rust code if you package it. See the Release notes: https://www.mercurial-scm.org/wiki/Release6.1 Raphaël ___ Mercurial-packaging mailing list

D12602: test-dirstate: print something when the check is skipped

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This makes a programming error obvious in cases when it should not be skipped REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D12601: test-dirstate: fix detection of Rust environment variable

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The Rust path never actually worked. This change also improves clarity of the comment. The next change will ensure we print something when this check fails.

Plan for the migration out of Phabricator

Hello all, It is time to set a flag day for our migration to Heptapod as a review tool. We are currently making very good progress with the team at OSUOSL who will - unless a disaster occurs - provide us with infrastructure and help with the migration, the details of which are being ironed

D12591: debugcommands: remove `debugdirstateignorepatternhash`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is replaced by the more complete `--docket` option to `debugstate`. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D12590: dirstate-v2: add flag to `debugstate` to print docket information

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is useful information that we don't easily have access to currently, unless you speak fluent xxd. This replaces `debugdirstateignorepatternshash`,

D12594: rust-dirstate-v2: fix the unused bytes counter when rewriting the dirstate

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As per the previous patch, the counter was incorrectly carried over from the old docket when it should be reset for a complete rewrite. REPOSITORY rHG

D12593: rust-dirstate-v2: show `unused_bytes` counter is not reset on total rewrite

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was picked up by @aalekseyev when doing unrelated debugging. The Rust implementation was never resetting this counter, so a brand new file would carry

D12592: test-dirstate: use new `--docket` flag to get the data uuid

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is more robust. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D12592 AFFECTED FILES tests/test-dirstate.t

D12587: color: support the NO_COLOR environment variable

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The https://no-color.org initiative is a good idea, it's easy to support. It even explicitly lists Mercurial as one of the programs that don't support it.

D12586: rhg: fix dirstate-v2 data file removal system

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY In D12581 I introduced logic to remove the previous dirstate-v2 data file after a new one is created (and its

Mercurial's minimum Rust version

Hi all, Mercurial has had Rust code for a few years now. Parts of it used as native extensions to the Python code and others as standalone executables for speed. Some distros have packaged the Rust versions in the past and we expect more to do so in the future. The current policy for the

D12580: rust-dirstate-v2: save proper data size if no new data on append

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is currently only triggered with the tests ran with `--rhg` without `--rust`, by "luck", there probably always was something to write, like an mtime when

D12581: rust-dirstate-v2: clean up previous data file after the docket is written

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was overlooked before and caused many data files to keep living forever. We could potentially consider adding a random cleanup of them in case they

D12578: rhg: use `Command::exec` instead of `Command::status`

Alphare created this revision. Alphare added a comment. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. Pending CI refresh REVISION SUMMARY `rhg` is supposed to be a transparent executable, using a subprocess defeats that purpose. See inline comments

D12575: actions: fix formatting issue

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was triggered by a new change in the file in cb21c9c1a480. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12574: rust: fix formatting

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This slipped through. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12574 AFFECTED FILES

Re: Moving away from Phabricator

On 4/13/22 22:24, Augie Fackler wrote: On Apr 13, 2022, at 12:06 PM, Raphaël Gomès wrote: Hi everyone, It has now been more than a month and our window to migrate out of our VM is closing down. Thanks for keeping track of this! Thanks for answering quickly! I am happy to report

Re: Moving away from Phabricator

e sysadmin burden, simplify, strengthen and modernize the contribution and review process and leave the project in a healthier, more maintainable state. I hope to see my mental load reduced by a lot after this transition, and I'm pretty sure I'm not the only one. On 3/10/22 14:28, Raphaël Gomès wrote:

D12541: rust-dirstatemap: remove unused helper from the old API

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12541 AFFECTED FILES rust/hg-core/src/dirstate_tree/dirstate_map.rs CHANGE

D12540: rust-status: stop using `state()` in the dispatch logic

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's use the new API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12540 AFFECTED FILES

D12539: rust-status: stop using `state()` in `handle_normal_file`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's use the new API REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12539 AFFECTED FILES

D12538: rust-dirstatemap: stop using `state()` in the cache logic

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's use the new API REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12538 AFFECTED FILES

D12537: rust-dirstatemap: stop using `.state` in `is_from_other_parent`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a deprecated API and will be removed one day. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12537

D12534: rust: use `entry.tracked()` directly

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new API REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12534 AFFECTED FILES

D12536: rust-dirstate-entry: add `modified` method

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will also be used in other places later in the series. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12536

D12535: rust: remove use of `EntryState` in `DirsMultiset`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's use the new API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12535 AFFECTED FILES

D12533: rust-hg-cpython: remove use of `EntryState`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's use the new API REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12533 AFFECTED FILES

D12532: rust-dirstatemap: use a checked sub instead of a potentially underflowing one

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was missed in 2593873cda0f REPOSITORY rHG Mercurial BRANCH default

D12531: rust-dirstatemap: add simpler version of `get_node_mut`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will help reduce code and footgun potential for simpler callers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12530: rust-dirstatemap: use `get_node_mut` instead or `get_or_insert_node`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This (along with the docstring), makes it more obvious that we're not expecting to insert a node here. This is less prone to bugs in later refactorings.

D12529: rust-dirstatemap: add `each_ancestor` argument to `get_node_mut`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This forces the callers to think about if the counters in the ancestors need to be adjusted. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12528: rust-dirstatemap: add a simpler method `get_or_insert_node` for the common case

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All but one case use the exact same input for most arguments, this simplifies code and reduces footgun potential. REPOSITORY rHG Mercurial BRANCH default

D12527: rust-dirstatemap: inline the last `get_or_insert` call

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The `get_or_insert` method was dangerous because it did not take the `DirstateMap` counters into account. This particular instance does not need to update the

D12526: rust-dirstatemap: add `set_cached_mtime` helper method

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will help remove the `get_or_insert` method, which is dangerous because it does not take the `DirstateMap` counters into account REPOSITORY rHG

D12525: rust-dirstatemap: add `clear_cached_mtime` helper method

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will help remove the `get_or_insert` method, which is dangerous because it does not take the `DirstateMap` counters into account. REPOSITORY rHG

D12524: rust-dirstatemap: add unit tests

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These were missing and have already proven valuable since they have found two bugs (fixed in previous patches). There may be other behavior to test, but

D12523: rust: add `Debug` trait to a bunch of structs

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is useful when... debugging. Right now the output is not in the most readable state it could be, but this is very low effort and is good enough for now.

D12522: rust-dirstatemap: use `` instead of `HgPathBuf` in `copy_map_insert`

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY No reason to require an owned path here. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12522 AFFECTED FILES

D12521: rust-dirstatemap: use `DirstateEntry::tracked` directly

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY `state()` is a legacy API that will be removed at some point, let's use the newer API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D12519: rust-dirstatemap: remove `set_dirstate_entry`/`set_entry` methods

Alphare created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These methods were needed crutches before the Rust implementation caught up to Python. Calling `set_entry` (whether from Python or Rust) was dangerous since

  1   2   3   4   5   6   7   8   9   10   >