[Differential] D6509: ignore me -testing phab email

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6509 AFFECTED FILES setup.py CHANGE DETAILS diff --git a/setup.py b/setup.py --- a/setup.py +++

D6457: perf: fix some missing b prefixes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4372d56112c9: perf: fix some missing b prefixes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6457?vs=15287=15292

D6456: testparseutil: fix doctest to use str instead of bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc2deb2512823: testparseutil: fix doctest to use str instead of bytes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6455: testparseutil: stop extracting using std* streams as bytes on py3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG37f38e1dea44: testparseutil: stop extracting using std* streams as bytes on py3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6454: tests: sort some imports that were previously missed

This revision was automatically updated to reflect the committed changes. Closed by commit rHG055687fe4c47: tests: sort some imports that were previously missed (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6453: contrib: fix import-checker to operate on str instead of bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG04eb3c5607af: contrib: fix import-checker to operate on str instead of bytes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6457: perf: fix some missing b prefixes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just b prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6457 AFFECTED FILES contrib/perf.py CHANGE DETAILS

D6456: testparseutil: fix doctest to use str instead of bytes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6456 AFFECTED FILES contrib/testparseutil.py CHANGE DETAILS diff --git a/contrib/testparseutil.py

D6455: testparseutil: stop extracting using std* streams as bytes on py3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is no longer required due to other cleanups in our linting tools. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6455 AFFECTED

D6454: tests: sort some imports that were previously missed

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm a little unclear why the import checker didn't catch this before, but when I fixed it to work in Python 3 this failure started showing up. Sigh. REPOSITORY

D6453: contrib: fix import-checker to operate on str instead of bytes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I believe this is fallout from other Python 3 cleanups, and our code linting tools are now leaning towards operating on str and not bytes. I don't feel

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

durin42 added inline comments. INLINE COMMENTS > hooper wrote in fix.py:106 > It depends on whether we want to make it easier for tools that want to > examine the tree upward from the cwd or tools that want to examine the tree > downward from the root. I suspect that "upward" will be more

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

durin42 added inline comments. INLINE COMMENTS > fix.py:106 > + > +Fixer tools are run the in same working directory as the :hg:`fix` command. > This > +allows them to read configuration files from the working copy, or even write > to I wonder if it'd be more generally useful to run the fixer

D6411: absorb: fix interactive mode I didn't know existed

This revision was automatically updated to reflect the committed changes. Closed by commit rHG86f17fc31aa8: absorb: fix interactive mode I didnt know existed (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6410: tests: work around libressl being different about error strings (issue6122)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe0ac310bd033: tests: work around libressl being different about error strings (issue6122) (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6411: absorb: fix interactive mode I didn't know existed

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While investigating a bug in `hg absorb -e` I unintentionally discovered `hg absorb --interactive` and its brokenness. This adds a test and restores the

D6410: tests: work around libressl being different about error strings (issue6122)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As far as I can tell, this is the right behavior. Thanks to Alex Gaynor for checking what the string means by looking at libressl sources for me. REPOSITORY

D6399: tests: fix test-clonebundles on recent openbsd

This revision was automatically updated to reflect the committed changes. Closed by commit rHGda3861ef7959: tests: fix test-clonebundles on recent openbsd (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6398: rust: sort dependencies entries in Cargo.toml

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0a6209c9fcf5: rust: sort dependencies entries in Cargo.toml (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6399: tests: fix test-clonebundles on recent openbsd

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I guess openbsd feels like it needs to stringify this errno in lowercase and omit the "host" part of "hostname. Okay. Reported in a big test diff talking

D6398: rust: sort dependencies entries in Cargo.toml

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I should probably write a test to enforce this... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6398 AFFECTED FILES

D6381: exthelper: add some semi-useful trace logs

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7d4ca1ad6537: exthelper: add some semi-useful trace logs (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6381?vs=15125=15138

D6381: exthelper: add some semi-useful trace logs

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It'd be nice to make the trace functions a little better-named in the output, but I'm not sure how much better we can do without overhead. This at least lets

D6271: rust-filepatterns: add a Rust implementation of pattern-related utils

durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. (forgot to tag as needing changes) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6271 To: Alphare, #hg-reviewers, kevincox, durin42 Cc: durin42,

D6273: rust-filepatterns: call new Rust implementations from Python

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Are there any performance implications of this yet? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6273 To: Alphare, #hg-reviewers, durin42 Cc: durin42,

D6271: rust-filepatterns: add a Rust implementation of pattern-related utils

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Meta-comment: we should extract an hgignore crate (with minimal other deps) and publish that, because that'd be a step towards automatic hgignore support in ripgrep (burntsushi has

D6271: rust-filepatterns: add a Rust implementation of pattern-related utils

durin42 added a comment. Ugh, but I got conflicts in Cargo.lock - could you rebase and let me know when you're ready? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6271 To: Alphare, #hg-reviewers, kevincox, durin42 Cc: durin42, kevincox, mercurial-devel

D5299: phabricator: fallback reading arcanist config files

durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. I see at least one outstanding comment that points out a typo. I'm generally in favor of this though, so please let us know when it's time to take another look. REPOSITORY

D6365: context: move contents of committablectx.markcommitted() to workingctx

durin42 added inline comments. INLINE COMMENTS > context.py:1228 > """ > - > -with self._repo.dirstate.parentchange(): > -for f in self.modified() + self.added(): > -self._repo.dirstate.normal(f) > -for f in self.removed(): > -

D6343: sslutil: add support for SSLKEYLOGFILE to wrapsocket

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc8d55ff80da1: sslutil: add support for SSLKEYLOGFILE to wrapsocket (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6353: remotefilelog: log when we're about to fetch files

This revision was automatically updated to reflect the committed changes. Closed by commit rHG65f3a77223e0: remotefilelog: log when were about to fetch files (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6353: remotefilelog: log when we're about to fetch files

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm debugging a slow client situation and knowing how many files are in the batch request would be a nice thing. REPOSITORY rHG Mercurial REVISION DETAIL

D6342: style: run a patched black on a subset of mercurial

durin42 updated this revision to Diff 15040. durin42 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6342?vs=15039=15040 REVISION DETAIL https://phab.mercurial-scm.org/D6342 AFFECTED FILES contrib/import-checker.py

D6342: style: run a patched black on a subset of mercurial

durin42 updated this revision to Diff 15039. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6342?vs=15009=15039 REVISION DETAIL https://phab.mercurial-scm.org/D6342 AFFECTED FILES contrib/import-checker.py mercurial/cacheutil.py

D6339: repair: reword comments that I noticed while working on source formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd811f17090a3: repair: reword comments that I noticed while working on source formatting (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6343: sslutil: add support for SSLKEYLOGFILE to wrapsocket

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I recently learned of a Firefox/Chrome feature that allows wiresharking otherwise-TLS'd network connections. Gloriously, there's a pypi module that enables this

D6342: style: run a patched black on a subset of mercurial

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This applied black to the 20 smallest files in mercurial/: ls -S1 mercurial/*.py | tail -n20 | xargs black Note that a few files failed to

D6339: repair: reword comments that I noticed while working on source formatting

durin42 added a comment. PTAL REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6339 To: durin42, #hg-reviewers Cc: martinvonz, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D6339: repair: reword comments that I noticed while working on source formatting

durin42 updated this revision to Diff 15008. durin42 marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6339?vs=15002=15008 REVISION DETAIL https://phab.mercurial-scm.org/D6339 AFFECTED FILES mercurial/repair.py CHANGE

D6340: repair: reword comment about bookmarks logic

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe10b8058da84: repair: reword comment about bookmarks logic (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6341: contrib: have byteify-strings explode if run in Python 2

This revision was automatically updated to reflect the committed changes. Closed by commit rHG970aaf38c3fc: contrib: have byteify-strings explode if run in Python 2 (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6341?vs=15004=15007#toc REPOSITORY

D6338: monotone: fix a bogus _() wrapper that was caught when formatting code

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd26bfbf419f9: monotone: fix a bogus _() wrapper that was caught when formatting code (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6341: contrib: have byteify-strings explode if run in Python 2

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6341 AFFECTED FILES contrib/byteify-strings.py CHANGE DETAILS diff --git

D6340: repair: reword comment about bookmarks logic

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Again, this will help auto-formatting shortly. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6340 AFFECTED FILES

D6339: repair: reword comments that I noticed while working on source formatting

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think this is clearer, and one will also keep us from upsetting check-code when other formatting cleanups happen. REPOSITORY rHG Mercurial REVISION DETAIL

D6338: monotone: fix a bogus _() wrapper that was caught when formatting code

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There was a spurious space after `debug`, which hid the _() inside ui.debug() from check-code. Sigh. While here, wrap things more concisely. REPOSITORY

D6258: packaging: coerce paths to strings

durin42 added a comment. In https://phab.mercurial-scm.org/D6258#91056, @indygreg wrote: > In https://phab.mercurial-scm.org/D6258#91055, @durin42 wrote: > > > Argh. This change appears to be wrong (!) so I'm going to drop it. > > > Eh? I don't see anything wrong with this.

D6258: packaging: coerce paths to strings

durin42 added a comment. Argh. This change appears to be wrong (!) so I'm going to drop it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6258 To: durin42, #hg-reviewers, pulkit Cc: mercurial-devel ___

D6258: packaging: coerce paths to strings

This revision was automatically updated to reflect the committed changes. Closed by commit rHG69b4426d288b: packaging: coerce paths to strings (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6258?vs=14788=14790

D6258: packaging: coerce paths to strings

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Experimentally passing the pathlib.Path to zipfile.ZipFile fails on at least some Python versions. I've gotten frustrated enough I'd rather just force them to

D6182: bundle2: handle compression in _forwardchunks

durin42 added a comment. Ugh I'm sorry - I evidently reviewed this and never pushed submit. :( INLINE COMMENTS > bundle2.py:846 > +if k.lower() != 'compression': > +oparams.append(p) > +outparams = ' '.join(outparams) so...what's going on with

D6226: rebase: fix bug that prevented dry-run rebases from printing failures

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1b5cec8b6a1e: rebase: fix bug that prevented dry-run rebases from printing failures (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6225: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8890fce7c13d: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6226: rebase: fix bug that prevented dry-run rebases from printing failures

durin42 created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As far as I can tell it should be fine to unconditionally skip _prepareabortorcontinue if we're in the process of raising an

D6225: rebase: demonstrate bug in dry-run mode which causes cycles to not be reported

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6225 AFFECTED FILES tests/test-rebase-dest.t CHANGE DETAILS diff --git a/tests/test-rebase-dest.t

D6167: fix: allow fixer tools to return metadata in addition to the file content

durin42 added a subscriber: lothiraldan. durin42 added a comment. @lothiraldan do y'all have opinions on this? I'd love to see this get landed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6167 To: hooper, #hg-reviewers, durin42 Cc: lothiraldan, durin42,

D6217: remotefilelog: correctly reject wdir filenodes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG864f9f63d3ed: remotefilelog: correctly reject wdir filenodes (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6217?vs=14690=14700#toc REPOSITORY rHG

D6216: remotefilelog: add tests of `hg grep -r 'wdir()'`

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb1b216a241cc: remotefilelog: add tests of `hg grep -r wdir()` (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6217: remotefilelog: correctly reject wdir filenodes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes `hg grep -r 'wdir()'` when remotefilelog is enabled and the working directory contains uncommitted modifications. REPOSITORY rHG Mercurial REVISION

D6216: remotefilelog: add tests of `hg grep -r 'wdir()'`

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This demonstrates how remotefilelog breaks grepping dirtied working directories. A future change will introduce a fix. REPOSITORY rHG Mercurial REVISION

D6189: py2exe: add workaround to allow bundling of hgext3rd.* extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rHG399ed3e86a49: py2exe: add workaround to allow bundling of hgext3rd.* extensions (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6187: wix: fix the package build when not adding features

This revision was automatically updated to reflect the committed changes. Closed by commit rHG429bed755ce1: wix: fix the package build when not adding features (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6189: py2exe: add workaround to allow bundling of hgext3rd.* extensions

durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY py2exe doesn't know how to handle namespace packages *at all*, so it treats them like normal packages. As a result, if we try

D6187: wix: fix the package build when not adding features

durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Should have used ifdef, not if. Sigh. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6187

D6180: wix: add functionality to inject additional Features into installer

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1711f5813a63: wix: add functionality to inject additional Features into installer (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6179: wix: add support for additional wxs files

This revision was automatically updated to reflect the committed changes. Closed by commit rHG978b03d5f66e: wix: add support for additional wxs files (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6179?vs=14629=14632

D6164: wix: add a hook for a prebuild script to inject extra libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rHG715d3220ac4f: wix: add a hook for a prebuild script to inject extra libraries (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6180: wix: add functionality to inject additional Features into installer

durin42 updated this revision to Diff 14630. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6180?vs=14618=14630 REVISION DETAIL https://phab.mercurial-scm.org/D6180 AFFECTED FILES contrib/packaging/hgpackaging/wix.py contrib/packaging/wix/build.py

D6179: wix: add support for additional wxs files

durin42 updated this revision to Diff 14629. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6179?vs=14617=14629 REVISION DETAIL https://phab.mercurial-scm.org/D6179 AFFECTED FILES contrib/packaging/hgpackaging/wix.py contrib/packaging/wix/build.py

D6164: wix: add a hook for a prebuild script to inject extra libraries

durin42 updated this revision to Diff 14628. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6164?vs=14576=14628 REVISION DETAIL https://phab.mercurial-scm.org/D6164 AFFECTED FILES contrib/packaging/hgpackaging/py2exe.py

D6164: wix: add a hook for a prebuild script to inject extra libraries

durin42 added a comment. In https://phab.mercurial-scm.org/D6164#90073, @indygreg wrote: > I would prefer you fix them :) Okay, then what should we call it? `--extra-packages-script` since that's what it's for? REPOSITORY rHG Mercurial REVISION DETAIL

D6164: wix: add a hook for a prebuild script to inject extra libraries

durin42 added a comment. In https://phab.mercurial-scm.org/D6164#90059, @indygreg wrote: > Was a newer version of this patch with the requested changes going to be uploaded? It's weird to see additional patches in the series without this one updated... You had indicated

D6180: wix: add functionality to inject additional Features into installer

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the last bit required to be able to glue extra configs etc into the installer. REPOSITORY rHG Mercurial REVISION DETAIL

D6179: wix: add support for additional wxs files

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As with my previous change for an --extra-prebuiild-script, I'm assuming this is predominantly useful in an enterprise environment and am only adding this to

D6167: fix: allow fixer tools to return metadata in addition to the file content

durin42 added subscribers: indygreg, durin42. durin42 accepted this revision as: durin42. durin42 added a comment. I'm what I'll call an unenthusiastic fan of this: it feels a little gross, but I have no better ideas (in fact, at least part of this interface was my idea...) so I'd like to

D6170: perf: copyedit a few documentation strings

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4c700c847aa2: perf: copyedit a few documentation strings (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6170?vs=14593=14595#toc REPOSITORY rHG

D6170: perf: copyedit a few documentation strings

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6170 AFFECTED FILES contrib/perf.py CHANGE DETAILS diff --git a/contrib/perf.py b/contrib/perf.py

D6164: wix: add a hook for a prebuild script to inject extra libraries

durin42 added a comment. In https://phab.mercurial-scm.org/D6164#89916, @indygreg wrote: > In https://phab.mercurial-scm.org/D6164#89915, @durin42 wrote: > > > In https://phab.mercurial-scm.org/D6164#89914, @indygreg wrote: > > > > > In https://phab.mercurial-scm.org/D6164#89913,

D6164: wix: add a hook for a prebuild script to inject extra libraries

durin42 added a comment. In https://phab.mercurial-scm.org/D6164#89914, @indygreg wrote: > In https://phab.mercurial-scm.org/D6164#89913, @durin42 wrote: > > > > > > How about we add an argument to define the path(s) to the pip requirements file(s) to use? By default, it can

D6164: wix: add a hook for a prebuild script to inject extra libraries

durin42 added a comment. In https://phab.mercurial-scm.org/D6164#89881, @indygreg wrote: > I like the flexibility. But I'm not super keen about the interface here. Using a script to inject custom options seems like it could be useful. But as it is currently implemented, the script

D6168: readline: provide styled prompt to readline (issue6070)

durin42 added a subscriber: spectral. durin42 added a comment. FYI @spectral I uploaded this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6168 To: durin42, #hg-reviewers Cc: spectral, mercurial-devel ___

D6168: readline: provide styled prompt to readline (issue6070)

durin42 added a comment. This is Kyle's patch from https://bz.mercurial-scm.org/show_bug.cgi?id=6070 - it feels regrettable but necessary, and anecdotally it seems to work. I'd give it an LGTM stamp here, but I can't since I uploaded it. REPOSITORY rHG Mercurial REVISION DETAIL

D6168: readline: provide styled prompt to readline (issue6070)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6168 AFFECTED FILES mercurial/ui.py CHANGE DETAILS diff --git a/mercurial/ui.py b/mercurial/ui.py

D6164: wix: add a hook for a prebuild script to inject extra libraries

durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I need this to build packages for Google so we can bundle some extensions in the installed image. My assumption is that this

D6076: cleanup: remove two bogus test names from python3 list

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe0384d4c51ae: cleanup: remove two bogus test names from python3 list (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6076: cleanup: remove two bogus test names from python3 list

durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I suspect one of these was a typo from the start, the other appears to have become a .t test at some point. REPOSITORY rHG

D6074: hghave: skip emacs tests on 24.3 and earlier

This revision was automatically updated to reflect the committed changes. Closed by commit rHG28842adf8ed5: hghave: skip emacs tests on 24.3 and earlier (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6074: hghave: skip emacs tests on 24.3 and earlier

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Turns out with-eval-after-load is new in 24.4. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6074 AFFECTED FILES tests/hghave.py

D6003: tests: add test for hg-test-mode emacs code

This revision was automatically updated to reflect the committed changes. Closed by commit rHG19979b8b87e2: tests: add test for hg-test-mode emacs code (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6002: hghave: add check for GNU emacs

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2a6ca0d94b70: hghave: add check for GNU emacs (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6002?vs=14185=14230 REVISION

D6000: contrib: add compilation-mode linking for our test output

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb6a757de2fff: contrib: add compilation-mode linking for our test output (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6001: contrib: also linkify tracebacks in compilation output when using hg-test-mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb6c062bb4be3: contrib: also linkify tracebacks in compilation output when using hg-test-mode (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6003: tests: add test for hg-test-mode emacs code

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is just coverage for the compilation-mode support, but that was enough of a hassle that I wanted to have it covered somehow. Test methodology is

D6002: hghave: add check for GNU emacs

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6002 AFFECTED FILES tests/hghave.py CHANGE DETAILS diff --git a/tests/hghave.py b/tests/hghave.py

D6001: contrib: also linkify tracebacks in compilation output when using hg-test-mode

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6001 AFFECTED FILES contrib/hg-test-mode.el CHANGE DETAILS diff --git a/contrib/hg-test-mode.el

D6000: contrib: add compilation-mode linking for our test output

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These regular expressions will cause compilation-mode buffers in emacs to link to source when there are check-code errors in the output of a .t test. In

D5993: cleanup: use () to wrap long lines instead of \

This revision was automatically updated to reflect the committed changes. Closed by commit rHGaaad36b88298: cleanup: use () to wrap long lines instead of \ (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5994: cleanup: prefer nested context managers to \-continuations

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1eb2fc21da12: cleanup: prefer nested context managers to \-continuations (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5995: contrib: enforce wrapping too-long lines with () instead of \

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe2472b12c842: contrib: enforce wrapping too-long lines with () instead of \ (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5992: tests: use () instead of \ to wrap lines

This revision was automatically updated to reflect the committed changes. Closed by commit rHG15d3facfa40a: tests: use () instead of \ to wrap lines (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5992?vs=14162=14177

<    5   6   7   8   9   10   11   12   13   14   >