D7280: scmposix: another suppression on IOError subscripting

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As before, this will clear up when we move to Python 3-only. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7280 AFFECTED FILES

D7279: pvec: add an explicit type hint to help pytype

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7279 AFFECTED FILES mercurial/pvec.py CHANGE DETAILS diff --git a/mercurial/pvec.py

D7278: procutil: suppress pytype warnings around windows-only attributes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7278 AFFECTED FILES mercurial/utils/procutil.py CHANGE DETAILS diff --git

D7276: posix: add a pytype suppression

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This one seems a little sketchier than the others, but this will clean up when we're Python 3-only. REPOSITORY rHG Mercurial REVISION DETAIL

D7277: dagparser: suppress some pytype errors around pycompat.bytestring

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I can't justify why we're getting these errors, but nothing I do fixes these handful of calls, so let's just move on with suppressions. REPOSITORY rHG

D7274: color: suppress pytype warning on a windows-only module

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7274 AFFECTED FILES mercurial/color.py CHANGE DETAILS diff --git a/mercurial/color.py

D7275: encoding: add comment-based type hints for pytype

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7275 AFFECTED FILES mercurial/encoding.py CHANGE DETAILS diff --git a/mercurial/encoding.py

D7273: compression: tell pytype to not sweat a missing `zstd` module

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7273 AFFECTED FILES mercurial/utils/compression.py CHANGE DETAILS diff --git

D7269: hgignore: ignore generated pytype stubs

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7269 AFFECTED FILES .hgignore CHANGE DETAILS diff --git a/.hgignore b/.hgignore --- a/.hgignore +++

D7271: linelog: be more careful about types before looking for _target attribute

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Without this, pytype (correctly) complains that fakejge might not have a _cmprev attribute. We're operating on some constraints not expressible in the type

D7268: hghave: add a check for pytype, Google's Python type checker

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not unbiased, but I strongly prefer pytype to mypy: it does more inference, so we don't need as many annontations. In theory we can use both, but since I'm

D7270: linelog: suppress annoying pytype warning about an ignored metaclass

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This isn't actively hurting us right now, and it's not trivial to set up this metaclass correctly on both Python 2 and Python 3 without dragging in all of

D7266: vfs: add NotImplementedError version of join

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Again, this helps out pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7266 AFFECTED FILES mercurial/vfs.py CHANGE DETAILS

D7267: encoding: define local identify functions with explicit type comments

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This removes some obfuscation as far as pytype is concerned and corrects many bogus type errors. REPOSITORY rHG Mercurial REVISION DETAIL

D7265: vfs: add a NotImplementedError implementation of __call__

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This helps pytype considerably on this file. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7265 AFFECTED FILES mercurial/vfs.py

D7264: vfs: fix erroneous bytes constants

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Detected with pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7264 AFFECTED FILES mercurial/vfs.py CHANGE DETAILS diff

D7262: templateutil: fix a missing ABCMeta assignment

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7262 AFFECTED FILES mercurial/templateutil.py CHANGE DETAILS

D7263: pvec: migrate to modern integer division

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Detected with pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7263 AFFECTED FILES mercurial/pvec.py CHANGE DETAILS diff

D7261: pvec: fix overlooked chr() call

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7261 AFFECTED FILES mercurial/pvec.py CHANGE DETAILS diff

D7259: statprof: correctly always pass a str as the thread name

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by pytype. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7259 AFFECTED FILES mercurial/statprof.py CHANGE DETAILS diff

D7260: vfs: another bytes-str confusion on thread name

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7260 AFFECTED FILES mercurial/vfs.py CHANGE DETAILS diff --git a/mercurial/vfs.py b/mercurial/vfs.py

D7189: git: use bytes in command name, not unicode

durin42 added a comment. Thanks, I've folded this into my initial patch so I won't break Python 3! I'm hoping to come back to this topic soon and get an initial version of the git extension landed - mostly I want to clean up how manifests/trees work and then I think it's worth landing.

D7252: dirs: reject consecutive slashes in paths

durin42 edited the summary of this revision. durin42 updated this revision to Diff 17620. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7252?vs=17619=17620 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7252/new/ REVISION DETAIL

D7252: dirs: reject consecutive slashes in paths

durin42 edited the summary of this revision. durin42 updated this revision to Diff 17619. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7252?vs=17618=17619 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7252/new/ REVISION DETAIL

D7234: dirs: reject consecutive slashes in paths

Closed by commit rHG88562eb65232: dirs: reject consecutive slashes in paths (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7234?vs=17564=17583 CHANGES SINCE

D7234: dirs: reject consecutive slashes in paths

durin42 updated this revision to Diff 17564. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7234?vs=17563=17564 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7234/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7234 AFFECTED FILES

D7234: dirs: reject consecutive slashes in paths

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We shouldn't ever see those, and the fuzzer go really excited that if it gives us a 65k string with 55k slashes in it we use a lot of RAM. This is a better

D7219: hghave: decode black's version before passing to StrictVersion

durin42 added a comment. This is subtlely wrong on Python 2, and I think D7221 is a correct fix. (I'd previously mailed that patch, but mail is backlogged.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7221: hghave: fix bytes/string issue on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7221 AFFECTED FILES tests/hghave.py CHANGE DETAILS diff --git a/tests/hghave.py b/tests/hghave.py

D7210: fsmonitor: handle unicode keys in tuples

durin42 added inline comments. INLINE COMMENTS > bser.c:182 > +#else > + PyObject* utf = PyUnicode_AsEncodedString(sval, "utf-8", "ignore"); > + if (utf == NULL) { By reading this code, I believe `sval` should have been `key`, so I've fixed that in flight. REPOSITORY rHG Mercurial

D7146: [RFC] grep: add config option to grep PWD by default

durin42 added a comment. (Note that post-5.2 is probably too late to make this tweak, so there's some urgency in this discussion.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7146/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7146 To:

D7146: [RFC] grep: add config option to grep PWD by default

durin42 added a comment. Huh, this behavior of `git grep` surprises me, but not _that_ much. We do already print PWD-relative paths if `tweakdefaults` is active, right? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7146/new/ REVISION DETAIL

D7116: rust-performance: introduce FastHashMap type alias for HashMap

durin42 added a comment. OOC, have you compared this with the hashbrown crate for perf? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7116/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7116 To: Alphare, #hg-reviewers Cc: durin42, kevincox,

D7056: phabricator: include bookmark in diff metadata

durin42 added a comment. (or a config knob) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7056/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7056 To: Kwan, #hg-reviewers Cc: durin42, mercurial-devel

D7056: phabricator: include bookmark in diff metadata

durin42 added a comment. Yeah, the bookmark-name disclosure seems like something that should be optional? Maybe put this behind a flag? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7056/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7056

D7061: convert: don't pass bytes to, or expect bytes from, emailparser

durin42 added inline comments. INLINE COMMENTS > Kwan wrote in gnuarch.py:301 > Hmm, I wasn't aware of that drawback of `unifromlocal()` if it's true. Is > there a canonical "Give me unicode from these mercurial bytes" function? > Regardless, `BytesParser` does sound handy, and is even in

D7055: phabricator: update hgmatcher to cope with the new data format

durin42 added inline comments. INLINE COMMENTS > Kwan wrote in phabricator.py:155-156 > These will need converting to unicode first for py3.5 (I keep forgetting > about loads only accepting bytes from 3.6 onwards). That might be a nudge towards dropping 3.5 support. We've already got problems

D7108: cleanup: hgdemandimport.tracing accepts strings, not bytes

Closed by commit rHG707a4d56f05a: cleanup: hgdemandimport.tracing accepts strings, not bytes (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6550: tracing: add a couple of trace points on obsolete and repoview

Closed by commit rHG149d6ba20d9a: tracing: add a couple of trace points on obsolete and repoview (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7109: dirstate: add some traces on listdir calls

Closed by commit rHGbc5c4919a1a0: dirstate: add some traces on listdir calls (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7109?vs=17179=17207 CHANGES SINCE

D7102: tests: fix formatting test after move of black config

Closed by commit rHG1a7d1f1aa0ac: tests: fix formatting test after move of black config (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7102?vs=17170=17205

D7105: dirs: reject consecutive slashes in paths

Closed by commit rHG1f04c51d52ea: dirs: reject consecutive slashes in paths (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7105?vs=17173=17192 CHANGES SINCE

D7104: dirs: give formatting oversight to clang-format

Closed by commit rHGea62d7b06c12: dirs: give formatting oversight to clang-format (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7104?vs=17172=17191 CHANGES

D7103: dirs: tag a struct as not being formattable

Closed by commit rHGbe178b5d91c8: dirs: tag a struct as not being formattable (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7103?vs=17171=17190 CHANGES

D7026: treemanifest: move out of experimental

durin42 added a comment. That sounds fine REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7026/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7026 To: pulkit, durin42, #hg-reviewers Cc: marmoute, mercurial-devel

D7108: cleanup: hgdemandimport.tracing accepts strings, not bytes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This does mean that the resulting traces will have some b'' goo in them on Python 3, but I think that's a worthwile price to pay since it doesn't break any

D6550: tracing: add a couple of trace points on obsolete and repoview

durin42 updated this revision to Diff 17180. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6550?vs=15609=17180 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6550/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6550 AFFECTED FILES

D7109: dirstate: add some traces on listdir calls

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm starting to spend some time trying to make `hg status` do less work, and knowing what's happening in here and what's expensive is an important start.

D7106: fuzz: restrict dirs fuzzer to only 40k of input

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Experimentally one very long path of this size shouldn't blow the RAM budget in the fuzzer environment, and it's not really exciting to discover that building

D7105: dirs: reject consecutive slashes in paths

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We shouldn't ever see those, and the fuzzer go really excited that if it gives us a 65k string with 55k slashes in it we use a lot of RAM. REPOSITORY rHG

D7104: dirs: give formatting oversight to clang-format

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7104 AFFECTED FILES contrib/clang-format-ignorelist mercurial/cext/dirs.c CHANGE DETAILS diff

D7103: dirs: tag a struct as not being formattable

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7103 AFFECTED FILES mercurial/cext/dirs.c CHANGE DETAILS diff --git a/mercurial/cext/dirs.c

D7102: tests: fix formatting test after move of black config

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7102 AFFECTED FILES tests/test-check-format.t CHANGE DETAILS diff --git

D7090: black: also ignore grey.py

Closed by commit rHG8343070ed758: black: also ignore grey.py (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7090?vs=17137=17163 CHANGES SINCE LAST ACTION

D7089: black: use multiline exclude definition

Closed by commit rHG2a201b366d5b: black: use multiline exclude definition (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7089?vs=17136=17162 CHANGES SINCE

D7088: black: move remaining config knobs into toml file

Closed by commit rHG15c05732d177: black: move remaining config knobs into toml file (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7088?vs=17135=17161

D7087: black: rename pyproject.toml to black.toml

Closed by commit rHG8f89899a5446: black: rename pyproject.toml to black.toml (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7087?vs=17134=17160 CHANGES SINCE

D7090: black: also ignore grey.py

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7090 AFFECTED FILES black.toml contrib/examples/fix.hgrc CHANGE DETAILS diff --git

D7088: black: move remaining config knobs into toml file

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7088 AFFECTED FILES black.toml contrib/examples/fix.hgrc CHANGE DETAILS diff --git

D7089: black: use multiline exclude definition

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Our excludes list is pretty complicated, so let's give ourselves some readability. Black treats multiline exclude definitions as verbse regular

D7087: black: rename pyproject.toml to black.toml

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Black won't read this automatically (you'll have to specify --config), but having a pyproject.toml *at all* puts pip in PEP 517/518 mode which breaks us for

D6993: black: add a pyproject.toml that contains our black settings

durin42 added a comment. Ugh, weird. I think this is an issue around setuptools versions, but I'll try and ask dstufft this week. :( REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6993/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6993 To:

D7034: fuzz: new target to fuzz jsonescapeu8fast

Closed by commit rHG2b11fe679a5d: fuzz: new target to fuzz jsonescapeu8fast (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7034?vs=16991=17035 CHANGES SINCE

D7033: fuzz: new fuzzer for fncache-related functions

Closed by commit rHGca2ca7fbad44: fuzz: new fuzzer for fncache-related functions (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7033?vs=16990=17034 CHANGES

D7032: fuzz: exercise a little more revlog code

Closed by commit rHGdc827f5aba93: fuzz: exercise a little more revlog code (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7032?vs=16988=17033 CHANGES SINCE

D7031: fuzz: new fuzzer for dirs.c

Closed by commit rHGbd503fdb878c: fuzz: new fuzzer for dirs.c (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7031?vs=16987=17032 CHANGES SINCE LAST ACTION

D7030: dirs: fix trivial over-read of input data

Closed by commit rHG2a0774e9d2a8: dirs: fix trivial over-read of input data (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7030?vs=16986=17031 CHANGES SINCE

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 17007. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=16858=17007 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL

D7034: fuzz: new target to fuzz jsonescapeu8fast

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code just feels complicated enough we should go ahead and give it a dedicated fuzzer: we've found bugs in similar things before. REPOSITORY rHG

D7033: fuzz: new fuzzer for fncache-related functions

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Not all of these are strictly fncache-related, but they all have th same signature and similar-enough behavior that we may as well fuzz them together.

D7032: fuzz: exercise a little more revlog code

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7032 AFFECTED FILES contrib/fuzz/revlog.cc CHANGE DETAILS diff --git a/contrib/fuzz/revlog.cc

D7031: fuzz: new fuzzer for dirs.c

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This found a six-year-old bug immediately, and then I put it through a few CPU-days of time before sending it. REPOSITORY rHG Mercurial REVISION DETAIL

D7030: dirs: fix trivial over-read of input data

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code, introduced in 8c0a7eeda06d , was intentionally over-reading an input

D7028: cleanup: join string literals that are already on one line

durin42 added a comment. nit: add a `# skip-blame: ` annotation to help us in the future (maybe check history to look for how it's been annotated in the past) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7028/new/ REVISION DETAIL

D7022: infinitepush: mark extension as likely to be deleted

Closed by commit rHGe5d535621ee1: infinitepush: mark extension as likely to be deleted (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7022?vs=16960=16972

D7022: infinitepush: mark extension as likely to be deleted

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY .. bc:: The infinitepush extension is believed to be unused, and will be deleted at the end of 2020 unless users contact

D7005: py3: manually import pycompat.open into files that need it

durin42 added a comment. In D7005#102780 , @martinvonz wrote: > Can we import `io.open` regardless of Python version instead? That won't work because pycompat.open accepts bytestrings as the mode argument. I'll take this now, and then we

D6996: cleanup: mark some ui.(status|note|warn|write) calls as not needing i18n

Closed by commit rHG86e4daa2d54c: cleanup: mark some ui.(status|note|warn|write) calls as not needing i18n (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6997: contrib: fix check-code to be able to detect missing _() with bytestrings

Closed by commit rHGe65e7290041e: contrib: fix check-code to be able to detect missing _() with bytestrings (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6972: formatting: byteify all mercurial/ and hgext/ string literals

Closed by commit rHG687b865b95ad: formatting: byteify all mercurial/ and hgext/ string literals (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6971: formatting: blacken the codebase

Closed by commit rHG2372284d9457: formatting: blacken the codebase (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6971?vs=16899=16903 CHANGES SINCE LAST

D6342: style: run a patched black on a subset of mercurial

Closed by commit rHG57875cf423c9: style: run a patched black on a subset of mercurial (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6342?vs=16881=16902

D6973: mangler: stop rewriting string constants to be bytes literals

Closed by commit rHG88eba7103660: mangler: stop rewriting string constants to be bytes literals (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6996: cleanup: mark some ui.(status|note|warn|write) calls as not needing i18n

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16901. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6996?vs=16887=16901 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6996/new/ REVISION DETAIL

D6972: formatting: byteify all mercurial/ and hgext/ string literals

durin42 updated this revision to Diff 16900. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6972?vs=16883=16900 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6972/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6972 AFFECTED FILES

D6971: formatting: blacken the codebase

durin42 updated this revision to Diff 16899. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6971?vs=16882=16899 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6971 AFFECTED FILES

D6994: ui: define (write|status|warn|note)noi18n aliases

durin42 edited the summary of this revision. durin42 retitled this revision from "ui: define a writenoi18n alias" to "ui: define (write|status|warn|note)noi18n aliases". durin42 updated this revision to Diff 16886. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6972: formatting: byteify all mercurial/ and hgext/ string literals

durin42 updated this revision to Diff 16883. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6972?vs=16869=16883 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6972/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6972 AFFECTED FILES

D6342: style: run a patched black on a subset of mercurial

durin42 updated this revision to Diff 16881. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6342?vs=16867=16881 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6342/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6342 AFFECTED FILES

D6971: formatting: blacken the codebase

durin42 updated this revision to Diff 16882. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6971?vs=16868=16882 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6971 AFFECTED FILES

D6974: examples: include a sample of how to use black with fix

Herald added a subscriber: mjpieters. Closed by commit rHG47cba083adb7: examples: include a sample of how to use black with fix (authored by durin42). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT

D6993: black: add a pyproject.toml that contains our black settings

Closed by commit rHG929678eb4cbd: black: add a pyproject.toml that contains our black settings (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6979: contrib: stop whining about whitespace around =

Closed by commit rHG9bfd083bc6ee: contrib: stop whining about whitespace around = (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6979?vs=16828=16874 CHANGES

D6978: contrib: black manages whitespace after Python keywords now

Closed by commit rHG28002d25eb54: contrib: black manages whitespace after Python keywords now (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6977: contrib: allow trailing commas in lists

Closed by commit rHGb61324854e93: contrib: allow trailing commas in lists (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6977?vs=16826=16872 CHANGES SINCE

D6976: contrib: remove check-code line length limit

Closed by commit rHG63e25ae9cdce: contrib: remove check-code line length limit (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6976?vs=16825=16871 CHANGES

D6973: mangler: stop rewriting string constants to be bytes literals

durin42 updated this revision to Diff 16870. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6973?vs=16833=16870 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6973/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6973 AFFECTED FILES

D6972: formatting: byteify all mercurial/ and hgext/ string literals

durin42 edited the summary of this revision. durin42 updated this revision to Diff 16869. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6972?vs=16845=16869 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6972/new/ REVISION DETAIL

D6971: formatting: blacken the codebase

durin42 updated this revision to Diff 16868. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6971?vs=16844=16868 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6971 AFFECTED FILES

D6342: style: run a patched black on a subset of mercurial

durin42 updated this revision to Diff 16867. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6342?vs=16829=16867 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6342/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6342 AFFECTED FILES

<    2   3   4   5   6   7   8   9   10   11   >