D6135: packaging: don't bundle DLLs in py2exe library.zip for x86 builds

2019-03-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I had ported the x86/x64 behavior difference from the Inno Setup installer files. Why things were this way, I'm not sure. The WiX configuration files are

D6138: wix: introduce variable to hold path to wix packaging directory

2019-03-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For convenience. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6138 AFFECTED FILES contrib/packaging/hgpackaging/wix.py CHANGE

D6137: wix: package missing .dll and .pyd files

2019-03-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY dist.wxs is currently missing some .pyd and .dll files which are picked up and staged by py2exe. This means that the WiX installer is missing some Python

D6136: setup: exclude crypt32.dll in py2exe builds

2019-03-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY py2exe is picking up crypt32.dll as a dependency and is including the DLL in the dist/lib directory, where it can get picked up by an installer and

D6134: packaging: convert files to LF

2019-03-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY My editor accidentally wrote CRLF line endings because I authored this code on Windows. Derp. I'm kinda surprised no linters caught this...

D2010: check-commit: allow foo_bar naming in functions

2019-03-14 Thread indygreg (Gregory Szorc)
indygreg added a comment. Should we queue this patch or abandon it? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2010 To: indygreg, #hg-reviewers, pulkit, durin42 Cc: av6, yuja, durin42, pulkit, mercurial-devel ___

D6098: wix: restore COPYING.rtf

2019-03-14 Thread indygreg (Gregory Szorc)
indygreg added a comment. Looks like this one forgot to be queued? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6098 To: indygreg, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

D6082: phabricator: add a `--branch` flag to `hg phabsend`

2019-03-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. While there may be a need for an explicit `--branch` argument, should we start by having `hg phabsend` automatically pick up the branch from the changeset? i.e. wouldn't we want branch selection to be automatic? REPOSITORY rHG Mercurial REVISION DETAIL

D6097: wix: functionality to automate building WiX installers

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4371f543efda: wix: functionality to automate building WiX installers (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6101: wix: remove enum and future packages

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9d4ae5044b4c: wix: remove enum and future packages (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6101?vs=14411=14455

D6100: wix: remove pywin32

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc7c7edd46849: wix: remove pywin32 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6100?vs=14410=14454 REVISION DETAIL

D6096: wix: move contrib/wix to contrib/packaging/wix

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc68a1df5c79a: wix: move contrib/wix to contrib/packaging/wix (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6099: wix: remove sphinx and dependencies

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc569f769c41d: wix: remove sphinx and dependencies (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6099?vs=14409=14453

D6094: setup: include hgext3rd package in py2exe builds

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5d9fdc9b0178: setup: include hgext3rd package in py2exe builds (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6095: wix: remove hg.cmd

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3dbd3cdfe0d6: wix: remove hg.cmd (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6095?vs=14405=14450 REVISION DETAIL

D6092: setup: configure py2exe config via environment variables

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG260305e8ddbd: setup: configure py2exe config via environment variables (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6093: setup: properly install build_hgextindex for py2exe builds

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGac32e04e887f: setup: properly install build_hgextindex for py2exe builds (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6091: packaging: extract py2exe functionality to own module

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2e191a937a9: packaging: extract py2exe functionality to own module (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6090: packaging: extract python exe info to own function

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7d1211168863: packaging: extract python exe info to own function (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6083: packaging: establish hgpackaging package

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9da97f49d4f4: packaging: establish hgpackaging package (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6083?vs=14390=14438

D6089: packaging: don't use temporary directory

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5e923355c595: packaging: dont use temporary directory (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6089?vs=14396=1

D6088: packaging: extract virtualenv and py2exe to build directory

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd4bf73ea06de: packaging: extract virtualenv and py2exe to build directory (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6087: packaging: move Inno Setup core logic into a module

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdc7827a9ba64: packaging: move Inno Setup core logic into a module (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6084: packaging: split downloading code into own module

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc2237fe1359e: packaging: split downloading code into own module (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6086: packaging: move find_vc_runtime_files() into hgpackaging.util

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1440dd6164f2: packaging: move find_vc_runtime_files() into hgpackaging.util (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6085: packaging: move DOWNLOADS dict to hgpackaging.downloads

2019-03-09 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1e8fb6522fee: packaging: move DOWNLOADS dict to hgpackaging.downloads (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6097: wix: functionality to automate building WiX installers

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Like we did for Inno Setup, we want to make it easier to produce WiX installers. This commit does that. We introduce a new hgpackaging.wix module for

D6101: wix: remove enum and future packages

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These were cargo culted from the THG installer code. I'm not sure what needs them in THG land. But the official MSIs certainly do not - at least not as direct

D6096: wix: move contrib/wix to contrib/packaging/wix

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We're trying to consolidate all our packaging code into contrib/packaging. Let's move the WiX files there. REPOSITORY rHG Mercurial REVISION DETAIL

D6100: wix: remove pywin32

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This dependency was for ancient Mercurial versions. We recently removed it from the Inno Setup installers. So let's remove it from the WiX installers as well.

D6099: wix: remove sphinx and dependencies

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Sphinx was cargo culted into our install environment as part of emulating TortoiseHG's behavior. THG seems to install Sphinx in order to generate THG

D6094: setup: include hgext3rd package in py2exe builds

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a core Mercurial package and we should always ship it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6094 AFFECTED FILES

D6098: wix: restore COPYING.rtf

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHG8427fea0401708ba95a27810163c17cee54ed4b0 accidentally blew away the content of this file. As part of restoring the content, I

D6093: setup: properly install build_hgextindex for py2exe builds

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Because the hgbuild class has a private copy of build.sub_commands, modifying build.sub_commands from this code effectively resulted in a no-op. Registering

D6095: wix: remove hg.cmd

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This file is not referenced anywhere AFAICT. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6095 AFFECTED FILES

D6092: setup: configure py2exe config via environment variables

2019-03-08 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The Inno Setup and WiX installers ship a different set of packages with py2exe builds. And there are multiple WiX installer variants (e.g. TortoiseHG).

D6091: packaging: extract py2exe functionality to own module

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY py2exe builds are shared between Inno Setup and WIX. We'll want the logic for performing py2exe builds to be reusable across the code for both

D6087: packaging: move Inno Setup core logic into a module

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Aspects of building the Inno Setup and WIX installers are shared. It will make sense for them to share code. Plus, having code in a reusable library (as

D6090: packaging: extract python exe info to own function

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is generic functionality. We'll need it for WIX. As part of the port, we expose the full version and return the data as a dict. REPOSITORY

D6089: packaging: don't use temporary directory

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We were no longer doing anything with it after extracting virtualenv and py2exe to the build directory. REPOSITORY rHG Mercurial REVISION DETAIL

D6083: packaging: establish hgpackaging package

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, contrib/packaging behaved as a root to a package directory and we had a "packagingutil" module. As I work more on packaging code, we'll want to

D6088: packaging: extract virtualenv and py2exe to build directory

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The build directory is essentially a cache. We can extract the virtualenv and py2exe package sources to this directory. REPOSITORY rHG Mercurial REVISION

D6086: packaging: move find_vc_runtime_files() into hgpackaging.util

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In preparation for moving the bulk of the Inno Setup code into hgpackaging. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6086

D6085: packaging: move DOWNLOADS dict to hgpackaging.downloads

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We'll want to keep state in sync between multiple packaging tools. It makes sense to share a central data structure defining downloads. We also change the

D6084: packaging: split downloading code into own module

2019-03-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As we will introduce more code to support packaging, it will be useful to have download code in its own module. REPOSITORY rHG Mercurial REVISION DETAIL

D6066: inno: script to automate building Inno installer

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd7dc4ac1ff84: inno: script to automate building Inno installer (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6067: inno: stop shipping pywin32

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7a1433e90482: inno: stop shipping pywin32 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6067?vs=14339=14370 REVISION

D6068: inno: remove w9xpopen.exe

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2dbdb9abcc4b: inno: remove w9xpopen.exe (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6068?vs=14340=14369 REVISION

D6065: setup: exclude some internal UCRT files

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdb3098d02a6d: setup: exclude some internal UCRT files (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6065?vs=14330=14367

D6064: setup: include additional packages in py2exe distribution

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGed35057421ae: setup: include additional packages in py2exe distribution (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6063: setup: define build_doc command

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd80d48928eb1: setup: define build_doc command (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6063?vs=14328=14365 REVISION

D6060: inno: replace add_path.exe with a Pascal script

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0f49b56d5d74: inno: replace add_path.exe with a Pascal script (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6062: inno: remove references to pywin32

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd22198b4b3dd: inno: remove references to pywin32 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6062?vs=14337=14364

D6061: inno: remove cacerts.pem from documentation

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG27eca52b1874: inno: remove cacerts.pem from documentation (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6059: inno: move inno installer files to contrib/packaging/inno

2019-03-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG765f836a9484: inno: move inno installer files to contrib/packaging/inno (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6066: inno: script to automate building Inno installer

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 14338. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6066?vs=14331=14338 REVISION DETAIL https://phab.mercurial-scm.org/D6066 AFFECTED FILES contrib/packaging/__init__.py contrib/packaging/inno/build.py

D6067: inno: stop shipping pywin32

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 14339. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6067?vs=14333=14339 REVISION DETAIL https://phab.mercurial-scm.org/D6067 AFFECTED FILES

D6068: inno: remove w9xpopen.exe

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY w9xpopen.exe is a utility program shipped with Python <3.4 (https://bugs.python.org/issue14470 tracked its removal). The program was used by subprocess to

D6060: inno: replace add_path.exe with a Pascal script

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 14335. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6060?vs=14325=14335 REVISION DETAIL https://phab.mercurial-scm.org/D6060 AFFECTED FILES contrib/packaging/inno/mercurial.iss

D6062: inno: remove references to pywin32

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 14337. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6062?vs=14327=14337 REVISION DETAIL https://phab.mercurial-scm.org/D6062 AFFECTED FILES contrib/packaging/inno/readme.txt contrib/win32/hgwebdir_wsgi.py

D6061: inno: remove cacerts.pem from documentation

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 14336. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6061?vs=14326=14336 REVISION DETAIL https://phab.mercurial-scm.org/D6061 AFFECTED FILES contrib/packaging/inno/readme.txt CHANGE DETAILS diff --git

D6059: inno: move inno installer files to contrib/packaging/inno-installer

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 14334. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6059?vs=14324=14334 REVISION DETAIL https://phab.mercurial-scm.org/D6059 AFFECTED FILES contrib/packaging/inno/mercurial.iss

D6067: inno: stop shipping pywin32

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 14333. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6067?vs=14332=14333 REVISION DETAIL https://phab.mercurial-scm.org/D6067 AFFECTED FILES contrib/packaging/inno-installer/build.py

D6066: inno: script to automate building Inno installer

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The official Inno installer build process is poorly documented. And attempting to reproduce behavior of the installer uploaded to www.mercurial-scm.org has

D6067: inno: stop shipping pywin32

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Ancient versions of Mercurial relied on pywin32 and I suspect that's why we have this dependency. We also ship the "keyring" package, which has a dependency

D6065: setup: exclude some internal UCRT files

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When attempting to build the Inno installer locally, I was getting several file not found errors when py2exe was crawling DLL dependencies. The missing DLLs

D6064: setup: include additional packages in py2exe distribution

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm attempting to reproduce the Inno installers on my local machine. As part of auditing differences between installer output, I noticed that the existing Inno

D6060: inno: replace add_path.exe with a Pascal script

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While attempting to build the Inno installer, I was unable to find a copy of add_path.exe from the source site previously listed in the docs. Some quick

D6063: setup: define build_doc command

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, various processes for packaging Mercurial state to manually invoke `make -C doc` in order to generate the documentation. This Makefile merely

D6062: inno: remove references to pywin32

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY According to the commit message for https://phab.mercurial-scm.org/rHG0c35bb01a119557a20558aba53087234df27ecd0, pywin32 was removed in Mercurial 1.8!

D6061: inno: remove cacerts.pem from documentation

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The inno distribution no longer includes cacert.pem as of https://phab.mercurial-scm.org/rHGca1ad8ef38be225caec42564502aafe43cae173d (April 2015). The docs were

D6059: inno: move inno installer files to contrib/packaging/inno-installer

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let's isolate the inno installer files to their own directory so the separation between things is clearer. This required adjusting a few relative paths and

D6045: inno: replace add_path.exe with a Pascal script

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg planned changes to this revision. indygreg added a comment. I'm going to make this part of a larger series to improve the Inno installer... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6045 To: indygreg, #hg-reviewers Cc: mercurial-devel

D6052: global: use raw string for setlocale() argument

2019-03-03 Thread indygreg (Gregory Szorc)
indygreg added a comment. Yeah, `''.join([u''])` will coerce the `str` to `unicode`, so we're fine on that front. The problem is only with `HGUNICODEPEDANTRY=1`, which will raise during implicit `str` <-> `unicode` coercion. One can reproduce a failure with `HGUNICODEPEDANTRY=1

D6052: global: use raw string for setlocale() argument

2019-03-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG82d9728ace95: global: use raw string for setlocale() argument (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6049: global: use raw strings for namedtuple()

2019-03-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7f63ec6969f3: global: use raw strings for namedtuple() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6049?vs=14298=14314

D6046: global: use raw strings for __slots__

2019-03-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGae189674bdad: global: use raw strings for __slots__ (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6046?vs=14295=14311

D6050: revsetlang: use sysbytes() instead of blind encode()

2019-03-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGddb174511f1b: revsetlang: use sysbytes() instead of blind encode() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6051: encoding: use raw strings for encoding arguments

2019-03-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG25694a78e4a4: encoding: use raw strings for encoding arguments (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6048: attr: don't attempt to .encode() a str on Python 2

2019-03-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG89f01ea906ae: attr: dont attempt to .encode() a str on Python 2 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6047: procutil: use a raw string for module name

2019-03-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb275dbb60089: procutil: use a raw string for module name (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6052: global: use raw string for setlocale() argument

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg added a subscriber: yuja. indygreg added a comment. The context for this series is that `HGUNICODEPEDANTRY` is completely broken without it. For those not aware, on Python 2, if you call `sys.setdefaultencoding('undefined')`, it loads a special codec

D6052: global: use raw string for setlocale() argument

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 2 will coerce a unicode to str, which fails on HGUNICODEPEDANTRY=1. REPOSITORY rHG Mercurial REVISION

D6049: global: use raw strings for namedtuple()

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 2 will attempt to coerce unicode to str, which we don't want. REPOSITORY rHG Mercurial REVISION DETAIL

D6046: global: use raw strings for __slots__

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 2 will coerce unicode to str at module load time. We don't like automatic string coercions. REPOSITORY rHG Mercurial REVISION DETAIL

D6051: encoding: use raw strings for encoding arguments

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This prevents the internals of Python from coercing a unicode to str on Python 2 and makes tests run with HGUNICODEPEDANTRY=1 a lot happier. REPOSITORY rHG

D6050: revsetlang: use sysbytes() instead of blind encode()

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise we will call str.encode() on Python 2, which is wrong. sysbytes() does encode('utf-8) on Python 3. But the source is guaranteed ASCII, so it

D6048: attr: don't attempt to .encode() a str on Python 2

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise it coerces automatically. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6048 AFFECTED FILES

D6047: procutil: use a raw string for module name

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 2 will coerce unicode to str. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6047 AFFECTED FILES

D6043: UnicodeEncoding:change the default encoding of the whole script to be 'UTF-8'(issue6040)

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. If we wanted to call ``sys.setdefaultencoding()``, we should call it once during ``hg`` or at the top of ``mercurial/__init__.py``. But we don't want to call

D6045: inno: replace add_path.exe with a Pascal script

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While attempting to build the Inno installer, I was unable to find a copy of add_path.exe from the source site previously listed in the docs. Some quick

D5296: store: don't read the whole fncache in memory

2019-02-25 Thread indygreg (Gregory Szorc)
indygreg added a comment. I suspect https://phab.mercurial-scm.org/rHG9fca5b056c0a2f673aefa64f7ec7488bd9188d9d made things faster because the code before was using 1 I/O operation for every entry. I would also not be surprised if CPython from that era did something very inefficient with

D5976: tests: add more wildcards to test-extdiff.t

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG88d4477ac4f6: tests: add more wildcards to test-extdiff.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5975: url: don't pass strict argument on Python 3

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG544035846830: url: dont pass strict argument on Python 3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5952: url: always use str for proxy configuration

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4028897dfa05: url: always use str for proxy configuration (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5974: tests: double escape \ in test-import-eol.t and test-mq-eol.t

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG140b542b0e59: tests: double escape \ in test-import-eol.t and test-mq-eol.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5951: py3: port tinyproxy.py to work with Python 3

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG97e2442a4595: py3: port tinyproxy.py to work with Python 3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5950: url: always access req._tunnel_host

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd20f1594ff4a: url: always access req._tunnel_host (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5950?vs=14053=14118

D5973: tests: use raw string in test-impexp-branch.t

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7396508ad92b: tests: use raw string in test-impexp-branch.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5976: tests: add more wildcards to test-extdiff.t

2019-02-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The diff tool (which is `echo`) runs in the background and output order can therefore be non-deterministic. We need to glob over the file names to account for

<    4   5   6   7   8   9   10   11   12   13   >