D3212: patch: implement a new worddiff algorithm

2018-04-12 Thread dhduvall (Danek Duvall)
dhduvall added a comment. I can't really tell what's going on there, frankly, unlike with the dim case, where it make sense, but I can always change the colors myself. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3212 To: quark, #hg-reviewers, durin42, yuja

D3212: patch: implement a new worddiff algorithm

2018-04-12 Thread dhduvall (Danek Duvall)
dhduvall added inline comments. INLINE COMMENTS > quark wrote in color.py:94 > There are not many choices - dim, 16/256 colors, or bold. We ended up with > 16/256 colors internally for wider support (ex. tmux). But I'd like to > express my (strong) options that: > > - diff.inserted.changed

D2391: sshpeer: factor out code for creating peers from pipes

2018-02-22 Thread dhduvall (Danek Duvall)
dhduvall added inline comments. INLINE COMMENTS > sshpeer.py:537 > + > +``path`` and ``path`` are stored on the eventual peer instance and may > +not be used for anything meaningful. That second `path` should be `proc`? REPOSITORY rHG Mercurial REVISION DETAIL