D6844: remotefilelog: replace repack lock to solve race condition

2019-09-17 Thread lothiraldan (Boris Feld)
Closed by commit rHG5fadf6103790: remotefilelog: replace repack lock to solve race condition (authored by lothiraldan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6844: remotefilelog: replace repack lock to solve race condition

2019-09-12 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 2c74337e6483 reduced the probability of race-conditions when starting

D6789: check-code: allow command substitution with $(command)

2019-09-09 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. FYI, Fish also doesn't support the `$(expr)` syntax but it's not a POSIX compatible shell REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6789/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6789 To: martinvonz,

D6772: remotefilelog: reduce probability of race-condition in remotefilelog tests

2019-09-03 Thread lothiraldan (Boris Feld)
Closed by commit rHG2c74337e6483: remotefilelog: reduce probability of race-condition in remotefilelog tests (authored by lothiraldan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D6772: remotefilelog: reduce probability of race-condition in remotefilelog tests

2019-09-03 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. lothiraldan added a subscriber: durin42. @durin42 Could you take a look? I think you are in the best condition to review this patch. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6772/new/ REVISION DETAIL

D6772: remotefilelog: reduce probability of race-condition in remotefilelog tests

2019-08-29 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY ca1014ad3de4 introduced a new parameter `ensurestart` to speed up

D6122: tests: add a file listing all the flaky tests

2019-06-12 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In D6122#89861 , @lothiraldan wrote: > In D6122#89819 , @av6 wrote: > >> In D6122#89818 , @lothiraldan wrote: >> >>>

D6122: tests: add a file listing all the flaky tests

2019-03-22 Thread lothiraldan (Boris Feld)
lothiraldan added a subscriber: durin42. lothiraldan added a comment. In https://phab.mercurial-scm.org/D6122#89819, @av6 wrote: > In https://phab.mercurial-scm.org/D6122#89818, @lothiraldan wrote: > > > @av6 is a `--no-flaky-tests` flag what you had in mind? > > > Something

D6122: tests: add a file listing all the flaky tests

2019-03-21 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. The big difference between `#require slow` and `#require flaky` is that we don't want to run the slow tests by default but we want to run the flaky test by default if not specified otherwise. I don't know enough about the test runner to evaluate the amount of

D6147: discovery: move cl.hasnode outside of the for-loop

2019-03-18 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. The series looks good to me after a very quick review. I think a more in-deep review will be necessary. @pulkit Do you have measured some performance improvement with this series? REPOSITORY rHG Mercurial REVISION DETAIL

D5955: watchman: ignore some of watchman errors

2019-03-16 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG76361969662a: watchman: ignore some of watchman errors (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5954: watchman: add the possibility to set the exact watchman binary location

2019-03-16 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG57264906a996: watchman: add the possibility to set the exact watchman binary location (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6122: tests: add a file listing all the flaky tests

2019-03-12 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D6122#89169, @av6 wrote: > Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can `#require flaky` or even mark a specific block with `#if flaky`.

D6122: tests: add a file listing all the flaky tests

2019-03-12 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This file can be used by CI instances to skip tests known to be flaky and focus on tests with no false negatives. REPOSITORY rHG Mercurial REVISION DETAIL

D6028: branchmap: prevent reading the file twice through different iterators

2019-02-27 Thread lothiraldan (Boris Feld)
lothiraldan added subscribers: yuja, lothiraldan. lothiraldan accepted this revision. lothiraldan added a comment. Queued thanks, the test now pass both locally and on gcc112. @yuja nice catch! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6028 To: pulkit,

D5955: watchman: ignore some of watchman errors

2019-02-27 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. Gentle ping on this series REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5955 To: lothiraldan, #hg-reviewers Cc: indygreg, mercurial-devel ___ Mercurial-devel mailing list

D6023: branchcache: move loading of branch names and nodes into it's own function

2019-02-25 Thread lothiraldan (Boris Feld)
lothiraldan accepted this revision. lothiraldan added a comment. LGTM, queued thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6023 To: pulkit, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel ___

D5966: test: stabilize test-run-tests.t output

2019-02-20 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4618bdf75d8a: test: stabilize test-run-tests.t output (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output

2019-02-20 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5b6ee1b16f9a: test: stabilize test-remotefilelog-bgprefetch.t flaky output (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5955: watchman: ignore some of watchman errors

2019-02-20 Thread lothiraldan (Boris Feld)
lothiraldan added a subscriber: indygreg. lothiraldan added a comment. @indygreg I've update the patchs with your reviews. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5955 To: lothiraldan, #hg-reviewers Cc: indygreg, mercurial-devel

D5966: test: stabilize test-run-tests.t output

2019-02-19 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > durin42 wrote in test-run-tests.t:1177 > I don't feel strongly, let's just make it permissive so the test passes on > both fast and slow systems. I think it's the case, the first part of the regex `\d+` will match any amount of seconds and

D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output

2019-02-19 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5960#87357, @durin42 wrote: > In https://phab.mercurial-scm.org/D5960#87330, @lothiraldan wrote: > > > In https://phab.mercurial-scm.org/D5960#87251, @durin42 wrote: > > > > > Huh. That's strictly a bug, as

D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output

2019-02-18 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5960#87251, @durin42 wrote: > Huh. That's strictly a bug, as `debugwaitonrepack` should actually be waiting. I've created a ticket to track it: https://phab.mercurial-scm.org/D5960 Do you have any idea what

D5966: test: stabilize test-run-tests.t output

2019-02-18 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > durin42 wrote in test-run-tests.t:1177 > Maybe we could make it 3,5 so it's be more permissive? Yes we could. I think the regex was previously `{4,5}` for two reasons: - We expected the duration to be less than 10 seconds. - The precision

D5968: obsutil: don't assume leftctx and rightctx repo as same

2019-02-15 Thread lothiraldan (Boris Feld)
lothiraldan accepted this revision. lothiraldan added a comment. LGTM, nice catch! Could you add a comment to clarify it? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5968 To: pulkit, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel

D5965: test: stabilize test-run-tests.t output

2019-02-14 Thread lothiraldan (Boris Feld)
lothiraldan abandoned this revision. lothiraldan added a comment. Replaced by https://phab.mercurial-scm.org/D5966 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5965 To: lothiraldan, #hg-reviewers Cc: mercurial-devel

D5966: test: stabilize test-run-tests.t output

2019-02-14 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have reached a point where the duration in JSON reports of `test-run-tests.t` were greater or equal than 10 seconds, which doesn't match anymore the

D5965: test: stabilize test-run-tests.t output

2019-02-14 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have reached a point where the duration in `test-run-tests.t` were greater or equal than 10s, which doesn't match anymore the regex. For example here:

D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output

2019-02-14 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When running the test suite with multiple processes, we often get flaky outputs, like here: https://ci.octobus.net/job/MercurialPy2/274/console -

D5590: watchman: ignore some of watchman errors

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan abandoned this revision. lothiraldan added a comment. Resent as https://phab.mercurial-scm.org/D5955 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5590 To: lothiraldan, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel

D5589: watchman: add the possibility to set the exact watchman binary location

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan abandoned this revision. lothiraldan added a comment. Resent as https://phab.mercurial-scm.org/D5954 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5589 To: lothiraldan, #hg-reviewers Cc: indygreg, mjpieters, mercurial-devel

D5955: watchman: ignore some of watchman errors

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Don't display 'illegal_fstypes' errors. In environments with network filesystems, the error messages are quickly pilling up and polluting outputs. REPOSITORY

D5954: watchman: add the possibility to set the exact watchman binary location

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is necessary to make rolling releases of new watchman versions across users. REPOSITORY rHG Mercurial REVISION DETAIL

D5587: watchman: detect nested mercurial repositories and abort

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 14075. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5587?vs=13645=14075 REVISION DETAIL https://phab.mercurial-scm.org/D5587 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D5590: watchman: ignore some of watchman errors

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 14074. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5590?vs=14071=14074 REVISION DETAIL https://phab.mercurial-scm.org/D5590 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D5589: watchman: add the possibility to set the exact watchman binary location

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 14073. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5589?vs=14070=14073 REVISION DETAIL https://phab.mercurial-scm.org/D5589 AFFECTED FILES hgext/fsmonitor/__init__.py

D5589: watchman: add the possibility to set the exact watchman binary location

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 14070. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5589?vs=13414=14070 REVISION DETAIL https://phab.mercurial-scm.org/D5589 AFFECTED FILES hgext/fsmonitor/__init__.py

D5590: watchman: ignore some of watchman errors

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 14071. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5590?vs=13415=14071 REVISION DETAIL https://phab.mercurial-scm.org/D5590 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D5588: watchman: disable fsmonitor when running non-interactively

2019-02-13 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 14069. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5588?vs=13413=14069 REVISION DETAIL https://phab.mercurial-scm.org/D5588 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D5897: test: stabilize test-wireproto-exchangev2.t flaky output

2019-02-12 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1ab6f5df263e: test: stabilize test-wireproto-exchangev2.t flaky output (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5897: test: stabilize test-wireproto-exchangev2.t flaky output

2019-02-08 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When running the test suite with multiple processes, we often get flaky outputs, like here: https://ci.octobus.net/job/MercurialPy2/267/console -

D5880: fsmonitor: rename new verbose config knob

2019-02-07 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG286eeed14893: fsmonitor: rename new verbose config knob (authored by lothiraldan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5880?vs=13890=13891#toc REPOSITORY rHG

D5880: fsmonitor: rename new verbose config knob

2019-02-07 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. Nice catch, sorry for the hasty phabsend REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5880 To: lothiraldan, #hg-reviewers Cc: pulkit, mjpieters, mercurial-devel ___ Mercurial-devel

D5880: fsmonitor: rename new verbose config knob

2019-02-07 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 13890. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5880?vs=13889=13890 REVISION DETAIL https://phab.mercurial-scm.org/D5880 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D5880: fsmonitor: rename new verbose config knob

2019-02-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The config knob was introduced in this release cycle under the old extension name, rename it before it is part of a release. REPOSITORY rHG

D5587: watchman: detect nested mercurial repositories and abort

2019-01-31 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6a7b2d2de124: watchman: detect nested mercurial repositories and abort (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5586: watchman: add verbose config knob

2019-01-31 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG158962bf4a52: watchman: add verbose config knob (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5586?vs=13411=13644

D5590: watchman: ignore some of watchman errors

2019-01-24 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 13415. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5590?vs=13226=13415 REVISION DETAIL https://phab.mercurial-scm.org/D5590 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D5589: watchman: add the possibility to set the exact watchman binary location

2019-01-24 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 13414. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5589?vs=13225=13414 REVISION DETAIL https://phab.mercurial-scm.org/D5589 AFFECTED FILES hgext/fsmonitor/__init__.py

D5588: watchman: disable fsmonitor when running non-interactively

2019-01-24 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 13413. Herald added a subscriber: mjpieters. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5588?vs=13224=13413 REVISION DETAIL https://phab.mercurial-scm.org/D5588 AFFECTED FILES hgext/fsmonitor/__init__.py

D5587: watchman: detect nested mercurial repositories and abort

2019-01-24 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 13412. Herald added a subscriber: mjpieters. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5587?vs=13223=13412 REVISION DETAIL https://phab.mercurial-scm.org/D5587 AFFECTED FILES hgext/fsmonitor/__init__.py

D5586: watchman: add verbose config knob

2019-01-24 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 13411. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5586?vs=13222=13411 REVISION DETAIL https://phab.mercurial-scm.org/D5586 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D5633: grep: use set instead of dict with dummy value

2019-01-23 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. I get a message stating that one of the hunk of patch failed to apply and couldn't understand what is going on, could you try rebase it to see if you have the issue locally? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5633 To:

D5594: copies: consider nullrev a common ancestor

2019-01-18 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5594#83078, @yuja wrote: > > I've seen many bugs in the git codebase that were caused by it not > > having a null revision and being forced to treat root commits > > differently. Mercurial has a null revision and I

D5622: localrepo: use context manager for transaction in commit()

2019-01-17 Thread lothiraldan (Boris Feld)
lothiraldan accepted this revision. lothiraldan added a comment. In https://phab.mercurial-scm.org/D5622#83013, @martinvonz wrote: > In https://phab.mercurial-scm.org/D5622#83011, @lothiraldan wrote: > > > I have the impression that the test changes are due to the previous patch in

D5590: watchman: ignore some of watchman errors

2019-01-17 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5590#82940, @indygreg wrote: > I don't suppose there's a way to easily test this? I'm guessing not... > > The change seems reasonable though. Unfortunately, I don't see an easy way to test it Thank you for

D5589: watchman: add the possibility to set the exact watchman binary location

2019-01-17 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in __init__.py:567-571 > Why the nested `__init__`? > > Perhaps this initialization code could be cleaned up so we are assigning an > instance instead of a class to `self.transport`? I see several ways to refactor the code

D5588: watchman: disable fsmonitor when running non-interactively

2019-01-17 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5588#82922, @indygreg wrote: > Why wouldn't we want automated, non-interactive tools to have the benefits of watchman? There are plenty of use cases where complex Mercurial operations are scripted and would benefit from

D5586: watchman: add verbose config knob

2019-01-17 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5586#83031, @pulkit wrote: > In https://phab.mercurial-scm.org/D5586#82915, @indygreg wrote: > > > This new config knob defaults to off and we're therefore changing the behavior to not warn when watchman is unavailable.

D5590: watchman: ignore some of watchman errors

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. This series is non-urgent and it's fine if not included in the RC. I would like to gather feedback from fsmonitor experts on it but phabricator doesn't allow to set a `RFC` flag REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5590

D5590: watchman: ignore some of watchman errors

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Don't display 'illegal_fstypes' errors. In environments with network filesystems, the error messages are quickly pilling up and polluting outputs. REPOSITORY

D5589: watchman: add the possibility to set the exact watchman binary location

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is necessary to make rolling releases of new watchman versions across users. REPOSITORY rHG Mercurial REVISION DETAIL

D5588: watchman: disable fsmonitor when running non-interactively

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of the risks with activating fsmonitor globally is resource exhaustion (like inotify watches on Linux). When launching background-jobs, it's often

D5587: watchman: detect nested mercurial repositories and abort

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Disable fsmonitor on nested mercurial repositories. Only depth one repositories are detected at the moment. REPOSITORY rHG Mercurial REVISION DETAIL

D5586: watchman: add verbose config knob

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This new config knob allows to silent watchman log and warning messages when watchman is unavailable. REPOSITORY rHG Mercurial REVISION DETAIL

D5495: revset: add "branch" positional arguments to the merge revset

2019-01-14 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. What about making the argument a revset instead of a branch name. You can get the same result `merge(branch("foo")` but have a more expressive result `merge(only(4.8, 4.7))` ? (Sorry to be a bit late to the party) REPOSITORY rHG Mercurial REVISION DETAIL

D5577: tests: replaced mockmakedate function in test-amend.t

2019-01-14 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. @taapas1128 You can also set the option `devel.default-date` that should do the trick REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5577 To: taapas1128, #hg-reviewers Cc: lothiraldan, yuja, mercurial-devel

D5565: revlog: add version 2 format flag to control sparse

2019-01-11 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. > Revlog behavior should live as close to the revlog as possible. > In version 1 revlogs, we engaged sparse semantics by using a > repository requirement. This constituted action at a distance > and wasn't optimal. > > This commit introduces a feature

D5531: progress: deprecate ui.progress()

2019-01-09 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. The new makeprogress API is more clean but more low-level, could we extend the deprecation warning until the 5.1 release to gives more time to extension authors to update? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5531 To:

D5477: branches: add -r option to show branch name(s) of a given rev (issue5948)

2018-12-27 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5477#81096, @yuja wrote: > > 0. I move metaedit command to core > > 1. I move branch changing functionality to metaedit > > No opinion about 0 and 1. I've never used the metaedit. > > > 2. and then we implement

D5453: test: introduce a new flag to display env variable line per line

2018-12-21 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG73da729ccfef: test: introduce a new flag to display env variable line per line (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5471: contrib: remove unused version of os

2018-12-21 Thread lothiraldan (Boris Feld)
lothiraldan accepted this revision. lothiraldan added a comment. Queued thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5471 To: pulkit, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel ___

D5453: test: introduce a new flag to display env variable line per line

2018-12-20 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5453#80871, @yuja wrote: > > +parser.add_argument( > > +"--line", > > +action="store_const", > > +const=True, > > +default=False, > > Nit: can be `action="store_true"` > > > vars =

D5452: tests: update printenv.py argument parsing

2018-12-20 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG07b15f64e560: tests: update printenv.py argument parsing (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5453: test: introduce a new flag to display env variable line per line

2018-12-19 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's easier to conditionalize some of the environment variables per Mercurial version once there is only one value per line. REPOSITORY rHG Mercurial

D5452: tests: update printenv.py argument parsing

2018-12-19 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We are about to introduce a new flag for printing the HG environment variables one per line and it's easier to do when using the argparse module for argument

D5445: tests: followup on network related errors on Debian 9

2018-12-17 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG97484e1d1834: tests: followup on network related errors on Debian 9 (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5445: tests: followup on network related errors on Debian 9

2018-12-16 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY First, update test-clonebundles.t which was failing since the introduction of the `$EADDRNOTAVAIL$` common pattern. Also update two tests from

D5346: tests: remove all transitional configuration

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa0886a4d6dce: tests: remove all transitional configuration (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5345: sparse-revlog: enabled by default

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3764330f76a6: sparse-revlog: enabled by default (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5345?vs=12654=12805

D5344: test: preemptively disable sparse-revlog for some of test-upgrade-repo

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe8cd688b2eb1: test: preemptively disable sparse-revlog for some of test-upgrade-repo (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5343: test: enable sparse-revlog for test-wireproto-content-redirects.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaeac89e78def: test: enable sparse-revlog for test-wireproto-content-redirects.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5342: test: enable sparse-revlog for test-wireproto-command-capabilities.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe64a28e2a1f2: test: enable sparse-revlog for test-wireproto-command-capabilities.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5341: test: enable sparse-revlog for test-wireproto-caching.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcebaaa38f8fd: test: enable sparse-revlog for test-wireproto-caching.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5339: test: enable sparse-revlog for test-stream-bundle-v2.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6679ce31dfcb: test: enable sparse-revlog for test-stream-bundle-v2.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5340: test: enable sparse-revlog for test-treemanifest.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG37cc627c5959: test: enable sparse-revlog for test-treemanifest.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5338: test: enable sparse-revlog for test-ssh.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8fcda0780136: test: enable sparse-revlog for test-ssh.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5337: test: enable sparse-revlog for test-ssh-proto-unbundle.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4bb6195755b1: test: enable sparse-revlog for test-ssh-proto-unbundle.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5336: test: enable sparse-revlog for test-ssh-proto.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1a1b957f5f2a: test: enable sparse-revlog for test-ssh-proto.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5335: test: enable sparse-revlog for test-ssh-bundle1.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf6904d60fc21: test: enable sparse-revlog for test-ssh-bundle1.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5333: test: enable sparse-revlog for test-revlog-v2.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG27fa1d2bf484: test: enable sparse-revlog for test-revlog-v2.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5334: test: enable sparse-revlog for test-sparse-requirement.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG74a519c86625: test: enable sparse-revlog for test-sparse-requirement.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5332: test: enable sparse-revlog for test-repo-compengines.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4fe18205bbdb: test: enable sparse-revlog for test-repo-compengines.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5330: test: enable sparse-revlog for test-remotefilelog-clone-tree.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG116cadf4f3e8: test: enable sparse-revlog for test-remotefilelog-clone-tree.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5331: test: enable sparse-revlog for test-remotefilelog-log.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb2b8afd66f78: test: enable sparse-revlog for test-remotefilelog-log.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5329: test: enable sparse-revlog for test-remotefilelog-clone.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2fd790468e43: test: enable sparse-revlog for test-remotefilelog-clone.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5328: test: enable sparse-revlog for test-phases.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7bdc97531490: test: enable sparse-revlog for test-phases.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5327: test: enable sparse-revlog for test-narrow-clone.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG56fff6d7e30a: test: enable sparse-revlog for test-narrow-clone.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5326: test: enable sparse-revlog for test-narrow-clone-stream.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG192291ca909b: test: enable sparse-revlog for test-narrow-clone-stream.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5325: test: enable sparse-revlog for test-narrow-clone-no-ellipsis.t

2018-12-10 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeecc7a2ebf52: test: enable sparse-revlog for test-narrow-clone-no-ellipsis.t (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

  1   2   3   4   5   6   7   8   >