This revision was automatically updated to reflect the committed changes.
Closed by commit rHG658ed9c7442b: releasenotes: replace abort with warning
while parsing (issue5775) (authored by rishabhmadan96, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa5891e94bfe1: releasenotes: allow notes for multiple
directives in a single changeset (authored by rishabhmadan96, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3fff6f30bd7f: releasenotes: mention changeset with warning
and abort (authored by rishabhmadan96, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
rishabhmadan96 updated this revision to Diff 6592.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2254?vs=5694=6592
REVISION DETAIL
https://phab.mercurial-scm.org/D2254
AFFECTED FILES
hgext/releasenotes.py
tests/test-releasenotes-formatting.t
rishabhmadan96 updated this revision to Diff 6590.
rishabhmadan96 edited the summary of this revision.
rishabhmadan96 retitled this revision from "releasenotes: replace abort with
warning while parsing" to "releasenotes: replace abort with warning while
parsing (issue5775)".
REPOSITORY
rHG
rishabhmadan96 updated this revision to Diff 6591.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2253?vs=5693=6591
REVISION DETAIL
https://phab.mercurial-scm.org/D2253
AFFECTED FILES
hgext/releasenotes.py
tests/test-releasenotes-parsing.t
CHANGE
rishabhmadan96 added a comment.
I totally forgot about this. I'll send them right away.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2255
To: rishabhmadan96, #hg-reviewers
Cc: durin42, pulkit, mercurial-devel
___
rishabhmadan96 added a comment.
It'd be better if you could update the commit message with the necessary
details that you mentioned in your previous comment.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2394
To: sangeet259, durin42, #hg-reviewers
Cc:
rishabhmadan96 added a comment.
Yeah, my bad. I'll send an updated version with the suggested changes.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2255
To: rishabhmadan96, #hg-reviewers
Cc: pulkit, mercurial-devel
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Output the changeset hash with the warning/abort message just to know where
things messed up.
REPOSITORY
rHG Mercurial
REVISION DETAIL
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This problem was caught in
https://phab.mercurial-scm.org/rHGda91e7309daf8ffc51bf3e6f4b2d8a16ef5af95a.
This patch just makes sure there is no warning when
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
During the 4.5 development cycle, the extension broke on two different
changesets. This change
simply makes sure that it just throws a warning when
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG159a6f7e09a9: releasenotes: display release notes when no
filename is specified (authored by rishabhmadan96, committed by ).
CHANGED PRIOR TO COMMIT
rishabhmadan96 updated this revision to Diff 2263.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D877?vs=2261=2263
REVISION DETAIL
https://phab.mercurial-scm.org/D877
AFFECTED FILES
hgext/releasenotes.py
tests/test-releasenotes-formatting.t
CHANGE
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
If the filename is not specified while using --rev, the notes for the
specified
revs will just be displayed on screen.
REPOSITORY
rHG Mercurial
rishabhmadan96 added a comment.
In https://phab.mercurial-scm.org/D873#14703, @pulkit wrote:
> Can't we just output the releasenotes using ui.write() if no file name is
specified. I sometimes wanted to check what releasenotes my commit will produce
and I needed to mention a file.
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Earlier, not specifying filename with --rev raised a really long TypeError.
This patch just raises a small error to specify the filename.
REPOSITORY
rHG
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The releasenotes command throws a TypeError when no filename is specified with
the --rev flag.
REPOSITORY
rHG Mercurial
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG741a511492d3: releasenotes: raise error on simultaneous
usage of flags (authored by rishabhmadan96, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG01e8ab4b6573: releasenotes: update docstrings with
information on additional flags (authored by rishabhmadan96, committed by ).
CHANGED PRIOR TO COMMIT
rishabhmadan96 updated this revision to Diff 2142.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D831?vs=2139=2142
REVISION DETAIL
https://phab.mercurial-scm.org/D831
AFFECTED FILES
hgext/releasenotes.py
tests/test-releasenotes-formatting.t
CHANGE
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The releasenotes command is supposed to raise an error when --list and
--rev/--check flags are used together. This patch adds the above
functionality.
rishabhmadan96 updated this revision to Diff 2047.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D544?vs=1690=2047
REVISION DETAIL
https://phab.mercurial-scm.org/D544
AFFECTED FILES
hgext/releasenotes.py
CHANGE DETAILS
diff --git
rishabhmadan96 updated this revision to Diff 1690.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D544?vs=1368=1690
REVISION DETAIL
https://phab.mercurial-scm.org/D544
AFFECTED FILES
hgext/releasenotes.py
CHANGE DETAILS
diff --git
rishabhmadan96 added inline comments.
INLINE COMMENTS
> dsp wrote in releasenotes.py:554
> I think we usually don't address "you" directly. Maybe something like
>
> The -c/--check option checks the commit message for invalid admonitions. In
> case of an invalid admonition, the flag returns
rishabhmadan96 updated this revision to Diff 1368.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D544?vs=1358=1368
REVISION DETAIL
https://phab.mercurial-scm.org/D544
AFFECTED FILES
hgext/releasenotes.py
CHANGE DETAILS
diff --git
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds documentation related to the two new flags --check and
--list for releasenotes extension.
https://phab.mercurial-scm.org/D544
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds documentation related to the two new flags --check and
--list for releasenotes extension.
REPOSITORY
rHG Mercurial
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2a37459aedf2: releasenotes: view admonition titles using -l
flag (authored by rishabhmadan96).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D454?vs=1331=1352
rishabhmadan96 updated this revision to Diff 1331.
rishabhmadan96 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D454?vs=1123=1331
REVISION DETAIL
https://phab.mercurial-scm.org/D454
AFFECTED FILES
rishabhmadan96 added a comment.
In https://phab.mercurial-scm.org/D454#8571, @pulkit wrote:
> @rishabhmadan96 Also make sure a user cannot pass any other flag with the
`--list` flag.
I'm using `return` while calling the function. Wouldn't that be enough for
this?
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6a49c74b1e8f: releasenotes: add check flag for use of
admonitions and its validity (authored by rishabhmadan96).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D368?vs=973=1200#toc
REPOSITORY
rishabhmadan96 updated this revision to Diff 1123.
rishabhmadan96 edited the summary of this revision.
rishabhmadan96 retitled this revision from "releasenotes: view admonition
titles using -a flag" to "releasenotes: view admonition titles using -l flag".
REPOSITORY
rHG Mercurial
CHANGES
rishabhmadan96 added inline comments.
INLINE COMMENTS
> pulkit wrote in releasenotes.py:475
> I am not sure whether `-a` is the best choice of flag. Maybe we can have `-l`
> and `--list`.
>
> Also the help can be improved to "list the available admonitions with their
> title".
`--list`
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Since this extension is fairly new for almost all the contributors,
remembering
the admonition (with titles) is difficult. The admonition (-a) flag
rishabhmadan96 added a comment.
Sorry I just edited the revision string. Will that work? Or should I update
it again with "Differential Revision: https://phab.mercurial-scm.org/D368; at
the end.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D368
To:
rishabhmadan96 updated this revision to Diff 973.
rishabhmadan96 retitled this revision from "releasenotes: add check flag for
use of admonitions and its validity" to "Differential Revision:
https://phab.mercurial-scm.org/D368
releasenotes: add check flag for use of admonitions and its
rishabhmadan96 abandoned this revision.
rishabhmadan96 marked an inline comment as done.
rishabhmadan96 added a comment.
In https://phab.mercurial-scm.org/D355#6196, @durin42 wrote:
> is this the same thing as https://phab.mercurial-scm.org/D368? Should we
close this one in favor of that
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
While using releasenotes extension, we will be using admonitions in commit
messages.
The check (-c) flag will look for an admonition within the message.
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
While using releasenotes extension, we will be using admonitions in commit
messages.
The check (-c) flag will look for an admonition within the message.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG589fda7895da: releasenotes: minor bug fix for index error
while serializing (authored by rishabhmadan96).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D356
AFFECTED FILES
hgext/releasenotes.py
CHANGE DETAILS
diff --git a/hgext/releasenotes.py
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
While using releasenotes extension, we will be using admonitions in commit
messages.
The check (-c) flag will look for an admonition within the message.
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D354
AFFECTED FILES
.hgsigs
.hgtags
hgext/fsmonitor/__init__.py
mercurial/cmdutil.py
44 matches
Mail list logo
