D6359: test: change test's diff generation to use mdiff for nicer output

sangeet259 added a comment. @pulkit > The commit message has diff which confuses `hg import`. You need to indent those diffs. ✅ > Also, remove the pastebin links as they are not required since we have diffs. ✅ >> Download this bundle : http://bit.ly/2DuJjsS > >

D6359: test: change test's diff generation to use mdiff for nicer output

sangeet259 updated this revision to Diff 15433. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6359?vs=15052=15433 REVISION DETAIL https://phab.mercurial-scm.org/D6359 AFFECTED FILES tests/run-tests.py

D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff

sangeet259 added a comment. @pulkit > My understanding is that the 1st patch should be present in the mercurial installed in the system, which is what you said right? If that's correct, we can go ahead and have this whole as one patch as I don't think people usually do install system

D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff

sangeet259 added a subscriber: durin42. sangeet259 added a comment. In https://phab.mercurial-scm.org/D6356#92644, @pulkit wrote: > > Why do I need to split the patches into two ? > > The reason to split what would have been a single patch into two is because > > for the next patch

D6359: test: change test's diff generation to use mdiff for nicer output

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is patch (2/2), hence must be there in the repo after 1/2, which is at https://phab.mercurial-scm.org/D6356 The current diff being used by tests upon

D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff

sangeet259 added a comment. > Oh, nice! I sometimes use run-tests.py -i and just accept an unreadable diff because I know that hg diff might make it easier to read. I had not understood why :) Glad to know you will be helped :) Added some description to the commit message!

D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff

sangeet259 added a comment. In https://phab.mercurial-scm.org/D6356#92451, @martinvonz wrote: > > The future changes to run-tests.py will enable one to use mdiif > > to diff rather than unidiff whenever the mercurial is installed in the system. > > Perhaps a naive question, but

D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Patch 1/2 This patch adds some functions to mdiff.py that will be called from run-tests.py which will be added in the second part of this patch series.

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 added a comment. Hey @durin42 , take a look at the changes when you get time. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5514 To: sangeet259, #hg-reviewers, durin42 Cc: pulkit, durin42, mercurial-devel

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 added a comment. ping @durin42 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5514 To: sangeet259, #hg-reviewers, durin42 Cc: pulkit, durin42, mercurial-devel ___ Mercurial-devel mailing list

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 updated this revision to Diff 13998. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5514?vs=13123=13998 REVISION DETAIL https://phab.mercurial-scm.org/D5514 AFFECTED FILES mercurial/mdiff.py tests/run-tests.py CHANGE DETAILS diff --git

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 updated this revision to Diff 13123. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5514?vs=13051=13123 REVISION DETAIL https://phab.mercurial-scm.org/D5514 AFFECTED FILES mercurial/mdiff.py

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 added a comment. @durin42 So the `try/except` will fall back to `unified diff`? Is there a way we can enforce this on system's that don't have mercurial installed globally and not have to fall back on the earlier practice. Also, I didn't get your comment on checking the API

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 added a comment. Note: To see this in action, one needs to add the changes from this `mdiff.py` to the mdiff.py of their installed mercurial. This is because unless you do that, you cannot import `mdiff.new_patch` as that function won't be there in your installed version, and

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 updated this revision to Diff 13051. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5514?vs=13050=13051 REVISION DETAIL https://phab.mercurial-scm.org/D5514 AFFECTED FILES mercurial/mdiff.py tests/run-tests.py CHANGE DETAILS diff --git

D5199: test: fix self._testdir to use ues the right mercurial library during testing

This revision was automatically updated to reflect the committed changes. Closed by commit rHG78e5b9d815fa: test: fix self._testdir to use the right mercurial library during testing (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT

D5199: test: fix self._testdir to use ues the right mercurial library during testing

sangeet259 added a comment. @yuja This passes the tests now. I had missed the subsequent code that was dependent on the earlier initialisation of `self._testdir`. Fixed it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5199 To: sangeet259, #hg-reviewers

D5199: test: fix self._testdir to use ues the right mercurial library during testing

sangeet259 updated this revision to Diff 12390. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5199?vs=12389=12390 REVISION DETAIL https://phab.mercurial-scm.org/D5199 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-tests.py

D5219: test: remove changes preparing the drop of `HGMERGE`

sangeet259 abandoned this revision. sangeet259 added a comment. I passed the wrong revision number in the -r flag. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5219 To: sangeet259, #hg-reviewers Cc: mercurial-devel

D5199: test: fix self._testdir to use ues the right mercurial library during testing

sangeet259 updated this revision to Diff 12389. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5199?vs=12351=12389 REVISION DETAIL https://phab.mercurial-scm.org/D5199 AFFECTED FILES tests/run-tests.py

D5219: test: remove changes preparing the drop of `HGMERGE`

sangeet259 added a comment. This was an error. Ignore, something went wrong. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5219 To: sangeet259, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

D5219: test: remove changes preparing the drop of `HGMERGE`

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These changes are no longer necessary so we better drop them. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5219 AFFECTED FILES

D5199: test: fix self._testdir to use ues the right mercurial library during testing

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY currently if you run tests from some other directory other than the ../tests/, you will get a warning stating warning: Testing with unexpected mercurial

D4157: grep: search all commits in allfiles mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd99468d2b09a: grep: search all commits in allfiles mode (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4157: grep: search all commits in allfiles mode

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All the commits are added to the 'wanted' set when allfiles mode is enabled. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4157

D3976: grep: add MULTIREV support to --allfiles flag

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf3f109971359: grep: add MULTIREV support to --allfiles flag (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 added a comment. In https://phab.mercurial-scm.org/D3976#64274, @yuja wrote: > Queued with minor cleanup, thanks. > > As a follow up, can you fix `hg grep --all-files -rREVS FILE` to scan > unchanged revisions? Sure REPOSITORY rHG Mercurial REVISION DETAIL

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 updated this revision to Diff 10059. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=10058=10059 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 updated this revision to Diff 10058. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=10057=10058 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 updated this revision to Diff 10057. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=9937=10057 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3976: grep: add MULTIREV support to --allfiles flag

sangeet259 updated this revision to Diff 9937. sangeet259 edited the summary of this revision. sangeet259 retitled this revision from "grep: add MULTIREV support to --all-files flag" to "grep: add MULTIREV support to --allfiles flag". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a comment. > I also expect hg grep --all-files -r0+1 foo will show matches from both rev 0 and 1. Suppose there are ten hits in 0 and the same 10 hits in 1, do you mean we print out all the 20 results, What purpose that would serve? REPOSITORY rHG Mercurial

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a comment. > Keeping all ctx objects might use too much memory. True I will change it to `files[f] = True` REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3976 To: sangeet259, #hg-reviewers Cc: yuja, mercurial-devel

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a comment. > I don't think we should omit files that were seen in earlier revisions If I don't skip that would mean the same file in the same state being searched across all the revisions, and getting repetitive and redundant hits. One way I think to circumvent this

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 added a subscriber: yuja. sangeet259 added a comment. @yuja can you review this one REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3976 To: sangeet259, #hg-reviewers Cc: yuja, mercurial-devel ___

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 updated this revision to Diff 9664. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=9663=9664 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py tests/test-grep.t CHANGE DETAILS diff --git

D3981: grep: add MULTIREV support to --all-files flag

sangeet259 abandoned this revision. sangeet259 added a comment. I created a new revision instead of updating the https://phab.mercurial-scm.org/D3976, ignore this one. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3981 To: sangeet259, #hg-reviewers Cc:

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 updated this revision to Diff 9663. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=9657=9663 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py

D3981: grep: add MULTIREV support to --all-files flag

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3981 AFFECTED FILES mercurial/cmdutil.py tests/test-grep.t CHANGE DETAILS diff --git

D3976: grep: add MULTIREV support to --all-files flag

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py tests/test-grep.t CHANGE DETAILS diff --git

D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

sangeet259 added a comment. So what is the way around this, does this mean grep can't be changed at all ? Also can't we update hglib to work accordingly. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3919 To: yuja, #hg-reviewers, sangeet259, pulkit Cc:

D3826: grep: change default behaviour of grep

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9ef10437bb88: grep: change default behaviour to search working directory files (BC) (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9492. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9482=9492 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9482. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9481=9482 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9481. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9480=9481 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9480. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9474=9480 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9474. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9473=9474 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9473. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9472=9473 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9472. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9470=9472 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9470. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9462=9470 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9462. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9461=9462 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3826: grep: change default behaviour of grep

sangeet259 updated this revision to Diff 9461. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9252=9461 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use

sangeet259 added a comment. I am sorry I accidentally pushed here :/ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2015 To: spectral, #hg-reviewers, martinvonz Cc: sangeet259, martinvonz, mercurial-devel ___

D2015: tests: in test-split.t, save a "clean" copy of pre-split repo for later use

sangeet259 updated this revision to Diff 9403. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2015?vs=9229=9403 REVISION DETAIL https://phab.mercurial-scm.org/D2015 AFFECTED FILES tests/test-split.t CHANGE DETAILS diff --git a/tests/test-split.t

D3825: grep: deprecates `--all` flag

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d9d0d30cfcc: grep: deprecates `--all` flag (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9340=9341 REVISION

D3825: grep: deprecates `--all` flag

sangeet259 updated this revision to Diff 9340. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9339=9340 REVISION DETAIL https://phab.mercurial-scm.org/D3825 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git

D3825: grep: deprecates `--all` flag

sangeet259 updated this revision to Diff 9339. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9250=9339 REVISION DETAIL https://phab.mercurial-scm.org/D3825 AFFECTED FILES mercurial/commands.py

D3826: grep: change default behaviour of grep

sangeet259 added a comment. I need some help with the tests failing here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3826 To: sangeet259, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

D3826: grep : change default behaviour of grep

sangeet259 updated this revision to Diff 9252. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3826?vs=9251=9252 REVISION DETAIL https://phab.mercurial-scm.org/D3826 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3826: grep : change default behaviour of grep

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY with this patch grep searches on the working directory by default and looks for all files tracked by the working directory and greps on them REPOSITORY rHG

D3825: grep: deprecates `--all` flag

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As the name "all" is a misnomer for an option that searches on diffs of revisions, we are moving to `diff` flag from `all`, deprecating it in the process.

D3763: grep: add `--diff` flag

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7fbb5d76c555: grep: add --diff flag (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3763?vs=9217=9245#toc REPOSITORY rHG Mercurial CHANGES SINCE

D3763: grep: add `--diff` flag

sangeet259 updated this revision to Diff 9217. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3763?vs=9125=9217 REVISION DETAIL https://phab.mercurial-scm.org/D3763 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3728: grep: adds allfiles mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb8f45fc27370: grep: adds allfiles mode (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3728?vs=9121=9123#toc REPOSITORY rHG Mercurial CHANGES SINCE

D3728: grep: adds allfiles mode

sangeet259 updated this revision to Diff 9121. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9107=9121 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3728: grep: adds allfiles mode

sangeet259 added a comment. @yuja Sorry I didn't run the tests after this edit . REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3728 To: sangeet259, #hg-reviewers Cc: pulkit, yuja, mharbison72, mercurial-devel ___

D3728: grep: adds unmodified mode

sangeet259 updated this revision to Diff 9107. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9092=9107 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3728: grep: adds unmodified mode

sangeet259 updated this revision to Diff 9092. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9050=9092 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3728: grep: adds unmodified mode

sangeet259 updated this revision to Diff 9049. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3728?vs=9041=9049 REVISION DETAIL https://phab.mercurial-scm.org/D3728 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3728: grep: adds unmodified mode

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY adds an unmodified flag that lets you grep on all files in the revision and not just the one that were modified in that changeset REPOSITORY rHG Mercurial

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @martinvonz, thanks for the reviews, but @yuja has asked me to break this patch into three patches. So I guess this is not going to be merged anyway. Currently, I am trying to add a flag like `--all_files` or `--unmodified` which will enable one to grep all

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @yuja I am adding an --unmodified flag to change to change the mode to grep on the unmodified files as well. What I am trying to do is :: def fns_generator(): if --unmodified: for f in ctx: for f in ctx:

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. Hey @yuja Can you explain why you did this ? > - slowpath = match.anypats() or (not match.always() and opts.get('removed')) +slowpath = True REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2938 To: sangeet259,

D3673: grep: enables passing wdir as a revision in grep

This revision was automatically updated to reflect the committed changes. Closed by commit rHG16f93a3b8b05: grep: enable passing wdir as a revision (authored by sangeet259, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3673?vs=8951=8954#toc REPOSITORY rHG Mercurial

D3673: grep: enables passing wdir as a revision in grep

sangeet259 updated this revision to Diff 8951. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3673?vs=8930=8951 REVISION DETAIL https://phab.mercurial-scm.org/D3673 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D3673: grep: enables passing wdir as a revision in grep

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When you pass wdir() to the -r flag, it catches the WdirUnsupported error and fall back to and alternate path REPOSITORY rHG Mercurial REVISION DETAIL

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. > Perhaps, we'll have to catch WdirUnsupported error to fall back to the filectx API. This seems a good idea. Trying it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2938 To: sangeet259, #hg-reviewers Cc: av6, yuja, pulkit,

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @yuja So I was working on it, but the way I tried to correct "wdir()" is by handling it as a special case, so introducing an "if" block again similar to this. But you were asking to eliminate the if/else block altogether, I wonder if there is way ?

D2938: grep: make grep search on working directory by default

sangeet259 marked 2 inline comments as done. sangeet259 added a comment. @yuja > fix grep -r 'wdir()' What exactly do you mean by fixing 'grep -r wdir()' ? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2938 To: sangeet259, #hg-reviewers Cc: av6,

D3031: histedit: make errror message translatable

This revision was automatically updated to reflect the committed changes. Closed by commit rHGffa79073e4ca: histedit: make errror message translatable (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3031: histedit: make errror message translatable

sangeet259 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a follow up patch to https://phab.mercurial-scm.org/D2394 As suggested by Yuya, this patch makes the error message

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 updated this revision to Diff 7342. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2943?vs=7321=7342 REVISION DETAIL https://phab.mercurial-scm.org/D2943 AFFECTED FILES mercurial/commands.py

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 added a comment. @yuja rebase it on which revision? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2943 To: sangeet259, #hg-reviewers, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 updated this revision to Diff 7321. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2943?vs=7290=7321 REVISION DETAIL https://phab.mercurial-scm.org/D2943 AFFECTED FILES mercurial/commands.py

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 added a comment. Currently, I am not sure what tests I should add, the tests in test-grep.t are passing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2943 To: sangeet259, #hg-reviewers Cc: mercurial-devel

D2943: grep: fixes errorneous output of grep in forward order

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If grep is passed a revset in forwards order via -r , say -r 0:tip Then the output is errorneous. This patch fixes that. The ouput was wrong because we

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7289. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7280=7289 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @yuja Can you please clarify this a bit more? > Perhaps we can start with adding an experimental option to grep files > including unchanged ones?" INLINE COMMENTS > yuja wrote in commands.py:2474 > Better to test if ctx is a workingctx (i.e. `ctx.rev() is

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7280. sangeet259 marked 7 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7267=7280 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.py

D2394: histedit: make histedit's commands accept revsets (issue5746)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d3cff1f6bde: histedit: make histedits commands accept revsets (issue5746) (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7267. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7266=7267 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.py

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7266. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7262=7266 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.py

D2938: grep: make grep search on working directory by default

sangeet259 updated this revision to Diff 7262. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2938?vs=7261=7262 REVISION DETAIL https://phab.mercurial-scm.org/D2938 AFFECTED FILES mercurial/commands.py tests/test-grep.t CHANGE DETAILS diff --git

D2938: grep: make grep search on working directory by default

sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The earlier behaviour of grep was quite counter intuitive as it searches history by default. It throws up matches from files which have been deleted and

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @pulkit It is not failing as of now. It's failing on the changes proposed by @durin42, which he assumed wont fail, but that's not the case! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 added a comment. Since the current code just overwrites message each time with the newer. What can be done to avoid losing the earlier message values? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2588 To: sangeet259, #hg-reviewers Cc: durin42,

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Should I make any changes? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Here is the output! https://bpaste.net/show/7ccf4a9fea50 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel

D2588: commit: adds multiline commit message support(issue5616)

sangeet259 added a comment. @pulkit Yeah, this rather a not so elegant hack. How can it be parsed in hg commit? As the first message passed is overwritten by the second one at this step only. :/ @yuja I think maybe subclassing the customopt may be a fair choice. REPOSITORY rHG

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. @durin42 Even I thought of this construct before as it appears more elegant. But it is failing some tests! Specifically, the error messages are changed in this one. Failed test-histedit-arguments.t: output changed Failed test-histedit-edit.t: output

  1   2   >