[PATCH 2 of 2 topics] flake8: ignore N801

2016-09-06 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1473216018 -28800 # Wed Sep 07 10:40:18 2016 +0800 # Node ID 8464a7708f9d73de1d13c2c4e5e5b6970ea0ec62 # Parent d9c1d140a831614a1a3994a0d87ec27ed3282049 flake8: ignore N801 N801 is "class names should use CapWords

[PATCH 1 of 2 topics] flake8: don't ignore E713 now that it's fixed

2016-09-06 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1473215747 -28800 # Wed Sep 07 10:35:47 2016 +0800 # Node ID d9c1d140a831614a1a3994a0d87ec27ed3282049 # Parent e3ddd696394f6d493d0181140cd9d7116be4478c flake8: don't ignore E713 now that it's fixed E713 is "test for

Re: RFC: bitmap storage for hidden

2016-09-06 Thread Durham Goode
On 9/6/16 10:06 AM, Pierre-Yves David wrote: On 08/31/2016 10:53 PM, Durham Goode wrote: One of the performance costs that affects every command is the computehidden function (which computes what commits are hidden based on a combination of obsmarkers, bookmarks, workingcopy, phases, and

Re: [PATCH V2] evolve: add template to show evolution troubles (issue4686)

2016-09-06 Thread Piotr Listkiewicz
> > In such cases can't we handle like, if evolution or the value returned > is none or empty, don't show the evolution part. Because this empty > line is bit weird. Right, i kept this because patch is more a proposal than final solution and im waiting for opinions about it 2016-09-06 23:21

Re: [PATCH] help: show content for explicitly disabled extension (issue5228)

2016-09-06 Thread Piotr Listkiewicz
> > Just looks for the hgext directory. > https://selenic.com/repo/hg/file/3.9.1/mercurial/extensions.py#l417 > The issue says "hg help -e eol" should print the same content as > "hg help -e eol --config extensions.eol=" even if eol isn't enabled. I > think > that will be doable by parsing the

Re: RFC: bitmap storage for hidden

2016-09-06 Thread Pierre-Yves David
On 08/31/2016 10:53 PM, Durham Goode wrote: One of the performance costs that affects every command is the computehidden function (which computes what commits are hidden based on a combination of obsmarkers, bookmarks, workingcopy, phases, and tags). At Facebook this function alone can add

[PATCH v2] discovery: explicitly check for None in outgoing init

2016-09-06 Thread Ryan McElroy
# HG changeset patch # User Ryan McElroy # Date 1473180205 25200 # Tue Sep 06 09:43:25 2016 -0700 # Node ID ebfcdb4b4697ca730c3d7a7594abd048e666ebb7 # Parent f148bfa40489269be2e48046734f81065129847a discovery: explicitly check for None in outgoing init f09d0004481c

Re: [PATCH] discovery: explicitly check for None in outgoing init

2016-09-06 Thread Ryan McElroy
On 9/6/2016 2:04 PM, Pierre-Yves David wrote: On 09/06/2016 02:35 PM, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1473164309 25200 # Tue Sep 06 05:18:29 2016 -0700 # Node ID d477c6241411af4dfc198fa779bcb7e3302efcc0 # Parent

Re: [PATCH 5 of 8 v2] fancyopts: notice default of false and rewrite it to None (API)

2016-09-06 Thread Pierre-Yves David
On 08/30/2016 10:16 PM, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 1472583470 14400 # Tue Aug 30 14:57:50 2016 -0400 # Node ID 120b94374a1226a152e46f42df00bcc477f38240 # Parent c65c0181a9885d3c95e808272c2f609c3a9c8749 fancyopts: notice

Re: [PATCH 8 of 8 v2] help: mark boolean flags with a ^ and explain that they can be negated (RFC)

2016-09-06 Thread Pierre-Yves David
On 08/31/2016 07:10 PM, Augie Fackler wrote: On Wed, Aug 31, 2016 at 12:13 PM, Matt Mackall wrote: On Tue, 2016-08-30 at 16:16 -0400, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 147258 14400 # Tue Aug 30 15:14:04 2016

Re: [PATCH V2] update: warn if cwd was deleted

2016-09-06 Thread Pierre-Yves David
On 09/06/2016 06:00 PM, Kevin Bullock wrote: On Sep 2, 2016, at 15:43, Stanislau Hlebik wrote: # HG changeset patch # User Stanislau Hlebik # Date 1472848944 25200 # Fri Sep 02 13:42:24 2016 -0700 # Node ID 374caff3f6ba064070d01329eec1bd33a6a45370 # Parent

Re: [PATCH 7 of 8 v2] diffopts: notice a negated boolean flag in diffopts

2016-09-06 Thread Pierre-Yves David
On 08/30/2016 10:16 PM, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 1472586907 14400 # Tue Aug 30 15:55:07 2016 -0400 # Node ID fd68fb86c29873eb32c4a2bd28f7ac0abe3dc172 # Parent 6127fee6ac8208a62f718d53aca6cb814f43b742 diffopts: notice a

Re: [PATCH V2] update: warn if cwd was deleted

2016-09-06 Thread Kevin Bullock
> On Sep 2, 2016, at 15:43, Stanislau Hlebik wrote: > > # HG changeset patch > # User Stanislau Hlebik > # Date 1472848944 25200 > # Fri Sep 02 13:42:24 2016 -0700 > # Node ID 374caff3f6ba064070d01329eec1bd33a6a45370 > # Parent

[PATCH] hghave: fix has_bzr() to not try to import RevisionSpec as module

2016-09-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1472977184 -32400 # Sun Sep 04 17:19:44 2016 +0900 # Node ID c68c8b3d8c371083eedc2c0ea11e736540146421 # Parent 3f274098e9f4965920576842bffe57ce4e85ee32 hghave: fix has_bzr() to not try to import RevisionSpec as module Since

Re: [PATCH] commands: remove unecessary copying of list in graft()

2016-09-06 Thread Yuya Nishihara
On Tue, 6 Sep 2016 16:01:17 +0100, Ryan McElroy wrote: > On 9/5/2016 10:59 AM, Hannes Oldenburg wrote: > > # HG changeset patch > > # User Hannes Oldenburg > > # Date 1473064176 0 > > # Mon Sep 05 08:29:36 2016 + > > # Node ID

Re: [PATCH 3 of 4] streamclone: clear caches after writing changes into files for visibility

2016-09-06 Thread Pierre-Yves David
On 09/06/2016 04:13 PM, Yuya Nishihara wrote: On Sat, 03 Sep 2016 03:34:12 +0900, FUJIWARA Katsunori wrote: # HG changeset patch # User FUJIWARA Katsunori # Date 1472840249 -32400 # Sat Sep 03 03:17:29 2016 +0900 # Node ID 33e29b5ebe885cdeeef433861e2d165b882d48d1

Re: [PATCH 5 of 7 V4] bundle2: add `pushbookmarks` part handler

2016-09-06 Thread Stanislau Hlebik
But in case of push we also send ‘old’ positions of the bookmarks (they are necessary for bookmarks.pushbookmarks). So the part handlers should be different, don’t they? On 9/6/16, 2:01 PM, "Pierre-Yves David" wrote: On 09/05/2016 12:46 AM,

Re: [PATCH V2] import: report directory-relative paths in error messages (issue5224)

2016-09-06 Thread Yuya Nishihara
On Mon, 05 Sep 2016 22:22:06 +0200, liscju wrote: > # HG changeset patch > # User liscju > # Date 1472208500 -7200 > # Fri Aug 26 12:48:20 2016 +0200 > # Node ID 63cb64dd80730bc01503b2f28bd159535301f649 > # Parent b1809f5d7630a3fff0fa715bbd30dba0f07672a8 >

Re: [PATCH] commands: remove unecessary copying of list in graft()

2016-09-06 Thread Yuya Nishihara
On Mon, 05 Sep 2016 09:59:00 +, Hannes Oldenburg wrote: > # HG changeset patch > # User Hannes Oldenburg > # Date 1473064176 0 > # Mon Sep 05 08:29:36 2016 + > # Node ID c072f8ecd0021e849360c8ffdcb8a5a973beb01f > # Parent

Re: [PATCH 3 of 4] streamclone: clear caches after writing changes into files for visibility

2016-09-06 Thread Yuya Nishihara
On Sat, 03 Sep 2016 03:34:12 +0900, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1472840249 -32400 > # Sat Sep 03 03:17:29 2016 +0900 > # Node ID 33e29b5ebe885cdeeef433861e2d165b882d48d1 > # Parent

Re: [PATCH 8 of 8] help: document wire protocol capabilities

2016-09-06 Thread Yuya Nishihara
On Tue, 6 Sep 2016 15:29:29 +0200, Pierre-Yves David wrote: > > On 09/06/2016 03:55 AM, Sean Farley wrote: > >> Yuya Nishihara writes: > >>> # HG changeset patch > >>> # User Gregory Szorc > >>> # Date 1471920511 25200 > >>> # Mon Aug 22 19:48:31 2016

Re: [PATCH 8 of 8] help: document wire protocol capabilities

2016-09-06 Thread Pierre-Yves David
On 09/06/2016 03:55 AM, Sean Farley wrote: Yuya Nishihara writes: # HG changeset patch # User Gregory Szorc # Date 1471920511 25200 # Mon Aug 22 19:48:31 2016 -0700 # Node ID 2435ba6c82e68a90aef129214af9dd9585442380 # Parent

Re: [PATCH 5 of 7 V4] bundle2: add `pushbookmarks` part handler

2016-09-06 Thread Pierre-Yves David
On 09/05/2016 12:46 AM, Stanislau Hlebik wrote: # HG changeset patch # User Stanislau Hlebik # Date 1473012368 25200 # Sun Sep 04 11:06:08 2016 -0700 # Node ID 6d2fbc0ed52b54dfe525063da90973f426f2bcbe # Parent db526b94eeb678879c2faceb40c64aebbe1054af bundle2: add

Re: [PATCH 7 of 7 V4] exchange: use `bookmarks` bundle2 part

2016-09-06 Thread Pierre-Yves David
On 09/05/2016 12:46 AM, Stanislau Hlebik wrote: # HG changeset patch # User Stanislau Hlebik # Date 1473029057 25200 # Sun Sep 04 15:44:17 2016 -0700 # Node ID 7fb1aa776715fbd291e536c91a910ec08223d7aa # Parent 2d27290ce3d64e28b035e2f48b3cd99c7930e93b exchange: use

Re: [PATCH V2] update: warn if cwd was deleted

2016-09-06 Thread Pierre-Yves David
On 09/06/2016 02:54 PM, Yuya Nishihara wrote: On Tue, 6 Sep 2016 14:36:58 +0200, Pierre-Yves David wrote: On 09/02/2016 10:43 PM, Stanislau Hlebik wrote: # HG changeset patch # User Stanislau Hlebik # Date 1472848944 25200 # Fri Sep 02 13:42:24 2016 -0700 # Node ID

Re: [PATCH] discovery: explicitly check for None in outgoing init

2016-09-06 Thread Pierre-Yves David
On 09/06/2016 02:35 PM, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1473164309 25200 # Tue Sep 06 05:18:29 2016 -0700 # Node ID d477c6241411af4dfc198fa779bcb7e3302efcc0 # Parent f148bfa40489269be2e48046734f81065129847a discovery: explicitly check

Re: [PATCH 4 of 7 V4] exchange: add `pushbookmarks` part generator

2016-09-06 Thread Pierre-Yves David
On 09/05/2016 12:46 AM, Stanislau Hlebik wrote: # HG changeset patch # User Stanislau Hlebik # Date 1473022588 25200 # Sun Sep 04 13:56:28 2016 -0700 # Node ID db526b94eeb678879c2faceb40c64aebbe1054af # Parent 70a86f2bd0e7684eda82310dc9024b346f59dbf6 exchange: add

Re: [PATCH 3 of 7 V4] bundle2: add `bookmarks` part handler

2016-09-06 Thread Pierre-Yves David
On 09/05/2016 12:46 AM, Stanislau Hlebik wrote: # HG changeset patch # User Stanislau Hlebik # Date 1473012054 25200 # Sun Sep 04 11:00:54 2016 -0700 # Node ID 70a86f2bd0e7684eda82310dc9024b346f59dbf6 # Parent f3bc1662dbce19de1f51c4da519238dbe98c1c95 bundle2: add

Re: [PATCH V2] update: warn if cwd was deleted

2016-09-06 Thread Yuya Nishihara
On Tue, 6 Sep 2016 14:36:58 +0200, Pierre-Yves David wrote: > On 09/02/2016 10:43 PM, Stanislau Hlebik wrote: > > # HG changeset patch > > # User Stanislau Hlebik > > # Date 1472848944 25200 > > # Fri Sep 02 13:42:24 2016 -0700 > > # Node ID

Re: [PATCH] help: show content for explicitly disabled extension (issue5228)

2016-09-06 Thread Yuya Nishihara
On Mon, 5 Sep 2016 22:32:34 +0200, Piotr Listkiewicz wrote: > > The change looks good, but this isn't what issue5228 proposes, which says > > complete docstring should be available for unloaded extensions. > > I don't understand it, does it deal with unloaded extension that are not > processed in

Re: [PATCH 2 of 7 V4] exchange: add `bookmarks` part generator

2016-09-06 Thread Pierre-Yves David
On 09/05/2016 12:46 AM, Stanislau Hlebik wrote: # HG changeset patch # User Stanislau Hlebik # Date 1473012054 25200 # Sun Sep 04 11:00:54 2016 -0700 # Node ID f3bc1662dbce19de1f51c4da519238dbe98c1c95 # Parent 6e9d1438a270ba02cd06590efd959039b0fae566 exchange: add

Re: [PATCH 1 of 7 V4] exchange: add `_get_bookmarks()` function

2016-09-06 Thread Pierre-Yves David
On 09/05/2016 12:46 AM, Stanislau Hlebik wrote: # HG changeset patch # User Stanislau Hlebik # Date 1473012054 25200 # Sun Sep 04 11:00:54 2016 -0700 # Node ID 6e9d1438a270ba02cd06590efd959039b0fae566 # Parent f148bfa40489269be2e48046734f81065129847a exchange: add

[Bug 5362] New: unicode paths are not deleted

2016-09-06 Thread bugzilla
https://bz.mercurial-scm.org/show_bug.cgi?id=5362 Bug ID: 5362 Summary: unicode paths are not deleted Product: Mercurial Version: 3.9 Hardware: PC OS: Windows Status: UNCONFIRMED Severity: bug

Re: zstd experimentations

2016-09-06 Thread Pierre-Yves David
On 09/01/2016 09:01 AM, Gregory Szorc wrote: I'd also like to invite a larger discussion around supporting zstd in the official Mercurial distribution. It seems like an all-around better compression format than zlib and supporting zstd seems like a relatively easy way to gain significant

Re: Confusing `hg add` + `hg remove` behavior

2016-09-06 Thread Pierre-Yves David
On 09/02/2016 04:53 PM, Augie Fackler wrote: On Sep 1, 2016, at 20:54, Gregory Szorc > wrote: One of my coworkers just blogged about confusing behavior w.r.t. performing a `hg remove` on a file that was `hg add`ed but not yet

Re: [PATCH 2 of 2] evolve: removed redundant try/finally blocks

2016-09-06 Thread Pierre-Yves David
On 09/01/2016 01:14 AM, Pulkit Goyal wrote: # HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1472684936 -19800 # Thu Sep 01 04:38:56 2016 +0530 # Branch stable # Node ID 2ab652cca0c72df663446cc5e79bef2afa0e9854 # Parent 20689e0835c621df4cd19efe7bd06127ab1e0bf8

Re: [PATCH 3 of 3] evolve: drop point release of versions

2016-09-06 Thread Pierre-Yves David
On 09/01/2016 04:13 AM, Pulkit Goyal wrote: # HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1472695827 -19800 # Thu Sep 01 07:40:27 2016 +0530 # Branch stable # Node ID 3f1d6170cb2a3a967d0eaa08c8d3a80037948bf0 # Parent 2ab652cca0c72df663446cc5e79bef2afa0e9854

Re: [PATCH 12 of 12 topics] flake8: fix E124 style

2016-09-06 Thread Pierre-Yves David
On 08/31/2016 06:39 AM, Sean Farley wrote: Sean Farley writes: # HG changeset patch # User Sean Farley # Date 1472595848 25200 # Tue Aug 30 15:24:08 2016 -0700 # Node ID c0064f048058b35713d7262b578a7fa5e216f195 # Parent

Re: [PATCH 12 of 12 topics] flake8: fix E124 style

2016-09-06 Thread Pierre-Yves David
On 08/31/2016 05:58 AM, Sean Farley wrote: # HG changeset patch # User Sean Farley # Date 1472595848 25200 # Tue Aug 30 15:24:08 2016 -0700 # Node ID c0064f048058b35713d7262b578a7fa5e216f195 # Parent b579ff9e41931a26ded12b409925d0fa40d9b05d # EXP-Topic flake8 flake8: fix

Re: [PATCH 09 of 12 topics] flake8: fix E501 style

2016-09-06 Thread Pierre-Yves David
On 08/31/2016 07:24 AM, Anton Shestakov wrote: On Tue, 30 Aug 2016 20:58:15 -0700 Sean Farley wrote: diff --git a/hgext3rd/topic/evolvebits.py b/hgext3rd/topic/evolvebits.py --- a/hgext3rd/topic/evolvebits.py +++ b/hgext3rd/topic/evolvebits.py @@ -40,14 +40,13 @@ def

Re: [PATCH 03 of 12 topics] flake8: fix E127 style

2016-09-06 Thread Pierre-Yves David
On 08/31/2016 02:56 PM, Augie Fackler wrote: On Tue, Aug 30, 2016 at 08:58:09PM -0700, Sean Farley wrote: # HG changeset patch # User Sean Farley # Date 1472591416 25200 # Tue Aug 30 14:10:16 2016 -0700 # Node ID a6f4b32f655ba895875640534b051c5ebe632695 # Parent

Re: [PATCH 07 of 12 topics] flake8: fix E123 style

2016-09-06 Thread Pierre-Yves David
On 08/31/2016 05:58 AM, Sean Farley wrote: # HG changeset patch # User Sean Farley # Date 1472595476 25200 # Tue Aug 30 15:17:56 2016 -0700 # Node ID 8eb5de0920f5dce2fbf4d511b73ea6bcc7d6fe8e # Parent e32ae663d1dcbcd21bcce74e58ddfdf8dcc7368c # EXP-Topic flake8 flake8: fix

Re: [PATCH 05 of 12 topics] flake8: fix W503 style

2016-09-06 Thread Pierre-Yves David
On 08/31/2016 07:23 PM, Sean Farley wrote: Augie Fackler writes: On Tue, Aug 30, 2016 at 08:58:11PM -0700, Sean Farley wrote: # HG changeset patch # User Sean Farley # Date 1472595240 25200 # Tue Aug 30 15:14:00 2016 -0700 # Node ID

[Bug 5361] New: hg backout forgets renames for non-direct ancestors

2016-09-06 Thread bugzilla
https://bz.mercurial-scm.org/show_bug.cgi?id=5361 Bug ID: 5361 Summary: hg backout forgets renames for non-direct ancestors Product: Mercurial Version: default branch Hardware: All OS: All Status: UNCONFIRMED

Re: [PATCH] evolution: make troubles appear in default log (issue4686)

2016-09-06 Thread Piotr Listkiewicz
> > I think having a way to show troubled changesets as such in the log is a > good idea, but the best we're able to do here is to add a new built-in > template (cf. `hg log -T phases`). The default log output is very strongly > a part of our command-line API, and changing it (even additively!) is

[PATCH V2] evolve: add template to show evolution troubles (issue4686)

2016-09-06 Thread liscju
# HG changeset patch # User liscju # Date 1473150616 -7200 # Tue Sep 06 10:30:16 2016 +0200 # Branch stable # Node ID 5273ba1d2b0027ce48238adfcf272adbfde9ddfe # Parent 7a2e0629bdee8cd842bb884094cef9683ed49520 evolve: add template to show evolution troubles