[PATCH 1 of 3] py3: use pycompat.fsdecode() to pass to imp.* functions

2016-12-05 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1480900611 -19800 # Mon Dec 05 06:46:51 2016 +0530 # Node ID d85f937e2f04d7b6356070adb99677ae1c2bab15 # Parent 14c06a896fd6bb59752e16ce43c4715b96449d27 py3: use pycompat.fsdecode() to pass to imp.* functions When we try

[PATCH 3 of 3] py3: make a bytes version of getopt.getopt()

2016-12-05 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1480986396 -19800 # Tue Dec 06 06:36:36 2016 +0530 # Node ID ef3b7f10f4ade315a42f5f9383a8ad1794bb1f01 # Parent 559b73b5d7b919da68bf2ce5b05dd9677ddc1c2d py3: make a bytes version of getopt.getopt() getopt.getopt() deals

[PATCH 2 of 3] fancyopts: switch from fancyopts.getopt.* to getopt.*

2016-12-05 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1480985878 -19800 # Tue Dec 06 06:27:58 2016 +0530 # Node ID 559b73b5d7b919da68bf2ce5b05dd9677ddc1c2d # Parent d85f937e2f04d7b6356070adb99677ae1c2bab15 fancyopts: switch from fancyopts.getopt.* to getopt.* In the next

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Jun Wu
Excerpts from Augie Fackler's message of 2016-12-05 18:13:14 -0500: > I'd rather see a new ProgrammingError or something in error.py, and have > it inherit from RuntimeError for six months or so and then cut the cord on > this silliness. +1 on ProgrammingError. I was actually a bit surprised that

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-05 Thread Kevin Bullock
> On Dec 5, 2016, at 17:03, Kostia Balytskyi wrote: > > # HG changeset patch > # User Kostia Balytskyi > # Date 1480978778 28800 > # Mon Dec 05 14:59:38 2016 -0800 > # Node ID bdc49209b0b926214e865f9a98ea987866f64d68 > # Parent

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Kevin Bullock
> On Dec 5, 2016, at 17:42, Augie Fackler wrote: > >> On Dec 5, 2016, at 18:41, Kevin Bullock >> wrote: >> >>> On Dec 5, 2016, at 16:51, Jun Wu wrote: >>> >>> Excerpts from Augie Fackler's message of 2016-12-05 17:07:47

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Augie Fackler
> On Dec 5, 2016, at 18:41, Kevin Bullock > wrote: > >> On Dec 5, 2016, at 16:51, Jun Wu wrote: >> >> Excerpts from Augie Fackler's message of 2016-12-05 17:07:47 -0500: >>> On Dec 5, 2016, at 16:54, Jun Wu wrote:

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Kevin Bullock
> On Dec 5, 2016, at 16:51, Jun Wu wrote: > > Excerpts from Augie Fackler's message of 2016-12-05 17:07:47 -0500: >> >>> On Dec 5, 2016, at 16:54, Jun Wu wrote: >>> +e = _("Invalid value in a simple key-value file") +raise

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Augie Fackler
> On Dec 5, 2016, at 17:51, Jun Wu wrote: > > Excerpts from Augie Fackler's message of 2016-12-05 17:07:47 -0500: >> >>> On Dec 5, 2016, at 16:54, Jun Wu wrote: >>> +e = _("Invalid value in a simple key-value file") +raise

[PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-05 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1480978778 28800 # Mon Dec 05 14:59:38 2016 -0800 # Node ID bdc49209b0b926214e865f9a98ea987866f64d68 # Parent 243ecbd4f5c9f452275d4435866359cf84dc03ff scmutil: add a simple key-value file helper The purpose of the added

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Jun Wu
Excerpts from Augie Fackler's message of 2016-12-05 17:07:47 -0500: > > > On Dec 5, 2016, at 16:54, Jun Wu wrote: > > > >> +e = _("Invalid value in a simple key-value file") > >> +raise self.InvalidValueInFileException(e) > > > > These sound like a

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Kostia Balytskyi
On 12/5/16 9:54 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-03 15:37:55 -0800: >> # HG changeset patch >> # User Kostia Balytskyi >> # Date 1480808065 28800 >> # Sat Dec 03 15:34:25 2016 -0800 >> # Node ID c4312906ef7d06dc3be1575ee5cde574b915c9c4

Re: [PATCH] chgserver: call "load" for new ui objects

2016-12-05 Thread Kostia Balytskyi
LGTM. On 12/5/16 9:37 PM, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1480973795 0 > # Mon Dec 05 21:36:35 2016 + > # Node ID b1877dc4bd741a4855c3fda0d473e5d821f5c4e2 > # Parent 2463b16bbd3710b619e0e948651db9948341f990 > # Available At

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Augie Fackler
> On Dec 5, 2016, at 16:54, Jun Wu wrote: > >> +e = _("Invalid value in a simple key-value file") >> +raise self.InvalidValueInFileException(e) > > These sound like a programmer error. Maybe just raise RuntimeError. I'm not comfortable with that,

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Jun Wu
Excerpts from Kostia Balytskyi's message of 2016-12-03 15:37:55 -0800: > # HG changeset patch > # User Kostia Balytskyi > # Date 1480808065 28800 > # Sat Dec 03 15:34:25 2016 -0800 > # Node ID c4312906ef7d06dc3be1575ee5cde574b915c9c4 > # Parent

[PATCH] chgserver: call "load" for new ui objects

2016-12-05 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1480973795 0 # Mon Dec 05 21:36:35 2016 + # Node ID b1877dc4bd741a4855c3fda0d473e5d821f5c4e2 # Parent 2463b16bbd3710b619e0e948651db9948341f990 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH RFC v2] scmutil: add a simple key-value file helper

2016-12-05 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1480967781 28800 # Mon Dec 05 11:56:21 2016 -0800 # Node ID eceaa3ab833141da00291a236a20ca0be0b4b3b0 # Parent 243ecbd4f5c9f452275d4435866359cf84dc03ff scmutil: add a simple key-value file helper The purpose of the added

Re: [PATCH 2 of 4 evolve-ext] metaedit: extend the functionality to support editing multiple commits

2016-12-05 Thread Mateusz Kwapich
Excerpts from Ryan McElroy's message of 2016-12-05 13:14:58 +: > > On 11/16/16 7:56 PM, Mateusz Kwapich wrote: > > # HG changeset patch > > # User Mateusz Kwapich > > # Date 1479324135 0 > > # Wed Nov 16 19:22:15 2016 + > > # Branch stable > > # Node ID

Re: [PATCH 1 of 4 evolve-ext] metaedit: add a helper function for just metadata rewrites

2016-12-05 Thread Mateusz Kwapich
Excerpts from Ryan McElroy's message of 2016-12-05 13:14:28 +: > > On 11/16/16 7:56 PM, Mateusz Kwapich wrote: > > # HG changeset patch > > # User Mateusz Kwapich > > # Date 1479324110 0 > > # Wed Nov 16 19:21:50 2016 + > > # Branch stable > > # Node ID

[PATCH] graft: support grafting changes to new file in renamed directory (issue5436)

2016-12-05 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1480956001 -3600 # Mon Dec 05 17:40:01 2016 +0100 # Node ID 5b31c62d10786bccaaebf33f4baa4cab8594363a # Parent cbeb54ec0481a4bf9723ba4b80a5861a813c8531 graft: support grafting changes to new file in renamed directory

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Augie Fackler
> On Dec 3, 2016, at 18:37, Kostia Balytskyi wrote: > > # HG changeset patch > # User Kostia Balytskyi > # Date 1480808065 28800 > # Sat Dec 03 15:34:25 2016 -0800 > # Node ID c4312906ef7d06dc3be1575ee5cde574b915c9c4 > # Parent

Re: [PATCH V2] help: show help for disabled extensions(issue5228)

2016-12-05 Thread Kevin Bullock
> On Dec 4, 2016, at 07:52, Pulkit Goyal <7895pul...@gmail.com> wrote: > > The status of bug doesn't seem to change, do we need more improvement > in this. I want to make sure to fix this one. > https://bz.mercurial-scm.org/show_bug.cgi?id=5228 > > On Sun, Nov 6, 2016 at 1:26 PM, Yuya Nishihara

Re: [PATCH] localrepository: remove None as default value of path argument in __init__()

2016-12-05 Thread Yuya Nishihara
On Mon, 05 Dec 2016 02:05:35 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1480873954 -19800 > # Sun Dec 04 23:22:34 2016 +0530 > # Node ID 14c06a896fd6bb59752e16ce43c4715b96449d27 > # Parent 93275b09d8977ad5700ca56a017f48ce602058ba >

Re: [PATCH 1 of 4 evolve-ext] metaedit: add a helper function for just metadata rewrites

2016-12-05 Thread Ryan McElroy
On 11/16/16 7:56 PM, Mateusz Kwapich wrote: # HG changeset patch # User Mateusz Kwapich # Date 1479324110 0 # Wed Nov 16 19:21:50 2016 + # Branch stable # Node ID 744c6acd84edf73ffdf505b9673b0383db727a0e # Parent 727c7211c810d304ebf92b32db7ecf697ce46ac6 metaedit:

Re: [PATCH 2 of 4 evolve-ext] metaedit: extend the functionality to support editing multiple commits

2016-12-05 Thread Ryan McElroy
On 11/16/16 7:56 PM, Mateusz Kwapich wrote: # HG changeset patch # User Mateusz Kwapich # Date 1479324135 0 # Wed Nov 16 19:22:15 2016 + # Branch stable # Node ID b2bde478bfebc390dba8f1ee314b7bdd062ab191 # Parent 744c6acd84edf73ffdf505b9673b0383db727a0e metaedit: