Re: [PATCH 1 of 2] error: add ProgrammingError

Jun Wu wrote: > +class ProgrammingError(RuntimeError): > +"""Raised if a developer has made some mistake""" I object to "developer" you probably mean "mercurial (core or extension) developer", not "generic developer". ___ Mercurial-devel mailing

Re: [PATCH 02 of 10 shelve-ext] shelve: add an ability to write json to a new type of shelve files

We should probably have check-code complain about it and explain why we don't want it. Self-documenting code is our friend. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 1 of 5] posix: move checkexec test file to .hg/cache

Gregory Szorc wrote: > The only scenario I can think of is someone who has moved .hg to another > filesystem and symlinked .hg in the working directory to it. I guess that's > plausible. Ugh. I can picture doing this. It's possible I've already done it...

Re: [PATCH V2] evolve: improve error message if unstable changes are disallowed

I'm not going to stop this from going in, it's definitely an improvement. >> @@ -3299,7 +3301,8 @@ >> head = repo[heads.first()] >> if _disallowednewunstable(repo, revs): >> raise error.Abort(_("cannot fold chain not ending with a head "\ >> -"or

Re: [PATCH 3 of 3] py3: make keys of keyword arguments strings

> 'cmdoptions' is passed to another function as a normal dict, which shouldn't > be a dict of unicode keys. Only **cmdoptions should be a unicode-key dict. > > Sorry I didn't notice it in earlier series. No problem, I will send a V6. ___ Mercurial-devel

Re: [PATCH 1 of 3] py3: make a bytes version of getopt.getopt()

On Sun, Dec 11, 2016 at 7:05 PM, Yuya Nishihara wrote: > On Sat, 10 Dec 2016 05:10:25 +0530, Pulkit Goyal wrote: >> # HG changeset patch >> # User Pulkit Goyal <7895pul...@gmail.com> >> # Date 1480986396 -19800 >> # Tue Dec 06 06:36:36 2016 +0530 >> # Node ID

Re: [PATCH 1 of 3] py3: make a bytes version of getopt.getopt()

On Sat, 10 Dec 2016 05:10:25 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1480986396 -19800 > # Tue Dec 06 06:36:36 2016 +0530 > # Node ID 4b57889d58056f95c58f2379836437a65950424c > # Parent a2b053b8d31aa01b1dcae2d3001b060ff59e8a68 >

Re: [PATCH 2 of 3] py3: utility functions to convert keys of kwargs to bytes/unicodes

On Sat, 10 Dec 2016 05:10:26 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1481127783 -19800 > # Wed Dec 07 21:53:03 2016 +0530 > # Node ID 7fcea54acba98b7f1d994bd7311bb0f5ec566b65 > # Parent 4b57889d58056f95c58f2379836437a65950424c >

Re: [PATCH 3 of 3] py3: make keys of keyword arguments strings

On Sat, 10 Dec 2016 05:10:27 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1481085372 -19800 > # Wed Dec 07 10:06:12 2016 +0530 > # Node ID 28203092739274efcb8c691beb9c4025a2c45ff5 > # Parent 7fcea54acba98b7f1d994bd7311bb0f5ec566b65 >