mercurial@30915: new changeset (1 on stable)

New changeset (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/aa25989b0658 changeset: 30915:aa25989b0658 branch: stable tag: tip user:Siddharth Agarwal date:Mon Feb 13 11:43:12 2017 -0800 summary: bundle2: fix assertion that

[PATCH] ui: fix configwith doctest

# HG changeset patch # User Jun Wu # Date 1487048450 28800 # Mon Feb 13 21:00:50 2017 -0800 # Node ID ba4d509ef528627871e26172fcf9cfd71c2195c4 # Parent f2ad0d8047009e6e58ab1fa34ae7107714f5dc30 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull

[PATCH 1 of 2] dispatch: move detection of profiling earlier during startup

# HG changeset patch # User Bryan O'Sullivan # Date 1487047460 28800 # Mon Feb 13 20:44:20 2017 -0800 # Node ID 82467bdb090b2500a97ae92e239bcdf72974f3f7 # Parent a0e3d808690d57d1c9dff840e0b8ee099526397b dispatch: move detection of profiling earlier during startup diff --git

[PATCH 2 of 2] dispatch: start profiling earlier

# HG changeset patch # User Bryan O'Sullivan # Date 1487047661 28800 # Mon Feb 13 20:47:41 2017 -0800 # Node ID fa6f486c80910c2a3ce6df58be0b8e616f2ae679 # Parent 82467bdb090b2500a97ae92e239bcdf72974f3f7 dispatch: start profiling earlier This makes it possible to profile

Re: RFC: bitmap storage for precursors and phases

> On Feb 10, 2017, at 10:33, Stanislau Hlebik wrote: > > Last year Durham sent a proposal for bitmap storage for computehidden() > https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-September/087860.html. > > It got a few useful comments, two most important comments:

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

> On Feb 13, 2017, at 18:25, Jun Wu wrote: > > Excerpts from Gregory Szorc's message of 2017-02-13 17:22:59 -0700: >> On Feb 13, 2017, at 12:55, Augie Fackler wrote: On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote: I'd like to note

Re: RFC: bitmap storage for precursors and phases

Jun Wu writes: > Excerpts from Sean Farley's message of 2017-02-13 17:04:35 -0800: >> I was thinking about a more high-level approach (please feel free to >> pick apart): >> >> r = repo.filtered("bitmap1") >> r2 = r.filtered("bitmap2") >> >> So that r2 would be an intersection of

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

Excerpts from Gregory Szorc's message of 2017-02-13 17:22:59 -0700: > > > On Feb 13, 2017, at 12:55, Augie Fackler wrote: > > > >> On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote: > >> I'd like to note that although this patch prevents repo corruption when > >> running

Re: RFC: bitmap storage for precursors and phases

Excerpts from Sean Farley's message of 2017-02-13 17:04:35 -0800: > I was thinking about a more high-level approach (please feel free to > pick apart): > > r = repo.filtered("bitmap1") > r2 = r.filtered("bitmap2") > > So that r2 would be an intersection of bitmap1 and bitmap2 (haven't > thought

Re: [PATCH 04 of 10] localrepo: move ui loading to baselocalrepository

Excerpts from Augie Fackler's message of 2017-02-13 18:58:59 -0500: > On Fri, Feb 10, 2017 at 01:07:49PM -0800, Jun Wu wrote: > > Side-effects are basically everything related to writes, like mutating > > (wrapping) internal Python objects, etc. They are done by Python code > > provided by an

[PATCH 4 of 6] update: show -C and -c as mutually exclusive in synopsis

# HG changeset patch # User Martin von Zweigbergk # Date 1487027086 28800 # Mon Feb 13 15:04:46 2017 -0800 # Node ID 59e2d3da607cc09ebe133ab199fc4f343d74e1e6 # Parent 4c11837859ce08ad07d09a544aa89e3e930499c3 update: show -C and -c as mutually exclusive in synopsis

[PATCH 1 of 6] destutil: remove duplicate check and leave it to merge.update()

# HG changeset patch # User Martin von Zweigbergk # Date 1486662752 28800 # Thu Feb 09 09:52:32 2017 -0800 # Node ID f261eed3d3080b00a25fd4f422966b40c44fceb6 # Parent 455677a7667f6658be5c6e3f3d7b81a29cf5f9a2 destutil: remove duplicate check and leave it to

[PATCH 3 of 6] update: move check for dirty wdir into hg.updatetotally()

# HG changeset patch # User Martin von Zweigbergk # Date 1487015882 28800 # Mon Feb 13 11:58:02 2017 -0800 # Node ID 4c11837859ce08ad07d09a544aa89e3e930499c3 # Parent dcd80a611a62f29b5c2130fe258ee305f7f6cab0 update: move check for dirty wdir into hg.updatetotally()

[PATCH 5 of 6] update: learn --merge to allow merging across topological branches (issue5125)

# HG changeset patch # User Martin von Zweigbergk # Date 1487019517 28800 # Mon Feb 13 12:58:37 2017 -0800 # Node ID 75e5a492d7f69420a554fe498ae24060c755b09f # Parent 59e2d3da607cc09ebe133ab199fc4f343d74e1e6 update: learn --merge to allow merging across topological

[PATCH 2 of 6] destutil: drop now-unused "check" parameter from destupdate()

# HG changeset patch # User Martin von Zweigbergk # Date 1487014329 28800 # Mon Feb 13 11:32:09 2017 -0800 # Node ID dcd80a611a62f29b5c2130fe258ee305f7f6cab0 # Parent f261eed3d3080b00a25fd4f422966b40c44fceb6 destutil: drop now-unused "check" parameter from

[PATCH 6 of 6] update: add config for default way of handling dirty wdir

# HG changeset patch # User Martin von Zweigbergk # Date 1487030585 28800 # Mon Feb 13 16:03:05 2017 -0800 # Node ID 9df8dd6fd23bd52f4acaf87ea455749a97da4099 # Parent 75e5a492d7f69420a554fe498ae24060c755b09f update: add config for default way of handling dirty wdir

[PATCH 2 of 2 v2] match: making visitdir() deal with non-recursive entries

# HG changeset patch # User Rodrigo Damazio Bovendorp # Date 1487034194 28800 # Mon Feb 13 17:03:14 2017 -0800 # Node ID e90de197586d0749e64cef752613e6fe41d1c8e3 # Parent 94264a6e6672c917d42518f7ae9322445868d067 match: making visitdir() deal with non-recursive entries

[PATCH 1 of 2 v2] match: adding support for matching files inside a directory

# HG changeset patch # User Rodrigo Damazio Bovendorp # Date 1487029169 28800 # Mon Feb 13 15:39:29 2017 -0800 # Node ID 94264a6e6672c917d42518f7ae9322445868d067 # Parent 72f25e17af9d6a206ea374c30f229ae9513f3f23 match: adding support for matching files inside a

Re: RFC: bitmap storage for precursors and phases

Jun Wu writes: > In general, I think this is a good direction. Some random thoughts: > > - general purposed > > I think the bitmap is not always a cache, so it should only have > operations like set/unset/readfromdisk/writetodisk. Practically, I won't > couple cache

Re: [PATCH 4 of 5 v2] statprof: allow rendering in the Chrome trace viewer format

On Mon, Feb 13, 2017 at 3:13 PM, Augie Fackler wrote: > My Rust brain was reading this code and was about to get puzzled that you > didn't use an enum and have these just be > fn write(, data, fp) -> Result<(), Error>. And then I got sad. > The code that makes you sad is a

Re: [PATCH 2 of 8 v4] ui: provide a mechanism to track and log blocked time

> On Feb 13, 2017, at 10:29, Simon Farnsworth wrote: > > # HG changeset patch > # User Simon Farnsworth > # Date 1486994849 28800 > # Mon Feb 13 06:07:29 2017 -0800 > # Node ID 00f01e9a24bc050ab5cbbfc5a8dc99e992e31d2b > # Parent

Re: [PATCH 2 of 2] py3: convert the mode argument of os.fdopen to unicodes (2 of 2)

> On Feb 13, 2017, at 17:32, Augie Fackler wrote: > > On Tue, Feb 14, 2017 at 01:59:15AM +0530, Pulkit Goyal wrote: >> # HG changeset patch >> # User Pulkit Goyal <7895pul...@gmail.com> >> # Date 1487004328 -19800 >> # Mon Feb 13 22:15:28 2017 +0530 >> # Node ID

Re: [PATCH 04 of 10] localrepo: move ui loading to baselocalrepository

On Fri, Feb 10, 2017 at 01:07:49PM -0800, Jun Wu wrote: > Side-effects are basically everything related to writes, like mutating > (wrapping) internal Python objects, etc. They are done by Python code > provided by an extension out of core's control. Usually that means > reposetup, uisetup, etc.

Re: [PATCH remotenames] remotenames: be compatible with upstream change about smartset

Jun Wu writes: > # HG changeset patch > # User Jun Wu > # Date 1486761243 28800 > # Fri Feb 10 13:14:03 2017 -0800 > # Node ID cefa2cc8e03941120286a1c8819dd7d5d62ae84b > # Parent 18f8e0f8ba54270bf158734c781327581cf43634 > remotenames: be compatible with

Re: [PATCH RFC v10] scmutil: add a simple key-value file helper

On Fri, Feb 03, 2017 at 02:47:26AM -0800, Kostia Balytskyi wrote: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484824655 28800 > # Thu Jan 19 03:17:35 2017 -0800 > # Node ID 19a449c91ef14e691cf1347748473e0094fedc86 > # Parent

Re: [PATCH RFC v10] scmutil: add a simple key-value file helper

On Fri, Feb 03, 2017 at 02:47:26AM -0800, Kostia Balytskyi wrote: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484824655 28800 > # Thu Jan 19 03:17:35 2017 -0800 > # Node ID 19a449c91ef14e691cf1347748473e0094fedc86 > # Parent

Re: [PATCH 5 of 5 v2] profiling: add statprof support for Chrome trace viewer rendering

Bryan O'Sullivan writes: > On Sun, Feb 12, 2017 at 10:39 PM, Bryan O'Sullivan > wrote: > >> profiling: add statprof support for Chrome trace viewer rendering >> > > Here's an example screenshot of the Chrome trace viewer: > >

Re: Inconsistent HG_PENDING handling

(+foozy, marmoute for transaction musing) On Sun, Feb 12, 2017 at 07:06:49PM -0500, timeless wrote: > bookmarks.py > if 'HG_PENDING' in encoding.environ: > try: > bkfile = repo.vfs('bookmarks.pending') > > dirstate.py > def _trypending(root, vfs, filename): > '''Open

Re: [PATCH RFC] contrib: script to generate release notes from commit messages

Augie Fackler writes: > On Thu, Feb 02, 2017 at 11:56:29PM -0800, Gregory Szorc wrote: >> # HG changeset patch >> # User Gregory Szorc >> # Date 1486108530 28800 >> # Thu Feb 02 23:55:30 2017 -0800 >> # Node ID

Re: [PATCH 4 of 5 v2] statprof: allow rendering in the Chrome trace viewer format

On Sun, Feb 12, 2017 at 10:39:56PM -0800, Bryan O'Sullivan wrote: > # HG changeset patch > # User Bryan O'Sullivan > # Date 1486966820 28800 > # Sun Feb 12 22:20:20 2017 -0800 > # Node ID 9c4ac8a20bd95c4069a20cf03a84b2c5c7b58def > # Parent

Re: [PATCH] test-bdiff: move import inside the function to avoid test failure

On Mon, Feb 13, 2017 at 2:29 PM, Augie Fackler wrote: > On Tue, Feb 14, 2017 at 01:59:48AM +0530, Pulkit Goyal wrote: > > # HG changeset patch > > # User Pulkit Goyal <7895pul...@gmail.com> > > # Date 1487017336 -19800 > > # Tue Feb 14 01:52:16 2017 +0530 > > # Node ID

Re: [PATCH RFC v10] scmutil: add a simple key-value file helper

On 13/02/2017 21:58, Jun Wu wrote: > As said before, I still prefer a simpler design without the "required" > boolean flag, and move the responsibility of checking requirements to the > higher-level code. Because: > >- As Yuya pointed out at the first place, "required" here will have >

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

> On Feb 13, 2017, at 17:32, Simon Farnsworth wrote: > > On 13/02/2017 19:55, Augie Fackler wrote: >> On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote: > >>> >>> I think if we do know the repo is not on NFS, and the system supports >>> flock(), flock() is way more

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

On 13/02/2017 19:55, Augie Fackler wrote: On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote: I think if we do know the repo is not on NFS, and the system supports flock(), flock() is way more robust and solves all kinds of pain here. I hereby propose a new repo requirement "flock",

Re: [PATCH 2 of 2] py3: convert the mode argument of os.fdopen to unicodes (2 of 2)

On Tue, Feb 14, 2017 at 01:59:15AM +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1487004328 -19800 > # Mon Feb 13 22:15:28 2017 +0530 > # Node ID 437f594e299aa68682783223e8fe60da230ee4a1 > # Parent

Re: [PATCH] test-bdiff: move import inside the function to avoid test failure

On Tue, Feb 14, 2017 at 01:59:48AM +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1487017336 -19800 > # Tue Feb 14 01:52:16 2017 +0530 > # Node ID a099a0633b39efcac1a8c1e018e5bc284f0b00a3 > # Parent

Re: Better release notes

timeless writes: > FWIW, @nokia, I looked at our commit message based changelog and > decided it wasn't useful, so I maintained a curated list. I assume that these commit messages were from employees with commit access? If that's true, then that's a bit different than

Re: [PATCH] bundle2: fix assertion that 'compression' hasn't been set

On Mon, Feb 13, 2017 at 12:41:59PM -0800, Siddharth Agarwal wrote: > # HG changeset patch > # User Siddharth Agarwal > # Date 1487014992 28800 > # Mon Feb 13 11:43:12 2017 -0800 > # Node ID 130eeba1cccdc63677da88a0f0dabe7fc39f963a > # Parent

Re: [PATCH 7 of 8 v4] extdiff: log time spent in external diff program

On Mon, Feb 13, 2017 at 10:25 AM, Simon Farnsworth wrote: > I want the caller to tell me what tag to apply to this blocking reason, so > that I can account for the blocking in hook.py (where it's running a > non-interactive process) and sshpeer.py (where it's network blocking as

Re: [PATCH RFC v10] scmutil: add a simple key-value file helper

As said before, I still prefer a simpler design without the "required" boolean flag, and move the responsibility of checking requirements to the higher-level code. Because: - As Yuya pointed out at the first place, "required" here will have trouble dealing with future schema changes. So

Re: [PATCH 10 of 10 shelve-ext v3] shelve: disable inhibit for shelving period

Excerpts from Sean Farley's message of 2017-02-13 12:08:39 -0800: > I didn't see any mention of inhibit in Mercurial? Is this a FB > extension? If so, should this logic be in hgext/shelve.py or in the FB > extension? (honest question) It's part of mutable-history and (imo) should be killed sooner

Re: Gardening extensions

Augie Fackler writes: > On Mon, Feb 06, 2017 at 02:58:29PM -0800, Bryan O'Sullivan wrote: >> On Mon, Feb 6, 2017 at 1:45 PM, Kevin Bullock < >> kbullock+mercur...@ringworld.org> wrote: >> >> > >> > Both of these are still extensions because they enable history editing. I >> >

Re: [PATCH 08 of 10 shelve-ext v3] shelve: add obs-based unshelve functionality

Jun Wu writes: > Excerpts from Sean Farley's message of 2017-02-06 11:41:55 -0800: >> Perhaps I'm the only one worried about adding all these markers. To me, >> it would make more sense to delete these markers since we're never going >> to push these shelved changesets. > > You are

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

Excerpts from Siddharth Agarwal's message of 2017-02-13 13:07:08 -0800: > On 2/13/17 13:03, Jun Wu wrote: > > I think it could be an extension outside core. > > I'd say make it a clone-time option, turned off by default, with caveats > documented. At FB we ban the situations where flock wouldn't

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

On 2/13/17 13:03, Jun Wu wrote: I think it could be an extension outside core. I'd say make it a clone-time option, turned off by default, with caveats documented. At FB we ban the situations where flock wouldn't work for scalability reasons anyway. Note that flock requires the file be

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

Excerpts from Augie Fackler's message of 2017-02-13 14:55:57 -0500: > On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote: > > I'd like to note that although this patch prevents repo corruption when > > running hg inside different containers (which has different pid namespaces), > > it does not

Re: [PATCH] tests: fix import order in test-bdiff

Initially I fixed a lot of such error messages while adding absolute_import to files. I just send a patch which I guess must prevent the test failure at Google. https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-February/092978.html On Mon, Feb 13, 2017 at 3:03 PM, Kyle Lippincott

[PATCH] test-bdiff: move import inside the function to avoid test failure

# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1487017336 -19800 # Tue Feb 14 01:52:16 2017 +0530 # Node ID a099a0633b39efcac1a8c1e018e5bc284f0b00a3 # Parent 437f594e299aa68682783223e8fe60da230ee4a1 test-bdiff: move import inside the function to avoid test failure

Re: [PATCH 3 of 6] debugcommands: move 'debuglabelcomplete' in the new module

> On Feb 13, 2017, at 15:22, Augie Fackler wrote: > > >> On Feb 13, 2017, at 14:24, Augie Fackler wrote: >> >>> Meant to be removed from commands.py too, right? >> >> Looks like it. I've queued patches 1,2, 4-6 of this series, we can get >> this one on a

Re: [PATCH 3 of 6] debugcommands: move 'debuglabelcomplete' in the new module

> On Feb 13, 2017, at 14:24, Augie Fackler wrote: > >> Meant to be removed from commands.py too, right? > > Looks like it. I've queued patches 1,2, 4-6 of this series, we can get > this one on a resend. Sigh. I'm getting test-completion.t failures with these applied, so I'm

Re: [PATCH 2 of 2] serve: make the URL the same for `hg serve` and `hg serve -S`

> On Feb 13, 2017, at 15:13, mharbiso...@gmail.com wrote: > > On Feb 13, 2017 2:51 PM, Augie Fackler wrote: > > On Sun, Feb 12, 2017 at 09:37:45PM -0500, Matt Harbison wrote: > > # HG changeset patch > > # User Matt Harbison > > # Date 1486877030

Re: [PATCH 2 of 2] serve: make the URL the same for `hg serve` and `hg serve -S`

On Feb 13, 2017 2:51 PM, Augie Fackler wrote: On Sun, Feb 12, 2017 at 09:37:45PM -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1486877030 18000 > # Sun Feb 12 00:23:50 2017 -0500 > # Node ID

Re: [PATCH 10 of 10 shelve-ext v3] shelve: disable inhibit for shelving period

Kostia Balytskyi writes: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484838335 28800 > # Thu Jan 19 07:05:35 2017 -0800 > # Node ID 6a7e7659886d35dfdc4d7d5efb3ef8479ae35367 > # Parent 088c9191d662d5c0003310119c51540926a815f7 > shelve: disable

Re: [PATCH 09 of 10 shelve-ext v3] shelve: add logic to preserve active bookmarks

Kostia Balytskyi writes: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484740179 28800 > # Wed Jan 18 03:49:39 2017 -0800 > # Node ID 088c9191d662d5c0003310119c51540926a815f7 > # Parent 94a237a046059ef246aacb2c3ad809c9f0bdbe70 > shelve: add

Re: [PATCH 08 of 10 shelve-ext v3] shelve: add obs-based unshelve functionality

Kostia Balytskyi writes: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484835394 28800 > # Thu Jan 19 06:16:34 2017 -0800 > # Node ID 94a237a046059ef246aacb2c3ad809c9f0bdbe70 > # Parent abdf9565fdce15604ea4abf013cb7c98a11f70ca > shelve: add

Re: [PATCH 07 of 10 shelve-ext v3] shelve: migrate config overrides to ui.configoverride

Kostia Balytskyi writes: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484740179 28800 > # Wed Jan 18 03:49:39 2017 -0800 > # Node ID abdf9565fdce15604ea4abf013cb7c98a11f70ca > # Parent 149fc6d767ce3502528b43b0e209eb411dd6e842 > shelve: migrate

Re: [PATCH 06 of 10 shelve-ext v3] shelve: add shelve type saving and loading

Kostia Balytskyi writes: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484740179 28800 > # Wed Jan 18 03:49:39 2017 -0800 > # Node ID 149fc6d767ce3502528b43b0e209eb411dd6e842 > # Parent 44425c4e86b2589184e23bed798999c15788b54b > shelve: add

Re: [PATCH 03 of 10 shelve-ext v3] shelve: move node-pruning functionality to be member of shelvedstate

Kostia Balytskyi writes: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484740179 28800 > # Wed Jan 18 03:49:39 2017 -0800 > # Node ID 249273f6db8bf0fdfbbf36bcbd9e3553e5715212 > # Parent 155f97b77a4866075fa709daa3bef6dac9108e81 > shelve: move

Re: [PATCH 02 of 10 shelve-ext v3] shelve: rename stripnodes to nodestoprune

Kostia Balytskyi writes: > # HG changeset patch > # User Kostia Balytskyi > # Date 1484740179 28800 > # Wed Jan 18 03:49:39 2017 -0800 > # Node ID 155f97b77a4866075fa709daa3bef6dac9108e81 > # Parent d904df83e9ead56f65104e10d765c0157d647401 > shelve: rename

Re: [PATCH 2 of 2] lock: include Linux pid namespace identifier in prefix

On Fri, Feb 10, 2017 at 04:50:55PM -0800, Jun Wu wrote: > I'd like to note that although this patch prevents repo corruption when > running hg inside different containers (which has different pid namespaces), > it does not prevent deadlock - if an hg process is SIGKILL-ed, every other > process

Re: [PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

On Mon, Feb 13, 2017 at 10:07:40AM -0800, Bryan O'Sullivan wrote: > On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth wrote: > > > mercurial: use best available timer for perf measurements > > > > Thanks for iterating on this patch series so quickly. After you're done > with my

Re: [PATCH 2 of 8 v4] ui: provide a mechanism to track and log blocked time

On Mon, Feb 13, 2017 at 09:29:02AM -0800, Simon Farnsworth wrote: > # HG changeset patch > # User Simon Farnsworth > # Date 1486994849 28800 > # Mon Feb 13 06:07:29 2017 -0800 > # Node ID 00f01e9a24bc050ab5cbbfc5a8dc99e992e31d2b > # Parent

Re: [PATCH 7 of 8 v4] extdiff: log time spent in external diff program

On Mon, Feb 13, 2017 at 06:25:11PM +, Simon Farnsworth wrote: > On 13/02/2017 18:04, Bryan O'Sullivan wrote: > > > > On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth > > wrote: > > > > +with ui.timeblockedsection('extdiff'): > > +

Re: [PATCH 4 of 8 v4] ui: log time spent blocked on stdio

On Mon, Feb 13, 2017 at 10:00:25AM -0800, Bryan O'Sullivan wrote: > On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth wrote: > > > The perfwrite microbenchmark shifts to: > > Linux: > > ! wall 3.316087 comb 0.90 user 0.81 sys 0.09 (best of 3) > > Mac: > > ! wall

Re: [PATCH 2 of 2 stable] debian: update copyright years

On Sun, Feb 12, 2017 at 06:15:39PM -0500, timeless wrote: > We should really write a test for this sort of thing. Yes it's a bit > silly, but it'd be helpful to catch it faster than 13 months late... Sure, but carefully, for the reasons expressed in

Re: [PATCH] dispatch: load debugcommand before extension

On Mon, Feb 13, 2017 at 05:07:07PM +0100, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1487000149 -3600 > # Mon Feb 13 16:35:49 2017 +0100 > # Node ID 135b457a4a6684f868a71cd0e10356297ec10ffe > # Parent

Re: [PATCH 08 of 10 shelve-ext v3] shelve: add obs-based unshelve functionality

On Mon, Feb 13, 2017 at 08:59:32AM -0800, Jun Wu wrote: > Excerpts from Sean Farley's message of 2017-02-06 11:41:55 -0800: > > Perhaps I'm the only one worried about adding all these markers. To me, > > it would make more sense to delete these markers since we're never going > > to push these

Re: [PATCH v3] hg: allow usage of XDG_CONFIG_HOME and $HOME/.config/hg/hgrc

On Mon, Feb 13, 2017 at 09:37:48AM -0800, Jun Wu wrote: > Excerpts from David Demelier's message of 2017-02-13 15:43:45 +0100: > > Le 10/02/2017 à 10:08, Raffaele Salmaso a écrit : > > > Hi, > > > > > > On Fri, Feb 10, 2017 at 9:19 AM, David Demelier > > >

Re: [PATCH v2] pager: migrate heavily-used extension into core

(+yuya explicitly for chg thoughts) On Fri, Feb 03, 2017 at 04:16:09PM -0800, Bryan O'Sullivan wrote: > # HG changeset patch > # User Bryan O'Sullivan > # Date 1486160890 28800 > # Fri Feb 03 14:28:10 2017 -0800 > # Node ID 30ee18bf947b97eca3582555f63eb3b2441e9db8 > # Parent

Re: [PATCH] perf: split obtaining chunks from decompression

On Sun, Feb 05, 2017 at 10:54:39AM -0800, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1486226866 28800 > # Sat Feb 04 08:47:46 2017 -0800 > # Node ID bc36af48a787dc1cd09a993163549054f3c78777 > # Parent

Re: [PATCH 2 of 2] ui: record and print wall clock time

On Thu, Feb 02, 2017 at 05:22:07PM -0800, Bryan O'Sullivan wrote: > On Thu, Feb 2, 2017 at 4:33 PM, Bryan O'Sullivan wrote: > > > ui: record and print wall clock time > > > > This patch is a total hack, but it contains an interesting few nuggets that > it doesn't call out

Re: [PATCH 3 of 6] debugcommands: move 'debuglabelcomplete' in the new module

On Mon, Feb 13, 2017 at 09:43:05AM -0800, Martin von Zweigbergk via Mercurial-devel wrote: > On Mon, Feb 13, 2017 at 8:07 AM, Pierre-Yves David > wrote: > > # HG changeset patch > > # User Pierre-Yves David > > # Date 1485967171

Re: Gardening extensions

On Mon, Feb 06, 2017 at 02:58:29PM -0800, Bryan O'Sullivan wrote: > On Mon, Feb 6, 2017 at 1:45 PM, Kevin Bullock < > kbullock+mercur...@ringworld.org> wrote: > > > > > Both of these are still extensions because they enable history editing. I > > recall discussions around moving these into core

Re: [PATCH 08 of 10 shelve-ext v3] shelve: add obs-based unshelve functionality

On Mon, Feb 06, 2017 at 03:22:56PM -0800, Sean Farley wrote: > Kostia Balytskyi writes: > > > On 06/02/2017 19:41, Sean Farley wrote: > > > >> Kostia Balytskyi writes: > >> > >>> On 03/02/2017 23:17, Sean Farley wrote: > >>> > Kostia Balytskyi

Re: [PATCH RFC] contrib: script to generate release notes from commit messages

On Thu, Feb 02, 2017 at 11:56:29PM -0800, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1486108530 28800 > # Thu Feb 02 23:55:30 2017 -0800 > # Node ID 5fe78521b9cb553b9a7c6bd4d96576a35b8d3517 > # Parent

Re: [PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

On 13/02/2017 18:49, Pulkit Goyal wrote: On Mon, Feb 13, 2017 at 10:59 PM, Simon Farnsworth > wrote: # HG changeset patch # User Simon Farnsworth > # Date 1486994849 28800 # Mon Feb 13

Re: [PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

On Mon, Feb 13, 2017 at 10:59 PM, Simon Farnsworth wrote: > # HG changeset patch > # User Simon Farnsworth > # Date 1486994849 28800 > # Mon Feb 13 06:07:29 2017 -0800 > # Node ID 88b51cd7e8e3764af542c25d79a33f5cbda37ac6 > # Parent

Re: [PATCH 2 of 8 v4] ui: provide a mechanism to track and log blocked time

On 13/02/2017 18:06, Bryan O'Sullivan wrote: On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth > wrote: +duration = (util.timer() - starttime) * 1000 +key += '_blocked' +self._blockedtimes[key] += duration Could be

Re: [PATCH 7 of 8 v4] extdiff: log time spent in external diff program

On 13/02/2017 18:04, Bryan O'Sullivan wrote: On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth > wrote: +with ui.timeblockedsection('extdiff'): +ui.system(cmdline, cwd=tmproot) Why not simply instrument ui.system directly,

Re: [PATCH 1 of 2] localrepo: cache self.changelog in local variable

On Mon, Feb 13, 2017 at 2:32 AM, Stanislau Hlebik wrote: > localrepo: cache self.changelog in local variable > > Repeated self.changelog lookups can incur overhead. Let's cache it in the > separate variable. > I'm not suggesting that you should change this since Yuya has already

Re: [PATCH 8 of 8 v4] histedit: log the time taken to read in the commands list

On 13/02/2017 18:03, Bryan O'Sullivan wrote: On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth > wrote: histedit: log the time taken to read in the commands list If we're being fed an external command list (histedit --commands), then the

Re: [PATCH 1 of 4 RFC] chgcache: new experimental extension

Excerpts from Yuya Nishihara's message of 2017-02-13 22:46:23 +0900: > On Wed, 8 Feb 2017 17:41:01 -0800, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1486601732 28800 > > # Wed Feb 08 16:55:32 2017 -0800 > > # Node ID

Re: [PATCH 4 of 8 v4] ui: log time spent blocked on stdio

On 13/02/2017 18:00, Bryan O'Sullivan wrote: On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth > wrote: The perfwrite microbenchmark shifts to: Linux: ! wall 3.316087 comb 0.90 user 0.81 sys 0.09 (best of 3) Mac: ! wall

Re: [PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth wrote: > mercurial: use best available timer for perf measurements > Thanks for iterating on this patch series so quickly. After you're done with my latest round of comments, this series looks great to ship.

Re: [PATCH 7 of 8 v4] extdiff: log time spent in external diff program

On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth wrote: > +with ui.timeblockedsection('extdiff'): > +ui.system(cmdline, cwd=tmproot) > Why not simply instrument ui.system directly, and leave its callers untouched?

Re: [PATCH 8 of 8 v4] histedit: log the time taken to read in the commands list

On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth wrote: > histedit: log the time taken to read in the commands list > > If we're being fed an external command list (histedit --commands), then the > time spent reading that file is out of our control. Log it. > I don't think

Re: [PATCH 4 of 8 v4] ui: log time spent blocked on stdio

On Mon, Feb 13, 2017 at 9:29 AM, Simon Farnsworth wrote: > The perfwrite microbenchmark shifts to: > Linux: > ! wall 3.316087 comb 0.90 user 0.81 sys 0.09 (best of 3) > Mac: > ! wall 0.939282 comb 0.58 user 0.47 sys 0.11 (best of 8) > > If I open-code

Re: [PATCH 2 of 4 RFC] chgcache: implement simple IPC mechanism

Excerpts from Yuya Nishihara's message of 2017-02-13 23:00:25 +0900: > Why not os.pipe()? > > We share the same (dup-ed) file descriptors. In this case, the write end can > be used by many forked processes, but IIRC the read end can't. Only one > reader can read out a message. So I think there's

Re: [PATCH 3 of 6] debugcommands: move 'debuglabelcomplete' in the new module

On Mon, Feb 13, 2017 at 8:07 AM, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1485967171 -3600 > # Wed Feb 01 17:39:31 2017 +0100 > # Node ID efbf6a59699575d328d71a6cdcb9a8db25a85c6e > #

Re: [PATCH v3] hg: allow usage of XDG_CONFIG_HOME and $HOME/.config/hg/hgrc

Excerpts from David Demelier's message of 2017-02-13 15:43:45 +0100: > Le 10/02/2017 à 10:08, Raffaele Salmaso a écrit : > > Hi, > > > > On Fri, Feb 10, 2017 at 9:19 AM, David Demelier > > > wrote: > > > > I've updated the code so that

Re: [PATCH 2 of 3] revset: use phasecache.getrevs

Excerpts from Yuya Nishihara's message of 2017-02-13 23:56:20 +0900: > On Fri, 10 Feb 2017 06:34:18 -0800, Jun Wu wrote: > > # HG changeset patch > > # User Jun Wu > > # Date 1486735766 28800 > > # Fri Feb 10 06:09:26 2017 -0800 > > # Node ID

[PATCH 8 of 8 v4] histedit: log the time taken to read in the commands list

# HG changeset patch # User Simon Farnsworth # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID b7557fd38e32b4d82b992003a242cd2a7c9496c5 # Parent 0727b4d77849fbefbf1ce1de6d9fe22ad2c5e1bd histedit: log the time taken to read in the commands list If we're

[PATCH 6 of 8 v4] crecord: log blocked time waiting for curses input

# HG changeset patch # User Simon Farnsworth # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 67a55b66a69520f84552cf3c1a7d93202c3f43da # Parent 74a43a6466712c42799528a25c4ca74eb2d25919 crecord: log blocked time waiting for curses input We want to know

[PATCH 7 of 8 v4] extdiff: log time spent in external diff program

# HG changeset patch # User Simon Farnsworth # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 0727b4d77849fbefbf1ce1de6d9fe22ad2c5e1bd # Parent 67a55b66a69520f84552cf3c1a7d93202c3f43da extdiff: log time spent in external diff program We can't fix the time

[PATCH 5 of 8 v4] ui: log time spent blocked on editor

# HG changeset patch # User Simon Farnsworth # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 74a43a6466712c42799528a25c4ca74eb2d25919 # Parent 923dcef529e523b391e26840cfa9ea6fd53c4131 ui: log time spent blocked on editor The user's editor is outside our

[PATCH 3 of 8 v4] contrib: add a write microbenchmark to perf.py

# HG changeset patch # User Simon Farnsworth # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 5a595ee2509989e440d70eb0e134fea915a0a8d6 # Parent 00f01e9a24bc050ab5cbbfc5a8dc99e992e31d2b contrib: add a write microbenchmark to perf.py I'm adding some

[PATCH 4 of 8 v4] ui: log time spent blocked on stdio

# HG changeset patch # User Simon Farnsworth # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 923dcef529e523b391e26840cfa9ea6fd53c4131 # Parent 5a595ee2509989e440d70eb0e134fea915a0a8d6 ui: log time spent blocked on stdio We use a wrapper around Mercurial

[PATCH 2 of 8 v4] ui: provide a mechanism to track and log blocked time

# HG changeset patch # User Simon Farnsworth # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 00f01e9a24bc050ab5cbbfc5a8dc99e992e31d2b # Parent 88b51cd7e8e3764af542c25d79a33f5cbda37ac6 ui: provide a mechanism to track and log blocked time We want to log

[PATCH 1 of 8 v4] mercurial: use best available timer for perf measurements

# HG changeset patch # User Simon Farnsworth # Date 1486994849 28800 # Mon Feb 13 06:07:29 2017 -0800 # Node ID 88b51cd7e8e3764af542c25d79a33f5cbda37ac6 # Parent a0e3d808690d57d1c9dff840e0b8ee099526397b mercurial: use best available timer for perf measurements As

mercurial@30914: 21 new changesets (8 on stable)

21 new changesets (8 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/5b60464efbde changeset: 30894:5b60464efbde user:Augie Fackler date:Thu Feb 09 21:44:32 2017 -0500 summary: tests: exclude python-zstandard from pyflakes analysis

  1   2   >