D460: revset: micro optimize _flipand by using anyorder for inner set

2017-08-20 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. This whole series looks great to me, but I'll let Yuya queue it since he knows this area better. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D460 To: quark, #hg-reviewers Cc: martinvonz, mercurial-devel

D460: revset: micro optimize _flipand by using anyorder for inner set

2017-08-20 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now the ordering issues are resolved so we can use `anyorder` for `x` in `_flipand(x, y)`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.

D457: revset: infer takeorder from function arguments

2017-08-20 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since we are inferring `takesubset`, it seems more consistent and user-friendly to infer `takeorder` too. REPOSITORY rHG Mercurial REVISION DETAIL https://phab

D459: revset: correct ordering issues caused by `return x - y`

2017-08-20 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The remaining revset ordering issues are caused by the pattern `return x - y`, which takes `x`'s order unconditionally. Since there are just 2 users, I'm fixing

D458: revset: correct ordering issues caused by `return subset.filter(...)`

2017-08-20 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A lot of revset functions use `return subset.filter(...)` which enforces `followorder`. This patch changes them to use `intersect` so order is handled correctly.

D452: revset: add an order-aware intersect helper function

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1115. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D452?vs=1112&id=1115 REVISION DETAIL https://phab.mercurial-scm.org/D452 AFFECTED FILES mercurial/revset.py tests/test-revset.t CHANGE DETAILS diff --git a/tes

D453: revset: make subrepo optional in revset predicate functions

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1116. quark edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D453?vs=1113&id=1116 REVISION DETAIL https://phab.mercurial-scm.org/D453 AFFECTED FILES mercurial/registrar.py mercuri

D456: revset: provide a way to check ordering support

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1117. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D456?vs=1114&id=1117 REVISION DETAIL https://phab.mercurial-scm.org/D456 AFFECTED FILES mercurial/debugcommands.py tests/test-completion.t tests/test-revset-or

mercurial@33813: 6 new changesets

2017-08-20 Thread Mercurial Commits
6 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/055fee3547df changeset: 33808:055fee3547df user:Alex Gaynor date:Fri Jul 14 19:27:28 2017 + summary: merge: removed sorting in casefolding detection, for a slight performance win https://www.mercu

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

2017-08-20 Thread quark (Jun Wu)
quark added inline comments. INLINE COMMENTS > test-fastcopytrace.t:1-9 > + $ cat >> $TESTTMP/copytrace.sh << '__EOF__' > + > initclient() { > + > cat >> $1/.hg/hgrc < + > [experimental] > + > fastcopytrace = True > + > EOF > + > } nit: could execute the script directly $ initclient()

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

2017-08-20 Thread quark (Jun Wu)
quark added subscribers: stash, quark. quark added a comment. For config options, I think it's cleaner if we can unify them: experimental.copytrace = disable | default | fast - `disable`: no copy tracing - `default`: old copy tracing algorithm - `fast`: this algorithm I'm f

[Bug 5663] New: `hg ls` should not be recursive by default

2017-08-20 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5663 Bug ID: 5663 Summary: `hg ls` should not be recursive by default Product: Mercurial Version: 4.3 Hardware: Macintosh OS: Mac OS Status: UNCONFIRMED Severit

D452: revset: add an order-aware intersect helper function

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1112. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D452?vs=1109&id=1112 REVISION DETAIL https://phab.mercurial-scm.org/D452 AFFECTED FILES mercurial/revset.py tests/test-revset.t CHANGE DETAILS diff --git a/tes

D456: revset: provide a way to check ordering support

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1114. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D456?vs=&id=1114 REVISION DETAIL https://phab.mercurial-scm.org/D456 AFFECTED FILES mercurial/debugcommands.py tests/test-completion.t tests/test-revset-or

D453: revset: make subrepo optional in revset predicate functions

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1113. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D453?vs=1110&id=1113 REVISION DETAIL https://phab.mercurial-scm.org/D453 AFFECTED FILES mercurial/registrar.py mercurial/revset.py CHANGE DETAILS diff --git a/

D451: revset: remove order information from tree

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1108. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1103&id=1108 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE

D456: revset: provide a way to check ordering support

2017-08-20 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Ordering support issues could be tricky to discover since they may be hidden behind other side effects. This patch implements `debugrevspec --check-ordering` so

D453: revset: make subrepo optional in revset predicate functions

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1110. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D453?vs=1105&id=1110 REVISION DETAIL https://phab.mercurial-scm.org/D453 AFFECTED FILES mercurial/registrar.py mercurial/revset.py CHANGE DETAILS diff --git a/

D455: test-revset: make it work with chg

2017-08-20 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY chg currently triggers `reposetup` as a side effect of `hg serve` command. Therefore change the test to not output during `reposetup` to be compatible with chg. R

D452: revset: add an order-aware intersect helper function

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1109. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D452?vs=1104&id=1109 REVISION DETAIL https://phab.mercurial-scm.org/D452 AFFECTED FILES mercurial/revset.py tests/test-revset.t CHANGE DETAILS diff --git a/tes

D454: releasenotes: view admonition titles using -a flag

2017-08-20 Thread rishabhmadan96 (Rishabh Madan)
rishabhmadan96 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since this extension is fairly new for almost all the contributors, remembering the admonition (with titles) is difficult. The admonition (-a) flag provide

D453: revset: make subrepo optional in revset predicate functions

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1105. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D453?vs=1102&id=1105 REVISION DETAIL https://phab.mercurial-scm.org/D453 AFFECTED FILES mercurial/registrar.py mercurial/revset.py CHANGE DETAILS diff --git a/

D451: revset: remove order information from tree

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1103. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1100&id=1103 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE

D452: revset: add an order-aware intersect helper function

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1104. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D452?vs=1101&id=1104 REVISION DETAIL https://phab.mercurial-scm.org/D452 AFFECTED FILES mercurial/revset.py tests/test-revset.t CHANGE DETAILS diff --git a/tes

D452: revset: add an order-aware intersect helper function

2017-08-20 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The code to handle `order` is a bit repetitive and error prone (`dagrange` is an example). This patch adds an `revset.intersect` helper function to make related ar

D453: revset: make subrepo optional in revset predicate functions

2017-08-20 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, a revset predicate must take a `subset` argument. It's not too hard for an inexperienced developer to make mistakes: @revsetpredicate('myre

D451: revset: remove order information from tree

2017-08-20 Thread quark (Jun Wu)
quark updated this revision to Diff 1100. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1099&id=1100 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE