D654: blackbox: unindent a try block

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The try block is no longer necessary. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D654 AFFECTED FILES hgext/blackbox.py CHANGE

D653: blackbox: remove blackboxui.copy

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's equivalent to its parent class. Therefore removed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D653 AFFECTED FILES

D652: blackbox: remove _partialinit

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's no longer needed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D652 AFFECTED FILES hgext/blackbox.py CHANGE DETAILS diff

D648: blackbox: fix rotation with chg

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The added test will show: $ $PYTHON showsize.py .hg/blackbox* .hg/blackbox.log: < 500 .hg/blackbox.log.1: < 500 .hg/blackbox.log.2: < 500

D650: blackbox: do not cache file handler

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Having the blackbox file handler cached in `ui._bbfp` could be troublesome if multiple processes (ex. chg servers) have file handlers to a same file. This

D649: blackbox: inline _bbwrite

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There is no need to make it a separate method. This makes the next change easier to read. REPOSITORY rHG Mercurial REVISION DETAIL

D651: blackbox: remove _bbvfs state

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `_bbvfs` is redundant because it could be calcualted from `_bbrepo`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D651 AFFECTED

[Bug 5676] New: debuginstall fails when trying to json-format exception

https://bz.mercurial-scm.org/show_bug.cgi?id=5676 Bug ID: 5676 Summary: debuginstall fails when trying to json-format exception Product: Mercurial Version: default branch Hardware: PC OS: Linux

D612: directaccess: add a hiddenlevel argument to registrar.command

durham added inline comments. INLINE COMMENTS > registrar.py:142 > +(recoverable write command) > +2: Can access the hidden commits without any warnings (read command) > """ I think an enum would be better here (UNRECOVERABLE_WRITE, RECOVERABLE_WRITE, READ_ONLY).

D646: changegroup: fix to allow empty manifest parts

durham created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The current chunk reading algorithm relied on counting the number of empty chunks and comparing it to the number of chunk lists it expected (1 list of files for

D644: rebase: remove complex unhiding code

quark updated this revision to Diff 1644. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D644?vs=1642=1644 REVISION DETAIL https://phab.mercurial-scm.org/D644 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py

D645: rebase: remove unnecessary '.unfiltered()' calls

quark updated this revision to Diff 1645. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D645?vs=1643=1645 REVISION DETAIL https://phab.mercurial-scm.org/D645 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py

D643: rebase: use unfiltered repo when loading state

quark updated this revision to Diff 1641. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D643?vs=1640=1641 REVISION DETAIL https://phab.mercurial-scm.org/D643 AFFECTED FILES hgext/rebase.py tests/test-rebase-obsolete.t CHANGE DETAILS diff --git

D644: rebase: remove complex unhiding code

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is similar to Martin von Zweigbergk's previous patch [1]. Previous patches are adding more `.unfiltered()` to the rebase code. So I wonder: are we playing

D645: rebase: remove unnecessary '.unfiltered()' calls

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now we have a clear centric place to control whether `rbstr.repo` is unfiltered or not, we can drop `unfiltered()` in other places. REPOSITORY rHG Mercurial

D529: uncommit: move fb-extension to core which uncommits a changeset

martinvonz added inline comments. INLINE COMMENTS > uncommit.py:16 > +files to their uncommitted state. This means that files modified or > +deleted in the changeset will be left unchanged, and so will remain modified > in > +the working directory. How about added files? Also, I think we use

D643: rebase: use unfiltered repo when loading state

martinvonz added a comment. Equally important is that --continue works after this :-) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D643 To: quark, #hg-reviewers Cc: martinvonz, mercurial-devel ___ Mercurial-devel

D643: rebase: use unfiltered repo when loading state

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, `rebase --abort` may fail to do the cleanup: $ hg rebase --abort rebase aborted (no revision is removed, only broken state is cleared)

D632: wrapfunction: use functools.partial if possible

phillco accepted this revision. phillco added a comment. Nice. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D632 To: quark, #hg-reviewers, phillco Cc: phillco, mercurial-devel ___ Mercurial-devel mailing list

D642: checknlink: renmae file object from 'fd' to 'fp'

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Make it clear that `fp` (`file` object) is different from `fd` (low-level file descriptor number). REPOSITORY rHG Mercurial REVISION DETAIL

D641: cleanup: rename "matchfn" to "match" where obviously a matcher

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We usually call matchers either "match" or "m" and reserve "matchfn" for functions. REPOSITORY rHG Mercurial REVISION DETAIL

D640: rebase: do not crash rebasing merge with a parent having hidden successor

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The added test will crash with previous code. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D640 AFFECTED FILES hgext/rebase.py

D639: amend: use context manager for config override

singhsrb accepted this revision. singhsrb added a comment. Thanks for helping out with cleaning this method! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D639 To: martinvonz, #hg-reviewers, singhsrb Cc: singhsrb, mercurial-devel

D611: checknlink: use a random temp file name for checking

quark added inline comments. INLINE COMMENTS > yuja wrote in util.py:1465 > Nit: here fd is a file descriptor, but later it's changed to a file > object. fd.close() would raise AttributeError if os.close(fd) failed. > > Maybe we should rename the latter to fp or something. Can > you send a

mercurial@34076: 12 new changesets

12 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c6c8a52e28c9 changeset: 34065:c6c8a52e28c9 user:Jun Wu date:Mon Aug 28 14:49:00 2017 -0700 summary: revset: optimize "draft() & ::x" pattern

D638: amend: delete dead assignment to "newid"

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D638 AFFECTED FILES mercurial/cmdutil.py CHANGE DETAILS diff --git a/mercurial/cmdutil.py

D639: amend: use context manager for config override

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D639 AFFECTED FILES mercurial/cmdutil.py CHANGE DETAILS diff --git a/mercurial/cmdutil.py

mercurial@34064: 37 new changesets

37 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/bfb38c5cebf4 changeset: 34028:bfb38c5cebf4 parent: 34026:b2eb0aa445cb user:Martin von Zweigbergk date:Wed Aug 30 09:21:31 2017 -0700 summary: revlog: move check for wdir

D637: check-code: fix incorrect capitalization in camelcase regex

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was found internally at Google as part of a monorepo-wide cleanup. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D637

[Bug 5675] New: ShareExtension does not avoid copying subrepositories

https://bz.mercurial-scm.org/show_bug.cgi?id=5675 Bug ID: 5675 Summary: ShareExtension does not avoid copying subrepositories Product: Mercurial Version: 2.8.2 Hardware: PC OS: Linux Status: UNCONFIRMED

D622: copytrace: move the default copytracing algorithm in a new function

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4b196092cc3: copytrace: move the default copytracing algorithm in a new function (authored by pulkit). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D611: checknlink: use a random temp file name for checking

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1104718fb090: checknlink: use a random temp file name for checking (authored by quark). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D611?vs=1616=1633 REVISION

D621: copytrace: replace experimental.disablecopytrace config with copytrace (BC)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG26531db4647a: copytrace: replace experimental.disablecopytrace config with copytrace (BC) (authored by pulkit). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D621?vs=1601=1631#toc REPOSITORY

D611: checknlink: use a random temp file name for checking

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Queued, thanks. INLINE COMMENTS > util.py:1465 > +os.close(fd) > +fd = None > +f2 = '%s2~' % f1[:-2] Nit: here fd is a file descriptor, but later it's changed to a

D625: copytrace: use the full copytracing method if only drafts are involved

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. > The `heuristics` option for `experimental.copytrace` performs full > copytracing if drafts are involved. This sounds somewhat incorrect. One of the involved revisions should

D624: copytrace: move the full copytracing algorithm under 'full' option

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copies.py:376 > else: > -return _fullcopytracing(repo, c1, c2, base) > +repo.ui.debug('unable to parse the copytracing mode %s' % >

D623: copytrace: move fast heuristic copytracing algorithm to core

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Generally looks good. We might need something to handle copies between `anc` (real common ancestor) and `base` (pseudo merge base) as we do in the "full" copy tracing, but I'm

D622: copytrace: move the default copytracing algorithm in a new function

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D622 To: pulkit, #hg-reviewers, yuja Cc: yuja, mercurial-devel

D621: copytrace: replace experimental.disablecopytrace config with copytrace (BC)

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. > experimental.copytrace defaults to 'off'. The new value is not boolean value as s/off/on/ and queued, thanks. INLINE COMMENTS > copies.py:366 > # rebase. > -if