[PATCH] docker: try to be more adherent to the best practices for writing Dockerfiles

2017-09-30 Thread a.mux--- via Mercurial-devel
# HG changeset patch # User mucianto # Date 1506812542 -7200 # Sun Oct 01 01:02:22 2017 +0200 # Branch stable # Node ID 991cb9aa90879d881054cce79e21ee44f583ed38 # Parent 0e4bed5c5c3849e1cd9317bef0810c64ee7fad89 docker: try to be more adherent to the best practices for writing Dockerfiles

D808: config: use copy-on-write to improve copy performance

2017-09-30 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > config.py:180 > if self.get(section, name) is not None: > del self._data[section][name] > self._unset.append((section, name)) Perhaps we need preparewrite() here? REPOSITORY rHG Mercurial

D859: tests: update some clonebundles expectations to pass on both pure and non-pure

2017-09-30 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Specifically, zstd isn't available in --pure mode, and we need to glob off the leading comma as well as the absent compression engine. REPOSITORY rHG Mercurial

D860: treediscovery: update test expectation

2017-09-30 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not sure why this needs an update, but the test passes for me both pure and non-pure. REPOSITORY rHG Mercurial REVISION DETAIL

D542: effectflag: document effect flag

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > obsutil.py:310 > > -# logic around storing and using effect flags > +## effectflag field > +# The extra leading "#' seems unusual. I suspect you didn't add it on purpose REPOSITORY rHG Mercurial REVISION DETAIL

D541: effectflag: detect when diff changed

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > obsutil.py:341 > +"""Drop all information but the username and patch""" > +cleanunk = [] > +for line in hunk.splitlines(): I think this should be "cleanhunk" > obsutil.py:360 > + > +This is a first and basic implementation,

Re: [PATCH RFC] commands: draft a "followlines" command (RFC)

2017-09-30 Thread Augie Fackler
> On Sep 30, 2017, at 17:39, Denis Laxalde wrote: > >>> This introduces a new "followlines" command to show history of files by line >>> range. The command relies on a special syntax to specify file's line range: >>> FILE,FROMLINE-TOLINE where FILE may be a (rel)path pattern.

Re: Windows x64 Inno Setup for 4.3.2

2017-09-30 Thread Pascal Quantin
Hi Ed, Le 30 sept. 2017 12:37, "Ed Brown" a écrit : Good Morning, Can someone build the Windows Inno Setup for x64 version 4.3.2. I no longer maintain a python 2 or VS 2008 install and have been relying on these releases for the last couple of years. The Inno Setup

Re: [PATCH RFC] commands: draft a "followlines" command (RFC)

2017-09-30 Thread Denis Laxalde
Augie Fackler a écrit : On Sep 28, 2017, at 11:04, Denis Laxalde wrote: # HG changeset patch # User Denis Laxalde # Date 1506589297 -7200 # Thu Sep 28 11:01:37 2017 +0200 # Node ID 0e0fef8d525d9cf60d9ca23de614e994aca5c9d8 # Parent

D540: effectflag: detect when meta changed

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > obsutil.py:327-330 > +def ismetablacklisted(metaitem): > +""" Check that the key of a meta item (extrakey, extravalue) does not > +match at least one of the blacklist pattern > +""" "ismetablacklisted" and "...does *not* match ...

D542: effectflag: document effect flag

2017-09-30 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. I've updated the series @martinvonz REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D542 To: lothiraldan, #hg-reviewers, quark Cc: martinvonz, quark, mercurial-devel ___ Mercurial-devel

mercurial@34351: 6 new changesets (1 on stable)

2017-09-30 Thread Mercurial Commits
6 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/46f45b7efa30 changeset: 34346:46f45b7efa30 user:Pulkit Goyal <7895pul...@gmail.com> date:Sat Sep 30 15:46:36 2017 +0530 summary: py3: use pycompat.strkwargs() before passing a dict as

Re: [PATCH 01 of 17] bugzilla: remove superfluous pass statements

2017-09-30 Thread Gregory Szorc
On Sat, Sep 30, 2017 at 1:02 PM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1506700526 14400 > # Fri Sep 29 11:55:26 2017 -0400 > # Node ID 200bd11a6fbb0a6f6667e65fd0af721e54e39d20 > # Parent

D750: rebase: move bookmarks with --keep (issue5682)

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz abandoned this revision. martinvonz added a comment. Dropping this as planned. Contents of it went in as https://phab.mercurial-scm.org/D727 (because it was Jun who wrote it). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D750 To: martinvonz,

D748: cleanupnodes: separate out bookmark destination calculation from actual update

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG033a5befbaf7: cleanupnodes: separate out bookmark destination calculation from actual update (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D727: rebase: move bookmarks with --keep (issue5682)

2017-09-30 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f427b57bf90: rebase: move bookmarks with --keep (issue5682) (authored by quark, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D727?vs=1869=2201#toc REPOSITORY rHG

D749: cleanupnodes: rename "mapping" to "replacements"

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2dbd6d259cd2: cleanupnodes: rename mapping to replacements (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D749: cleanupnodes: rename "mapping" to "replacements"

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 2197. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D749?vs=1986=2197 REVISION DETAIL https://phab.mercurial-scm.org/D749 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D750: rebase: move bookmarks with --keep (issue5682)

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 2198. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D750?vs=1987=2198 REVISION DETAIL https://phab.mercurial-scm.org/D750 AFFECTED FILES hgext/rebase.py mercurial/scmutil.py tests/test-rebase-bookmarks.t

D748: cleanupnodes: separate out bookmark destination calculation from actual update

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 2196. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D748?vs=1985=2196 REVISION DETAIL https://phab.mercurial-scm.org/D748 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

mercurial@34345: new changeset

2017-09-30 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/05167447f90d changeset: 34345:05167447f90d bookmark:@ tag: tip user:Pulkit Goyal <7895pul...@gmail.com> date:Sat Sep 30 05:22:22 2017 +0530 summary: py3: return False early while checking

Re: [PATCH RFC] commands: draft a "followlines" command (RFC)

2017-09-30 Thread Augie Fackler
> On Sep 28, 2017, at 11:04, Denis Laxalde wrote: > > # HG changeset patch > # User Denis Laxalde > # Date 1506589297 -7200 > # Thu Sep 28 11:01:37 2017 +0200 > # Node ID 0e0fef8d525d9cf60d9ca23de614e994aca5c9d8 > # Parent

D833: exchange: perform stream clone with clone bundle with --uncompressed

2017-09-30 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGff406f3e57b2: exchange: perform stream clone with clone bundle with --uncompressed (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D833: exchange: perform stream clone with clone bundle with --uncompressed

2017-09-30 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Queued these, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D833 To: indygreg, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D832: tests: add tests for clone bundles with --uncompressed

2017-09-30 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG880e47351d1a: tests: add tests for clone bundles with --uncompressed (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH] copytrace: use ctx.mutable() instead of adhoc constant of non-public phases

2017-09-30 Thread Augie Fackler
> On Sep 28, 2017, at 07:56, Pulkit Goyal <7895pul...@gmail.com> wrote: > > LGTM. Thanks Yuya for cleaning this up. Queued, thanks > > On Wed, Sep 27, 2017 at 6:03 PM, Yuya Nishihara wrote: >> # HG changeset patch >> # User Yuya Nishihara >> # Date 1506087902

Re: [PATCH 5 of 5] py3: work around bytes/unicode divergence in parsedate()

2017-09-30 Thread Augie Fackler
> On Sep 30, 2017, at 01:05, Pulkit Goyal <7895pul...@gmail.com> wrote: > > On Wed, Sep 27, 2017 at 6:04 PM, Yuya Nishihara wrote: >> # HG changeset patch >> # User Yuya Nishihara >> # Date 1506508061 -32400 >> # Wed Sep 27 19:27:41 2017 +0900 >> # Node ID

D856: py3: use '%d' instead of '%s' for integers

2017-09-30 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG87a6be5b29f4: py3: use %d instead of %s for integers (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D856?vs=2181=2189

D808: config: use copy-on-write to improve copy performance

2017-09-30 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc41444a39de2: config: use copy-on-write to improve copy performance (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D853: py3: explicitly convert dict.keys() and dict.items() into a list

2017-09-30 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1a5abc45e2fa: py3: explicitly convert dict.keys() and dict.items() into a list (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D854: py3: use pycompat.strkwargs() before passing a dict as keyword argument

2017-09-30 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG46f45b7efa30: py3: use pycompat.strkwargs() before passing a dict as keyword argument (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D858: py3: whitelist 15 more tests passing on Python 3

2017-09-30 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf975cb7c4dbe: py3: whitelist 15 more tests passing on Python 3 (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D855: py3: use pycompat.bytestr instead of str

2017-09-30 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6f49ea88d984: py3: use pycompat.bytestr instead of str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D855?vs=2186=2191

D852: py3: return False early while checking whether None is a key in lazymanifest

2017-09-30 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG05167447f90d: py3: return False early while checking whether None is a key in lazymanifest (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH phase] exchange: fix test for remote support of binary phases

2017-09-30 Thread Yuya Nishihara
On Sat, 30 Sep 2017 16:01:36 +0530, Pulkit Goyal wrote: > I don't see the traceback after applying this patch. If possible, this > patch should be folded with the previous series. > > On Sat, Sep 30, 2017 at 3:05 PM, Boris Feld wrote: > > # HG changeset patch > > # User

D855: py3: use pycompat.bytestr instead of str

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2186. pulkit retitled this revision from "py3: use bytes instead of str" to "py3: use pycompat.bytestr instead of str". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D855?vs=2180=2186 REVISION DETAIL

D853: py3: explicitly convert dict.keys() and dict.items() into a list

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 2185. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D853?vs=2178=2185 REVISION DETAIL https://phab.mercurial-scm.org/D853 AFFECTED FILES mercurial/copies.py mercurial/merge.py CHANGE DETAILS diff --git

D857: py3: add a test showing a normal `hg merge` works on Python 3

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D857#14374, @durin42 wrote: > Do we need this with https://phab.mercurial-scm.org/D858? It looks like we get enough extra coverage from that we don't need this extra check here. Yeah I guess we don't even need that file

D858: py3: whitelist 15 more tests passing on Python 3

2017-09-30 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. (Accepted, but need some of the ancestors to be ready first) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D858 To: pulkit, #hg-reviewers, durin42 Cc:

D857: py3: add a test showing a normal `hg merge` works on Python 3

2017-09-30 Thread durin42 (Augie Fackler)
durin42 added a comment. Do we need this with https://phab.mercurial-scm.org/D858? It looks like we get enough extra coverage from that we don't need this extra check here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D857 To: pulkit, #hg-reviewers Cc:

D855: py3: use bytes instead of str

2017-09-30 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > merge.py:993 > _("note: merging %s and %s using bids from ancestors %s\n") % > -(wctx, mctx, _(' and ').join(str(anc) for anc in ancestors))) > +(wctx, mctx, _(' and ').join(bytes(anc) for anc in ancestors))) >

D853: py3: explicitly convert dict.keys() and dict.items() into a list

2017-09-30 Thread durin42 (Augie Fackler)
durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. One nit. INLINE COMMENTS > copies.py:144 > c = ds.copies().copy() > -for k in c.keys(): > +for k in list(c.keys()): > if ds[k] not in 'anm': please use

D851: [RFC] setup: increase MAX_PATH limit on Windows 10 Anniversary Update

2017-09-30 Thread abuehl (Adrian Buehlmann)
abuehl added a comment. In addition, Mercurial is not using the ...W Windows API functions. I think, for example https://phab.mercurial-scm.org/diffusion/HG/browse/default/mercurial/cext/osutil.c;da8bdeb1be28b976909a963c89e974264686e2bb$1207 would have to be changed to call

D858: py3: whitelist 15 more tests passing on Python 3

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have reached the count of 75 tests passing on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D858 AFFECTED FILES

D856: py3: use '%d' instead of '%s' for integers

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D856 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py

D853: py3: explicitly convert dict.keys() and dict.items() into a list

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D853 AFFECTED FILES mercurial/copies.py mercurial/merge.py CHANGE DETAILS diff --git

D855: py3: use bytes instead of str

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D855 AFFECTED FILES mercurial/merge.py CHANGE DETAILS diff --git a/mercurial/merge.py

D857: py3: add a test showing a normal `hg merge` works on Python 3

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D857 AFFECTED FILES tests/test-py3-commands.t CHANGE DETAILS diff --git a/tests/test-py3-commands.t

D854: py3: use pycompat.strkwargs() before passing a dict as keyword argument

2017-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D854 AFFECTED FILES mercurial/templater.py CHANGE DETAILS diff --git a/mercurial/templater.py

[PATCH 13 of 17] patch: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771907 14400 # Sat Sep 30 07:45:07 2017 -0400 # Node ID 5802876c662320ca23433eccfc2c6ed1475fb6c6 # Parent 09e901272db94667bc14dc8455a2299d540bb021 patch: remove superfluous pass statements diff --git

[PATCH 17 of 17] contrib: add a check to check-code to ban superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506700544 14400 # Fri Sep 29 11:55:44 2017 -0400 # Node ID f4cdd3ad19cf7638f1b80dc33f292064177efe52 # Parent 8016928028e542909be78f9f0233b5e6cf73cc40 contrib: add a check to check-code to ban superfluous pass statements

[PATCH 05 of 17] cmdutil: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771806 14400 # Sat Sep 30 07:43:26 2017 -0400 # Node ID 979cb36af44c9f3104131ba078221eca550874f1 # Parent 6b594a14e15fa86291fadd25f45e280ba7e004a9 cmdutil: remove superfluous pass statements diff --git

[PATCH 06 of 17] commandserver: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771820 14400 # Sat Sep 30 07:43:40 2017 -0400 # Node ID 511a498528e67b15c71de5b1c7cc01ec723ae98c # Parent 979cb36af44c9f3104131ba078221eca550874f1 commandserver: remove superfluous pass statements diff --git

[PATCH 08 of 17] formatter: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771848 14400 # Sat Sep 30 07:44:08 2017 -0400 # Node ID 261a764fc0d8d6315208be36c716c0a1e917cf40 # Parent 733439ef2461439f4c3e16f51777e7266868dfff formatter: remove superfluous pass statements diff --git

[PATCH 12 of 17] obsolete: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771895 14400 # Sat Sep 30 07:44:55 2017 -0400 # Node ID 09e901272db94667bc14dc8455a2299d540bb021 # Parent 28011b88d7cf1a95de128c932c3dda33f6293c5e obsolete: remove superfluous pass statements diff --git

[PATCH 11 of 17] match: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771885 14400 # Sat Sep 30 07:44:45 2017 -0400 # Node ID 28011b88d7cf1a95de128c932c3dda33f6293c5e # Parent de6ef744e94a4c0c30b64487c345c9e4acab64c0 match: remove superfluous pass statements diff --git

[PATCH 09 of 17] hgweb: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771860 14400 # Sat Sep 30 07:44:20 2017 -0400 # Node ID de46978e0268bd174dfe620469e4f5f4cffa9c6e # Parent 261a764fc0d8d6315208be36c716c0a1e917cf40 hgweb: remove superfluous pass statements diff --git

[PATCH 14 of 17] registrar: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771941 14400 # Sat Sep 30 07:45:41 2017 -0400 # Node ID 83b1dba69bcc3474fb7ec09ddbbccd55cda9ea17 # Parent 5802876c662320ca23433eccfc2c6ed1475fb6c6 registrar: remove superfluous pass statements diff --git

[PATCH 07 of 17] exchange: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771833 14400 # Sat Sep 30 07:43:53 2017 -0400 # Node ID 733439ef2461439f4c3e16f51777e7266868dfff # Parent 511a498528e67b15c71de5b1c7cc01ec723ae98c exchange: remove superfluous pass statements diff --git

[PATCH 15 of 17] subrepo: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771951 14400 # Sat Sep 30 07:45:51 2017 -0400 # Node ID 050e03d6e79c6465b9f2644facccb340ab1f9b78 # Parent 83b1dba69bcc3474fb7ec09ddbbccd55cda9ea17 subrepo: remove superfluous pass statements diff --git

[PATCH 10 of 17] localrepo: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771874 14400 # Sat Sep 30 07:44:34 2017 -0400 # Node ID de6ef744e94a4c0c30b64487c345c9e4acab64c0 # Parent de46978e0268bd174dfe620469e4f5f4cffa9c6e localrepo: remove superfluous pass statements diff --git

[PATCH 01 of 17] bugzilla: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506700526 14400 # Fri Sep 29 11:55:26 2017 -0400 # Node ID 200bd11a6fbb0a6f6667e65fd0af721e54e39d20 # Parent ac0cd81e2f83cd6a2910c61afbb98a415832f8e7 bugzilla: remove superfluous pass statements diff --git

[PATCH 16 of 17] posix: replace superfluous pass statement with explicit return

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771918 14400 # Sat Sep 30 07:45:18 2017 -0400 # Node ID 8016928028e542909be78f9f0233b5e6cf73cc40 # Parent 050e03d6e79c6465b9f2644facccb340ab1f9b78 posix: replace superfluous pass statement with explicit return diff

[PATCH 04 of 17] byterange: remove superfluous pass statements

2017-09-30 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1506771791 14400 # Sat Sep 30 07:43:11 2017 -0400 # Node ID 6b594a14e15fa86291fadd25f45e280ba7e004a9 # Parent fa24e8e3eb1bbd5f5dfac4af9c54bf3fb196afe4 byterange: remove superfluous pass statements diff --git

D743: ui: check for progress singleton when clearing progress bar (issue5684)

2017-09-30 Thread krbullock (Kevin Bullock)
krbullock added a comment. Queued for stable, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D743 To: mbthomas, #hg-reviewers, durin42, krbullock Cc: durin42, mercurial-devel ___ Mercurial-devel mailing list

D851: [RFC] setup: increase MAX_PATH limit on Windows 10 Anniversary Update

2017-09-30 Thread abuehl (Adrian Buehlmann)
abuehl added a comment. In https://phab.mercurial-scm.org/D851#14301, @indygreg wrote: > In https://phab.mercurial-scm.org/D851#14300, @abuehl wrote: > > > What about file I/O done via Python lib (e.g. python27.dll)? > > > I /think/ this works at the process - not DLL - level.

D851: [RFC] setup: increase MAX_PATH limit on Windows 10 Anniversary Update

2017-09-30 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D851#14300, @abuehl wrote: > What about file I/O done via Python lib (e.g. python27.dll)? I /think/ this works at the process - not DLL - level. But I need to test on a Windows machine to be sure. One of the reasons this

D851: [RFC] setup: increase MAX_PATH limit on Windows 10 Anniversary Update

2017-09-30 Thread abuehl (Adrian Buehlmann)
abuehl added a comment. What about file I/O done via Python lib (e.g. python27.dll)? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D851 To: indygreg, #hg-reviewers Cc: abuehl, mercurial-devel ___ Mercurial-devel

Windows x64 Inno Setup for 4.3.2

2017-09-30 Thread Ed Brown
Good Morning, Can someone build the Windows Inno Setup for x64 version 4.3.2. I no longer maintain a python 2 or VS 2008 install and have been relying on these releases for the last couple of years. Thanks, Ed ___ Mercurial-devel mailing list

Re: [PATCH phase] exchange: fix test for remote support of binary phases

2017-09-30 Thread Pulkit Goyal
I don't see the traceback after applying this patch. If possible, this patch should be folded with the previous series. On Sat, Sep 30, 2017 at 3:05 PM, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1506762569 -3600 > #

Re: [PATCH 6 of 7 bundle2] pull: use 'phase-heads' to retrieve phase information

2017-09-30 Thread Pulkit Goyal
On Sat, Sep 30, 2017 at 10:49 AM, Yuya Nishihara wrote: > On Thu, 28 Sep 2017 07:08:41 +0200, Boris Feld wrote: >> # HG changeset patch >> # User Boris Feld >> # Date 1506281238 -7200 >> # Sun Sep 24 21:27:18 2017 +0200 >> # Node ID

mercurial@34344: 5 new changesets

2017-09-30 Thread Mercurial Commits
5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/741a511492d3 changeset: 34340:741a511492d3 user:Rishabh Madan date:Thu Sep 28 13:22:58 2017 +0530 summary: releasenotes: raise error on simultaneous usage of flags

D851: [RFC] setup: increase MAX_PATH limit on Windows 10 Anniversary Update

2017-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As documented at https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247(v=vs.85).aspx system settings or per-application settings can now opt in to

[PATCH phase] exchange: fix test for remote support of binary phases

2017-09-30 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1506762569 -3600 # Sat Sep 30 10:09:29 2017 +0100 # Node ID 4d26dbcdfdb38fd3fc4efa157b64819f5281c8e0 # Parent ec769bba34d377503f42308dea5ddcb8ce4c0ade # EXP-Topic fix-phases exchange: fix test for remote support of binary

D850: hgweb: add HTML elements to control whitespace settings for annotate

2017-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Building on top of the new URL query string arguments to control whitespace settings for annotate, this commit adds HTML checkboxes reflecting the values of

D849: hgweb: query string arguments to control whitespace for annotate

2017-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This feature should hopefully be pretty straightforward. We simply examine some query string arguments to feed into the diff options. The function to obtain

D848: tests: add tests for hgweb annotate output

2017-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In preparation for adding features to modify whitespace settings. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D848 AFFECTED

D846: dirstate: use keyword arguments to clarify walk()'s callers

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG255c761a52db: dirstate: use keyword arguments to clarify walk()s callers (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D847: dirstate: use keyword arguments to clarify status()'s callers

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGac0cd81e2f83: dirstate: use keyword arguments to clarify status()s callers (authored by martinvonz, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D847?vs=2167=2171#toc

D845: perf: remove fallbacks to ancient versions of dirstate.walk()

2017-09-30 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb3538c03a804: perf: remove fallbacks to ancient versions of dirstate.walk() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D831: releasenotes: raise error on simultaneous usage of flags

2017-09-30 Thread rishabhmadan96 (Rishabh Madan)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG741a511492d3: releasenotes: raise error on simultaneous usage of flags (authored by rishabhmadan96, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D544: releasenotes: update docstrings with information on additional flags

2017-09-30 Thread rishabhmadan96 (Rishabh Madan)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG01e8ab4b6573: releasenotes: update docstrings with information on additional flags (authored by rishabhmadan96, committed by ). CHANGED PRIOR TO COMMIT

D847: dirstate: use keyword arguments to clarify status()'s callers

2017-09-30 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > overrides.py:1222 > +unsure, s = lfdirstate.status(matchmod.always(repo.root, repo.getcwd()), > + subrepos=[], ignores=False,

D544: releasenotes: update docstrings with information on additional flags

2017-09-30 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. Looks every nit is addressed. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D544 To: rishabhmadan96, #hg-reviewers, krbullock, yuja Cc: yuja, krbullock, dsp, durin42, mercurial-devel

Re: [PATCH 6 of 7 bundle2] pull: use 'phase-heads' to retrieve phase information

2017-09-30 Thread Yuya Nishihara
On Thu, 28 Sep 2017 07:08:41 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1506281238 -7200 > # Sun Sep 24 21:27:18 2017 +0200 > # Node ID dca2166f424196e9b4b6ef9c6b0925f249c54682 > # Parent 7079b5aaf647e041e2dc8bc6526b9c7a2efbdc71 > #