Re: [PATCH 6 of 6 v2] paths: allow util.finddirs touse os.path.sep

2017-10-01 Thread Matt Harbison
> On Oct 1, 2017, at 6:33 AM, Kostia Balytskyi wrote: > > You guys are correct, these patches should not land. Yesterday I did another > pass of experiments on Windows 10 (build 10.0.14393), and if looks like >

[Bug 5696] New: hg incoming exit status is ambiguous

2017-10-01 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5696 Bug ID: 5696 Summary: hg incoming exit status is ambiguous Product: Mercurial Version: 4.3 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: bug

D894: fsmonitor: warn when fsmonitor could be used

2017-10-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY fsmonitor can significantly speed up operations on large working directories. But fsmonitor isn't enabled by default, so naive users may not realize there is a

D893: fsmonitor: use configitem

2017-10-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We might as well get this out of the way. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D893 AFFECTED FILES

D892: fsmonitor: access copymap in new location

2017-10-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY fsmonitor has been busted since https://phab.mercurial-scm.org/rHG0865d25e8a8ad664e8da31ab1bf12f1fc9bf0c7a due to moving self._copymap. Fix it. REPOSITORY

Re: [PATCH] formatter: fix default list/dict generator to be evaluated more than once

2017-10-01 Thread Augie Fackler
On Sun, Oct 01, 2017 at 09:25:25AM +0100, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1506843424 -3600 > # Sun Oct 01 08:37:04 2017 +0100 > # Node ID 743f288540ff52670eb36e5728c4bf35fcca2a07 > # Parent 8de6dc4ab3304251a0bce4154603b784d4d519a0

Re: [PATCH] doctest: drop hack to run py2/3 tests selectively

2017-10-01 Thread Augie Fackler
On Sun, Oct 01, 2017 at 09:25:15AM +0100, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1506515928 -32400 > # Wed Sep 27 21:38:48 2017 +0900 > # Node ID 8de6dc4ab3304251a0bce4154603b784d4d519a0 > # Parent

Re: [PATCH] docker: try to follow the best practices for writing Dockerfiles

2017-10-01 Thread Augie Fackler
On Sun, Oct 01, 2017 at 06:51:49PM +0200, a.mux--- via Mercurial-devel wrote: > # HG changeset patch > # User muxator > # Date 1506812542 -7200 > # Sun Oct 01 01:02:22 2017 +0200 > # Node ID b99e818a197220cf0f3a6d608bc3ddbdee6dcd18 > # Parent

mercurial@34422: 14 new changesets

2017-10-01 Thread Mercurial Commits
14 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7de145167ae7 changeset: 34409:7de145167ae7 user:Boris Feld date:Fri Jun 30 03:43:55 2017 +0200 summary: configitems: register the 'profiling.output' config

D539: effectflag: detect when parents changed

2017-10-01 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa26f5891e68: effectflag: detect when parents changed (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D539?vs=2110=2310

D542: effectflag: document effect flag

2017-10-01 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2fd06499dc8e: effectflag: document effect flag (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D542?vs=2288=2312

D536: effectflag: detect when user changed

2017-10-01 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG55ef17ec8e59: effectflag: detect when user changed (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D536?vs=2107=2308

D538: effectflag: detect when branch changed

2017-10-01 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG57980af73cfa: effectflag: detect when branch changed (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D538?vs=2109=2309

D533: effectflag: store an empty effect flag for the moment

2017-10-01 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG014d467f9d08: effectflag: store an empty effect flag for the moment (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D535: effectflag: detect when description changed

2017-10-01 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG51aadc0d0da2: effectflag: detect when description changed (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D534: tests: add tests for effect flags

2017-10-01 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG468646386e95: tests: add tests for effect flags (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D534?vs=2105=2305

Re: [PATCH 1 of 4] configitems: register the 'profiling.output' config

2017-10-01 Thread Gregory Szorc
On Sun, Oct 1, 2017 at 7:32 PM, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1498787035 -7200 > # Fri Jun 30 03:43:55 2017 +0200 > # Node ID 49eb5157513e5870b1842beb44420d00f334d133 > # Parent

[PATCH 2 of 4] configitems: register the 'profiling.showmax' config

2017-10-01 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1498787036 -7200 # Fri Jun 30 03:43:56 2017 +0200 # Node ID 5e5cd4ac398ab2d3c5c964adbf639cc5590fe7c1 # Parent 49eb5157513e5870b1842beb44420d00f334d133 # EXP-Topic config.register.profiling configitems: register the

[PATCH 1 of 4] configitems: register the 'profiling.output' config

2017-10-01 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1498787035 -7200 # Fri Jun 30 03:43:55 2017 +0200 # Node ID 49eb5157513e5870b1842beb44420d00f334d133 # Parent 7d2f71b7bc31acf1290ad3211481c5c77345a1da # EXP-Topic config.register.profiling configitems: register the

[PATCH 3 of 4] configitems: register the 'profiling.showmin' config

2017-10-01 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1498787037 -7200 # Fri Jun 30 03:43:57 2017 +0200 # Node ID dcee30ee38b6865c13b03bcbe4e817341dca1a15 # Parent 5e5cd4ac398ab2d3c5c964adbf639cc5590fe7c1 # EXP-Topic config.register.profiling configitems: register the

[PATCH 4 of 4] configitems: register the 'profiling.type' config

2017-10-01 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1498787040 -7200 # Fri Jun 30 03:44:00 2017 +0200 # Node ID f57cc93de27e7f6594f2588cd2496f6bddf7024c # Parent dcee30ee38b6865c13b03bcbe4e817341dca1a15 # EXP-Topic config.register.profiling configitems: register the

mercurial@34408: 2 new changesets

2017-10-01 Thread Mercurial Commits
2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b6692ba7d5b0 changeset: 34407:b6692ba7d5b0 user:Simon Whitaker date:Sun Oct 01 12:54:35 2017 +0100 summary: obsmarker: crash more helpfully when metadata fields are >255bytes

Re: [PATCH] docker: try to be more adherent to the best practices for writing Dockerfiles

2017-10-01 Thread Antonio Muci via Mercurial-devel
Please ignore this patch. I have just seen that the Fedora Dockerfiles need the same treatment. I will send a single changeset. Sorry for the noise. On 10/01/2017 06:26 PM, a@inwind.it wrote: # HG changeset patch # User muxator # Date 1506812542 -7200 # Sun Oct 01

Re: [PATCH] docker: try to be more adherent to the best practices for writing Dockerfiles

2017-10-01 Thread Antonio Muci via Mercurial-devel
Please ignore also this patch. I have just seen that the Fedora Dockerfiles require the same treatment. I will send a single changeset. On 10/01/2017 06:26 PM, a@inwind.it wrote: # HG changeset patch # User muxator # Date 1506812542 -7200 # Sun Oct 01 01:02:22 2017

D891: cleanup: use urllibcompat for renamed methods on urllib request objects

2017-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D891 AFFECTED FILES mercurial/byterange.py mercurial/httpconnection.py mercurial/keepalive.py

D888: keepalive: python 3 portability tweaks

2017-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D888 AFFECTED FILES mercurial/keepalive.py CHANGE DETAILS diff --git a/mercurial/keepalive.py

D885: httppasswordmgrdbproxy: specify exact arguments

2017-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We only ever call these functions in a single way, so let's just actually specify them. We need to do some string/bytes encoding dancing here for Python 3, so

D887: httppeer: use native strings for headers

2017-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On Python 3, we need to use unicodes, rather than bytes. This lets test-pull.t get a lot further along. REPOSITORY rHG Mercurial REVISION DETAIL

D886: ui: convert to/from Optional[bytes] to Optional[str] in password manager

2017-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This password manager proxy is roughly the right-looking layer to convert between strings and bytes. Many of these arguments can be None, so we have a helper

D889: url: use native strings for header values

2017-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D889 AFFECTED FILES mercurial/url.py CHANGE DETAILS diff --git a/mercurial/url.py b/mercurial/url.py

D890: urllibcompat: new library to help abstract out some python3 urllib2 stuff

2017-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Doing a new file instead of pycompat because I'm starting to feel like pycompat is getting a little enormous in terms of scope. REPOSITORY rHG Mercurial

[PATCH] docker: try to be more adherent to the best practices for writing Dockerfiles

2017-10-01 Thread a.mux--- via Mercurial-devel
# HG changeset patch # User muxator # Date 1506812542 -7200 # Sun Oct 01 01:02:22 2017 +0200 # Node ID 75d89e4aec93490431b81526c292766f4c08b38e # Parent 0133ca39c68875e1d50e6ed48913e33e1f8f15ac docker: try to be more adherent to the best practices for writing Dockerfiles

Re: [PATCH 7 of 7] extdata: abort if external command exits with non-zero status

2017-10-01 Thread FUJIWARA Katsunori
At Sun, 01 Oct 2017 13:00:18 +0100, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1506856910 -3600 > # Sun Oct 01 12:21:50 2017 +0100 > # Node ID 86c51cf6c4ff8a9a01e34e365c8fbc50415d072e > # Parent b3a36705720f5ed1e7cc5129b27450ca59c7952b >

D884: dirstate: implement __len__ on dirstatemap (issue5695)

2017-10-01 Thread swhitaker (Simon Whitaker)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7d2f71b7bc31: dirstate: implement __len__ on dirstatemap (issue5695) (authored by swhitaker, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D884: dirstate: implement __len__ on dirstatemap (issue5695)

2017-10-01 Thread swhitaker (Simon Whitaker)
swhitaker created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D884 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git a/mercurial/dirstate.py

[Bug 5695] New: Crash on attempting to fetch length of dirstate map

2017-10-01 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5695 Bug ID: 5695 Summary: Crash on attempting to fetch length of dirstate map Product: Mercurial Version: 4.3-rc Hardware: PC OS: Mac OS Status: UNCONFIRMED

mercurial@34406: 2 new changesets

2017-10-01 Thread Mercurial Commits
2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/9ecc622ca23f changeset: 34405:9ecc622ca23f user:Kyle Lippincott date:Sun Oct 01 02:53:10 2017 -0700 summary: deb: install zsh completions to /usr/share/zsh/vendor-completions

D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681)

2017-10-01 Thread swhitaker (Simon Whitaker)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb6692ba7d5b0: obsmarker: crash more helpfully when metadata fields are 255bytes (issue5681) (authored by swhitaker, committed by ). CHANGED PRIOR TO COMMIT

D865: obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681)

2017-10-01 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Removed translation marker and queued, thanks. > obsmarker: crash more helpfully when metadata fields are >255 bytes (issue5681) s/255 bytes/255bytes/ to silence test-check-commit.t

mercurial@34404: 47 new changesets

2017-10-01 Thread Mercurial Commits
47 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/8cbcee0b923d changeset: 34358:8cbcee0b923d user:Yuya Nishihara date:Wed Sep 27 19:04:32 2017 +0900 summary: py3: remove use of str() in hgwebdir

The 'attrs' library is now available within Mercurial -- a better namedtuple

2017-10-01 Thread Siddharth Agarwal
Hi everyone -- The attrs library is now available to use within Mercurial as 'mercurial.thirdparty.attrs'. attrs is basically a better version of collections.namedtuple with none of the weird semantics (e.g. you can't compare a tuple and an attr) and no runtime performance cost (especially

D883: deb: build and install chg

2017-10-01 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0133ca39c688: deb: build and install chg (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D883?vs=2281=2291 REVISION DETAIL

D882: deb: install zsh completions to /usr/share/zsh/vendor-completions

2017-10-01 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9ecc622ca23f: deb: install zsh completions to /usr/share/zsh/vendor-completions (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D883: deb: build and install chg

2017-10-01 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. It's probably better to hook override_dh_auto_build, but we don't care the correctness of the Debian packaging. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL

D877: releasenotes: display release notes when no filename is specified

2017-10-01 Thread rishabhmadan96 (Rishabh Madan)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG159a6f7e09a9: releasenotes: display release notes when no filename is specified (authored by rishabhmadan96, committed by ). CHANGED PRIOR TO COMMIT

D541: effectflag: detect when diff changed

2017-10-01 Thread lothiraldan (Boris Feld)
lothiraldan marked an inline comment as done. lothiraldan added inline comments. INLINE COMMENTS > martinvonz wrote in obsutil.py:370-377 > Oops, I didn't mean to drop _prepare_hunk, I just don't like StopIteration > and wanted to make _getdifffiles() a generator instead and simplified a bit

D541: effectflag: detect when diff changed

2017-10-01 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 2287. lothiraldan marked 2 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D541?vs=2258=2287 REVISION DETAIL https://phab.mercurial-scm.org/D541 AFFECTED FILES mercurial/obsutil.py

D542: effectflag: document effect flag

2017-10-01 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 2288. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D542?vs=2259=2288 REVISION DETAIL https://phab.mercurial-scm.org/D542 AFFECTED FILES mercurial/obsutil.py CHANGE DETAILS diff --git a/mercurial/obsutil.py

D533: effectflag: store an empty effect flag for the moment

2017-10-01 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 2286. lothiraldan edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D533?vs=2104=2286 REVISION DETAIL https://phab.mercurial-scm.org/D533 AFFECTED FILES mercurial/obsolete.py

D872: releasenotes: add test showing TypeError with no file specified

2017-10-01 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Folded into https://phab.mercurial-scm.org/D877 since traceback message isn't reproducible. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D872 To:

D878: tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages)

2017-10-01 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d936da4f97b: tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D879: tests: add "have" check for dpkg builddeps

2017-10-01 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG13d3f8aaed87: tests: add have check for dpkg builddeps (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D879?vs=2265=2283

D875: hgweb: use parsebool for parsing diff query string options

2017-10-01 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG407ebe7a9b93: hgweb: use parsebool for parsing diff query string options (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D880: hgweb: remove extra

2017-10-01 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG689f6cdccef5: hgweb: remove extra /div (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D880?vs=2276=2284 REVISION DETAIL

D883: deb: build and install chg

2017-10-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D883 AFFECTED FILES contrib/debian/rules tests/test-debian-packages.t CHANGE DETAILS diff --git

D882: deb: install zsh completions to /usr/share/zsh/vendor-completions

2017-10-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This location is used by debian (and ubuntu) to store completions provided by other deb packages. The default fpath appears to have this before any of the

D875: hgweb: use parsebool for parsing diff query string options

2017-10-01 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > webutil.py:181 > +v = util.parsebool(v) > +setattr(diffopts, k, v if v is not None else True) > It might be better to ignore an invalid boolean,

D541: effectflag: detect when diff changed

2017-10-01 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > lothiraldan wrote in obsutil.py:370-377 > No that doesn't work because if you rebase a changeset, context would change > and the diff would be detected as different, that's why we call > `_prepare_hunk` Oops, I didn't mean to drop

mercurial@34357: new changeset

2017-10-01 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c41444a39de2 changeset: 34357:c41444a39de2 bookmark:@ tag: tip parent: 34350:f975cb7c4dbe user:Jun Wu date:Wed Sep 27 18:07:48 2017 -0700 summary: config: use copy-on-write

D877: releasenotes: display release notes when no filename is specified

2017-10-01 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. Can you also update the doc as a follow-up as it says `parse release notes from commit messages into an output file` which is not always the case now. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D877 To:

D880: hgweb: remove extra

2017-10-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was accidentally added in https://phab.mercurial-scm.org/rHG6797f1fbc6426c7ee691f3ee21610d33e4825c61. REPOSITORY rHG Mercurial REVISION DETAIL

D850: hgweb: add HTML elements to control whitespace settings for annotate

2017-10-01 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > map:352 > + > + ' Maybe extra ? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D850 To: indygreg, #hg-reviewers, simpkins, durin42 Cc: yuja, simpkins, mercurial-devel ___

D879: tests: add "have" check for dpkg builddeps

2017-10-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D879 AFFECTED FILES tests/hghave.py tests/test-debian-packages.t CHANGE DETAILS diff --git

D878: tests: expect parsers.so in cext, parsers.py in pure (test-debian-packages)

2017-10-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D878 AFFECTED FILES tests/test-debian-packages.t CHANGE DETAILS diff --git

D877: releasenotes: display release notes when no filename is specified

2017-10-01 Thread rishabhmadan96 (Rishabh Madan)
ph of fix 1. + > EOF + $ hg releasenote -r . - ** unknown exception encountered, please report by visiting - ** https://mercurial-scm.org/wiki/BugTracker - ** Python 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609] - ** Mercurial Distributed SCM (version 4.3.3+701-c4594d38b2da+20

D877: releasenotes: display release notes when no filename is specified

2017-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Apart from the nit, the patch looks good to me. INLINE COMMENTS > releasenotes.py:579 > > +if file_==None: > +return ui.write(serializenotes(sections, incoming)) nit: `if file is None` REPOSITORY rHG Mercurial REVISION DETAIL

D808: config: use copy-on-write to improve copy performance

2017-10-01 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > yuja wrote in config.py:180 > Perhaps we need preparewrite() here? This won't be problem as long as we parse/read file only once per config object, so accepted. Please send a follow up. REPOSITORY rHG Mercurial REVISION DETAIL

D874: hghave: check for debuild being installed as well

2017-10-01 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG200eadbcf0b0: hghave: check for debuild being installed as well (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 6 of 7] extdata: use subprocess so we don't have to chdir() manually

2017-10-01 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1506856376 -3600 # Sun Oct 01 12:12:56 2017 +0100 # Node ID b3a36705720f5ed1e7cc5129b27450ca59c7952b # Parent 88bc2465f1c9dd7c9a7f76eec68530b1a62f3794 extdata: use subprocess so we don't have to chdir() manually diff --git

[PATCH 3 of 7] templater: add experimental support for extdata

2017-10-01 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1506852789 -3600 # Sun Oct 01 11:13:09 2017 +0100 # Node ID 2b81a9a4752373722a9a568c7031dcf53171cc6b # Parent 2c9054ec242d781c0bda1d0d0ab0b26b5b93f012 templater: add experimental support for extdata This is minimal and

[PATCH 2 of 7] revset: add experimental support for extdata

2017-10-01 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1506851400 -3600 # Sun Oct 01 10:50:00 2017 +0100 # Node ID 2c9054ec242d781c0bda1d0d0ab0b26b5b93f012 # Parent 4bcad24c850624811d6f4d1aa6d982c01270d2fd revset: add experimental support for extdata This is minimal and

[PATCH 1 of 7] extdata: add extdatasource reader

2017-10-01 Thread Yuya Nishihara
# HG changeset patch # User Matt Mackall # Date 1473794045 18000 # Tue Sep 13 14:14:05 2016 -0500 # Node ID 4bcad24c850624811d6f4d1aa6d982c01270d2fd # Parent 8a89dfa01997bb3dd9e89aa167f2b28ed865e9fc extdata: add extdatasource reader This adds basic support for extdata, a

[PATCH 7 of 7] extdata: abort if external command exits with non-zero status

2017-10-01 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1506856910 -3600 # Sun Oct 01 12:21:50 2017 +0100 # Node ID 86c51cf6c4ff8a9a01e34e365c8fbc50415d072e # Parent b3a36705720f5ed1e7cc5129b27450ca59c7952b extdata: abort if external command exits with non-zero status It could be

[PATCH 4 of 7] extdata: ignore ambiguous identifier as well

2017-10-01 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1506855401 -3600 # Sun Oct 01 11:56:41 2017 +0100 # Node ID 18b0ae593fb5f391878567cd0f676c623847614e # Parent 2b81a9a4752373722a9a568c7031dcf53171cc6b extdata: ignore ambiguous identifier as well diff --git

[PATCH 5 of 7] extdata: just use iterator to read lines one by one

2017-10-01 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1506855507 -3600 # Sun Oct 01 11:58:27 2017 +0100 # Node ID 88bc2465f1c9dd7c9a7f76eec68530b1a62f3794 # Parent 18b0ae593fb5f391878567cd0f676c623847614e extdata: just use iterator to read lines one by one diff --git

D877: releasenotes: display release notes when no filename is specified

2017-10-01 Thread rishabhmadan96 (Rishabh Madan)
* Python 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609] - ** Mercurial Distributed SCM (version 4.3.3+701-c4594d38b2da+20171001) - ** Extensions loaded: releasenotes - Traceback (most recent call last): -File "/tmp/hgtests.5N93rp/install/bin/hg", line 47, in - disp

D541: effectflag: detect when diff changed

2017-10-01 Thread lothiraldan (Boris Feld)
lothiraldan marked 3 inline comments as done. lothiraldan added inline comments. INLINE COMMENTS > martinvonz wrote in obsutil.py:360 > I see this as an argument against storing it in the obsmarker. Can we remove > all shortcomings before it's no longer experimental? > > But, as I said before,

D865: obsmarker: fix crash when metadata fields are >255 bytes (issue5681)

2017-10-01 Thread ikostia (Kostia Balytskyi)
ikostia accepted this revision. ikostia added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D865 To: swhitaker, #hg-reviewers, ikostia Cc: pulkit, ikostia, mercurial-devel ___ Mercurial-devel mailing

D542: effectflag: document effect flag

2017-10-01 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 2259. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D542?vs=2113=2259 REVISION DETAIL https://phab.mercurial-scm.org/D542 AFFECTED FILES mercurial/obsutil.py CHANGE DETAILS diff --git a/mercurial/obsutil.py

D540: effectflag: detect when meta changed

2017-10-01 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 2257. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D540?vs=2111=2257 REVISION DETAIL https://phab.mercurial-scm.org/D540 AFFECTED FILES mercurial/obsutil.py tests/test-obsmarkers-effectflag.t CHANGE

D532: obsolete: clean createmarkers part about operation

2017-10-01 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 2256. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D532?vs=2233=2256 REVISION DETAIL https://phab.mercurial-scm.org/D532 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git

D865: obsmarker: fix crash when metadata fields are >255 bytes (issue5681)

2017-10-01 Thread swhitaker (Simon Whitaker)
swhitaker updated this revision to Diff 2255. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D865?vs=2229=2255 REVISION DETAIL https://phab.mercurial-scm.org/D865 AFFECTED FILES mercurial/obsolete.py tests/test-obsolete-bounds-checking.t CHANGE

D875: hgweb: use parsebool for parsing diff query string options

2017-10-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D875 AFFECTED FILES mercurial/hgweb/webcommands.py mercurial/hgweb/webutil.py CHANGE DETAILS diff

D873: releasenotes: raise error when no filename specified

2017-10-01 Thread rishabhmadan96 (Rishabh Madan)
rishabhmadan96 added a comment. In https://phab.mercurial-scm.org/D873#14703, @pulkit wrote: > Can't we just output the releasenotes using ui.write() if no file name is specified. I sometimes wanted to check what releasenotes my commit will produce and I needed to mention a file.

D867: thirdparty: vendor attrs

2017-10-01 Thread sid0 (Siddharth Agarwal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG765eb17a7eb8: thirdparty: vendor attrs (authored by sid0, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D867?vs=2244=2253 REVISION DETAIL

D871: python3: don't byte mangle third-party packages

2017-10-01 Thread sid0 (Siddharth Agarwal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9fb9f8440b71: python3: dont byte mangle third-party packages (authored by sid0, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D871?vs=2246=2251

D868: changelog: use attrs instead of namedtuple

2017-10-01 Thread sid0 (Siddharth Agarwal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe51c8ffa1ffa: changelog: use attrs instead of namedtuple (authored by sid0, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D868?vs=2232=2252#toc REPOSITORY rHG Mercurial

D866: tests: disable lints on mercurial/thirdparty

2017-10-01 Thread sid0 (Siddharth Agarwal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG41401f502c83: tests: disable lints on mercurial/thirdparty (authored by sid0, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D866?vs=2230=2250

D874: hghave: check for debuild being installed as well

2017-10-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D874 AFFECTED FILES tests/hghave.py CHANGE DETAILS diff --git a/tests/hghave.py b/tests/hghave.py

[Bug 5693] New: Allow running Ansible playbook on Vagrant environment without vault secrets

2017-10-01 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5693 Bug ID: 5693 Summary: Allow running Ansible playbook on Vagrant environment without vault secrets Product: Mercurial Version: unspecified Hardware: PC OS:

D873: releasenotes: raise error when no filename specified

2017-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Can't we just output the releasenotes using ui.write() if no file name is specified. I sometimes wanted to check what releasenotes my commit will produce and I needed to mention a file. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D873

D873: releasenotes: raise error when no filename specified

2017-10-01 Thread rishabhmadan96 (Rishabh Madan)
) [GCC 5.4.0 20160609] - ** Mercurial Distributed SCM (version 4.3.3+701-c4594d38b2da+20171001) - ** Extensions loaded: releasenotes - Traceback (most recent call last): -File "/tmp/hgtests.5N93rp/install/bin/hg", line 47, in - dispatch.run() -File "/tmp/hgtests.5N9

D872: releasenotes: add test showing TypeError with no file specified

2017-10-01 Thread rishabhmadan96 (Rishabh Madan)
-scm.org/wiki/BugTracker + ** Python 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609] + ** Mercurial Distributed SCM (version 4.3.3+701-c4594d38b2da+20171001) + ** Extensions loaded: releasenotes + Traceback (most recent call last): +File "/tmp/hgtests.5N93rp/install/bin/hg&q

D871: python3: don't byte mangle third-party packages

2017-10-01 Thread sid0 (Siddharth Agarwal)
sid0 updated this revision to Diff 2246. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D871?vs=2243=2246 REVISION DETAIL https://phab.mercurial-scm.org/D871 AFFECTED FILES mercurial/__init__.py CHANGE DETAILS diff --git a/mercurial/__init__.py

D785: context: also consider path conflicts when clearing unknown files

2017-10-01 Thread kiilerix (Mads Kiilerich)
kiilerix added inline comments. INLINE COMMENTS > test-pathconflicts-basic.t:38 >1 files updated, 0 files merged, 1 files removed, 0 files unresolved > + $ rm a~853701544ac3+ > I don't know about these `~hash` files, but including the `+` in the name definitely seems wrong. REPOSITORY

D867: thirdparty: vendor attrs

2017-10-01 Thread sid0 (Siddharth Agarwal)
sid0 updated this revision to Diff 2244. sid0 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D867?vs=2231=2244 REVISION DETAIL https://phab.mercurial-scm.org/D867 AFFECTED FILES mercurial/thirdparty/__init__.py

D871: python3: don't byte mangle third-party packages

2017-10-01 Thread sid0 (Siddharth Agarwal)
sid0 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Third-party packages are already expected to be dual-version clean. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D871 AFFECTED FILES

D865: obsmarker: fix crash when metadata fields are >255 bytes (issue5681)

2017-10-01 Thread ikostia (Kostia Balytskyi)
ikostia added a comment. That is why we raise `ProgrammingError`, not some sort of `UserError`. If your extension writes metadata longer than 255 chars, it is a bad extension. Your proposal is weird, because it is quietly modifying things, IMO this is much worse. I'd rather be forced to

D778: merge: backup conflicting directories when getting files

2017-10-01 Thread kiilerix (Mads Kiilerich)
kiilerix added inline comments. INLINE COMMENTS > merge.py:1175 > +absf = repo.wjoin(p) > +break > orig = scmutil.origpath(ui, repo, absf) This seems quite a bit slower. But I guess it never will happen in tight loops? If

[Bug 5692] New: Bundle seeking after interrupt behavior regressed

2017-10-01 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5692 Bug ID: 5692 Summary: Bundle seeking after interrupt behavior regressed Product: Mercurial Version: default branch Hardware: All OS: All Status: UNCONFIRMED

  1   2   >