D1601: clone: add support for storing remotenames while cloning

2017-12-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If `experimental.remotenames` is set to True, we store the remotenames in case of `hg pull`. This patch adds that support to clone command also. REPOSITORY rHG

[PATCH 1 of 2 evolve-ext V2] help: remove a few commands from `hg` (no args) command list

2017-12-05 Thread Kyle Lippincott via Mercurial-devel
# HG changeset patch # User Kyle Lippincott # Date 1512518930 28800 # Tue Dec 05 16:08:50 2017 -0800 # Node ID 21abe1e218b87428e4249e67990c345c63d521f6 # Parent 28fb347a5bf8cce93ebdfd0cc64a818e335804f9 help: remove a few commands from `hg` (no args) command list

[PATCH 2 of 2 evolve-ext V2] help: fix output for `hg help -e evolve` wrt 'touch' command

2017-12-05 Thread Kyle Lippincott via Mercurial-devel
# HG changeset patch # User Kyle Lippincott # Date 1512519068 28800 # Tue Dec 05 16:11:08 2017 -0800 # Node ID d584dfa21ea0bfa8a0fde0800978e8e682fa7544 # Parent 21abe1e218b87428e4249e67990c345c63d521f6 help: fix output for `hg help -e evolve` wrt 'touch' command

[PATCH evolve-ext] help: fix output for `hg help -e evolve` wrt 'touch' command

2017-12-05 Thread Kyle Lippincott via Mercurial-devel
# HG changeset patch # User Kyle Lippincott # Date 1512519068 28800 # Tue Dec 05 16:11:08 2017 -0800 # Node ID d584dfa21ea0bfa8a0fde0800978e8e682fa7544 # Parent 21abe1e218b87428e4249e67990c345c63d521f6 help: fix output for `hg help -e evolve` wrt 'touch' command

D1597: tests: write and use a custom helper script to avoid find's -printf

2017-12-05 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d172ca55d3b: tests: write and use a custom helper script to avoid finds -printf (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1526: rewriteutil: use precheck() in uncommit and amend commands

2017-12-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG98f97eb20597: rewriteutil: use precheck() in uncommit and amend commands (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D1526?vs=3901=4146#toc REPOSITORY

D1502: rewriteutil: add utility function to check if we can create new unstable cset

2017-12-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG27d5c2d2db2b: rewriteutil: add utility function to check if we can create new unstable cset (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1503: rewriteutil: add a precheck function to check if revs can be rewritten

2017-12-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG490df753894d: rewriteutil: add a precheck function to check if revs can be rewritten (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 3 of 3] repoview: include filter name in repr for debugging

2017-12-05 Thread Augie Fackler
On Tue, Dec 05, 2017 at 10:40:36PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1512478608 -32400 > # Tue Dec 05 21:56:48 2017 +0900 > # Node ID 298081d4ff9f22b3b996eee3a7008973933c2908 > # Parent

Re: [PATCH] thirdparty: move selectors2 module to where it should be

2017-12-05 Thread Augie Fackler
On Tue, Dec 05, 2017 at 10:40:11PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1512049383 -32400 > # Thu Nov 30 22:43:03 2017 +0900 > # Node ID ea7cb45b9606371ccd43418eb68ed99132f8c854 > # Parent

Re: [PATCH] setup: convert version strings to unicode on Python 3

2017-12-05 Thread Augie Fackler
On Tue, Dec 05, 2017 at 10:40:22PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1512477061 -32400 > # Tue Dec 05 21:31:01 2017 +0900 > # Node ID 5de6402805efd2451e6853f49098145d3d9d176f > # Parent

D1564: worker: make windows workers daemons

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added a comment. (specifically on https://phab.mercurial-scm.org/D1460?) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1564 To: wlis, #hg-reviewers, ikostia Cc: durin42, durham, ikostia, mercurial-devel ___

D1564: worker: make windows workers daemons

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added a comment. Is this missing a dependent revision annotation? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1564 To: wlis, #hg-reviewers, ikostia Cc: durin42, durham, ikostia, mercurial-devel ___

D1063: rebase: enable multidest by default

2017-12-05 Thread durin42 (Augie Fackler)
durin42 accepted this revision as: durin42. durin42 added a comment. I'm fine with this based on the reports that it's working well for FB. Anyone else have an objection? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1063 To: quark, #hg-reviewers, durin42 Cc:

D1354: dirstate: change all writes to dirstatemap._map to go through one method

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added a comment. Is this still relevant? Nobody's answered my question. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1354 To: mbolin, mbthomas, durham, #hg-reviewers Cc: durin42, mercurial-devel ___

D1458: workers: implemented worker on windows

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added a comment. Did you test this on a non-remotefilelog repo? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1458 To: wlis, #hg-reviewers Cc: durin42, indygreg, mercurial-devel ___ Mercurial-devel mailing

D1457: workers: don't use backgroundfilecloser in threads

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > vfs.py:420 > > -if backgroundclose: > +if backgroundclose and \ > +isinstance(threading.currentThread(), threading._MainThread): nit: wrap lines using () instead of \, eg if (backgroundclose and

D1551: remotenames: consider existing data while storing newer data

2017-12-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2ea6e42ed15e: remotenames: consider existing data while storing newer data (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1595: test-run-tests: do not rebuild hg in the test

2017-12-05 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2a99c5bfea47: test-run-tests: do not rebuild hg in the test (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1595?vs=4123=4143

D1549: remotenames: add test showing overwriting on remotenames data

2017-12-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG54bb94b715ad: remotenames: add test showing overwriting on remotenames data (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1547: remotenames: move function to pull remotenames from the remoterepo to core

2017-12-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5a62910948d2: remotenames: move function to pull remotenames from the remoterepo to core (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT

D1550: remotenames: add functions to read remotenames data from .hg/remotenames/

2017-12-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG744d1c874a59: remotenames: add functions to read remotenames data from .hg/remotenames/ (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1548: remotenames: add functionality to store remotenames under .hg/hgremotenames/

2017-12-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8df8ce2cc5dd: remotenames: add functionality to store remotenames under .hg/hgremotenames/ (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1591: visibility: improve the message when accessing filtered obsolete rev

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > test-log.t:1720 >$ hg log -r a >abort: hidden revision 'a'! > + (use --hidden to access hidden revisions; pruned) would it be better to put the verb in the abort top-line, isntead of the hint? that is: abort: hidden revision 'a' is

D1595: test-run-tests: do not rebuild hg in the test

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added a comment. nice find REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1595 To: quark, #hg-reviewers, durin42 Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D1551: remotenames: consider existing data while storing newer data

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm landing this series as-is, even though there are some good ideas for how we could improve the storage layer. My reasoning is this: we've had this as a semi-popular extension for literally years, it's functionality that we know is useful, and it'd be better to

D1547: remotenames: move function to pull remotenames from the remoterepo to core

2017-12-05 Thread durin42 (Augie Fackler)
durin42 added a comment. One nit that I will fix in flight. Thanks! INLINE COMMENTS > remotenames.py:3 > +# > +# Copyright 2017 Augie Fackler > +# Copyright 2017 Sean Farley Nit: my work on this code predates my time at Google. This should be

D1597: tests: write and use a custom helper script to avoid find's -printf

2017-12-05 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY -printf on find is a GNU-ism and will be banned in an upcoming check-code change. REPOSITORY rHG Mercurial REVISION DETAIL

D1599: tests: remove shell function helper from test-largefiles-misc

2017-12-05 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that all the complexity is in a Python script, we can just directly invoke the tool. REPOSITORY rHG Mercurial REVISION DETAIL

D1598: contrib: ban find(1)'s -printf operator, as it is a GNU-ism

2017-12-05 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1598 AFFECTED FILES contrib/check-code.py CHANGE DETAILS diff --git a/contrib/check-code.py

D1562: test: fix common-pattern for pure variant

2017-12-05 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf0445eea9b93: test: fix common-pattern for pure variant (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1592: test: fix bad replace for fixing pure-only build

2017-12-05 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4a6c51f5ae4d: test: fix bad replace for fixing pure-only build (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1595: test-run-tests: do not rebuild hg in the test

2017-12-05 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHGd600bda4a3e1ef0dea44c915a3d70f22212a4274 and https://phab.mercurial-scm.org/rHGfc0f3ed071fc3547c991dc6eb4ff03101a90d1fb added code

D1581: [RFC] rust: Rust implementation of `hg` and standalone packaging

2017-12-05 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > main.rs:101 > +fn set_python_home(env: ) { > +let raw = CString::new(env.python_home.to_str().unwrap()) > +.unwrap() Perhaps we'll need a utility function for platform-specific cstr conversion. On Unix, the story is simple. We can use

Re: [PATCH evolve-ext] typos: fix typos in several locations

2017-12-05 Thread Boris Feld
Pushed, thanks for the many fixes. On Mon, 2017-12-04 at 14:33 -0800, Kyle Lippincott via Mercurial-devel wrote: > # HG changeset patch > # User Kyle Lippincott > # Date 1512426447 28800 > #  Mon Dec 04 14:27:27 2017 -0800 > # Node ID

D1591: visibility: improve the message when accessing filtered obsolete rev

2017-12-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When trying to access filtered revision, it is likely because they have been obsoleted by an obs-marker. The current message shows how to access the

[PATCH 3 of 3] repoview: include filter name in repr for debugging

2017-12-05 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1512478608 -32400 # Tue Dec 05 21:56:48 2017 +0900 # Node ID 298081d4ff9f22b3b996eee3a7008973933c2908 # Parent 4c2ec6b9d65bd38a7ac9138241a42a2e60d0a605 repoview: include filter name in repr for debugging diff --git

[PATCH 1 of 3] repoview: do not include filter name in name of proxy class

2017-12-05 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1512477450 -32400 # Tue Dec 05 21:37:30 2017 +0900 # Node ID ac2f7bb76d318b3f32d83f4674d99a78bb3ea42b # Parent 5de6402805efd2451e6853f49098145d3d9d176f repoview: do not include filter name in name of proxy class The type

[PATCH] thirdparty: move selectors2 module to where it should be

2017-12-05 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1512049383 -32400 # Thu Nov 30 22:43:03 2017 +0900 # Node ID ea7cb45b9606371ccd43418eb68ed99132f8c854 # Parent 1b22d325089c9881dff3418ffc72d8c5c4ee24f5 thirdparty: move selectors2 module to where it should be diff --git

[PATCH 2 of 3] repoview: extract a factory function of proxy class

2017-12-05 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1512478233 -32400 # Tue Dec 05 21:50:33 2017 +0900 # Node ID 4c2ec6b9d65bd38a7ac9138241a42a2e60d0a605 # Parent ac2f7bb76d318b3f32d83f4674d99a78bb3ea42b repoview: extract a factory function of proxy class This makes sure that

[PATCH] setup: convert version strings to unicode on Python 3

2017-12-05 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1512477061 -32400 # Tue Dec 05 21:31:01 2017 +0900 # Node ID 5de6402805efd2451e6853f49098145d3d9d176f # Parent ea7cb45b9606371ccd43418eb68ed99132f8c854 setup: convert version strings to unicode on Python 3 Fixes the following

mercurial@35210: new changeset

2017-12-05 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/15d38e8fcb1e changeset: 35210:15d38e8fcb1e bookmark:@ tag: tip parent: 35209:9153871d50e0 parent: 35198:759234670d19 user:Augie Fackler date:Mon Dec 04 11:28:29 2017

D1584: python3: whitelist many more passing tests

2017-12-05 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG04a2820f2fca: python3: whitelist many more passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1584?vs=4099=4114

D1580: setup: only write some autogenerated files if they change

2017-12-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG61ff0d7d56fd: setup: only write some autogenerated files if they change (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D1580?vs=4089=4115#toc REPOSITORY

Re: [PATCH 2 of 5] tests: add a substitution for ENOENT/ERROR_FILE_NOT_FOUND messages

2017-12-05 Thread Yuya Nishihara
On Sun, 03 Dec 2017 12:07:59 -0500, Matt Harbison wrote: > On Sun, 03 Dec 2017 03:59:37 -0500, Yuya Nishihara wrote: > > > On Sun, 03 Dec 2017 01:54:55 -0500, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1512261214

D1580: setup: only write some autogenerated files if they change

2017-12-05 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > setup.py:499 > + > +content = ''.join([ > +'# this file is autogenerated by setup.py\n', Made it bytes and queued, thanks. REPOSITORY rHG Mercurial

Re: [PATCH 6 of 6] spartan: render changesets server-side on /graph page

2017-12-05 Thread Anton Shestakov
On Mon, 4 Dec 2017 21:46:55 -0800 Gregory Szorc wrote: > On Mon, Dec 4, 2017 at 1:28 PM, Augie Fackler wrote: > > > On Mon, Dec 04, 2017 at 08:40:43PM +0800, Anton Shestakov wrote: > > > # HG changeset patch > > > # User Anton Shestakov