[PATCH 2 of 7 V2] lfs: prefetch lfs blobs when applying merge updates

2018-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517711172 18000 # Sat Feb 03 21:26:12 2018 -0500 # Node ID 94d427f881cfca5cae792c5eac4bf00e942106ec # Parent ae7b40a6cb0863e26e245966388d766adf065bac lfs: prefetch lfs blobs when applying merge updates In addition

[PATCH 5 of 7 V2] archive: call the storage prefetch hook

2018-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517772692 18000 # Sun Feb 04 14:31:32 2018 -0500 # Node ID 4e8306a344c8660625a1a85e139fa4deded6b82c # Parent d5eedbdb4116e489915228341f9bde4922bd archive: call the storage prefetch hook diff --git

[PATCH 7 of 7 V2] lfs: deduplicate oids in the transfer

2018-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517779063 18000 # Sun Feb 04 16:17:43 2018 -0500 # Node ID 3693ddf8c5f6f50cdb3272929f40c48d0400beb3 # Parent 73ff18b27dd03449d99668148afc02894162a2ae lfs: deduplicate oids in the transfer Apparently, we can't rely

[PATCH 3 of 7 V2] cmdutil: convert _revertprefetch() to a generic stored file hook (API)

2018-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517771668 18000 # Sun Feb 04 14:14:28 2018 -0500 # Node ID ab23d9644edaf62b2c3927b735d2170fc76ca711 # Parent 94d427f881cfca5cae792c5eac4bf00e942106ec cmdutil: convert _revertprefetch() to a generic stored file hook

[PATCH 6 of 7 V2] cat: call the storage prefetch hook

2018-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517776009 18000 # Sun Feb 04 15:26:49 2018 -0500 # Node ID 73ff18b27dd03449d99668148afc02894162a2ae # Parent 4e8306a344c8660625a1a85e139fa4deded6b82c cat: call the storage prefetch hook It's not important to call in

[PATCH 1 of 7 V2] lfs: factor out a method for extracting the pointer of a single file

2018-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517082796 18000 # Sat Jan 27 14:53:16 2018 -0500 # Node ID ae7b40a6cb0863e26e245966388d766adf065bac # Parent 2912bed9b0c7d02a1cac6f56584c0c0a2f9debe4 lfs: factor out a method for extracting the pointer of a single

[PATCH 4 of 7 V2] lfs: prefetch lfs blobs during revert

2018-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1517722408 18000 # Sun Feb 04 00:33:28 2018 -0500 # Node ID d5eedbdb4116e489915228341f9bde4922bd # Parent ab23d9644edaf62b2c3927b735d2170fc76ca711 lfs: prefetch lfs blobs during revert The revert command oddly

[Bug 5781] New: "assert sf not in data['diverge']" error trying to graft a changeset that has file moves

2018-02-05 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5781 Bug ID: 5781 Summary: "assert sf not in data['diverge']" error trying to graft a changeset that has file moves Product: Mercurial Version: 4.4.2 Hardware: PC

D2057: translate base85.c into rust code

2018-02-05 Thread Ivzhh (Sheng Mao)
Ivzhh created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY - python extension to encode/decode base85 - add test suits to call encode/decode base85 in rust-/python- convention - add proper python

D2036: sshpeer: remove support for connecting to <0.9.1 servers (BC)

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5237. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2036?vs=5231=5237 REVISION DETAIL https://phab.mercurial-scm.org/D2036 AFFECTED FILES mercurial/sshpeer.py tests/test-ssh-proto.t CHANGE DETAILS diff

D2034: sshpeer: move handshake outside of sshpeer

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5235. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2034?vs=5229=5235 REVISION DETAIL https://phab.mercurial-scm.org/D2034 AFFECTED FILES mercurial/sshpeer.py tests/sshprotoext.py

D2035: sshpeer: document the handshake mechanism

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5236. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2035?vs=5230=5236 REVISION DETAIL https://phab.mercurial-scm.org/D2035 AFFECTED FILES mercurial/sshpeer.py CHANGE DETAILS diff --git a/mercurial/sshpeer.py

D2031: sshpeer: establish SSH connection before class instantiation

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5232. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2031?vs=5189=5232 REVISION DETAIL https://phab.mercurial-scm.org/D2031 AFFECTED FILES mercurial/sshpeer.py

D2032: sshpeer: clean up API for sshpeer.__init__ (API)

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5233. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2032?vs=5190=5233 REVISION DETAIL https://phab.mercurial-scm.org/D2032 AFFECTED FILES mercurial/sshpeer.py tests/test-check-interfaces.py CHANGE DETAILS

D1979: tests: fold narrow treemanifest tests into main test file using testcases

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Very nice. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1979 To: durin42, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel

D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg added a comment. OK. I've now looked at all the Python code. I haven't yet spent much time on tests. But the amount of tests is encouraging. I did glance over some of the complicated parts of the Python. Namely some of the algorithms around changegroup and bundle semantics. I

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-05 Thread spectral (Kyle Lippincott)
spectral added a comment. In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > I wonder if we should instead have a --draft option for this. Reasons: > > - If we ever add a fourth phase (like Jun's proposed "archived" phase), then --no-secret doesn't clearly indicate

mercurial@35914: 11 new changesets

2018-02-05 Thread Mercurial Commits
11 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/fc44c2657dc5 changeset: 35904:fc44c2657dc5 user:Yuya Nishihara date:Sat Jan 27 17:46:37 2018 +0900 summary: py3: drop b'' from repr() of smartset

Re: [PATCH] makefile: remove Ubuntu Yakkety and Zesty docker targets

2018-02-05 Thread Gregory Szorc
On Mon, Feb 5, 2018 at 5:23 AM, Yuya Nishihara wrote: > On Mon, 05 Feb 2018 18:48:00 +0800, Anton Shestakov wrote: > > # HG changeset patch > > # User Anton Shestakov > > # Date 1517827181 -28800 > > # Mon Feb 05 18:39:41 2018 +0800 > > # Node ID

D2033: sshpeer: inline I/O into _validaterepo()

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5228. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2033?vs=5191=5228 REVISION DETAIL https://phab.mercurial-scm.org/D2033 AFFECTED FILES mercurial/sshpeer.py tests/sshprotoext.py CHANGE DETAILS diff --git

D2026: tests: add low-level SSH protocol tests

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5227. indygreg marked 2 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2026?vs=5184=5227 REVISION DETAIL https://phab.mercurial-scm.org/D2026 AFFECTED FILES tests/sshprotoext.py

D2035: sshpeer: document the handshake mechanism

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5230. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2035?vs=5193=5230 REVISION DETAIL https://phab.mercurial-scm.org/D2035 AFFECTED FILES mercurial/sshpeer.py CHANGE DETAILS diff --git a/mercurial/sshpeer.py

D2036: sshpeer: remove support for connecting to <0.9.1 servers (BC)

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5231. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2036?vs=5194=5231 REVISION DETAIL https://phab.mercurial-scm.org/D2036 AFFECTED FILES mercurial/sshpeer.py tests/test-ssh-proto.t CHANGE DETAILS diff

D2034: sshpeer: move handshake outside of sshpeer

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5229. indygreg marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2034?vs=5192=5229 REVISION DETAIL https://phab.mercurial-scm.org/D2034 AFFECTED FILES mercurial/sshpeer.py

D2034: sshpeer: move handshake outside of sshpeer

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg marked an inline comment as done. indygreg added inline comments. INLINE COMMENTS > lothiraldan wrote in sshpeer.py:422 > Nit: Could the except block could be replaced by a finally block? No, because the pipes are used for the remainder of the connection. I would like to switch peers

D2026: tests: add low-level SSH protocol tests

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg marked 2 inline comments as done. indygreg added inline comments. INLINE COMMENTS > lothiraldan wrote in test-ssh-proto.t:114 > Is the SSHSERVERMODE needed here? Yes. `dummyssh` will run `hg serve --stdio` and that process needs to inherit the environment variable so it ignores the

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > I wonder if we should instead have a --draft option for this. Reasons: > > - If we ever add a fourth phase (like Jun's proposed "archived" phase), then --no-secret doesn't clearly indicate

D2003: util: extract all date-related utils in utils/dateutil module

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan abandoned this revision. lothiraldan added a comment. I updated the series with copying util.py to utils/dateutil.py. I've also added the deprecation warnings but I'm not sure how to add deprecation warnings for variables. I also splitted the change as copying util.py

D2055: util: extract parsedate

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extract parsedate from util.py to utils/dateutil.py REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2055 AFFECTED FILES

D2051: util: extract datestr

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extract datestr from util.py to utils/dateutil.py REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2051 AFFECTED FILES

D2054: util: extract strdate

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extract strdate from util.py to utils/dateutil.py REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2054 AFFECTED FILES

D2056: util: extract matchdate

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extract matchdate from util.py to utils/dateutil.py After this commit, util.py losed 313 lines REPOSITORY rHG Mercurial REVISION DETAIL

D2050: util: extract makedate

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extract makedate from util.py to utils/dateutil.py REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2050 AFFECTED FILES

D2053: util: extract parsetimezone

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extract parsetimezone from util.py to utils/dateutil.py REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2053 AFFECTED FILES

D2052: util: extract shortdate

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extract shortdate from util.py to utils/dateutil.py REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2052 AFFECTED FILES

D2049: util: extract defaultdateformats and extendeddateformats

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Extract defaultdateformats and extendeddateformats from util.py to utils/dateutil.py REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH 3 of 3] lfs: prefetch lfs blobs during revert

2018-02-05 Thread Yuya Nishihara
On Mon, 05 Feb 2018 09:08:22 -0500, Matt Harbison wrote: > On Mon, 05 Feb 2018 08:51:47 -0500, Yuya Nishihara wrote: > > It might be better to provide a single hook point for prefetching, > > because > > it isn't a trivial task to parse merge actions into a list of files. > >

D2044: py3: use open() instead of file()

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe35616bb6ede: py3: use open() instead of file() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2044?vs=5202=5215 REVISION

D2046: py3: add b'' to literals in check-config.py

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2912bed9b0c7: py3: add b to literals in check-config.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2046?vs=5204=5217

D2042: py3: add __bytes__() for mq.patchheader and make sure __str__ returns str

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd41e41d11574: py3: add __bytes__() for mq.patchheader and make sure __str__ returns str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2045: check-config: specify the mode 'rb' to open the file

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG143d7b27b09c: check-config: specify the mode rb to open the file (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2041: py3: use "%d" to convert integer to bytes

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG83b9f96ce20f: py3: use %d to convert integer to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2041?vs=5199=5212

D2043: py3: use pycompat.strkwargs() to convert kwargs' key to str

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d8b0020f470: py3: use pycompat.strkwargs() to convert kwargs key to str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2040: py3: use .startswith() instead of bytes[0]

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7a991241f586: py3: use .startswith() instead of bytes[0] (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2040?vs=5198=5211

D2039: py3: slice on bytes to prevent getting the ascii values

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG558e01a23f40: py3: slice on bytes to prevent getting the ascii values (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2023: cmdutil: introduce deprecated aliases

2018-02-05 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb82c6dd15f5d: cmdutil: introduce deprecated aliases (authored by lothiraldan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2023?vs=5180=5207#toc REPOSITORY rHG Mercurial

D2037: py3: add b'' to tweakdefualts config string

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG704095e27c5c: py3: add b to tweakdefaults config string (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2037?vs=5195=5208

D2038: py3: add r'' to convert keys to keyword arguments to str

2018-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG78b985c75731: py3: add r to convert keys to keyword arguments to str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2038: py3: add r'' to convert keys to keyword arguments to str

2018-02-05 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, but perhaps we should stop using `**{...}` since we no longer need to support Python 2.5. `*args, opt=...` should work. https://docs.python.org/2/whatsnew/2.6.html#other-language-changes REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH 3 of 3] lfs: prefetch lfs blobs during revert

2018-02-05 Thread Matt Harbison
On Mon, 05 Feb 2018 08:51:47 -0500, Yuya Nishihara wrote: On Sun, 04 Feb 2018 01:18:25 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1517722408 18000 # Sun Feb 04 00:33:28 2018 -0500 # Node ID

D2003: util: extract all date-related utils in utils/dateutil module

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 5205. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2003?vs=5153=5205 REVISION DETAIL https://phab.mercurial-scm.org/D2003 AFFECTED FILES contrib/synthrepo.py hgext/blackbox.py hgext/churn.py

D2047: util: prepare a new utils package

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Brace yourself, the util module is gonna be splitted. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2047 AFFECTED FILES

Re: [PATCH 2 of 3] lfs: prefetch lfs blobs when applying merge updates

2018-02-05 Thread Matt Harbison
On Mon, 05 Feb 2018 08:44:50 -0500, Yuya Nishihara wrote: On Sun, 04 Feb 2018 01:18:24 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1517711172 18000 # Sat Feb 03 21:26:12 2018 -0500 # Node ID

Re: [PATCH evolve-ext] compat: add wrapper for logcmdutil functions

2018-02-05 Thread Feld Boris
We've taken it, thanks! (We moved it to stable in the process). On 05/02/2018 13:28, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1517831926 -32400 # Mon Feb 05 20:58:46 2018 +0900 # Node ID cc46c32da6b0e9aed1d50aa0596353365213eec3 # Parent

D2023: cmdutil: introduce deprecated aliases

2018-02-05 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Seems fine, queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2023 To: lothiraldan, #hg-reviewers, yuja Cc: yuja, mercurial-devel

Re: [PATCH 2 of 3] lfs: prefetch lfs blobs when applying merge updates

2018-02-05 Thread Yuya Nishihara
On Sun, 04 Feb 2018 01:18:24 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1517711172 18000 > # Sat Feb 03 21:26:12 2018 -0500 > # Node ID e779b0c34d6989e45cabbf8da8cdfeb060134dbd > # Parent

Re: [PATCH 3 of 3] lfs: prefetch lfs blobs during revert

2018-02-05 Thread Yuya Nishihara
On Sun, 04 Feb 2018 01:18:25 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1517722408 18000 > # Sun Feb 04 00:33:28 2018 -0500 > # Node ID 702a3c1d6335cd8f7cf7916029e10e22691e3091 > # Parent

Re: [PATCH] makefile: remove Ubuntu Yakkety and Zesty docker targets

2018-02-05 Thread Yuya Nishihara
On Mon, 05 Feb 2018 18:48:00 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1517827181 -28800 > # Mon Feb 05 18:39:41 2018 +0800 > # Node ID d5509e242b927dbee808e4d62a7f10b3a5c406cf > # Parent

D2037: py3: add b'' to tweakdefualts config string

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. Nit small typo in the commit description first line: s/tweakdefualts/tweakdefaults REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2037 To: pulkit, #hg-reviewers Cc: lothiraldan, mercurial-devel

D2034: sshpeer: move handshake outside of sshpeer

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > sshpeer.py:175 > + > +requestlog = ui.configbool('devel', 'debug.peer-request') > + Nit that could be outside of the try: Except: > sshpeer.py:422 > +_cleanuppipes(ui, pipei, pipeo, pipee) > +raise > + Nit: Could the

D2026: tests: add low-level SSH protocol tests

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > test-ssh-proto.t:114 > + > + $ SSHSERVERMODE=no-hello hg --debug debugpeer ssh://user@dummy/server > + running * "*/tests/dummyssh" 'user@dummy' 'hg -R server serve --stdio' > (glob) Is the SSHSERVERMODE needed here? >

[PATCH evolve-ext] compat: add wrapper for logcmdutil functions

2018-02-05 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517831926 -32400 # Mon Feb 05 20:58:46 2018 +0900 # Node ID cc46c32da6b0e9aed1d50aa0596353365213eec3 # Parent 7f646d98858ef02e7ec536aff260be21a0eeebe4 compat: add wrapper for logcmdutil functions These classes and functions

[PATCH 1 of 2] ui: write prompt text in ui.prompt(), not in ui._readline()

2018-02-05 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517830849 -32400 # Mon Feb 05 20:40:49 2018 +0900 # Node ID 9be8a0f8d48502734066a66e3d5b9b22e460ae70 # Parent a9802c9ecfb5aa20d89480763ae15b03f78f3a88 ui: write prompt text in ui.prompt(), not in ui._readline() self.label()

[PATCH 2 of 2] ui: add explicit path to write prompt text bypassing buffers

2018-02-05 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1517831331 -32400 # Mon Feb 05 20:48:51 2018 +0900 # Node ID 59869758acd7b38d9de045d5a72f5196cc80f047 # Parent 9be8a0f8d48502734066a66e3d5b9b22e460ae70 ui: add explicit path to write prompt text bypassing buffers The prompt=

[PATCH] makefile: remove Ubuntu Yakkety and Zesty docker targets

2018-02-05 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1517827181 -28800 # Mon Feb 05 18:39:41 2018 +0800 # Node ID d5509e242b927dbee808e4d62a7f10b3a5c406cf # Parent ed3a7300b7b5a427bdcffefd0c80aab65824bf4b makefile: remove Ubuntu Yakkety and Zesty docker targets Yakkety

D2045: check-config: specify the mode 'rb' to open the file

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2045 AFFECTED FILES contrib/check-config.py CHANGE DETAILS diff --git a/contrib/check-config.py

D2044: py3: use open() instead of file()

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY file() is not present in Python 3 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2044 AFFECTED FILES hgext/mq.py CHANGE DETAILS

D2046: py3: add b'' to literals in check-config.py

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we are just adding b'' REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2046 AFFECTED FILES

D2041: py3: use "%d" to convert integer to bytes

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2041 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py b/hgext/rebase.py ---

D2042: py3: add __bytes__() for mq.patchheader and make sure __str__ returns str

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, __str__() function for mq.patchheader class return bytes which is not str on Python 3. So let's move that logic to __bytes__() and for

D2040: py3: use .startswith() instead of bytes[0]

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2040 AFFECTED FILES mercurial/revset.py CHANGE DETAILS diff --git a/mercurial/revset.py

D2043: py3: use pycompat.strkwargs() to convert kwargs' key to str

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2043 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py b/hgext/rebase.py ---

D2038: py3: add r'' to convert keys to keyword arguments to str

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame as we are just adding r'' REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2038 AFFECTED FILES hgext/shelve.py CHANGE

D2037: py3: add b'' to tweakdefualts config string

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The tweakdefaults config string is enclosed inside triple quotes and the transformer does not adds b'' there. 1. skip-blame because we are just adding b''

D2039: py3: slice on bytes to prevent getting the ascii values

2018-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2039 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py