D2967: context: avoid using a context object as a changeid

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Oh wow. Thanks for cleaning this up. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2967 To: martinvonz, #hg-reviewers, indygreg Cc: indygreg,

D2933: repository: define interface for local repositories

indygreg marked 2 inline comments as done. indygreg added inline comments. INLINE COMMENTS > durin42 wrote in repository.py:273 > I'm unclear: are all the methods supposed to be abstract, or are some of them > default implementations? In `zope.interface`, the interface declaration is its own

mercurial@37155: 54 new changesets

54 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/638a241202a3 changeset: 37102:638a241202a3 user:Yuya Nishihara date:Thu Mar 15 21:49:33 2018 +0900 summary: templater: add hook point to populate additional mapping items

D1954: bundle: add the possibility to bundle a stream v2 part

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6f467adf9f05: bundle: add the possibility to bundle a stream v2 part (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1957: streamclonebundle: make sure we accept new stream clone bundle spec

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb837655c1509: streamclonebundle: make sure we accept new stream clone bundle spec (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1955: bundlespec: add support for some variants

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2b350d9f6ae: bundlespec: add support for some variants (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1956: streamclonebundle: add a test for stream clone bundle v2

This revision was automatically updated to reflect the committed changes. Closed by commit rHG99f28a4b2a3a: streamclonebundle: add a test for stream clone bundle v2 (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1952: bundlespec: move computing the bundle contentops in parsebundlespec

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6c7a6b04b274: bundlespec: move computing the bundle contentops in parsebundlespec (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2971: bundlespec: introduce an attr-based class for bundlespec

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb229fd9adeae: bundlespec: introduce an attr-based class for bundlespec (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1953: streambundlev2: add a new test-file

This revision was automatically updated to reflect the committed changes. Closed by commit rHG568e9b928c4c: streambundlev2: add a new test-file (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1953?vs=7375=7384

D1952: bundlespec: move computing the bundle contentops in parsebundlespec

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Thanks for following up. This looks great! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1952 To: lothiraldan, #hg-reviewers, indygreg Cc: indygreg,

Re: [PATCH 7 of 7] templater: factor out unwrapastype() from evalastype()

On Sun, Mar 25, 2018 at 02:15:54PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1521805435 -32400 > # Fri Mar 23 20:43:55 2018 +0900 > # Node ID bcfa34ae805b92d3c9d32c8bed19c6432ba44120 > # Parent

D2904: templatefuncs: add mailmap template function

sheehan updated this revision to Diff 7381. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2904?vs=7361=7381 REVISION DETAIL https://phab.mercurial-scm.org/D2904 AFFECTED FILES mercurial/templatefuncs.py mercurial/utils/stringutil.py

D2964: context: change default changeid from old form '' to '.'

martinvonz added inline comments. INLINE COMMENTS > yuja wrote in context.py:65 > Nit: one more `changeid=''` here. Good catch. I found this one while working on the next series, so it will get fixed then. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2964 To:

D1954: bundle: add the possibility to bundle a stream v2 part

lothiraldan updated this revision to Diff 7376. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1954?vs=5152=7376 REVISION DETAIL https://phab.mercurial-scm.org/D1954 AFFECTED FILES mercurial/bundle2.py mercurial/exchange.py CHANGE DETAILS diff

D1952: bundlespec: move computing the bundle contentops in parsebundlespec

lothiraldan updated this revision to Diff 7374. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1952?vs=5151=7374 REVISION DETAIL https://phab.mercurial-scm.org/D1952 AFFECTED FILES hgext/lfs/__init__.py mercurial/bundle2.py mercurial/commands.py

D2960: stringutil: move person function from templatefilters

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfb7140f1d09d: stringutil: move person function from templatefilters (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2960?vs=7360=7380#toc REPOSITORY

D2959: stringutil: add isauthorwellformed function

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf8e1f48de118: stringutil: add isauthorwellformed function (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2959?vs=7359=7379#toc REPOSITORY rHG

D1957: streamclonebundle: make sure we accept new stream clone bundle spec

lothiraldan updated this revision to Diff 7378. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1957?vs=5029=7378 REVISION DETAIL https://phab.mercurial-scm.org/D1957 AFFECTED FILES mercurial/exchange.py tests/test-stream-bundle-v2.t CHANGE DETAILS

D1953: streambundlev2: add a new test-file

lothiraldan updated this revision to Diff 7375. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1953?vs=5025=7375 REVISION DETAIL https://phab.mercurial-scm.org/D1953 AFFECTED FILES tests/test-stream-bundle-v2.t CHANGE DETAILS diff --git

D1955: bundlespec: add support for some variants

lothiraldan updated this revision to Diff 7377. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1955?vs=5027=7377 REVISION DETAIL https://phab.mercurial-scm.org/D1955 AFFECTED FILES mercurial/exchange.py tests/test-stream-bundle-v2.t CHANGE DETAILS

D2971: bundlespec: introduce an attr-based class for bundlespec

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We will add support of contentops in the next patch, introduce a class instead of returning a 4-items tuple. REPOSITORY rHG Mercurial REVISION DETAIL

D2904: templatefuncs: add mailmap template function

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > templatefuncs.py:186 > + > +if not repo.wvfs.exists('.mailmap'): > +return author Nit: `.exists()` isn't needed. `tryread()` handles it. >

D2960: stringutil: move person function from templatefilters

yuja added a comment. Queued, thanks. I've adjusted the location of codes so the author-related functions are grouped. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2960 To: sheehan, #hg-reviewers, av6, yuja Cc: av6, mercurial-devel

D2969: context: move reuse of context object to repo.__getitem__ (API)

yuja added subscribers: smf, yuja. yuja added a comment. +1, but I don't remember why we made that hack. @smf Any thoughts? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2969 To: martinvonz, #hg-reviewers Cc: yuja, smf, mercurial-devel

D2964: context: change default changeid from old form '' to '.'

yuja added inline comments. INLINE COMMENTS > context.py:65 > be committed.""" > def __new__(cls, repo, changeid='', *args, **kwargs): > if isinstance(changeid, basectx): Nit: one more `changeid=''` here. REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH 5 of 6] lfs: add support for serving blob files

On Thu, 29 Mar 2018 23:26:03 -0400, Matt Harbison wrote: > >> elif method == b'GET': > >> checkperm('pull') > >> > >> -return False > >> +res.status = hgwebcommon.statusmessage(HTTP_OK) > >> +res.headers[b'Content-Type'] = b'application/octet-stream' > >> + > >> +

Re: [PATCH 1 of 2] server: add an error feedback mechanism for when the daemon fails to launch

On Thu, 29 Mar 2018 23:04:39 -0400, Matt Harbison wrote: > On Thu, 29 Mar 2018 07:26:04 -0400, Yuya Nishihara wrote: > > > On Wed, 28 Mar 2018 22:45:30 -0400, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1522210269

Re: [PATCH V3] test-lfs-test-server: add a testcase for `hg serve`

On Thu, 29 Mar 2018 22:50:52 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1521268666 14400 > # Sat Mar 17 02:37:46 2018 -0400 > # Node ID 2c5755e3d9832cba3dd46b4eb296b5733ce10dfe > # Parent

D2965: push: use "repo['.']" instead of old form "repo['']"

martinvonz updated this revision to Diff 7367. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2965?vs=7365=7367 REVISION DETAIL https://phab.mercurial-scm.org/D2965 AFFECTED FILES mercurial/commands.py mercurial/subrepo.py CHANGE DETAILS diff

D2969: context: move reuse of context object to repo.__getitem__ (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As an example of how weird the basectx.__new__ is: whenever you create a workingctx, basectx.__new__ gets called first. Since our __new__ has a "changeid"

D2968: memctx: create parent contexts using "repo[p]" syntax

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I want to reduce dependence on basectx.__new__() and move that code over to repo.__getitem__(). REPOSITORY rHG Mercurial REVISION DETAIL

D2970: context: set repo property in basectx

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems like a good practice to call the super constructor. Let's start by passing the repo along to basectx so it can assign it to a private attribute. We

D2967: context: avoid using a context object as a changeid

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I find it misleading to pass changeid=changectx. It currently works to do that because there's weird (IMO) handling of it in basectx.__new__. I'm planning on

D2966: context: remove unwanted assignments in basectx.__new__() (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The two subclasses in core apparently didn't trust __new__() to do the job anyway (they both reassigned all the properties after). REPOSITORY rHG Mercurial

<    1   2