D3027: debugcommands: drop base revision from debugindex

indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Revlog index data consists of generic index metadata that will likely be implemented across all storage engines and

D3028: debugcommands: drop offset and length from debugindex by default

indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These fields are an implementation detail of revlog storage. As such, they are not part of the generic storage "index"

D3030: tests: conditionalize tests based on presence of revlogs for files

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY ~85 tests don't like our non-revlog file store for various reasons. This commit introduces hghave functionality for declaring and querying repository

D3025: tests: don't use revlog paths in tests

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Debug commands operating on revlogs don't need the full revlog path: they can accept the relative path to a tracked file or use -c/-m to specify a changelog or

D3026: tests: use debugdeltachain where appropriate

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some tests are verifying delta chain type things. This metadata has more to do with a revlog implementation details than index data, which is theoretically

D3029: tests: add test extension implementing custom filelog storage

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In order to better support partial clones, we'll need alternate repository storage mechanisms that aren't based on revlogs. Today, the interface for

D2988: fix: use a portable python script instead of sed in test

durin42 added a comment. In https://phab.mercurial-scm.org/D2988#48864, @mharbison72 wrote: > I'm not sure what the state of this is (`hg phabread` failed for 3022 and 3023), but this works on Windows. I've got a separate patch to fix the printfs (which doesn't help the {rootpath}

D2988: fix: use a portable python script instead of sed in test

hooper added a comment. In https://phab.mercurial-scm.org/D2988#48864, @mharbison72 wrote: > I'm not sure what the state of this is (`hg phabread` failed for 3022 and 3023), but this works on Windows. I've got a separate patch to fix the printfs (which doesn't help the {rootpath} issue

D2988: fix: use a portable python script instead of sed in test

mharbison72 added a subscriber: durin42. mharbison72 added a comment. I'm not sure what the state of this is (`hg phabread` failed for 3022 and 3023), but this works on Windows. I've got a separate patch to fix the printfs (which doesn't help the {rootpath} issue I mentioned). In

Re: [PATCH 1 of 8] rust-hglib: import the latest version and update URLs

On Mon, Apr 2, 2018 at 5:53 PM, Kevin Bullock < kbullock+mercur...@ringworld.org> wrote: > > On Apr 1, 2018, at 13:53, Gregory Szorc wrote: > > > > On Sun, Apr 1, 2018 at 4:14 AM, Yuya Nishihara wrote: > > # HG changeset patch > > # User Kevin Bullock

D3024: scmutil: add method for looking up a context given a revision symbol

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY changectx's constructor currently supports a mix if inputs: - integer revnums - binary nodeids - '.', 'tip', 'null' - stringified revnums -

D3000: addremove: remove dry_run, similarity from scmutil.addremove

khanchi97 updated this revision to Diff 7524. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3000?vs=7523=7524 REVISION DETAIL https://phab.mercurial-scm.org/D3000 AFFECTED FILES contrib/perf.py hgext/largefiles/overrides.py mercurial/commands.py

D3000: addremove: remove dry_run, similarity from scmutil.addremove

khanchi97 updated this revision to Diff 7523. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3000?vs=7500=7523 REVISION DETAIL https://phab.mercurial-scm.org/D3000 AFFECTED FILES contrib/perf.py hgext/largefiles/overrides.py mercurial/commands.py

D2988: fix: use a portable python script instead of sed in test

hooper updated this revision to Diff 7522. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2988?vs=7451=7522 REVISION DETAIL https://phab.mercurial-scm.org/D2988 AFFECTED FILES tests/test-fix-topology.t tests/test-fix.t CHANGE DETAILS diff --git

D2988: fix: use a portable python script instead of sed in test

hooper added a comment. > - subprocess: /usr/bin/python $TESTTMP/uppercase.py 1-1 3-3 + subprocess: c:/Python27/python.exe $TESTTMP/uppercase.py 1-1 3-3 I had wondered if there's a reason we don't substitute $PYTHON like we do $TESTTMP? The glob makes the test a little weaker. >

D3023: fix: use a portable python script instead of sed in test

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3023 AFFECTED FILES tests/test-fix-topology.t tests/test-fix.t CHANGE DETAILS diff --git

D3022: fix: use a portable python script instead of sed in test

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3022 AFFECTED FILES tests/test-fix-topology.t tests/test-fix.t CHANGE DETAILS diff --git

D3016: clone: rename "rev" to "revs" since there can be many

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbb7523115e5: clone: rename rev to revs since there can be many (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3018: revset: drop support for '' as alias for '.'

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe387d8073f22: revset: drop support for as alias for . (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3018?vs=7509=7516

D3019: subrepo: use repo['.'] instead of repo['']

This revision was automatically updated to reflect the committed changes. Closed by commit rHG78e9e63c13f5: subrepo: use repo[.] instead of repo[] (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3019?vs=7510=7518

D3021: context: drop support for changeid='' (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG21811e4643ea: context: drop support for changeid= (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3021?vs=7512=7519

D3015: parseurl: consistently call second output "branches"

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdab71fa7bc2f: parseurl: consistently call second output branches (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3020: children: : use repo['.'] instead of repo['']

This revision was automatically updated to reflect the committed changes. Closed by commit rHG802c03975ab3: children: use repo[.] instead of repo[] (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3020?vs=7511=7517

D3017: tests: add test showing current parse of empty string symbol in revset

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0dbc6f37c8fc: tests: add test showing current parse of empty string symbol in revset (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3020: children: : use repo['.'] instead of repo['']

pulkit added a comment. Edited commit message of this one to removed extra ': '. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3020 To: martinvonz, #hg-reviewers, pulkit Cc: mercurial-devel ___ Mercurial-devel

D3019: subrepo: use repo['.'] instead of repo['']

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The "state" value (a revision) passed to abstractsubrepo.phase() can be '' to represent the currently checked out revisions. Let's convert that to the more

D3021: context: drop support for changeid='' (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since the previous commit, there seem to be no users who pass '' to repo.__getitem__, so let's drop support for it. It may seem like a small cost to keep

D3018: revset: drop support for '' as alias for '.'

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Not marked BC because I think support for using '' on the CLI was there by accident, and we don't seem to have documented it. REPOSITORY rHG Mercurial

D3020: children: : use repo['.'] instead of repo['']

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3020 AFFECTED FILES hgext/children.py CHANGE DETAILS diff --git a/hgext/children.py

D3017: tests: add test showing current parse of empty string symbol in revset

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We support e.g. parents(""), but I think that's by accident and I'll change it soon. REPOSITORY rHG Mercurial REVISION DETAIL

D3016: clone: rename "rev" to "revs" since there can be many

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It was a little tricky in hg.clone(), since there was a local "revs" variable defined there, but "rev" was never used after "revs", so I just overwrote it.

D3015: parseurl: consistently call second output "branches"

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3015 AFFECTED FILES hgext/histedit.py mercurial/hg.py CHANGE

D3000: addremove: remove dry_run, similarity from scmutil.addremove

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Other than that, the patch looks good to me. Thanks! INLINE COMMENTS > perf.py:426 > matcher = scmutil.match(repo[None]) > -timer(lambda: scmutil.addremove(repo,

Re: [PATCH 1 of 8] rust-hglib: import the latest version and update URLs

On Sun, 1 Apr 2018 11:53:47 -0700, Gregory Szorc wrote: > Also, Kevin Kox has been giving good Rust reviews. But I believe they are > only active in Phabricator. Consider submitting futures Rust patches to > Phabricator or CC'ing Kevin explicitly. Ok, thanks. *a big sigh*

Re: [PATCH 1 of 8] templater: pass context down to unwraphybrid()

On Sun, 01 Apr 2018 11:45:58 +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1521284945 -32400 > # Sat Mar 17 20:09:05 2018 +0900 > # Node ID 529838f7858556c0f9d180a276b483578c6d55d4 > # Parent 02079695afdd39020b13f238c69691dce14b932f >