D3146: context: move handling of stringified ints to revsymbol (API)

martinvonz planned changes to this revision. martinvonz added a comment. I should decide what to do about the `changeid == repo.dirstate.p1()` case before this patch. Also, I may find more cases that should be fixed when I move out other parts (I just found one case in hgweb), so please hold

D3150: revlog: move parsemeta() and packmeta() from filelog (API)

indygreg updated this revision to Diff 7769. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3150?vs=7764=7769 REVISION DETAIL https://phab.mercurial-scm.org/D3150 AFFECTED FILES hgext/censor.py hgext/lfs/wrapper.py mercurial/filelog.py

D3154: filelog: wrap revlog instead of inheriting it (API)

indygreg added a comment. I want to draw attention to this patch for the potential performance concerns. Like I said in the commit message, I'd love to know what the performance impact is. I'm just not sure which revlog/filelog attributes/methods are called in tight loops outside of

D3151: revlog: move censor logic into main revlog class

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, the revlog class implemented dummy methods for various censor-related functionality. Revision censoring was (and will continue to be) only possible

D3148: repository: define existing interface for file storage

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have mostly successfully implemented an alternate storage backend for files data, let's start to define the interface for it! This commit

D3149: filelog: declare that filelog implements a storage interface

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have a declared interface, let's declare that filelog implements it. Tests have been added that confirm the object conforms to the interface.

D3153: tests: call rawsize() directly

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY rawsize() is not reimplemented outside of revlog. I'm not sure why this code was insisting it call a specific implementation. Changing it to call rawsize() on

D3152: upgrade: sniff for filelog type

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The upgrade code should never encounter a vanilla revlog instance: only changelog, manifestrevlog, and filelog should be seen. The previous code assumed

D3154: filelog: wrap revlog instead of inheriting it (API)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The revlog base class exposes a ton of methods. Inheriting the revlog class for filelog will make it difficult to expose a clean interface. There will be

D3119: commands: don't violate storage abstractions in `manifest --all`

indygreg updated this revision to Diff 7760. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3119?vs=7701=7760 REVISION DETAIL https://phab.mercurial-scm.org/D3119 AFFECTED FILES mercurial/commands.py tests/test-convert-git.t tests/test-manifest.t

RE: [PATCH 2 of 2] copies: clean up _related logic

> -Original Message- > From: Yuya Nishihara [mailto:you...@gmail.com] On Behalf Of Yuya > Nishihara > Sent: Thursday, April 5, 2018 2:57 PM > To: Gábor STEFANIK > Cc: mercurial-devel@mercurial-scm.org > Subject: Re: [PATCH 2 of 2] copies: clean up _related logic

D3141: mq: avoid a silly conversion from binary nodeid to hex

This revision was automatically updated to reflect the committed changes. Closed by commit rHG76823340a899: mq: avoid a silly conversion from binary nodeid to hex (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3142: narrow: remove unused "cacheprop" stuff

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc3c76194f0c1: narrow: remove unused cacheprop stuff (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3142?vs=7753=7758

D3146: context: move handling of stringified ints to revsymbol (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now there seem to be no more cases where we pass a stringified int into repo.__getitem__, so now can finally move that out of changectx's constructor and

D3145: context: catch right exceptions from namespace lookup (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Similar to the previous patch, here we were catching FilteredRepoLookupError and RepoLookupError instead of FilteredLookupError and LookupError. What makes

D3143: context: move handling of filtering error to revsymbol() (API)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When changectx's constructor runs into various Filtered*Error, it creates an exception with a hint about using --hidden. This only makes sense when the

D3144: context: make repo[] match node

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If you pass in a binary nodeid of a filtered node to repo.__getitem__, it would run through this code: try: self._node = changeid self._rev

D3142: narrow: remove unused "cacheprop" stuff

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is unused since https://phab.mercurial-scm.org/D3046. I didn't even notice it then, but tests still pass so I hope it's

D3062: tests: disable infinitepush tests for simple store

This revision was automatically updated to reflect the committed changes. Closed by commit rHG24c7428983c5: tests: disable infinitepush tests for simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3125: py3: convert user value to bytes by b'' prefix

pulkit updated this revision to Diff 7751. pulkit edited the summary of this revision. pulkit retitled this revision from "py3: convert user value to bytes using pycompat.fsencode()" to "py3: convert user value to bytes by b'' prefix". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3125: py3: convert user value to bytes using pycompat.fsencode()

pulkit added a comment. In https://phab.mercurial-scm.org/D3125#50284, @yuja wrote: > Unicode issue is handled by posix.py. The problem is `mockgetuser()` > returns a unicode string. Thanks, I overlooked that and was unable to find what can cause trouble so just added an extra

D3135: bookmarks: drop always-None argument from calculateupdate()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa973bb92ab71: bookmarks: drop always-None argument from calculateupdate() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3139: rebase: convert "oldrev" to revnum earlier

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3dfd7f018c69: rebase: convert oldrev to revnum earlier (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3139?vs=7740=7749

D3138: rebase: make "destnode" consistently a revnum and rename it to "destrev"

This revision was automatically updated to reflect the committed changes. Closed by commit rHG25940470c7e6: rebase: make destnode consistently a revnum and rename it to destrev (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2819: hgweb: refactor repository name URL parsing

mharbison72 added a comment. In https://phab.mercurial-scm.org/D2819#49519, @mharbison72 wrote: > I installed the latest default branch with SCM Manager, and it 404s even simple things like `hg id https://...`. I bisected back to this. The paths in the access log looks unchanged: >

D3045: narrow: move manifestrevlog overrides to core

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc50078fc32f3: narrow: move manifestrevlog overrides to core (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3140: rebase: remove unnecessary and incorrect handling of nullid

martinvonz updated this revision to Diff 7742. martinvonz edited the summary of this revision. martinvonz retitled this revision from "rebase: fix explicit handling of nullid in rebase state" to "rebase: remove unnecessary and incorrect handling of nullid". REPOSITORY rHG Mercurial CHANGES

D3140: rebase: remove unnecessary and incorrect handling of nullid

martinvonz added a comment. In https://phab.mercurial-scm.org/D3140#50376, @quark wrote: > Hmm... maybe just remove it. Done. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3140 To: martinvonz, #hg-reviewers, quark Cc: quark, mercurial-devel

D3120: tests: add test for `hg children -r `

martinvonz abandoned this revision. martinvonz added a comment. Folded into https://phab.mercurial-scm.org/D3085 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3120 To: martinvonz, #hg-reviewers, pulkit, indygreg Cc: pulkit, mercurial-devel

D3138: rebase: make "destnode" consistently a revnum and rename it to "destrev"

quark accepted this revision. quark added a comment. Thanks. I was not too happy about the old code using `rev` as `node`s. But I didn't spend much time changing them. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3138 To: martinvonz, #hg-reviewers, quark Cc:

D3120: tests: add test for `hg children -r `

indygreg added a comment. @martinvonz looks like you'll need to mark this as abandoned so it disappears from Phabricator. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3120 To: martinvonz, #hg-reviewers, pulkit, indygreg Cc: pulkit, mercurial-devel

D3139: rebase: convert "oldrev" to revnum earlier

quark accepted this revision. quark added a comment. Nice catch. I guess my initial consideration was `oldrev` was not always a valid node. But it seems no longer a concern. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3139 To: martinvonz, #hg-reviewers,

D3140: rebase: fix explicit handling of nullid in rebase state

quark accepted this revision. quark added a comment. Hmm... maybe just remove it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3140 To: martinvonz, #hg-reviewers, quark Cc: quark, mercurial-devel ___ Mercurial-devel

D3140: rebase: fix explicit handling of nullid in rebase state

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We used to write a nullid as hex to the rebase state file and interpret it as the "todo" state (value -1). However, when reading it, we compared the string

D3139: rebase: convert "oldrev" to revnum earlier

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It was done in 3 places before, now just 1. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3139 AFFECTED FILES hgext/rebase.py

D3138: rebase: make "destnode" consistently a revnum and rename it to "destrev"

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3138 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py b/hgext/rebase.py

[PATCH 1 of 2 v2] copies: create and use _loosenext function for _related

# HG changeset patch # User Gábor Stefanik # Date 1522943551 -7200 # Thu Apr 05 17:52:31 2018 +0200 # Node ID 7d13af1b5cd6e5c95dceefc7d905429889583c8c # Parent 656ac240f39284eec4435d25c01d71056aa4e8a5 copies: create and use _loosenext function for _related

D2398: histedit: use the new stack definition for histedit

lothiraldan marked an inline comment as done. lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in destutil.py:356 > Can be `return revs.min()`? It seems so and it's much simpler to read. I have sent a follow-up: https://phab.mercurial-scm.org/D3137 REPOSITORY rHG Mercurial

D2396: stack: import Evolve stack test file

lothiraldan marked 3 inline comments as done. lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in revset.py:1549 > This breaks the order of `tip:0 & stack()` for example, and is moot > since > https://phab.mercurial-scm.org/rHG68fcc5503ec55bda2d6be2887f8fc3f61000c666, > which

D3137: histedit: simplify desthistedit

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Instead of sorting the revset and take the first one, take the minimum revision. REPOSITORY rHG Mercurial REVISION DETAIL

D3136: stack: follow-up on the stack revset

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Follow good-practice for defining the stack revset. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3136 AFFECTED FILES

D2400: stack: begin to make the stack revset configurable

lothiraldan updated this revision to Diff 7733. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2400?vs=6216=7733 REVISION DETAIL https://phab.mercurial-scm.org/D2400 AFFECTED FILES mercurial/configitems.py mercurial/stack.py CHANGE DETAILS diff

D2402: stack: introduce an option to limit the selection on the current branch

lothiraldan updated this revision to Diff 7735. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2402?vs=6218=7735 REVISION DETAIL https://phab.mercurial-scm.org/D2402 AFFECTED FILES mercurial/configitems.py mercurial/stack.py tests/test-stack.t

D2403: stack: remove destutil.stackbase

lothiraldan updated this revision to Diff 7736. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2403?vs=6219=7736 REVISION DETAIL https://phab.mercurial-scm.org/D2403 AFFECTED FILES hgext/show.py mercurial/destutil.py CHANGE DETAILS diff --git

D2401: stack: introduce an option to disable the restriction on ancestor

lothiraldan updated this revision to Diff 7734. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2401?vs=6217=7734 REVISION DETAIL https://phab.mercurial-scm.org/D2401 AFFECTED FILES mercurial/configitems.py mercurial/stack.py CHANGE DETAILS diff

D2399: stack: return a sorted smartrev by default

lothiraldan marked an inline comment as done. lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in stack.py:25 > `reverse()` can be removed as well? reverse is removed in the next commit https://phab.mercurial-scm.org/D2400 REPOSITORY rHG Mercurial REVISION DETAIL

D3135: bookmarks: drop always-None argument from calculateupdate()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Thanks to Yuya for noticing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3135 AFFECTED FILES mercurial/bookmarks.py

D2400: stack: begin to make the stack revset configurable

lothiraldan added a comment. The goal of this series is to define a clean API so that commands and tools can be built in a stack-definition agnostic way. It's not to define a one-size-fits-all stack definition. People and companies have different workflows and needs. Their definition of

D2396: stack: import Evolve stack test file

lothiraldan added inline comments. INLINE COMMENTS > martinvonz wrote in test-stack.t:96-108 > I think I would have preferred to see all of these in my stack rather than > just commit 6. Would you? The goal of this series is to define a clean stack definition API. We started by reusing the

[PATCH 4 of 8] hgweb: fix summary {tags} and {shortlog} to not forcibly expand template

# HG changeset patch # User Yuya Nishihara # Date 1521376543 -32400 # Sun Mar 18 21:35:43 2018 +0900 # Node ID 9e623cb78522c9a52eeb25092c75b7f439c9e045 # Parent 083ce2cf66079739b029f7e067a2e9339704c006 hgweb: fix summary {tags} and {shortlog} to not forcibly expand template

[PATCH 1 of 8] templater: add function that expands internal literal templates

# HG changeset patch # User Yuya Nishihara # Date 1521295009 -32400 # Sat Mar 17 22:56:49 2018 +0900 # Node ID befd68a9bd8bb3ee4e450d20e6e7d279464f3f36 # Parent d3286dd2ca2f9f9e2b332e00c4b25b21729c54f5 templater: add function that expands internal literal templates This will

[PATCH 7 of 8] templater: complain about invalid application of '%' operator (BC)

# HG changeset patch # User Yuya Nishihara # Date 1521374483 -32400 # Sun Mar 18 21:01:23 2018 +0900 # Node ID 00c9dda81b49f4242f174fd218c68b5c8bbc5fea # Parent 1c22443660286f711ea1c6993f6aef77d82a5c63 templater: complain about invalid application of '%' operator (BC)

[PATCH 8 of 8] templater: deduplicate iterator of overlay mappings

# HG changeset patch # User Yuya Nishihara # Date 1522673652 -32400 # Mon Apr 02 21:54:12 2018 +0900 # Node ID 0e92d8efaea91db21670c7158b1128f924b30cf4 # Parent 00c9dda81b49f4242f174fd218c68b5c8bbc5fea templater: deduplicate iterator of overlay mappings diff --git

[PATCH 3 of 8] hgweb: fix search {entries} to not return results of template expansion

# HG changeset patch # User Yuya Nishihara # Date 1521373899 -32400 # Sun Mar 18 20:51:39 2018 +0900 # Node ID 083ce2cf66079739b029f7e067a2e9339704c006 # Parent 41f4b8e798c8c46261aa4b6060f5aae4954c1b24 hgweb: fix search {entries} to not return results of template expansion

[PATCH 2 of 8] templater: add class representing a nested mappings

# HG changeset patch # User Yuya Nishihara # Date 1521294422 -32400 # Sat Mar 17 22:47:02 2018 +0900 # Node ID 41f4b8e798c8c46261aa4b6060f5aae4954c1b24 # Parent befd68a9bd8bb3ee4e450d20e6e7d279464f3f36 templater: add class representing a nested mappings The mappinggenerator

[PATCH 5 of 8] hgweb: fix {diff} expansion in JSON template

# HG changeset patch # User Yuya Nishihara # Date 1521377180 -32400 # Sun Mar 18 21:46:20 2018 +0900 # Node ID a55c83d928093ea1e1b8d40eee4e799fb3bfe0cd # Parent 9e623cb78522c9a52eeb25092c75b7f439c9e045 hgweb: fix {diff} expansion in JSON template The same sort of bug as the

[PATCH 6 of 8] hgweb: fix type of {nav} keyword when linerange filter is active

# HG changeset patch # User Yuya Nishihara # Date 1521375537 -32400 # Sun Mar 18 21:18:57 2018 +0900 # Node ID 1c22443660286f711ea1c6993f6aef77d82a5c63 # Parent a55c83d928093ea1e1b8d40eee4e799fb3bfe0cd hgweb: fix type of {nav} keyword when linerange filter is active Spotted

D3134: util: whitelist apfs for hardlink support

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Seems to work fine for me. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3134 AFFECTED FILES mercurial/util.py CHANGE DETAILS

D3130: py3: suppress output from f.write() function class

This revision was automatically updated to reflect the committed changes. Closed by commit rHG22f19da5736e: py3: suppress output from f.write() function class (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3127: py3: return bytes from util.removeauth()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb23e3cc1afd4: py3: return bytes from util.removeauth() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3127?vs=7710=7725

D3128: py3: suppress the output of open() using `and None`

This revision was automatically updated to reflect the committed changes. Closed by commit rHG87c4253bebdb: py3: suppress the output of open() using `and None` (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3132: py3: add missing b'' prefix in mdiff.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd3286dd2ca2f: py3: add missing b prefix in mdiff.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3132?vs=7715=7730

D3131: py3: fix error string with bytestr() on repr()d value

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb6de372b4309: py3: fix error string with bytestr() on repr()d value (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3126: py3: use bytes instead of str in instance()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1ccd75027abb: py3: use bytes instead of str in instance() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3126?vs=7709=7724

D3129: py3: use pycompat.byteskwargs() in tests/autodiff.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGcdccfe20eed7: py3: use pycompat.byteskwargs() in tests/autodiff.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3124: py3: use pycompat.bytestr in test-journal.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1d26f745a10b: py3: use pycompat.bytestr in test-journal.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3124?vs=7707=7723

D3125: py3: convert user value to bytes using pycompat.fsencode()

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Unicode issue is handled by posix.py. The problem is `mockgetuser()` returns a unicode string. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3125

D3123: py3: use list comprehension instead of map()

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. That shouldn't matter here because bytes.join() takes an iterable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3123 To: pulkit, #hg-reviewers, yuja

D3086: pull: pass rev to check out as integer to postincoming()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd5e1678026fd: pull: pass rev to check out as integer to postincoming() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3122: hgweb: don't include hidden revisions in /filelog/ view

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd3a236e6: hgweb: dont include hidden revisions in /filelog/ view (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3121: tests: show that hgweb contains hidden revisions in /filelog/ view

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc16b55edd408: tests: show that hgweb contains hidden revisions in /filelog/ view (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3088: extdatasource: use revsymbol() for converting to node

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd0d55980ffa7: extdatasource: use revsymbol() for converting to node (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3089: convert: use repo.lookup() for converting to nodeid

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe45545f7895e: convert: use repo.lookup() for converting to nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3087: bookmarks: calculateupdate() returns a bookmark, not a rev

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe27298bf11dd: bookmarks: calculateupdate() returns a bookmark, not a rev (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3122: hgweb: don't include hidden revisions in /filelog/ view

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. It's a bit scary to rely on `linkrev()`, but the way how hgweb handles fctxs effectively disables linkrev adjustment. So this should be good enough for now. Queued, thanks. REPOSITORY

D3088: extdatasource: use revsymbol() for converting to node

yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. > Perhaps it should just be nodeids? I think it should be, but the test disagree. Maybe we can make BC since it's still an experimental feature. REPOSITORY rHG Mercurial REVISION

D3087: bookmarks: calculateupdate() returns a bookmark, not a rev

yuja accepted this revision. yuja added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > bookmarks.py:353 > +'''Return a tuple (activemark, movemarkfrom) indicating the active > bookmark > +and where to move the active bookmark from, if needed.''' >

Re: [PATCH 1 of 2] copies: create and use _loose_next function for _related

On Wed, 04 Apr 2018 15:35:33 +0200, Gábor Stefanik wrote: > # HG changeset patch > # User Gábor Stefanik > # Date 1522848489 -7200 > # Wed Apr 04 15:28:09 2018 +0200 > # Node ID d72ca973100a1f1a4451a7d1efdc3e43ebc2912e > # Parent

Re: [PATCH 2 of 2] copies: clean up _related logic

On Wed, 04 Apr 2018 15:35:34 +0200, Gábor Stefanik wrote: > # HG changeset patch > # User Gábor Stefanik > # Date 1522848882 -7200 > # Wed Apr 04 15:34:42 2018 +0200 > # Node ID 084ee003f2f3cb4d51129c4f1bb63e1ff4db14d0 > # Parent

D3132: py3: add missing b'' prefix in mdiff.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Transformer won't add b'' prefix because that value is already have a r'' prefix. 1. skip-blame because just b'' prefix REPOSITORY rHG Mercurial REVISION

D3133: py3: whitelist 13 new passing tests

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some tests were passing before the series too. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3133 AFFECTED FILES

D3131: py3: fix error string with bytestr() on repr()d value

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3131 AFFECTED FILES mercurial/mdiff.py CHANGE DETAILS diff --git a/mercurial/mdiff.py

D3127: py3: return bytes from util.removeauth()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY util.hidepassword() also returns bytes and we should deal in bytes as much as possible. This makes test-logexchange.t pass on Python 3.5 REPOSITORY rHG

D3130: py3: suppress output from f.write() function class

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We need to suppress them because the output is not present on Python 2 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3130 AFFECTED

D3129: py3: use pycompat.byteskwargs() in tests/autodiff.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3129 AFFECTED FILES tests/autodiff.py CHANGE DETAILS diff --git a/tests/autodiff.py

D3126: py3: use bytes instead of str in instance()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We deal internally with bytes, so we should check whether the remote is a bytes or not. REPOSITORY rHG Mercurial REVISION DETAIL

D3124: py3: use pycompat.bytestr in test-journal.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3124 AFFECTED FILES tests/test-journal.t CHANGE DETAILS diff --git a/tests/test-journal.t

D3125: py3: convert user value to bytes using pycompat.fsencode()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY procutil.getuser() can return unicode values. Let's convert them to bytes. This makes test-journal* pass on Python 3.5. REPOSITORY rHG Mercurial REVISION

D3128: py3: suppress the output of open() using `and None`

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch suppresses the output of open() on Python 3 as it does not return any output on Python 2. This makes test-diffstat.t pass on Python 3.5

D3123: py3: use list comprehension instead of map()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY map() on Python 3 returns a map object not a list, so let's use list comprehension where we require list. REPOSITORY rHG Mercurial REVISION DETAIL

mercurial@37287: 2 new changesets (2 on stable)

2 new changesets (2 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/61f6cee88940 changeset: 37286:61f6cee88940 branch: stable parent: 37156:7de7bd407251 user:Augie Fackler date:Wed Apr 04 10:35:09 2018 -0400 summary: Added tag

D1944: wireproto: provide accessors for client capabilities

joerg.sonnenberger updated this revision to Diff 7705. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1944?vs=7505=7705 REVISION DETAIL https://phab.mercurial-scm.org/D1944 AFFECTED FILES mercurial/help/internals/wireprotocol.txt

D3120: tests: add test for `hg children -r `

pulkit accepted this revision. pulkit added a comment. Folded this into https://phab.mercurial-scm.org/D3085. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3120 To: martinvonz, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel

D3122: hgweb: don't include hidden revisions in /filelog/ view

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a very crude way of doing it, but it seems to be working well enough. The number of entries on the page won't be the usual maximum number per page,

D3121: tests: show that hgweb contains hidden revisions in /filelog/ view

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Note that these entries contain the summary line of the hidden commit, which is a bit a privacy issue to display. Also note that the links from the entries