[PATCH] tests: stabilize test-patch.t on Windows

# HG changeset patch # User Matt Harbison # Date 1526871918 14400 # Sun May 20 23:05:18 2018 -0400 # Node ID 341bec645529aa249423f3aa683dac876d9e1510 # Parent 6acf41bb8d40c55073e846b81c7466f4b0d390dc tests: stabilize test-patch.t on Windows $PYTHON needs to be

D3639: remotenames: add paths argument to remotenames revset

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds paths argument to the revsets provided by the remotenames extension. The revsets are remotenames(), remotebranches() and remotebookmarks(). paths

D3627: status: add a config knob for setting default of --terse

This revision was automatically updated to reflect the committed changes. Closed by commit rHG18424aeece7f: status: add a config knob for setting default of --terse (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3628: status: add default of --terse=u to tweakdefaults (BC)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6acf41bb8d40: status: add default of --terse=u to tweakdefaults (BC) (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3627: status: add a config knob for setting default of --terse

pulkit accepted this revision. pulkit added a comment. > I'm very unhappy with how the default value for --terse looks rigt > now, but it does *work*. The alternative would be to define an > "optional string" flag type using fancyopts.customopt and then use > that, leaving the default

D2409: graft: add no-commit mode (issue5631)

pulkit added a comment. In https://phab.mercurial-scm.org/D2409#56200, @khanchi97 wrote: > In https://phab.mercurial-scm.org/D2409#44682, @pulkit wrote: > > > In https://phab.mercurial-scm.org/D2409#43891, @khanchi97 wrote: > > > > > pulkit: Can you please review it? I have made

D3557: commit: add new close-branch command

pulkit added a comment. > `hg close-branch` allows closing arbitrary heads. It is equivalent to > checking out the given revisions and commit an empty change with > `hg commit --close-branch`. I am -1 on having a new command for this. How about adding this as a `--close` flag to

D3187: phase: add dry-run functionality

pulkit added inline comments. INLINE COMMENTS > commands.py:3898 > if newdata[cl.rev(n)] < targetphase] > +if opts['dry_run']: > +rejected = [] Since all the logic is copy-pasted from phases.advanceboundary and phases.retractboundary, why not we just

D3638: py3: add 3 new passing tests to whitelist

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We ave crossed the 500 mark! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3638 AFFECTED FILES contrib/python3-whitelist CHANGE

D3635: py3: add support for NoneType in stringutil.pprint()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are some places in codebase where we try to print the value None, however `'%s' % None` is invalid on Python 3. So it will be good to have support in

D3636: py3: use pycompat.fsencode() to convert user value to bytes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3636 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git a/mercurial/debugcommands.py

D3637: py3: add b'' prefixes in tests/test-revset2.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3637 AFFECTED FILES tests/test-revset2.t

D3634: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes two of sparse tests which were failing on Python 3. 1. skip-blame because just r'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL

D3633: py3: use bytes in tests/printenv.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch add b'' prefixes and adds some .encode() calls to convert str to bytes on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL

D3632: py3: use stringutil.pprint() to prevent b'' prefixes in output

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch uses stringutil.pprint to print a list with bytes in it to prevent the b'' prefixes in the output. REPOSITORY rHG Mercurial REVISION DETAIL

D3631: py3: use pycompat.fsencode to convert path to bytes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3631 AFFECTED FILES contrib/hg-ssh CHANGE DETAILS diff --git a/contrib/hg-ssh b/contrib/hg-ssh ---

D3630: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3630 AFFECTED FILES

D3629: py3: add b'' prefixes in contrib/hg-ssh

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3629 AFFECTED FILES contrib/hg-ssh CHANGE

D2721: util: observable proxy objects for sockets

pulkit added inline comments. INLINE COMMENTS > util.py:1014 > + > +def setsockopt(self, level, optname, value): > +if not self.states: While debugging the test failure on Python 3.6, the caller at line 751 can pass 5 positional arguments. Here is the traceback after running

D2721: util: observable proxy objects for sockets

pulkit added inline comments. INLINE COMMENTS > util.py:1019 > +self.fh.write('%s> setsockopt(%r, %r, %r) -> %r\n' % ( > +self.name, level, optname, value)) > + If I am understanding this correctly, this can lead to `TypeError: not enough arguments for format string`