[PATCH 5 of 5] githelp: lowercase the start of output messages for consistency

# HG changeset patch # User Matt Harbison # Date 1526958268 14400 # Mon May 21 23:04:28 2018 -0400 # Node ID d6ecb77cc36283d5141cef8f87b014619322132a # Parent 8e4cdc86c55f579eac9887bd2bd09a5867232d32 githelp: lowercase the start of output messages for consistency I

[PATCH 1 of 5] githelp: fail gracefully in a couple cases where arguments are missing

# HG changeset patch # User Matt Harbison # Date 1526956335 14400 # Mon May 21 22:32:15 2018 -0400 # Node ID a34bed7475cc8237665aa8a3febc1237a090bc20 # Parent 90e02bd8c4473fec03639f26f3d1b2d30d9861d3 githelp: fail gracefully in a couple cases where arguments are

[PATCH 4 of 5] githelp: rewrite a Yoda conditional

# HG changeset patch # User Matt Harbison # Date 1526957825 14400 # Mon May 21 22:57:05 2018 -0400 # Node ID 8e4cdc86c55f579eac9887bd2bd09a5867232d32 # Parent d00bfbf24df05e8b8e21acf1444ea24f265a6123 githelp: rewrite a Yoda conditional diff --git a/hgext/githelp.py

[PATCH 2 of 5] githelp: cleanly abort if the `svn` command is unknown

# HG changeset patch # User Matt Harbison # Date 1526956915 14400 # Mon May 21 22:41:55 2018 -0400 # Node ID c137053c30e3a477d9f27aa72f0f791d5bcbe5b2 # Parent a34bed7475cc8237665aa8a3febc1237a090bc20 githelp: cleanly abort if the `svn` command is unknown

[PATCH 3 of 5] githelp: make several strings localizable

# HG changeset patch # User Matt Harbison # Date 1526957717 14400 # Mon May 21 22:55:17 2018 -0400 # Node ID d00bfbf24df05e8b8e21acf1444ea24f265a6123 # Parent c137053c30e3a477d9f27aa72f0f791d5bcbe5b2 githelp: make several strings localizable diff --git

[PATCH V2] tests: stabilize test-patch.t on Windows

# HG changeset patch # User Matt Harbison # Date 1526871918 14400 # Sun May 20 23:05:18 2018 -0400 # Node ID 589535dae225b24312ef6d86a54865314a9acebd # Parent 6acf41bb8d40c55073e846b81c7466f4b0d390dc tests: stabilize test-patch.t on Windows $PYTHON needs to be

Re: [PATCH 1 of 6] revlog: in _getcandidaterevs, shorten revlog._generaldelta to gdelta

On Mon, May 21, 2018 at 2:47 PM, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1525438855 -7200 > # Fri May 04 15:00:55 2018 +0200 > # Node ID 054469518b3480201e7f8ada16957027009e9f64 > # Parent

[PATCH 3 of 6] revlog: make variable name 'd' more explicit in _isgooddeltainfo

# HG changeset patch # User Paul Morelle # Date 1520420407 -3600 # Wed Mar 07 12:00:07 2018 +0100 # Node ID d9a8f10cfaa662c5dc6f64e2726da7d763e7e717 # Parent 3eb11b8fe014f5698a3c857ee670a7892f06fc56 # EXP-Topic semi-snapshots # Available At

[PATCH 2 of 6] debugdeltachain: r.start and r.length can be retrieved outside the loop

# HG changeset patch # User Paul Morelle # Date 1524117426 -7200 # Thu Apr 19 07:57:06 2018 +0200 # Node ID 3eb11b8fe014f5698a3c857ee670a7892f06fc56 # Parent 054469518b3480201e7f8ada16957027009e9f64 # EXP-Topic semi-snapshots # Available At

[PATCH 5 of 6] revlog: make getcandidaterevs more consistent about updating tested revs set

# HG changeset patch # User Paul Morelle # Date 1520417422 -3600 # Wed Mar 07 11:10:22 2018 +0100 # Node ID fbb85c011ea4c6ba474dbe616f63543cffb5f909 # Parent 3270177368354d88aba86d5b00b96b7fecadd65b # EXP-Topic semi-snapshots # Available At

[PATCH 6 of 6] revlog: make chainbase cache its result for the correct revision

# HG changeset patch # User Paul Morelle # Date 1524324477 -7200 # Sat Apr 21 17:27:57 2018 +0200 # Node ID f7f55d6f2966181f243d69b1afa598c12f6c4220 # Parent fbb85c011ea4c6ba474dbe616f63543cffb5f909 # EXP-Topic semi-snapshots # Available At

[PATCH 4 of 6] revlog: isgooddeltainfo takes the whole revinfo object

# HG changeset patch # User Paul Morelle # Date 1520420458 -3600 # Wed Mar 07 12:00:58 2018 +0100 # Node ID 3270177368354d88aba86d5b00b96b7fecadd65b # Parent d9a8f10cfaa662c5dc6f64e2726da7d763e7e717 # EXP-Topic semi-snapshots # Available At

[PATCH 1 of 6] revlog: in _getcandidaterevs, shorten revlog._generaldelta to gdelta

# HG changeset patch # User Paul Morelle # Date 1525438855 -7200 # Fri May 04 15:00:55 2018 +0200 # Node ID 054469518b3480201e7f8ada16957027009e9f64 # Parent 514605777244de61b68c7e1503c4f106773913f4 # EXP-Topic semi-snapshots # Available At

D3557: commit: add new close-branch command

joerg.sonnenberger added a comment. It doesn't seem to fit the argument schema for `hg branch` at all. I'm open for better places, but I couldn't think of a consistent place. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3557 To: joerg.sonnenberger,

D3642: py3: use encoding.strfromlocal() instead of pycompat.sysstr()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY opts['dateformat'] is provided by the user and can be encoded in local encoding. Thanks to Yuya for catching. REPOSITORY rHG Mercurial REVISION DETAIL

mercurial@38000: 4 new changesets (1 on stable)

4 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/71cf20d47f25 changeset: 37997:71cf20d47f25 user:Matt Harbison date:Mon May 14 23:00:30 2018 -0400 summary: phabricator: split auth.url into the standard

D3641: state: temporary silence pyflakes warning by removing variable assignment

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The variable 'version' is going to be used in upcoming series where we will be using the version number to read a certain state file. However currently, pyflakes

D3640: state: fix usage of an unassigned variable

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The variable iv was used in earlier iterations of the patches and was dropped since we made sure 'version' is always int. This usage of 'iv' should have been

D3618: pathencode: remove unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf9eaa5cd9ee9: pathencode: remove unused variable (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3618?vs=8790=8861 REVISION

D3635: py3: add support for NoneType in stringutil.pprint()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7aeb8aa262eb: py3: add support for NoneType in stringutil.pprint() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3633: py3: use bytes in tests/printenv.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbacbe829c2bf: py3: use bytes in tests/printenv.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3633?vs=8841=8858 REVISION

D3632: py3: use stringutil.pprint() to prevent b'' prefixes in output

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb0144fc8b681: py3: use stringutil.pprint() to prevent b prefixes in output (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3630: py3: add b'' prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe69628f36196: py3: add b prefixes in tests/test-ssh.t and tests/test-ssh-bundle1.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3631: py3: use pycompat.fsencode to convert path to bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG666d90ace0bb: py3: use pycompat.fsencode to convert path to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3634: py3: add r'' prefixes to fix kwargs handling in hgext/sparse.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd7cecea0b254: py3: add r prefixes to fix kwargs handling in hgext/sparse.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3629: py3: add b'' prefixes in contrib/hg-ssh

This revision was automatically updated to reflect the committed changes. Closed by commit rHG44ef9bb7ccd9: py3: add b prefixes in contrib/hg-ssh (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3629?vs=8837=8854

D3633: py3: use bytes in tests/printenv.py

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. This one worries me a bit because environment variable values can contain non-ASCII. However, the changed code only operates on `HG_` variables and I //think// those variables are

D3579: state: write the version number in plain text on top of state files

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa0e4d654bceb: state: write the version number in plain text on top of state files (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3578: state: set canonical=True to write deterministically

This revision was automatically updated to reflect the committed changes. Closed by commit rHG18c6d8b565bf: state: set canonical=True to write deterministically (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3572: state: don't have a dict like interface for cmdstate class

This revision was automatically updated to reflect the committed changes. Closed by commit rHG36a5a1239a15: state: dont have a dict like interface for cmdstate class (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2591: state: import the file to write state files from evolve extension

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2f83661f721: state: import the file to write state files from evolve extension (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 2 of 2 STABLE] httppeer: declare 'dgb' at the function level

# HG changeset patch # User Boris Feld # Date 1526908486 -7200 # Mon May 21 15:14:46 2018 +0200 # Branch stable # Node ID 06458d4a1ca84506d04280052d0288221b2701f0 # Parent 413f444c264455169af8ff0431a36f9901afc36a # EXP-Topic stable-dbg-bug # Available At

[PATCH 1 of 2 STABLE] httppeer: properly gate debug usage behind debug flag check

# HG changeset patch # User Boris Feld # Date 1525453606 -7200 # Fri May 04 19:06:46 2018 +0200 # Branch stable # Node ID 413f444c264455169af8ff0431a36f9901afc36a # Parent 273ea09f65500ea7936afe2983bf6a126c5bf4e6 # EXP-Topic stable-dbg-bug # Available At

Re: D3614: py3: check for None before comparing with integers

> --- a/mercurial/revlog.py > +++ b/mercurial/revlog.py > @@ -846,7 +846,7 @@ > def rawsize(self, rev): > """return the length of the uncompressed text for a given revision""" > l = self.index[rev][2] > -if l >= 0: > +if l is not None and l >= 0: Ugh,

D3614: py3: check for None before comparing with integers

yuja added a comment. > - a/mercurial/revlog.py +++ b/mercurial/revlog.py @@ -846,7 +846,7 @@ def rawsize(self, rev): """return the length of the uncompressed text for a given revision""" l = self.index[rev][2] > - if l >= 0: +if l is not None and l >= 0: Ugh, rawsize could

Re: D3612: py3: use pycompat.fsencode() to convert tempfile name to bytes

> bundle = None > try: # guards bundle > -bundlepath = "bundle:%s+%s" % (op.repo.root, bundlefile) > +bundlepath = "bundle:%s+%s" % (op.repo.root, > + pycompat.fsencode(bundlefile)) It's probably better to handle this by callers

D3612: py3: use pycompat.fsencode() to convert tempfile name to bytes

yuja added a comment. > bundle = None > try: # guards bundle > > - bundlepath = "bundle:%s+%s" % (op.repo.root, bundlefile) + bundlepath = "bundle:%s+%s" % (op.repo.root, + pycompat.fsencode(bundlefile)) It's probably better to

Re: D3590: py3: make sure we pass str to date.strftime()

> -return date.strftime(opts['dateformat']) > +return date.strftime(pycompat.sysstr(opts['dateformat'])) Should be `encoding.strfromlocal()` because `opts['dateformat']` is provided by user. ___ Mercurial-devel mailing list

D3590: py3: make sure we pass str to date.strftime()

yuja added a comment. > - return date.strftime(opts['dateformat']) +return date.strftime(pycompat.sysstr(opts['dateformat'])) Should be `encoding.strfromlocal()` because `opts['dateformat']` is provided by user. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH 1 of 8] hgweb: wrap {entries}* of bookmarks with mappinggenerator

# HG changeset patch # User Yuya Nishihara # Date 1522840791 -32400 # Wed Apr 04 20:19:51 2018 +0900 # Node ID 56e8ac64a7a3d529a596778d16ffc442a87f96e6 # Parent 9bf0bd4d7a2e44be4b15f8e1d51eb6d562e509e8 hgweb: wrap {entries}* of bookmarks with mappinggenerator They were

[PATCH 7 of 8] hgweb: don't use dict(key=value) to build a mapping dict in filelog

# HG changeset patch # User Yuya Nishihara # Date 1522841823 -32400 # Wed Apr 04 20:37:03 2018 +0900 # Node ID dc1e237534cea84c4d501d8b0ceb0dd2f4e7 # Parent 11795e08de913fd3285f9052599e32d3dcde0c0d hgweb: don't use dict(key=value) to build a mapping dict in filelog It

[PATCH 2 of 8] hgweb: wrap {lastchange} of bookmarks with mappinglist

# HG changeset patch # User Yuya Nishihara # Date 1522840889 -32400 # Wed Apr 04 20:21:29 2018 +0900 # Node ID 45d63bc6a089475a963400047b3c9ee8dd75eeeb # Parent 56e8ac64a7a3d529a596778d16ffc442a87f96e6 hgweb: wrap {lastchange} of bookmarks with mappinglist It was an 1-length

[PATCH 3 of 8] hgweb: wrap {bookmarks} of summary with mappinggenerator

# HG changeset patch # User Yuya Nishihara # Date 1522841044 -32400 # Wed Apr 04 20:24:04 2018 +0900 # Node ID 7da55cdf4a0846788d92775adfec37de79c7a925 # Parent 45d63bc6a089475a963400047b3c9ee8dd75eeeb hgweb: wrap {bookmarks} of summary with mappinggenerator No bare

[PATCH 6 of 8] hgweb: wrap {diffopts} of annotate by hybriddict()

# HG changeset patch # User Yuya Nishihara # Date 1522841476 -32400 # Wed Apr 04 20:31:16 2018 +0900 # Node ID 11795e08de913fd3285f9052599e32d3dcde0c0d # Parent e58591b37eada3d982d2db29901c73e8b084c4f9 hgweb: wrap {diffopts} of annotate by hybriddict() The diffopts here is a

[PATCH 5 of 8] hgweb: wrap {parents} of {annotate} with mappinggenerator

# HG changeset patch # User Yuya Nishihara # Date 1522841398 -32400 # Wed Apr 04 20:29:58 2018 +0900 # Node ID e58591b37eada3d982d2db29901c73e8b084c4f9 # Parent 6970d3a9c6a4ee333a1a10abccfa40a8771af471 hgweb: wrap {parents} of {annotate} with mappinggenerator It's a

[PATCH 4 of 8] hgweb: wrap {annotate} with mappinggenerator

# HG changeset patch # User Yuya Nishihara # Date 1522841331 -32400 # Wed Apr 04 20:28:51 2018 +0900 # Node ID 6970d3a9c6a4ee333a1a10abccfa40a8771af471 # Parent 7da55cdf4a0846788d92775adfec37de79c7a925 hgweb: wrap {annotate} with mappinggenerator No bare generator of

[PATCH 8 of 8] hgweb: wrap {entries}* of filelog with mappinglist

# HG changeset patch # User Yuya Nishihara # Date 1522841872 -32400 # Wed Apr 04 20:37:52 2018 +0900 # Node ID 21a9c92342e6b82473fbaf266b0b95b2bb924245 # Parent dc1e237534cea84c4d501d8b0ceb0dd2f4e7 hgweb: wrap {entries}* of filelog with mappinglist They were lists of

Re: [PATCH] tests: stabilize test-patch.t on Windows

On Sun, 20 May 2018 23:06:44 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1526871918 14400 > # Sun May 20 23:05:18 2018 -0400 > # Node ID 341bec645529aa249423f3aa683dac876d9e1510 > # Parent

Re: [PATCH V2] revlog: suggest other parent when a parent was refused for a delta (issue5481)

On Mon, 14 May 2018 14:11:57 +0200, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1526295914 -7200 > # Mon May 14 13:05:14 2018 +0200 > # Node ID 12fd4a2e154a679a601b8facbb5f15956d427e9e > # Parent