D3721: run-tests: restrict the test cases allowed characters

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb5651ae53127: run-tests: restrict the test cases allowed characters (authored by lothiraldan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3721?vs=9030=9040#toc REPOSITORY

Re: [PATCH] tests: don't bother supporting test case names with exotic characters

On Tue, 12 Jun 2018 18:18:48 -0400, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 1528841922 14400 # Tue Jun 12 18:18:42 2018 -0400 # Node ID 05a80f347ad401bdb8c37782d6251a40aaf9cf2a # Parent f9c426385853657be0082f63567a1e78a3d5474b tests: don't bother supporting

D3723: cvsps: avoid comparison between None and a tuple in date sorting

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids badness on Python 3. I had to figure out which entries in this object *could* be None experimentally, but I think I've got them all now. REPOSITORY

D3726: hgweb: pass a sysstr to low-level _start_response method

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes a regression in Python 3 support introduced in https://phab.mercurial-scm.org/rHG7de7bd407251af2bc98e5b809c8598ee95830daf on the stable branch. We're

D3725: tests: fix printenv script on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3725 AFFECTED FILES tests/printenv.py CHANGE DETAILS diff --git a/tests/printenv.py

D3724: cvsps: port changeset __repr__ to py3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This appears to be unused except as a debugging aid, as it didn't break until I added a debug print() in service of the previous fix. Sigh. REPOSITORY rHG

Re: D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

durin42 (Augie Fackler) writes: > durin42 added subscribers: lothiraldan, smf, durin42. > durin42 accepted this revision as: durin42. > durin42 added a comment. > > > I'm in favor, but feel like I've got enough conflict of interest I > shouldn't land the patches. > > @smf @lothiraldan this

Re: Discussion about Mercurial 4.8 Sprint

Kyle Lippincott writes: > On Thu, Jun 7, 2018 at 9:16 PM, Sean Farley wrote: > >> >> Kyle Lippincott writes: >> >> > On Thu, Jun 7, 2018 at 9:16 AM, Boris FELD >> wrote: >> > >> >> Hello everyone, >> >> >> >> I have also been in contact with Mercurial contributors, small >> >> contributors

D3721: run-tests: restrict the test cases allowed characters

mharbison72 accepted this revision. mharbison72 added a comment. The second hunk in run-test.py doesn't apply for me (it looks like adding `b` to a string has landed, but wasn't applied near the first hunk). But manually applying it, Windows is happy again. Thanks. REPOSITORY rHG

D3699: run-tests: follow-up on the test-case format

mharbison72 added a comment. In https://phab.mercurial-scm.org/D3699#58394, @lothiraldan wrote: > @mharbison72 I was not aware that this patch had been merged, is it breaking the windows build right now? Yes.

mercurial@38289: 7 new changesets

7 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/0e0d03d09ecd changeset: 38283:0e0d03d09ecd user:Yuya Nishihara date:Sat Jun 09 12:36:06 2018 +0900 summary: templater: rename mappable to hybriditem as it is the primary use case

D3722: py3: buildbot informs me we have two new passing tests

durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3722 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

[PATCH STABLE] tests: fix test-patch.t on pickier /bin/sh implementations

# HG changeset patch # User Augie Fackler # Date 1526871918 14400 # Sun May 20 23:05:18 2018 -0400 # Branch stable # Node ID 0c4019611293212012b598949832dcb2de6b96b2 # Parent 3c84493556db3bffcff2fa2f24bb6738dde9fc58 tests: fix test-patch.t on pickier /bin/sh implementations This is a graft

[PATCH] tests: don't bother supporting test case names with exotic characters

# HG changeset patch # User Augie Fackler # Date 1528841922 14400 # Tue Jun 12 18:18:42 2018 -0400 # Node ID 05a80f347ad401bdb8c37782d6251a40aaf9cf2a # Parent f9c426385853657be0082f63567a1e78a3d5474b tests: don't bother supporting test case names with exotic characters [a-z], [0-9] and -

mercurial@38282: 82 new changesets

82 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/56dd15178190 changeset: 38201:56dd15178190 user:Joerg Sonnenberger date:Fri Apr 20 15:21:03 2018 +0200 summary: templatefilters: add commonprefix

D3439: templatefilters: add commonprefix

martinvonz added a comment. In https://phab.mercurial-scm.org/D3439#58410, @joerg.sonnenberger wrote: > In https://phab.mercurial-scm.org/D3439#58405, @martinvonz wrote: > > > Do you think we should call it `commonpath()` or `commondir()` instead in case we want `commonprefix()` to

Re: [PATCH 3 of 7] templater: introduce a wrapper for date tuple (BC)

On Tue, Jun 12, 2018 at 11:49:05PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1521881642 -32400 > # Sat Mar 24 17:54:02 2018 +0900 > # Node ID 61e21a5a89d421909c45718ffc50f72cf83ee4b5 > # Parent 5eb83a6310845fb61fef9eda799731b90061 > templater:

D3439: templatefilters: add commonprefix

joerg.sonnenberger added a comment. In https://phab.mercurial-scm.org/D3439#58405, @martinvonz wrote: > Do you think we should call it `commonpath()` or `commondir()` instead in case we want `commonprefix()` to work for any string in the future (and not care about path separators)?

D3694: shelve: use more accurate description in conflict marker

durin42 added a comment. In https://phab.mercurial-scm.org/D3694#58369, @lothiraldan wrote: > > How much work is this, do you have any idea? > > The first option (adding "reserved" phase) should be very quick to implement. It might need minor adjustment for performance but I don't

D3716: ui: add an unsafeoperation context manager that can block SIGINT

durin42 added a comment. Good suggestions, integrated them. :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3716 To: durin42, #hg-reviewers Cc: martinvonz, mercurial-devel ___ Mercurial-devel mailing list

D3716: ui: add an unsafeoperation context manager that can block SIGINT

durin42 updated this revision to Diff 9033. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3716?vs=9023=9033 REVISION DETAIL https://phab.mercurial-scm.org/D3716 AFFECTED FILES mercurial/configitems.py mercurial/ui.py CHANGE DETAILS diff --git

Re: [PATCH 7 of 7] templater: abstract truth testing to fix {if(list_of_empty_strings)}

On Tue, Jun 12, 2018 at 11:49:09PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1528518887 -32400 > # Sat Jun 09 13:34:47 2018 +0900 > # Node ID 4eb2c19f741f50389c3de234654510deede597e2 > # Parent 0bf2bc3ec4f89f4a847b68d00011968732aacd7a > templater:

D3439: templatefilters: add commonprefix

martinvonz added a comment. Do you think we should call it `commonpath()` or `commondir()` instead in case we want `commonprefix()` to work for any string in the future (and not care about path separators)? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3439

D3700: run-tests: add support for external test result

durin42 added a comment. In https://phab.mercurial-scm.org/D3700#58403, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D3700#58376, @durin42 wrote: > > > I see some what, but not any why. Why is this useful? > > > I need this changeset to integrate the mercurial test

D3700: run-tests: add support for external test result

lothiraldan added a comment. In https://phab.mercurial-scm.org/D3700#58376, @durin42 wrote: > I see some what, but not any why. Why is this useful? I need this changeset to integrate the mercurial test runner with some external tools. REPOSITORY rHG Mercurial REVISION DETAIL

D3700: run-tests: add support for external test result

lothiraldan updated this revision to Diff 9031. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3700?vs=8992=9031 REVISION DETAIL https://phab.mercurial-scm.org/D3700 AFFECTED FILES tests/basic_test_result.py tests/run-tests.py

D3701: run-tests: extract onStart and onEnd into the test result

lothiraldan updated this revision to Diff 9032. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3701?vs=8993=9032 REVISION DETAIL https://phab.mercurial-scm.org/D3701 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-tests.py

D3721: run-tests: restrict the test cases allowed characters

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Most test cases in core and in extension only use `A-Za-z0-9-` but a few tests in extensions also have a `.` in their test cases names. Also add a `_` to

D3699: run-tests: follow-up on the test-case format

lothiraldan added a comment. In https://phab.mercurial-scm.org/D3699#58174, @yuja wrote: > >> test-run-tests.t:1669 > > > + --- $TESTTMP/anothertests/cases/test-cases-advanced-cases.t > > > + +++ $TESTTMP/anothertests/cases/test-cases-advanced-cases.t.casewith!@#$%^&*()chars.err

Re: [PATCH 2 of 4] debugwalk: show matcher output only if -v/--verbose

On Mon, Jun 11, 2018 at 6:07 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1528599236 -32400 > # Sun Jun 10 11:53:56 2018 +0900 > # Node ID ff248c56af342b1e07e1d51bb4760da202111ba3 > # Parent 40a20b62d7cc17999c8e879d62b4d95f1c3bb4cd > debugwalk: show

D3720: commandserver: close server's fds explicitly from a worker

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The forked worker does not need to accept connections from the server's socket fd. So let's just close them explicitly to avoid surprises. REPOSITORY rHG

D3703: serve: do not daemonize by default by --print-url

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1a05e205832a: serve: do not daemonize by default by --print-url (authored by yuja, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3715: namespaces: allow namespaces whose symbols resolve to many nodes (API)

durin42 added subscribers: lothiraldan, smf, durin42. durin42 accepted this revision as: durin42. durin42 added a comment. I'm in favor, but feel like I've got enough conflict of interest I shouldn't land the patches. @smf @lothiraldan this might be of interest to both of you?

D3716: ui: add an unsafeoperation context manager that can block SIGINT

martinvonz added inline comments. INLINE COMMENTS > ui.py:347-350 > +enabled = self.configbool('experimental', 'nointerrupt') > +inter = self.interactive() or not self.configbool( > +'experimental', 'nointerrupt-interactiveonly') > +if not (enabled and inter

D3700: run-tests: add support for external test result

durin42 added a comment. I see some what, but not any why. Why is this useful? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3700 To: lothiraldan, #hg-reviewers Cc: durin42, mercurial-devel ___ Mercurial-devel

D3702: mercurial: add .t files to .editorconfig

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1d6066336d7b: mercurial: add .t files to .editorconfig (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3702?vs=8994=9027#toc REPOSITORY rHG Mercurial

D3702: mercurial: add .t files to .editorconfig

durin42 added inline comments. INLINE COMMENTS > av6 wrote in .editorconfig:17 > Nit: I'd sort these two lines for consistency with the two entries above, > otherwise looks good. queued with that fixed REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3702 To:

D3694: shelve: use more accurate description in conflict marker

lothiraldan added a comment. In https://phab.mercurial-scm.org/D3694#58242, @durin42 wrote: > In https://phab.mercurial-scm.org/D3694#58241, @lothiraldan wrote: > > > > Interesting. I think I like this, it's a bummer that it requires a format bump in requires. > > > > > > > >

D3716: ui: add an unsafeoperation context manager that can block SIGINT

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The blocking of SIGINT is not done by default, but my hope is that we will one day. This was inspired by Facebook's "nointerrupt" extension, which is a bit more

D3717: repair: mark the critical section of strip() as unsafe

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When our experimental nointerrupt feature is enabled, this will help prevent users from corrupting their repo during a strip. REPOSITORY rHG Mercurial

D3718: narrow: mark the critical chunks of narrowing/widening as unsafe

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm _mostly_ sure these are the only unsafe chunks here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3718 AFFECTED FILES

D3719: narrowbundle2: when we handle a widen, mark the operation as unsafe

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have to manually drive the context manager here since the logic is awkwardly split between a couple of places. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH RFC] fileset: add "tracked()" to explicitly select files in the revision

# HG changeset patch # User Yuya Nishihara # Date 1528636796 -32400 # Sun Jun 10 22:19:56 2018 +0900 # Node ID c7fd574b35c8d7953fce3b5747ed27f23ea1 # Parent 4eb2c19f741f50389c3de234654510deede597e2 fileset: add "tracked()" to explicitly select files in the revision (This is RFC to show

[PATCH 7 of 7] templater: abstract truth testing to fix {if(list_of_empty_strings)}

# HG changeset patch # User Yuya Nishihara # Date 1528518887 -32400 # Sat Jun 09 13:34:47 2018 +0900 # Node ID 4eb2c19f741f50389c3de234654510deede597e2 # Parent 0bf2bc3ec4f89f4a847b68d00011968732aacd7a templater: abstract truth testing to fix {if(list_of_empty_strings)} Non-empty list

[PATCH 5 of 7] templatefilters: deprecate hgdate as {date|hgdate} is the default format

# HG changeset patch # User Yuya Nishihara # Date 1521882203 -32400 # Sat Mar 24 18:03:23 2018 +0900 # Node ID bc18058428fc50a9da867e9fd8a3c9f15f133851 # Parent cb223b044175c8444053bd55aa6d78992243c30a templatefilters: deprecate hgdate as {date|hgdate} is the default format diff --git

[PATCH 6 of 7] show: stringify filtered list of tags before testing emptiness

# HG changeset patch # User Yuya Nishihara # Date 1528813058 -32400 # Tue Jun 12 23:17:38 2018 +0900 # Node ID 0bf2bc3ec4f89f4a847b68d00011968732aacd7a # Parent bc18058428fc50a9da867e9fd8a3c9f15f133851 show: stringify filtered list of tags before testing emptiness `names % "{ifeq(name,

[PATCH 3 of 7] templater: introduce a wrapper for date tuple (BC)

# HG changeset patch # User Yuya Nishihara # Date 1521881642 -32400 # Sat Mar 24 17:54:02 2018 +0900 # Node ID 61e21a5a89d421909c45718ffc50f72cf83ee4b5 # Parent 5eb83a6310845fb61fef9eda799731b90061 templater: introduce a wrapper for date tuple (BC) Strictly speaking, this is BC, but I

[PATCH 2 of 7] templater: promote tomap() to an interface type

# HG changeset patch # User Yuya Nishihara # Date 1524304895 -32400 # Sat Apr 21 19:01:35 2018 +0900 # Node ID 5eb83a6310845fb61fef9eda799731b90061 # Parent 9c54939508aa66b09f2384ac37974addbabb90e9 templater: promote tomap() to an interface type I originally considered merging tomap()

[PATCH 4 of 7] templater: make date wrapper support dot/map operations

# HG changeset patch # User Yuya Nishihara # Date 1521881959 -32400 # Sat Mar 24 17:59:19 2018 +0900 # Node ID cb223b044175c8444053bd55aa6d78992243c30a # Parent 61e21a5a89d421909c45718ffc50f72cf83ee4b5 templater: make date wrapper support dot/map operations No idea if it will be useful,

[PATCH 1 of 7] templater: rename mappable to hybriditem as it is the primary use case

# HG changeset patch # User Yuya Nishihara # Date 1528515366 -32400 # Sat Jun 09 12:36:06 2018 +0900 # Node ID 9c54939508aa66b09f2384ac37974addbabb90e9 # Parent 94e4a283c6d720f8b13978de9c750a4d0402f209 templater: rename mappable to hybriditem as it is the primary use case This frees up the

Re: D2938: grep: make grep search on working directory by default

> @yuja I am adding an --unmodified flag to change to change the mode to > grep on the unmodified files as well. > What I am trying to do is :: > > def fns_generator(): > if --unmodified: > for f in ctx: > for f in ctx: > if

D2938: grep: make grep search on working directory by default

yuja added a comment. > @yuja I am adding an --unmodified flag to change to change the mode to grep on the unmodified files as well. > What I am trying to do is :: > > def fns_generator(): > if --unmodified: > for f in ctx: > for f

Re: D3667: graft: fix the help text to say `graft reapplies previous options`

> > +The -c/--continue option does reapply all the earlier options. > > Minor nit: > > s/does reapply/reapplies/ Fixed, thanks. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: D3667: graft: fix the help text to say `graft reapplies previous options`

On Tue, Jun 12, 2018 at 12:27:04 +, pulkit (Pulkit Goyal) wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rHGad4c5c0af6b5: graft: fix the help text to say `graft > reapplies previous options` (authored by pulkit, committed by ). > >

D3667: graft: fix the help text to say `graft reapplies previous options`

This revision was automatically updated to reflect the committed changes. Closed by commit rHGad4c5c0af6b5: graft: fix the help text to say `graft reapplies previous options` (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3668: graft: add a new `--stop` flag to stop interrupted graft

This revision was automatically updated to reflect the committed changes. Closed by commit rHG94e4a283c6d7: graft: add a new `--stop` flag to stop interrupted graft (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3668?vs=9013=9022#toc REPOSITORY

D3711: context: make workingctx.matches() filter our removed files (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGaaed058a0390: context: make workingctx.matches() filter our removed files (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3712: files: drop now-unnecessary filtering of removed dirstate files

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0c7970d4e6b4: files: drop now-unnecessary filtering of removed dirstate files (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3710: locate: explicitly use dirstate.matches() for working copy

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa4a286410a5: locate: explicitly use dirstate.matches() for working copy (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3713: revsets: define a none() revset

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf1d55ae2c5c8: revsets: define a none() revset (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3713?vs=9012=9017 REVISION

D3668: graft: add a new `--stop` flag to stop interrupted graft

yuja added a comment. > In https://phab.mercurial-scm.org/D3668#58070, @yuja wrote: > > > > The `--stop` flag takes back you to the last successful step i.e. it will keep > > > your grafted commits, it will just clear the mergestate and interrupted graft > > > state.

Re: D3668: graft: add a new `--stop` flag to stop interrupted graft

> In https://phab.mercurial-scm.org/D3668#58070, @yuja wrote: > > > > The `--stop` flag takes back you to the last successful step i.e. it > will keep > > > your grafted commits, it will just clear the mergestate and > interrupted graft > > > state. > > > > No idea if git is

D3711: context: make workingctx.matches() filter our removed files (API)

yuja added a comment. > It seems surprising that workingctx.matches() includes files that had > been removed in the working copy. The callers don't want that either > (besides the `hg locate` that was changed in the previous patch). > > The only observable difference that

Re: D3711: context: make workingctx.matches() filter our removed files (API)

> It seems surprising that workingctx.matches() includes files that had > been removed in the working copy. The callers don't want that either > (besides the `hg locate` that was changed in the previous patch). > > The only observable difference that I'm aware of is that `hg log -T >

Re: [PATCH follow-up] perftemplating: abort on incompatible version

On Tue, 12 Jun 2018 09:42:42 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1528736741 -7200 > # Mon Jun 11 19:05:41 2018 +0200 > # Node ID 1d1ccc0388cd266b6186be64dafbc46015440fa0 > # Parent a577a199983c5033192660c55db909df83fe65fc > # EXP-Topic perftemplating

Re: [PATCH follow-up] statprof: fix save and load

On Tue, 12 Jun 2018 09:54:03 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1528737841 -7200 > # Mon Jun 11 19:24:01 2018 +0200 > # Node ID 4e4c30424be81d5eb3748e4b031b61c7622341b6 > # Parent 15a1e37f80bd5af4b8eedd55b0c347c41a974839 > # EXP-Topic

[PATCH follow-up] statprof: fix save and load

# HG changeset patch # User Boris Feld # Date 1528737841 -7200 # Mon Jun 11 19:24:01 2018 +0200 # Node ID 4e4c30424be81d5eb3748e4b031b61c7622341b6 # Parent 15a1e37f80bd5af4b8eedd55b0c347c41a974839 # EXP-Topic walltime-followup # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH follow-up] perftemplating: abort on incompatible version

# HG changeset patch # User Boris Feld # Date 1528736741 -7200 # Mon Jun 11 19:05:41 2018 +0200 # Node ID 1d1ccc0388cd266b6186be64dafbc46015440fa0 # Parent a577a199983c5033192660c55db909df83fe65fc # EXP-Topic perftemplating # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D2938: grep: make grep search on working directory by default

sangeet259 added a comment. @martinvonz, thanks for the reviews, but @yuja has asked me to break this patch into three patches. So I guess this is not going to be merged anyway. Currently, I am trying to add a flag like `--all_files` or `--unmodified` which will enable one to grep all