D3811: changegroup: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Although it looks like this code was micro-optimized, I could not measure any slow-down. REPOSITORY rHG Mercurial REVISION DETAIL

D3812: tests: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With this commit, the only in-tree caller of ui.progress() is scmutil.progress(). That means that we could deprecate it. It also means that we can

D3804: patchbomb: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3804 AFFECTED FILES hgext/patchbomb.py CHANGE DETAILS diff --git a/hgext/patchbomb.py

D3810: synthrepo: close progress topics

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3810 AFFECTED FILES contrib/synthrepo.py CHANGE DETAILS diff --git a/contrib/synthrepo.py

D3803: patchbomb: don't close unused progress topic

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The "writing" topic has not been used since https://phab.mercurial-scm.org/rHG1830d0cc4bc1e5d99ec5ef954878e3ba59604470 (patchbomb: minor refactoring of mbox

D3806: lfs: use progess helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3806 AFFECTED FILES hgext/lfs/blobstore.py CHANGE DETAILS diff --git a/hgext/lfs/blobstore.py

D3805: relink: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This doesn't use progress.increment() because progress output is skipped for some positions (so we may end up calling "update(0), update(2), update(7)", or

D3808: largefiles: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3808 AFFECTED FILES hgext/largefiles/basestore.py hgext/largefiles/lfcommands.py

D3809: synthrepo: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3809 AFFECTED FILES contrib/synthrepo.py CHANGE DETAILS diff --git a/contrib/synthrepo.py

D3802: churn: use progess helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3802 AFFECTED FILES hgext/churn.py CHANGE DETAILS diff --git a/hgext/churn.py b/hgext/churn.py

D3807: convert: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3807 AFFECTED FILES hgext/convert/convcmd.py hgext/convert/subversion.py CHANGE DETAILS diff

mercurial@38400: 40 new changesets

2018-06-18 Thread Mercurial Commits
40 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/2ceea1554d1e changeset: 38361:2ceea1554d1e user:Martin von Zweigbergk date:Thu Jun 14 15:17:47 2018 -0700 summary: import: use context manager for lock, dirstateguard, transaction

[Bug 5922] New: Grafting over tens of thousands of changesets is slow

2018-06-18 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5922 Bug ID: 5922 Summary: Grafting over tens of thousands of changesets is slow Product: Mercurial Version: default branch Hardware: PC OS: Windows Status: UNCONFIRMED

D3764: rebase: improve output of --dry-run

2018-06-18 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D3764#59425, @pulkit wrote: > Thinking out loud here: I see that `--dry-run` for rebase will be very useful for automation. How about returning 1 when there are conflicts and returning 0 when there are no conflicts? Also maybe

[Bug 5921] New: hg convert fails on .hgsubstate merges

2018-06-18 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5921 Bug ID: 5921 Summary: hg convert fails on .hgsubstate merges Product: Mercurial Version: 4.6 Hardware: PC OS: Windows Status: UNCONFIRMED Severity: bug

D3800: upgrade: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG185588cb0c4b: upgrade: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3800?vs=9194=9201 REVISION

D3797: verify: use progress helper for subdirectory progress

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0ddbe03c5aaa: verify: use progress helper for subdirectory progress (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3798: verify: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1249475f0bd6: verify: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3798?vs=9192=9200 REVISION

D3799: upgrade: close progress after each revlog

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf273b768b60f: upgrade: close progress after each revlog (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3799?vs=9193=9202

D3801: treediscovery: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f5c622fcb73: treediscovery: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3801?vs=9195=9203

D3794: httpconnection: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5f9d436cd3b7: httpconnection: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3794?vs=9188=9196

D3796: similar: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG59c9d3cc810f: similar: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3796?vs=9190=9198 REVISION

D3795: repair: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf0b0c853f598: repair: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3795?vs=9189=9197 REVISION

D3764: rebase: improve output of --dry-run

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Thinking out loud here: I see that `--dry-run` for rebase will be very useful for automation. How about returning 1 when there are conflicts and returning 0 when there are no conflicts? Also maybe we should add formatter support to the dry-run output for each command

D3763: grep: add `--diff` flag

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > commands.py:2419 > ('', 'all', None, _('print all revisions that match')), > +('', 'diff', None, _('print all revisions that match')), > ('a', 'text', None, _('treat all files as text')), We definitely need better help text here to

Re: [PATCH 1 of 9] byteify-strings: fork py3 code transformer to make it a standalone command

2018-06-18 Thread Pulkit Goyal
On Mon, Jun 18, 2018 at 6:47 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1527772024 -32400 > # Thu May 31 22:07:04 2018 +0900 > # Node ID 1daa265ac761404a6aec3404dabdad01aac1ab76 > # Parent 140cfc3770b87c8aad8cbe3be9f21a02f3636ef3 > byteify-strings:

Re: [PATCH 6 of 9] byteify-strings: do not rewrite system string literals to u''

2018-06-18 Thread Pulkit Goyal
On Mon, Jun 18, 2018 at 6:47 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 152875 -32400 > # Thu May 31 23:44:35 2018 +0900 > # Node ID 5cdd7f14f888f265459ab94b79ae837d515a2ad8 > # Parent e17f54b6889bceba8abbe7d4b9c450e66125a807 > byteify-strings: do

mercurial@38360: 26 new changesets (1 on stable)

2018-06-18 Thread Mercurial Commits
26 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/ae7f27867c2a changeset: 38335:ae7f27867c2a branch: stable user:Yuya Nishihara date:Fri Jun 15 22:16:58 2018 +0900 summary: manifest: fix possible SEGV caused by uninitialized

D3801: treediscovery: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3801 AFFECTED FILES mercurial/treediscovery.py CHANGE DETAILS diff --git

D3800: upgrade: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A minor side-effect is that we no longer print the progress at 0 (and that we don't re-print it at its current value when starting the next manifest/file).

D3796: similar: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A side-effect is that progress is now reported as 1 *before* we start checking the first file. That seems to be how we do it in most places. Also, the

D3799: upgrade: close progress after each revlog

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY IIUC, one is supposed to close each progress topic before strarting a new one. Otherwise the topics are considered nested, which we don't want here.

D3798: verify: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3798 AFFECTED FILES mercurial/verify.py CHANGE DETAILS diff --git a/mercurial/verify.py

D3797: verify: use progress helper for subdirectory progress

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I also reworded a variable to make it clearer that it's only used for subdirectories. REPOSITORY rHG Mercurial REVISION DETAIL

D3795: repair: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3795 AFFECTED FILES mercurial/repair.py CHANGE DETAILS diff --git a/mercurial/repair.py

D3794: httpconnection: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3794 AFFECTED FILES mercurial/httpconnection.py CHANGE DETAILS diff --git

Re: [PATCH] highlight: get around tmpl.load() which now returns a parsed tree

2018-06-18 Thread Martin von Zweigbergk via Mercurial-devel
Queued, thanks! On Mon, Jun 18, 2018 at 6:05 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1529326492 -32400 > # Mon Jun 18 21:54:52 2018 +0900 > # Node ID 140cfc3770b87c8aad8cbe3be9f21a02f3636ef3 > # Parent f4f1fb1cbfb42fb24b7b546f39b35f1bf5a7267c >

D3777: debugbuilddag: use context manager for progress, locks, transaction

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0d7ec620faef: debugbuilddag: use context manager for progress, locks, transaction (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3774: progress: hide update(None) in a new complete() method

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGef692614e601: progress: hide update(None) in a new complete() method (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3782: archival: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1a2ff11e8a88: archival: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3782?vs=9153=9186 REVISION

D3783: changegroup: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdaa08d45740f: changegroup: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3783?vs=9154=9187

D3780: subrepo: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3a7c33a2cc5e: subrepo: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3780?vs=9151=9184 REVISION

D3781: copystore: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG63e6f5ae84bc: copystore: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3781?vs=9152=9185 REVISION

D3779: histedit: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe5d87c69bbcb: histedit: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3779?vs=9150=9183 REVISION

D3776: debugbuilddag: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfce1c17493db: debugbuilddag: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3776?vs=9147=9180

D3775: progress: make the progress helper a context manager

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG800f5a2c869e: progress: make the progress helper a context manager (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3778: rebase: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa73eab7d6575: rebase: use progress helper (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3778?vs=9149=9182 REVISION

mercurial@38334: 2 new changesets (2 on stable)

2018-06-18 Thread Mercurial Commits
2 new changesets (2 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/03350f5234a4 changeset: 38333:03350f5234a4 branch: stable parent: 38302:6caca2a7d37f user:Jun Wu date:Thu Jun 14 14:04:26 2018 -0700 summary: crecord: fix line number in hunk

[PATCH 1 of 4] templatefuncs: minimize resource requirements

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1528978676 -32400 # Thu Jun 14 21:17:56 2018 +0900 # Node ID 6d021282f5c6b39c4f3af64e3ed0a658253974d3 # Parent ed4f41dd0fdb2e5396830084805223ca334bee3b templatefuncs: minimize resource requirements diff --git a/mercurial/templatefuncs.py

[PATCH 3 of 4] formatter: provide hint of context keys required by template

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1528463422 -32400 # Fri Jun 08 22:10:22 2018 +0900 # Node ID e669b5c1e8a6d4d36d38b0f9c525cfd05846cec8 # Parent 21015eb08c98d12fa2060e8d1414e9f557a448d7 formatter: provide hint of context keys required by template This allows us to create

[PATCH 2 of 4] templatefuncs: declare resource requirements for future use

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1528978738 -32400 # Thu Jun 14 21:18:58 2018 +0900 # Node ID 21015eb08c98d12fa2060e8d1414e9f557a448d7 # Parent 6d021282f5c6b39c4f3af64e3ed0a658253974d3 templatefuncs: declare resource requirements for future use diff --git

[PATCH 4 of 4] tags: unblock log-like template keywords and functions

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1528463783 -32400 # Fri Jun 08 22:16:23 2018 +0900 # Node ID a7593c4a8c90d1182f21fa1b802ef1bea63a5c14 # Parent e669b5c1e8a6d4d36d38b0f9c525cfd05846cec8 tags: unblock log-like template keywords and functions It checks if ctx will be used in

[PATCH 9 of 9] py3: byte-stringify literals in contrib/phabricator.py as example

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1528017516 -32400 # Sun Jun 03 18:18:36 2018 +0900 # Node ID ed4f41dd0fdb2e5396830084805223ca334bee3b # Parent b5d9406ce43ef12ce2500d3e7d532ece8d55a0fc py3: byte-stringify literals in contrib/phabricator.py as example Transformed by

[PATCH 5 of 9] byteify-strings: do not rewrite iteritems() and itervalues() by default

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1527773663 -32400 # Thu May 31 22:34:23 2018 +0900 # Node ID e17f54b6889bceba8abbe7d4b9c450e66125a807 # Parent 7e028b27e28395e759c94c571ee483223694c0e8 byteify-strings: do not rewrite iteritems() and itervalues() by default We can't do that

[PATCH 8 of 9] byteify-strings: remove superfluous "if True" block

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1528017594 -32400 # Sun Jun 03 18:19:54 2018 +0900 # Node ID b5d9406ce43ef12ce2500d3e7d532ece8d55a0fc # Parent 62a63e0a54536b934dbe1f26f0e27f6fed2ebfdc byteify-strings: remove superfluous "if True" block diff --git

[PATCH 7 of 9] byteify-strings: try to preserve column alignment

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1527779635 -32400 # Fri Jun 01 00:13:55 2018 +0900 # Node ID 62a63e0a54536b934dbe1f26f0e27f6fed2ebfdc # Parent 5cdd7f14f888f265459ab94b79ae837d515a2ad8 byteify-strings: try to preserve column alignment diff --git

[PATCH 1 of 9] byteify-strings: fork py3 code transformer to make it a standalone command

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1527772024 -32400 # Thu May 31 22:07:04 2018 +0900 # Node ID 1daa265ac761404a6aec3404dabdad01aac1ab76 # Parent 140cfc3770b87c8aad8cbe3be9f21a02f3636ef3 byteify-strings: fork py3 code transformer to make it a standalone command I'm thinking

[PATCH 4 of 9] byteify-strings: drop import-line hack

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1527773497 -32400 # Thu May 31 22:31:37 2018 +0900 # Node ID 7e028b27e28395e759c94c571ee483223694c0e8 # Parent e1566a950374c824a1ca950904ed5c053af1037b byteify-strings: drop import-line hack This is ugly, and valid only for Python 3. We'll

[PATCH 2 of 9] byteify-strings: add basic command interface

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1527773010 -32400 # Thu May 31 22:23:30 2018 +0900 # Node ID 27476a7a2bbcd16085794977001a189114a114f0 # Parent 1daa265ac761404a6aec3404dabdad01aac1ab76 byteify-strings: add basic command interface diff --git a/contrib/byteify-strings.py

[PATCH 3 of 9] byteify-strings: add --inplace option to write back result

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1527773309 -32400 # Thu May 31 22:28:29 2018 +0900 # Node ID e1566a950374c824a1ca950904ed5c053af1037b # Parent 27476a7a2bbcd16085794977001a189114a114f0 byteify-strings: add --inplace option to write back result diff --git

[PATCH 6 of 9] byteify-strings: do not rewrite system string literals to u''

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 152875 -32400 # Thu May 31 23:44:35 2018 +0900 # Node ID 5cdd7f14f888f265459ab94b79ae837d515a2ad8 # Parent e17f54b6889bceba8abbe7d4b9c450e66125a807 byteify-strings: do not rewrite system string literals to u'' It would make things worse

[PATCH] highlight: get around tmpl.load() which now returns a parsed tree

2018-06-18 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1529326492 -32400 # Mon Jun 18 21:54:52 2018 +0900 # Node ID 140cfc3770b87c8aad8cbe3be9f21a02f3636ef3 # Parent f4f1fb1cbfb42fb24b7b546f39b35f1bf5a7267c highlight: get around tmpl.load() which now returns a parsed tree Broken at

Re: D3771: py3: make contrib/perf.py compatible to Python 3

2018-06-18 Thread Yuya Nishihara
> +fm.write(b'wall', ' wall %f', m[0]) > +fm.write(b'comb', ' comb %f', m[1] + m[2]) > +fm.write(b'user', ' user %f', m[1]) > +fm.write(b'sys', ' sys %f', m[2]) > +fm.write(b'count', ' (best of %d)', count) Needs more b''s. I think it's better to split patches to b'' and

D3771: py3: make contrib/perf.py compatible to Python 3

2018-06-18 Thread yuja (Yuya Nishihara)
yuja added a comment. > +fm.write(b'wall', ' wall %f', m[0]) > +fm.write(b'comb', ' comb %f', m[1] + m[2]) > +fm.write(b'user', ' user %f', m[1]) > +fm.write(b'sys', ' sys %f', m[2]) > +fm.write(b'count', ' (best of %d)', count) Needs more b''s. I

D3757: rebase: add dry-run functionality

2018-06-18 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf4f1fb1cbfb4: rebase: add dry-run functionality (authored by khanchi97, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3757?vs=9124=9177#toc REPOSITORY rHG Mercurial

D3793: py3: add `and None` to suppress return values of .write() calls

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfb4813304c5f: py3: add `and None` to suppress return values of .write() calls (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3793?vs=9164=9175#toc

D3792: py3: slice over bytes to prevent getting ascii values

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc7eb9bce6041: py3: slice over bytes to prevent getting ascii values (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3791: py3: use pycompat.maplist() instead of map() in hgext/transplant.py

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG365a78daf735: py3: use pycompat.maplist() instead of map() in hgext/transplant.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3748: import: use context manager for lock, dirstateguard, transaction

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2ceea1554d1e: import: use context manager for lock, dirstateguard, transaction (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3789: py3: make tests/test-impexp-branch.t compatible with Python 3

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe033fd788bf8: py3: make tests/test-impexp-branch.t compatible with Python 3 (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3787: py3: encode sys.argv to bytes using .encode()

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbf953d218a91: py3: encode sys.argv to bytes using .encode() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3787?vs=9158=9170

D3790: py3: add 4 new passing tests to whitelist

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG96ee5276340a: py3: add 4 new passing tests to whitelist (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3790?vs=9161=9173

D3788: py3: convert error instances to bytes using pycompat.bytestr()

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4a6d01b49d91: py3: convert error instances to bytes using pycompat.bytestr() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3785: py3: suppress the output of .write() calls in tests/test-revlog-v2.t

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa6426dd3210d: py3: suppress the output of .write() calls in tests/test-revlog-v2.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3786: py3: use '%d' for os.stat_result.st_nlink instead of '%s'

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG06c85cbd6824: py3: use %d for os.stat_result.st_nlink instead of %s (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3784: py3: add couple of missing b'' prefixes in tests/test-pager-legacy.t

2018-06-18 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe53879421ecd: py3: add couple of missing b prefixes in tests/test-pager-legacy.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3757: rebase: add dry-run functionality

2018-06-18 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, thanks. > -def _origrebase(ui, repo, inmemory=False, **opts): > +def _origrebase(ui, repo, inmemory=False, leaveunfinished=None, **opts): I did s/None/False/ for readability. REPOSITORY rHG Mercurial REVISION DETAIL

Re: D3757: rebase: add dry-run functionality

2018-06-18 Thread Yuya Nishihara
Queued, thanks. > -def _origrebase(ui, repo, inmemory=False, **opts): > +def _origrebase(ui, repo, inmemory=False, leaveunfinished=None, **opts): I did s/None/False/ for readability. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH 3 of 4] diff: accept "dict" as diff option

2018-06-18 Thread Yuya Nishihara
On Sun, 17 Jun 2018 17:47:11 +0200, Boris FELD wrote: > On 15/06/2018 13:44, Yuya Nishihara wrote: > > On Fri, 15 Jun 2018 10:48:34 +0200, Boris FELD wrote: > >>> I'd rather force callers of ctx.diff() to build a diffopts object. > >> Do you see a way to solves the import cycle? > > Which one? >

Re: [PATCH 1 of 8] templater: mark most attributes as private

2018-06-18 Thread Yuya Nishihara
On Sun, 17 Jun 2018 13:58:31 -0700, Martin von Zweigbergk wrote: > >> # HG changeset patch > >> # User Yuya Nishihara > >> # Date 1525312409 -32400 > >> # Thu May 03 10:53:29 2018 +0900 > >> # Node ID 8541f1e6178053f6cafd2ff22c8b632499ffa298 > >> # Parent

D3792: py3: slice over bytes to prevent getting ascii values

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 9165. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3792?vs=9163=9165 REVISION DETAIL https://phab.mercurial-scm.org/D3792 AFFECTED FILES hgext/transplant.py mercurial/subrepo.py CHANGE DETAILS diff --git

D3793: py3: add `and None` to suppress return values of .write() calls

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY .write() calls don't return anything on Python2, so we need to make sure we suppress that on py3 too. This makes the test pass on Python 3. REPOSITORY rHG

D3792: py3: slice over bytes to prevent getting ascii values

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3792 AFFECTED FILES hgext/transplant.py CHANGE DETAILS diff --git a/hgext/transplant.py

D3791: py3: use pycompat.maplist() instead of map() in hgext/transplant.py

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY map() returns a map-object on Python3 instead of a list. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3791 AFFECTED FILES

D3790: py3: add 4 new passing tests to whitelist

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3790 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D3789: py3: make tests/test-impexp-branch.t compatible with Python 3

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds some missig b'' prefixes and add suppress the output of write() calls. REPOSITORY rHG Mercurial REVISION DETAIL

D3788: py3: convert error instances to bytes using pycompat.bytestr()

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3788 AFFECTED FILES hgext/convert/convcmd.py CHANGE DETAILS diff --git a/hgext/convert/convcmd.py

D3784: py3: add couple of missing b'' prefixes in tests/test-pager-legacy.t

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3784 AFFECTED FILES

D3785: py3: suppress the output of .write() calls in tests/test-revlog-v2.t

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes the test pass on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3785 AFFECTED FILES tests/test-revlog-v2.t

D3787: py3: encode sys.argv to bytes using .encode()

2018-06-18 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3787 AFFECTED FILES tests/test-import-context.t tests/test-patch-offset.t CHANGE DETAILS diff --git

D3781: copystore: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3781 AFFECTED FILES mercurial/hg.py mercurial/util.py CHANGE DETAILS diff --git

D3780: subrepo: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3780 AFFECTED FILES mercurial/subrepo.py CHANGE DETAILS diff --git a/mercurial/subrepo.py

D3778: rebase: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3778 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py b/hgext/rebase.py

D3783: changegroup: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3783 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git a/mercurial/changegroup.py

D3777: debugbuilddag: use context manager for progress, locks, transaction

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I minor side-effect is that .hg/localtags is now written before the transaction commits. REPOSITORY rHG Mercurial REVISION DETAIL

D3776: debugbuilddag: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3776 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

D3774: progress: hide update(None) in a new complete() method

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY update(None) seemed a bit cryptic. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3774 AFFECTED FILES mercurial/changegroup.py

D3779: histedit: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3779 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D3775: progress: make the progress helper a context manager

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This lets us simplify the use site in streamclone. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3775 AFFECTED FILES

D3782: archival: use progress helper

2018-06-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3782 AFFECTED FILES mercurial/archival.py CHANGE DETAILS diff --git a/mercurial/archival.py

  1   2   >