[PATCH 1 of 2] phases: remove excessive optimization from newheads() (issue5939)

2018-07-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1531541958 -32400 # Sat Jul 14 13:19:18 2018 +0900 # Node ID c8f181c48ae26247478aea82c8d2ab2f886831f9 # Parent d5b851a39710f8415f98575e4f00396fe7ee2809 phases: remove excessive optimization from newheads() (issue5939) This function is

Re: Discussion about Mercurial 4.8 Sprint

2018-07-13 Thread Yuya Nishihara
On Fri, 13 Jul 2018 20:33:19 -0700, Sean Farley wrote: > > Martin von Zweigbergk writes: > > > On Fri, Jul 13, 2018, 00:32 Sean Farley wrote: > > > >> > >> Martin von Zweigbergk writes: > >> > >> > On Thu, Jul 12, 2018 at 9:11 PM Sean Farley wrote: > >> > > >> >> > >> >> Martin von

[PATCH 2 of 2] phases: micro-optimize newheads() to not create context objects

2018-07-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1531542109 -32400 # Sat Jul 14 13:21:49 2018 +0900 # Node ID 503d14253b22603b1f76c80dd6b89b6ebcfe5e06 # Parent c8f181c48ae26247478aea82c8d2ab2f886831f9 phases: micro-optimize newheads() to not create context objects diff --git

D3933: pullbundle: fix handling of gzip bundlespecs

2018-07-13 Thread joerg.sonnenberger (Joerg Sonnenberger)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7e4a856a4f05: pullbundle: fix handling of gzip bundlespecs (authored by joerg.sonnenberger, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: Discussion about Mercurial 4.8 Sprint

2018-07-13 Thread Sean Farley
Augie Fackler writes: >> On Jul 13, 2018, at 09:29, Martin von Zweigbergk via Mercurial-devel >> wrote: >> >> We took people's voices into account. That's why we choose Europe over Asia >> (it felt like people on the committee generally preferred Tokyo). But again, >> I agree that we should

Re: Discussion about Mercurial 4.8 Sprint

2018-07-13 Thread Sean Farley
Martin von Zweigbergk writes: > On Fri, Jul 13, 2018, 00:32 Sean Farley wrote: > >> >> Martin von Zweigbergk writes: >> >> > On Thu, Jul 12, 2018 at 9:11 PM Sean Farley wrote: >> > >> >> >> >> Martin von Zweigbergk writes: >> >> >> >> > On Thu, Jul 12, 2018, 17:41 Sean Farley wrote: >> >>

[PATCH 2 of 2] hghave: require clang-format >= 6 due to output change

2018-07-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1531533112 -32400 # Sat Jul 14 10:51:52 2018 +0900 # Node ID d5b851a39710f8415f98575e4f00396fe7ee2809 # Parent 42bce1d7778658cae95ec0a2aa29ff72d503c000 hghave: require clang-format >= 6 due to output change diff --git a/tests/hghave.py

[PATCH 1 of 2] cext: reformat with clang-format 6.0

2018-07-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1531533010 -32400 # Sat Jul 14 10:50:10 2018 +0900 # Node ID 42bce1d7778658cae95ec0a2aa29ff72d503c000 # Parent 2a227782e75426a3e4408273a9a4eebe79dfdcea cext: reformat with clang-format 6.0 It appears some changes in clang-format affect our

Re: D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

2018-07-13 Thread Yuya Nishihara
(resend) > So what's the next step should be ? Maybe add support for "--all-files -rMULTIREV" so the feature can be documented properly? https://www.mercurial-scm.org/wiki/GrepPlan#hg_grep "If given a set of revisions, it will do the same but search the given revision(s)."

D3943: scmutil: rewrite docstring for filecache

2018-07-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3b072388ca78: scmutil: rewrite docstring for filecache (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3943?vs=9588=9589

D3932: tests: add test demonstrating phase loss when cloning (issue5939)

2018-07-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2a227782e754: tests: add test demonstrating phase loss when cloning (issue5939) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

2018-07-13 Thread Yuya Nishihara
> So what's the next step should be ? Maybe add support for "--all-files -rMULTIREV" so the feature can be documented properly? https://www.mercurial-scm.org/wiki/GrepPlan#hg_grep "If given a set of revisions, it will do the same but search the given revision(s)."

D3943: scmutil: rewrite docstring for filecache

2018-07-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The old docstring was incorrect in that it said that subsequent calls perform a stat() and refresh the object if things change. This is not how things work:

Re: D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

2018-07-13 Thread Sangeet Kumar Mishra
So what's the next step should be ? On Fri, 13 Jul 2018, 18:13 yuja (Yuya Nishihara), < phabrica...@mercurial-scm.org> wrote: > yuja added a comment. > > > > How do you feel about treating the current behavior of `hg grep` as > a bug? > > I'm 0 on this. 10 years are long enough to turn a

Re: Discussion about Mercurial 4.8 Sprint

2018-07-13 Thread Augie Fackler
> On Jul 13, 2018, at 09:29, Martin von Zweigbergk via Mercurial-devel > wrote: > > We took people's voices into account. That's why we choose Europe over Asia > (it felt like people on the committee generally preferred Tokyo). But again, > I agree that we should have been more transparent.

D3871: rebase: improve output of --confirm option

2018-07-13 Thread durin42 (Augie Fackler)
durin42 added a comment. This doesn't apply cleanly, could you rebase it? INLINE COMMENTS > rebase.py:975 > with util.acceptintervention(dsguard): > -rbsrt._performrebase(tr) > +rbsrt._performrebase(tr, supprbinfo=supprbinfo) > if

Re: Discussion about Mercurial 4.8 Sprint

2018-07-13 Thread Martin von Zweigbergk via Mercurial-devel
On Fri, Jul 13, 2018, 00:32 Sean Farley wrote: > > Martin von Zweigbergk writes: > > > On Thu, Jul 12, 2018 at 9:11 PM Sean Farley wrote: > > > >> > >> Martin von Zweigbergk writes: > >> > >> > On Thu, Jul 12, 2018, 17:41 Sean Farley wrote: > >> > > >> >> > >> >> Martin von Zweigbergk via

D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

2018-07-13 Thread yuja (Yuya Nishihara)
yuja added a comment. > How do you feel about treating the current behavior of `hg grep` as a bug? I'm 0 on this. 10 years are long enough to turn a bug into a feature, but I agree the grep (without --all/--diff) is useless. If we had no easy way to opt-in BC, I would give thumbs up

Re: D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

2018-07-13 Thread Yuya Nishihara
> How do you feel about treating the current behavior of `hg grep` as a bug? I'm 0 on this. 10 years are long enough to turn a bug into a feature, but I agree the grep (without --all/--diff) is useless. If we had no easy way to opt-in BC, I would give thumbs up on changing the default behavior.

Re: D3870: rebase: add --confirm option

2018-07-13 Thread Yuya Nishihara
> >> +if confirm: > >> +# abort as in-memory merge doesn't support conflict > >> +rbsrt._prepareabortorcontinue(isabort=True, > backup=False, > >> + suppwarns=True) > >> +

D3870: rebase: add --confirm option

2018-07-13 Thread yuja (Yuya Nishihara)
yuja added a comment. > >> +if confirm: > >> +# abort as in-memory merge doesn't support conflict > >> +rbsrt._prepareabortorcontinue(isabort=True, backup=False, > >> + suppwarns=True)

D3934: revlog: delete isdescendantrev() in favor of isancestorrev()

2018-07-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG21846c94e605: revlog: delete isdescendantrev() in favor of isancestorrev() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3936: context: rename descendant() to isancestorof()

2018-07-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbec9c0b32d3: context: rename descendant() to isancestorof() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3940: rebase: reduce scope of a variable

2018-07-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG99ed6e2f6606: rebase: reduce scope of a variable (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3940?vs=9577=9583

D3939: rebase: correct misleading message in --confirm option

2018-07-13 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG35b3f686157a: rebase: correct misleading message in --confirm option (authored by khanchi97, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3938: rebase: make sure we don't loose the return code in --confirm option

2018-07-13 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa50482254b0a: rebase: make sure we dont loose the return code in --confirm option (authored by khanchi97, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3941: rebase: avoid converting from nodes to revnums twice

2018-07-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0f8599afb92f: rebase: avoid converting from nodes to revnums twice (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3942: rebase: use revnums (not nodes) for set of extinct revisions

2018-07-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG20a30bb8f276: rebase: use revnums (not nodes) for set of extinct revisions (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3935: copies: delete now-unnecessary check for "a == b" before "a.descendant(b)"

2018-07-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb5891bf8ab13: copies: delete now-unnecessary check for a == b before a.descendant(b) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3919: grep: restore pre-9ef10437bb88 behavior, enable wdir search by tweakdefaults

2018-07-13 Thread durin42 (Augie Fackler)
durin42 added a comment. > If we can take the current `hg grep` behavior as a bug, we can say the > same thing for python-hglib. I don't want to make hglib grep diverged from > hg one since hglib is a thin wrapper. That's not a bad thought. Sounds like a plan to me. How do

Re: [PATCH 01 of 13] sparse-read: target density of 50% instead of 25%

2018-07-13 Thread Boris FELD
On 11/07/2018 00:37, Gregory Szorc wrote: On Tue, Jul 10, 2018 at 6:27 AM, Boris Feld > wrote: # HG changeset patch # User Paul Morelle mailto:paul.more...@octobus.net>> # Date 1529680344 -7200 #      Fri Jun 22 17:12:24 2018 +0200 # Node ID

Re: [PATCH 1 of 2] config: introduce load order tracking

2018-07-13 Thread Boris FELD
On 11/07/2018 13:32, David Demelier wrote: On Wed, 2018-07-11 at 00:01 +0900, Yuya Nishihara wrote: If the problem to be addressed by this hack is important, and if the hack is really simple, sure I would say go for it. But I, as an old Mercurial user, see the bulk renaming of the config keys

Re: Discussion about Mercurial 4.8 Sprint

2018-07-13 Thread Sean Farley
Martin von Zweigbergk writes: > On Thu, Jul 12, 2018 at 9:11 PM Sean Farley wrote: > >> >> Martin von Zweigbergk writes: >> >> > On Thu, Jul 12, 2018, 17:41 Sean Farley wrote: >> > >> >> >> >> Martin von Zweigbergk via Mercurial-devel < >> >> mercurial-devel@mercurial-scm.org> writes: >> >>

mercurial@38659: 44 new changesets

2018-07-13 Thread Mercurial Commits
44 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c44ae5997869 changeset: 38616:c44ae5997869 parent: 38614:4d5fb4062f0b user:Boris Feld date:Sat Apr 28 12:51:44 2018 +0200 summary: run-tests: add support for external test result