D4058: narrowspec: remove the unused _parsestoredpatterns() function

2018-08-03 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 9830. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4058?vs=9797=9830 REVISION DETAIL https://phab.mercurial-scm.org/D4058 AFFECTED FILES mercurial/narrowspec.py CHANGE DETAILS diff --git

D4057: narrowspec: use sparse.parseconfig() to parse narrowspec file

2018-08-03 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 9829. pulkit edited the summary of this revision. pulkit retitled this revision from "narrowspec: use sparse.parseconfig() to parse narrowspec file (BC)" to "narrowspec: use sparse.parseconfig() to parse narrowspec file". REPOSITORY rHG Mercurial CHANGES

Re: [PATCH 7 of 7] fileset: optimize 'x and not y' to 'x - y'

2018-08-03 Thread Martin von Zweigbergk via Mercurial-devel
On Fri, Aug 3, 2018 at 8:02 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1532159341 -32400 > # Sat Jul 21 16:49:01 2018 +0900 > # Node ID 64a966e607ee1aefe5d19f061015d271aeb46358 > # Parent 6a0bf2f620f877d609896f649c0feae09c3f5d2d > fileset: optimize 'x

D4069: py3: whitelist another 3 tests caught by the ratchet

2018-08-03 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8a9f6076e60c: py3: whitelist another 3 tests caught by the ratchet (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4069: py3: whitelist another 3 tests caught by the ratchet

2018-08-03 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4069 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

[PATCH 2 of 7] fileset: drop 'group' node from tree to be evaluated

2018-08-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532157210 -32400 # Sat Jul 21 16:13:30 2018 +0900 # Node ID 9321d75764446672280a850db18ef335e4d3ee92 # Parent 78c669de8c435c0594ab4f849f591aacad074097 fileset: drop 'group' node from tree to be evaluated This helps rewriting a parsed tree.

[PATCH 3 of 7] fileset: reject 'negate' node early while transforming parsed tree

2018-08-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532157404 -32400 # Sat Jul 21 16:16:44 2018 +0900 # Node ID 1598c4146f74757fef4e2db244b03188d197df52 # Parent 9321d75764446672280a850db18ef335e4d3ee92 fileset: reject 'negate' node early while transforming parsed tree That's how a 'negate'

[PATCH 4 of 7] fileset: add stub for weight-based optimization

2018-08-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532155946 -32400 # Sat Jul 21 15:52:26 2018 +0900 # Node ID 6c9246c08523616914af131700126cfc408114f7 # Parent 1598c4146f74757fef4e2db244b03188d197df52 fileset: add stub for weight-based optimization The main purpose of this change is to

[PATCH 5 of 7] fileset: roughly adjust weights of functions

2018-08-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532227649 -32400 # Sun Jul 22 11:47:29 2018 +0900 # Node ID 1ec115b2c5525f0507ff7c4dc2019b57ae391911 # Parent 6c9246c08523616914af131700126cfc408114f7 fileset: roughly adjust weights of functions ... in order to move status predicates far

[PATCH 7 of 7] fileset: optimize 'x and not y' to 'x - y'

2018-08-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532159341 -32400 # Sat Jul 21 16:49:01 2018 +0900 # Node ID 64a966e607ee1aefe5d19f061015d271aeb46358 # Parent 6a0bf2f620f877d609896f649c0feae09c3f5d2d fileset: optimize 'x and not y' to 'x - y' 'x - y' is first rewritten to 'x and not y'

[PATCH 6 of 7] fileset: reorder 'and' expression to evaluate basic patterns first

2018-08-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532158905 -32400 # Sat Jul 21 16:41:45 2018 +0900 # Node ID 6a0bf2f620f877d609896f649c0feae09c3f5d2d # Parent 1ec115b2c5525f0507ff7c4dc2019b57ae391911 fileset: reorder 'and' expression to evaluate basic patterns first Timing of a crafted

[PATCH 1 of 7] fileset: add phase to transform parsed tree

2018-08-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532157096 -32400 # Sat Jul 21 16:11:36 2018 +0900 # Node ID 78c669de8c435c0594ab4f849f591aacad074097 # Parent d814bbd229467f7e5d866fd3af41df8beb131b9a fileset: add phase to transform parsed tree This isn't strictly necessary, but I decided

D3639: remotenames: add names argument to remotenames revset

2018-08-03 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3639#63068, @yuja wrote: > > +@revsetpredicate('remotebranches([name, ...])') > > Can you start with a single "name" argument? > > It doesn't make sense that `remotebranches()` accepts many OR patterns but > `branch()`

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3086a8627b29: testrunner: allow multiple #testcases (authored by martinvonz, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4049?vs=9790=9825#toc REPOSITORY rHG Mercurial

D3988: resolve: add confirm config option

2018-08-03 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf8732e33bcbc: resolve: add confirm config option (authored by khanchi97, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3988?vs=9816=9823#toc REPOSITORY rHG Mercurial

D4052: testrunner: use "#" for "test cases" suffix in .err filename too

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa9a4b0fc1e5d: testrunner: use # for test cases suffix in .err filename too (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4054: hgsubversion: add 4.7 to list of supported mercurial

2018-08-03 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. Sorry for the noise. I managed to email it using my personal laptop. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4054 To: pulkit, #hg-reviewers Cc: mercurial-devel

D3976: grep: add MULTIREV support to --all-files flag

2018-08-03 Thread yuja (Yuya Nishihara)
yuja added a comment. > +# the files dictionary stores all the files that have been looked at > +# in the allfiles mode > +files ={} I don't think we should omit files that were seen in earlier revisions, because --all-files is supposed to scan files of

Re: D3639: remotenames: add names argument to remotenames revset

2018-08-03 Thread Yuya Nishihara
> +@revsetpredicate('remotebranches([name, ...])') Can you start with a single "name" argument? It doesn't make sense that `remotebranches()` accepts many OR patterns but `branch()` doesn't. ___ Mercurial-devel mailing list

Re: D3976: grep: add MULTIREV support to --all-files flag

2018-08-03 Thread Yuya Nishihara
> +# the files dictionary stores all the files that have been looked at > +# in the allfiles mode > +files ={} I don't think we should omit files that were seen in earlier revisions, because --all-files is supposed to scan files of any states. I also expect `hg grep

D3639: remotenames: add names argument to remotenames revset

2018-08-03 Thread yuja (Yuya Nishihara)
yuja added a comment. > +@revsetpredicate('remotebranches([name, ...])') Can you start with a single "name" argument? It doesn't make sense that `remotebranches()` accepts many OR patterns but `branch()` doesn't. REPOSITORY rHG Mercurial REVISION DETAIL

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > run-tests.py:2705 > else: > -tests += [{'path': t, 'case': c} for c in > sorted(cases)] > + pass > +tests += [{'path': t, 'case': c} for c in sorted(cases)]

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Thanks to @mharbison72 for review and testing it on windows. Queuing this, many thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4049 To: martinvonz, #hg-reviewers, mharbison72 Cc: pulkit, quark, lothiraldan, mharbison72,

D3968: amend: support "history-editing-backup" config option

2018-08-03 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG32ece991955c: amend: support history-editing-backup config option (authored by khanchi97, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4026: revlog: remove unnecessary output parameter from node_check()

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG49628742d264: revlog: remove unnecessary output parameter from node_check() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4027: revlog: remove micro-optimization for looking up only nullid

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG44bbc89ec5e0: revlog: remove micro-optimization for looking up only nullid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4028: revlog: remove side effect from failed nt_init()

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd814bbd22946: revlog: remove side effect from failed nt_init() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4068: narrow: move status-filtering to core and to ctx

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe411774a2e0f: narrow: move status-filtering to core and to ctx (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4055: rebase: move "backup" flag to rbsrt

2018-08-03 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2b728789edfd: rebase: move backup flag to rebaseruntime (authored by khanchi97, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4055?vs=9815=9817

Re: [PATCH 2 of 4] i18n: omit redundant warnings of GNU xgettext command

2018-08-03 Thread Yuya Nishihara
On Fri, 03 Aug 2018 02:21:50 +0900, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1533224280 -32400 > # Fri Aug 03 00:38:00 2018 +0900 > # Node ID b2d92c607d9af9945a03cd2e5d781021bfc80de1 > # Parent 984894e4ad78ef5799a6974d079d45bcf5a64f05 > #

Re: [PATCH 1 of 4] i18n: avoid substitution of PYFILES at runtime for readability of output

2018-08-03 Thread Yuya Nishihara
On Fri, 03 Aug 2018 02:21:49 +0900, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1533211650 -32400 > # Thu Aug 02 21:07:30 2018 +0900 > # Node ID 984894e4ad78ef5799a6974d079d45bcf5a64f05 > # Parent 2002c193f2bcb07ea898d6229835e7d61bc48aae > #

Re: [PATCH] util: make new timedcmstats class Python 3 compatible

2018-08-03 Thread Yuya Nishihara
On Thu, 02 Aug 2018 20:58:01 +0100, Martijn Pieters wrote: > # HG changeset patch > # User Martijn Pieters > # Date 1533239583 -3600 > # Thu Aug 02 20:53:03 2018 +0100 > # Branch stable > # Node ID d7c68ee641ff02542680bdaa4bff95a348db688e > # Parent 07ca3b8354d59c70db5f10448e53d4bbfd50e72e

D3988: resolve: add confirm config option

2018-08-03 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 9816. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3988?vs=9785=9816 REVISION DETAIL https://phab.mercurial-scm.org/D3988 AFFECTED FILES mercurial/commands.py mercurial/configitems.py

D4055: rebase: move "backup" flag to rbsrt

2018-08-03 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 9815. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4055?vs=9793=9815 REVISION DETAIL https://phab.mercurial-scm.org/D4055 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py

D4055: rebase: move "backup" flag to rbsrt

2018-08-03 Thread khanchi97 (Sushil khanchi)
khanchi97 added inline comments. INLINE COMMENTS > pulkit wrote in rebase.py:349 > not A or not B = not (A and B) > not(not A or not B) = A and B Ah, right. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4055 To: khanchi97, #hg-reviewers Cc: pulkit,

D4068: narrow: move status-filtering to core and to ctx

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of my recent changes from repo.status(ctx1, ctx2) to ctx1.status(ctx2) broke some of our Google-internal tests. The

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread quark (Jun Wu)
quark added a comment. `--stack` should work as expected if dependency is set manually. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4049 To: martinvonz, #hg-reviewers, mharbison72 Cc: quark, lothiraldan, mharbison72, mercurial-devel

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In https://phab.mercurial-scm.org/D4049#63027, @quark wrote: > In https://phab.mercurial-scm.org/D4049#63026, @martinvonz wrote: > > > Sorry, I was just misremembering that https://phab.mercurial-scm.org/D4052 had been queued. I don't know why

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D4049#63029, @mharbison72 wrote: > In https://phab.mercurial-scm.org/D4049#63026, @martinvonz wrote: > > > In https://phab.mercurial-scm.org/D4049#63024, @mharbison72 wrote: > > > > > In

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D4049#63027, @quark wrote: > In https://phab.mercurial-scm.org/D4049#63026, @martinvonz wrote: > > > Sorry, I was just misremembering that https://phab.mercurial-scm.org/D4052 had been queued. I don't know why phabricator

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread quark (Jun Wu)
quark added a comment. In https://phab.mercurial-scm.org/D4049#63026, @martinvonz wrote: > Sorry, I was just misremembering that https://phab.mercurial-scm.org/D4052 had been queued. I don't know why phabricator doesn't understand that this patch is on top of

D4049: testrunner: allow multiple #testcases

2018-08-03 Thread mharbison72 (Matt Harbison)
mharbison72 accepted this revision. mharbison72 added a comment. In https://phab.mercurial-scm.org/D4049#63026, @martinvonz wrote: > In https://phab.mercurial-scm.org/D4049#63024, @mharbison72 wrote: > > > In https://phab.mercurial-scm.org/D4049#63019, @martinvonz wrote: > > > > >

<    1   2